From nobody Tue Feb 10 02:44:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1663374533; cv=none; d=zohomail.com; s=zohoarc; b=CelDkeWVuUZFzN82CUru0KgUTcNz8/KeGvzo8k1S2YvVgncPmVfN9eftMbUAXUtGm+/sq7OsIT7F0L+dP4c++u9OqS4vg0jsBueCZtpaeIyuvflPqVFCzw0ppmgAZYxlMGjlD8aQkc3VRfJuzzWvz4fOGtRy6XM32Do6Ji2x31o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663374533; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L7b8NiPFkTnnx0MNNVwPsKPc8hFO12ywiOznrQpiIgw=; b=JKaJXahjxKRTCt8E3jOLvV5qXgbz5WRFpETB1HqdlL0vL6iJ3Y3evAKl+zdM15Cnh0RAgkIG6KGJuxTdrBHdAYe+JIJulOzBj1GgJa52yjMvVhmkqoCN5+YDhBchRxs5+0rfyTbFl/Rv9wVtjsJsG7jHZ7pJSF+yorLcwSGIHlc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1663374533380110.59193092604085; Fri, 16 Sep 2022 17:28:53 -0700 (PDT) Received: from localhost ([::1]:52370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZLhS-00076m-TT for importer@patchew.org; Fri, 16 Sep 2022 20:28:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZLgC-0005l6-NM for qemu-devel@nongnu.org; Fri, 16 Sep 2022 20:27:33 -0400 Received: from mga17.intel.com ([192.55.52.151]:23527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZLgB-0000iY-4u for qemu-devel@nongnu.org; Fri, 16 Sep 2022 20:27:32 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2022 17:27:20 -0700 Received: from vkasired-desk2.fm.intel.com ([10.105.128.127]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2022 17:27:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663374451; x=1694910451; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tyQ9swSZYvERopPc45XEuZ3lVkPVWxE8P613hgl7eIA=; b=fhnf/GlNWkTk9nPem6ehWLlrS53S9a4rHeAw7VH9MrJedUzfTVXXTDNU 644H9w/sTTD0qSHb6NoQ3ABW/gwvbSsWYuUptywS0BI6qv1+UJWOMamoA dSo0JCXGAwwfvfL/BTGF6OEO5tkAV6sj3dZesWYPB+ZqWJ+lV7V9r9s74 gTWzmDIt9R5XMka5BoHEtZeGzQsqdLlEBmMRqz9FDFJZPQ/hxF0fMSBUu jbWpF/touPSnqRBBrM8+DoQy8neOLECEpKy+3H0XWvbcGpnd3dG6kQ1Z9 oOeN9TARzvW3wVIHltIZiHSdvWDqij6OFCTi3tuuj1+fSe3JhJoxzLUa+ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10472"; a="279489394" X-IronPort-AV: E=Sophos;i="5.93,321,1654585200"; d="scan'208";a="279489394" X-IronPort-AV: E=Sophos;i="5.93,321,1654585200"; d="scan'208";a="760235121" From: Vivek Kasireddy To: qemu-devel@nongnu.org Cc: Vivek Kasireddy , Gerd Hoffmann , Dongwon Kim Subject: [PATCH v1 1/3] ui/gtk: Disable the scanout when a detached tab is closed Date: Fri, 16 Sep 2022 17:07:29 -0700 Message-Id: <20220917000731.465003-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220917000731.465003-1-vivek.kasireddy@intel.com> References: <20220917000731.465003-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.151; envelope-from=vivek.kasireddy@intel.com; helo=mga17.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1663374535309100003 Content-Type: text/plain; charset="utf-8" When a detached tab window is closed, the underlying (EGL) context is destroyed; therefore, disable the scanout which also destroys the underlying framebuffer (id) and other objects. Also add calls to make the context current in disable scanout and other missing places. Cc: Gerd Hoffmann Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- ui/gtk-egl.c | 2 ++ ui/gtk-gl-area.c | 2 ++ ui/gtk.c | 1 + 3 files changed, 5 insertions(+) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index b5bffbab25..0f9ef11f4c 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -211,6 +211,8 @@ void gd_egl_scanout_disable(DisplayChangeListener *dcl) { VirtualConsole *vc =3D container_of(dcl, VirtualConsole, gfx.dcl); =20 + eglMakeCurrent(qemu_egl_display, vc->gfx.esurface, + vc->gfx.esurface, vc->gfx.ectx); vc->gfx.w =3D 0; vc->gfx.h =3D 0; gtk_egl_set_scanout_mode(vc, false); diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 682638a197..0b9fd4713a 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -270,6 +270,7 @@ void gd_gl_area_scanout_disable(DisplayChangeListener *= dcl) { VirtualConsole *vc =3D container_of(dcl, VirtualConsole, gfx.dcl); =20 + gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); gtk_gl_area_set_scanout_mode(vc, false); } =20 @@ -278,6 +279,7 @@ void gd_gl_area_scanout_flush(DisplayChangeListener *dc= l, { VirtualConsole *vc =3D container_of(dcl, VirtualConsole, gfx.dcl); =20 + gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); if (vc->gfx.guest_fb.dmabuf) { graphic_hw_gl_block(vc->gfx.dcl.con, true); vc->gfx.guest_fb.dmabuf->draw_submitted =3D true; diff --git a/ui/gtk.c b/ui/gtk.c index 1467b8c7d7..0ff31cb852 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1302,6 +1302,7 @@ static gboolean gd_tab_window_close(GtkWidget *widget= , GdkEvent *event, VirtualConsole *vc =3D opaque; GtkDisplayState *s =3D vc->s; =20 + dpy_gl_scanout_disable(vc->gfx.dcl.con); gtk_widget_set_sensitive(vc->menu_item, true); gd_widget_reparent(vc->window, s->notebook, vc->tab_item); gtk_notebook_set_tab_label_text(GTK_NOTEBOOK(s->notebook), --=20 2.37.2