From nobody Tue Feb 10 14:33:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1662978518; cv=none; d=zohomail.com; s=zohoarc; b=M6yguwOBPjx6s4UGVS51UYDx/K3USh5PceUioEjjX/LcnoNVtH/G4sAhfYKTg1QDYJH+s2JmYHu16b+P4kiZp5NMBXEVRsQEgntkbMK2I6DSoRWafpBbQCZ17H6BNR4gnp4WOg5QXcLGL0Ae3u46jKQGVk6eb7oJvSxi00OqAW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662978518; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+H1dlVsO6rIooekJM324mF3TSdjJTMlQUL56IAhHClM=; b=Cnqy45zCKcSLHois7XSMiz0KZGCszN4CK2g8T3nmk/yI0W2NRxYDQZGZ1q42kQ6OT179FoSYQALv+Pof3iI75eSTm6KzkTzjMRgLTVcFUYHE8UNOGVkJjkBf3+jYEoPFOmsMGdLsn4iDfNPNo9dGPLmvc4iUFtumDPmPTB0R86k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662978518349345.5722861514256; Mon, 12 Sep 2022 03:28:38 -0700 (PDT) Received: from localhost ([::1]:52504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXgg8-0000rF-Sg for importer@patchew.org; Mon, 12 Sep 2022 06:28:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXgcv-00072b-Mh for qemu-devel@nongnu.org; Mon, 12 Sep 2022 06:25:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:49711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXgcp-0007FT-25 for qemu-devel@nongnu.org; Mon, 12 Sep 2022 06:25:14 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-237-xmQYMFJ8MFWp6d1Ne7bCEA-1; Mon, 12 Sep 2022 06:25:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF91C3C02B71 for ; Mon, 12 Sep 2022 10:25:05 +0000 (UTC) Received: from localhost (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF3C92027063; Mon, 12 Sep 2022 10:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662978307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+H1dlVsO6rIooekJM324mF3TSdjJTMlQUL56IAhHClM=; b=L9IkoD8Qf29792XQ5yF+IGtEb9PCL/+NeQhgC9I5R+KOBhGROziCEekQ1Dug7GGgx8ODhE FdzpkJ0A7W6Lt/YWTYnKO2d0P1fZhOrnt3XAIaVj5XQSWMgca9heDVUkN17TcP0IhOBNHc w1gsWZ90Kv3+MA4jj47UEPqDivAVlQ4= X-MC-Unique: xmQYMFJ8MFWp6d1Ne7bCEA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 1/5] ui: add some vdagent related traces Date: Mon, 12 Sep 2022 14:24:51 +0400 Message-Id: <20220912102455.111765-2-marcandre.lureau@redhat.com> In-Reply-To: <20220912102455.111765-1-marcandre.lureau@redhat.com> References: <20220912102455.111765-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1662978520040100001 From: Marc-Andr=C3=A9 Lureau This helps debugging clipboard serial sync issues. Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/clipboard.c | 11 +++++++++-- ui/vdagent.c | 3 +++ ui/trace-events | 5 +++++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/ui/clipboard.c b/ui/clipboard.c index 9079ef829b..cd5382fcb0 100644 --- a/ui/clipboard.c +++ b/ui/clipboard.c @@ -1,5 +1,6 @@ #include "qemu/osdep.h" #include "ui/clipboard.h" +#include "trace.h" =20 static NotifierList clipboard_notifiers =3D NOTIFIER_LIST_INITIALIZER(clipboard_notifiers); @@ -43,17 +44,23 @@ void qemu_clipboard_peer_release(QemuClipboardPeer *pee= r, =20 bool qemu_clipboard_check_serial(QemuClipboardInfo *info, bool client) { + bool ok; + if (!info->has_serial || !cbinfo[info->selection] || !cbinfo[info->selection]->has_serial) { + trace_clipboard_check_serial(-1, -1, true); return true; } =20 if (client) { - return cbinfo[info->selection]->serial >=3D info->serial; + ok =3D cbinfo[info->selection]->serial >=3D info->serial; } else { - return cbinfo[info->selection]->serial > info->serial; + ok =3D cbinfo[info->selection]->serial > info->serial; } + + trace_clipboard_check_serial(cbinfo[info->selection]->serial, info->se= rial, ok); + return ok; } =20 void qemu_clipboard_update(QemuClipboardInfo *info) diff --git a/ui/vdagent.c b/ui/vdagent.c index a899eed195..f3bd56e3e7 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -533,6 +533,7 @@ static void vdagent_clipboard_recv_grab(VDAgentChardev = *vd, uint8_t s, uint32_t info->has_serial =3D true; info->serial =3D *(uint32_t *)data; if (info->serial < vd->last_serial[s]) { + trace_vdagent_cb_grab_discard(GET_NAME(sel_name, s), vd->last_= serial[s], info->serial); /* discard lower-ordering guest grab */ return; } @@ -853,6 +854,8 @@ static void vdagent_chr_accept_input(Chardev *chr) =20 static void vdagent_disconnect(VDAgentChardev *vd) { + trace_vdagent_disconnect(); + buffer_reset(&vd->outbuf); vdagent_reset_bufs(vd); vd->caps =3D 0; diff --git a/ui/trace-events b/ui/trace-events index a922f00e10..977577fbba 100644 --- a/ui/trace-events +++ b/ui/trace-events @@ -127,15 +127,20 @@ xkeymap_vendor(const char *name) "vendor '%s'" xkeymap_keycodes(const char *name) "keycodes '%s'" xkeymap_keymap(const char *name) "keymap '%s'" =20 +# clipboard.c +clipboard_check_serial(int cur, int recv, bool ok) "cur:%d recv:%d %d" + # vdagent.c vdagent_open(void) "" vdagent_close(void) "" +vdagent_disconnect(void) "" vdagent_send(const char *name) "msg %s" vdagent_send_empty_clipboard(void) "" vdagent_recv_chunk(uint32_t size) "size %d" vdagent_recv_msg(const char *name, uint32_t size) "msg %s, size %d" vdagent_peer_cap(const char *name) "cap %s" vdagent_cb_grab_selection(const char *name) "selection %s" +vdagent_cb_grab_discard(const char *name, int cur, int recv) "selection %s= , cur:%d recv:%d" vdagent_cb_grab_type(const char *name) "type %s" vdagent_cb_serial_discard(uint32_t current, uint32_t received) "current=3D= %u, received=3D%u" =20 --=20 2.37.3