From nobody Mon Feb 9 08:11:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1662477676; cv=none; d=zohomail.com; s=zohoarc; b=jhjQMtW6cf/ocCaaMsdCoADZMg1MrKzk2IV1Cv/eEDHIboPKXa7AUE8JYOZqFVHAcFP/Gpxwt1KUT1ThghIoxlFfchv/AFmfvosDvfnK+OAk+2Y+ADfrY9icwVd3jOn+1b5Y/DyXRWcSVlzA8oSw8+iGe6+z1GPNU1MeHZRAQH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662477676; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=98v2Byg4txCUkMYx+EdCgVj34yNLWuRwxgR2JKC9H/I=; b=eqWpb+o0RUFWYL43zCHxuN7FZIPdg/3qvSc7u98pu3kst/bqZ6uq0wceZGMyD1C6AI2PIvtsTHhelxp4EAg/cTTtpPfZjreqkGbBz+Dih4CWFEVI7lORFzekW5kIhkb292xpT9kqzHQWu/h00qFbRjmQI+lEIP5Z3A5GFS+9Fw0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662477676237852.2996816286842; Tue, 6 Sep 2022 08:21:16 -0700 (PDT) Received: from localhost ([::1]:48790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVaO3-0003Jp-7J for importer@patchew.org; Tue, 06 Sep 2022 11:21:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVaB0-0004yS-Ht for qemu-devel@nongnu.org; Tue, 06 Sep 2022 11:07:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:41321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVaAy-0002Ij-TT for qemu-devel@nongnu.org; Tue, 06 Sep 2022 11:07:46 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-519-ZZFcPEb5MEKa8fgeOwj4gA-1; Tue, 06 Sep 2022 11:07:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA4C4101A56C; Tue, 6 Sep 2022 15:07:40 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.195.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 017D140D296C; Tue, 6 Sep 2022 15:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662476863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98v2Byg4txCUkMYx+EdCgVj34yNLWuRwxgR2JKC9H/I=; b=X/8Q83p/ZJPhWYr8lU8CRi+6bsJzaC+t2KeaBXqMyjbecHGzrUx1ziToHWBKf0+7EWJXAy UqbWEBBedRgBci8W+DZcBruHdgbvGbUWEbPOHoOYGTCxofB9lSzpVnSfnurE2vjz78B9CV yq97aPA4JKxSqAOUtwozcMuC6JhmNQg= X-MC-Unique: ZZFcPEb5MEKa8fgeOwj4gA-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Harpreet Singh Anand , Stefano Garzarella , Si-Wei Liu , Jason Wang , Parav Pandit , Liuxiangdong , Laurent Vivier , Zhu Lingshan , Cindy Lu , Eli Cohen , "Michael S. Tsirkin" , Paolo Bonzini , "Gonglei (Arei)" , Cornelia Huck , Gautam Dawar Subject: [PATCH v4 5/6] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends Date: Tue, 6 Sep 2022 17:07:18 +0200 Message-Id: <20220906150719.1134955-6-eperezma@redhat.com> In-Reply-To: <20220906150719.1134955-1-eperezma@redhat.com> References: <20220906150719.1134955-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1662477676865100001 It was returned as error before. Instead of it, simply update the corresponding field so qemu can send it in the migration data. Signed-off-by: Eugenio P=C3=A9rez Acked-by: Si-Wei Liu --- hw/net/virtio-net.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index dd0d056fde..63a8332cd0 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -1412,19 +1412,14 @@ static int virtio_net_handle_mq(VirtIONet *n, uint8= _t cmd, return VIRTIO_NET_ERR; } =20 - /* Avoid changing the number of queue_pairs for vdpa device in - * userspace handler. A future fix is needed to handle the mq - * change in userspace handler with vhost-vdpa. Let's disable - * the mq handling from userspace for now and only allow get - * done through the kernel. Ripples may be seen when falling - * back to userspace, but without doing it qemu process would - * crash on a recursive entry to virtio_net_set_status(). - */ + n->curr_queue_pairs =3D queue_pairs; if (nc->peer && nc->peer->info->type =3D=3D NET_CLIENT_DRIVER_VHOST_VD= PA) { - return VIRTIO_NET_ERR; + /* + * Avoid updating the backend for a vdpa device: We're only intere= sted + * in updating the device model queues. + */ + return VIRTIO_NET_OK; } - - n->curr_queue_pairs =3D queue_pairs; /* stop the backend before changing the number of queue_pairs to avoid= handling a * disabled queue */ virtio_net_set_status(vdev, vdev->status); --=20 2.31.1