From nobody Mon Feb 9 12:09:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1662476990; cv=none; d=zohomail.com; s=zohoarc; b=fqPOxhndDuXVT8WTXv+OOKtrPj8wbMlxvRjoWrjJFFgM7DNeU+eLcCgeDUkdkgR1eRkWZG0CooEkRKgt9cq0gDzEV/JXAIfgUqLo+xjk9rP9nUyBrjv6sZyKg1iYbKnfYRgEkeeyOthr93gwzdyQB/YM5TW53TiUsbOhXF6djDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662476990; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=947XT4qKSHAoxN6t9wuk7kVV5CX4QvokhO/FmmUQDNI=; b=ns0g2FcOwTUrrtrAYZ8ktJDqGA7Ns+ACzZSmkk/CFqxBTTi+Ll8fm2DiKz5JSRHb13MyQ47+CXfV+3H/TWMGU0uMQEb3WDvmAt9+Bcu9NYFi0p6KVQ8ZJ2uPS4ARZXxo80un8JnJO948spJLAqvgTXv/7333B/swh4riHv0+r4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662476990777645.2612000546434; Tue, 6 Sep 2022 08:09:50 -0700 (PDT) Received: from localhost ([::1]:39124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVaCz-0006oi-EP for importer@patchew.org; Tue, 06 Sep 2022 11:09:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVaAq-0004gJ-Fx for qemu-devel@nongnu.org; Tue, 06 Sep 2022 11:07:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVaAo-0002GE-6U for qemu-devel@nongnu.org; Tue, 06 Sep 2022 11:07:36 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-G_6ilHrxMoed4Ee-UZ6eNQ-1; Tue, 06 Sep 2022 11:07:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 66C748007CE; Tue, 6 Sep 2022 15:07:31 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.195.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9827C40D296C; Tue, 6 Sep 2022 15:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662476853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=947XT4qKSHAoxN6t9wuk7kVV5CX4QvokhO/FmmUQDNI=; b=LShCGX8Ek5Txv13EeBy59IDE0mHhSOqJVjptLqtPUzNlXRjYf8Z/90c7ieZ4dZkHFo5pH0 lswNvwQJg8fPy25K4s6Adc579py2sMqNlmlFEINTXCBnhoUTsczu48PGLeWHnnBdZf4n91 z1xL7Wgo2kdhWAof/Kf+SITzduyXSFk= X-MC-Unique: G_6ilHrxMoed4Ee-UZ6eNQ-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Harpreet Singh Anand , Stefano Garzarella , Si-Wei Liu , Jason Wang , Parav Pandit , Liuxiangdong , Laurent Vivier , Zhu Lingshan , Cindy Lu , Eli Cohen , "Michael S. Tsirkin" , Paolo Bonzini , "Gonglei (Arei)" , Cornelia Huck , Gautam Dawar Subject: [PATCH v4 2/6] vdpa: extract vhost_vdpa_net_load_mac from vhost_vdpa_net_load Date: Tue, 6 Sep 2022 17:07:15 +0200 Message-Id: <20220906150719.1134955-3-eperezma@redhat.com> In-Reply-To: <20220906150719.1134955-1-eperezma@redhat.com> References: <20220906150719.1134955-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1662476992637100001 Since there may be many commands we need to issue to load the NIC state, let's split them in individual functions Signed-off-by: Eugenio P=C3=A9rez -- v2: Add vhost_vdpa_net_load_cmd helper v3: Move ctrl header definition to vhost_vdpa_net_load_cmd --- net/vhost-vdpa.c | 62 +++++++++++++++++++++++++++++++----------------- 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 535315c1d0..e799e744cd 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -365,12 +365,47 @@ static ssize_t vhost_vdpa_net_cvq_add(VhostVDPAState = *s, size_t out_len, return vhost_svq_poll(svq); } =20 +static ssize_t vhost_vdpa_net_load_cmd(VhostVDPAState *s, uint8_t class, + uint8_t cmd, const void *data, + size_t data_size) +{ + const struct virtio_net_ctrl_hdr ctrl =3D { + .class =3D class, + .cmd =3D cmd, + }; + + assert(data_size < vhost_vdpa_net_cvq_cmd_page_len() - sizeof(ctrl)); + + memcpy(s->cvq_cmd_out_buffer, &ctrl, sizeof(ctrl)); + memcpy(s->cvq_cmd_out_buffer + sizeof(ctrl), data, data_size); + + return vhost_vdpa_net_cvq_add(s, sizeof(ctrl) + data_size, + sizeof(virtio_net_ctrl_ack)); +} + +static int vhost_vdpa_net_load_mac(VhostVDPAState *s, const VirtIONet *n) +{ + uint64_t features =3D n->parent_obj.guest_features; + if (features & BIT_ULL(VIRTIO_NET_F_CTRL_MAC_ADDR)) { + ssize_t dev_written =3D vhost_vdpa_net_load_cmd(s, VIRTIO_NET_CTRL= _MAC, + VIRTIO_NET_CTRL_MAC_ADDR= _SET, + n->mac, sizeof(n->mac)); + if (unlikely(dev_written < 0)) { + return dev_written; + } + + return *s->status !=3D VIRTIO_NET_OK; + } + + return 0; +} + static int vhost_vdpa_net_load(NetClientState *nc) { VhostVDPAState *s =3D DO_UPCAST(VhostVDPAState, nc, nc); - const struct vhost_vdpa *v =3D &s->vhost_vdpa; + struct vhost_vdpa *v =3D &s->vhost_vdpa; const VirtIONet *n; - uint64_t features; + int r; =20 assert(nc->info->type =3D=3D NET_CLIENT_DRIVER_VHOST_VDPA); =20 @@ -379,26 +414,9 @@ static int vhost_vdpa_net_load(NetClientState *nc) } =20 n =3D VIRTIO_NET(v->dev->vdev); - features =3D n->parent_obj.guest_features; - if (features & BIT_ULL(VIRTIO_NET_F_CTRL_MAC_ADDR)) { - const struct virtio_net_ctrl_hdr ctrl =3D { - .class =3D VIRTIO_NET_CTRL_MAC, - .cmd =3D VIRTIO_NET_CTRL_MAC_ADDR_SET, - }; - char *cursor =3D s->cvq_cmd_out_buffer; - ssize_t dev_written; - - memcpy(cursor, &ctrl, sizeof(ctrl)); - cursor +=3D sizeof(ctrl); - memcpy(cursor, n->mac, sizeof(n->mac)); - - dev_written =3D vhost_vdpa_net_cvq_add(s, sizeof(ctrl) + sizeof(n-= >mac), - sizeof(virtio_net_ctrl_ack)); - if (unlikely(dev_written < 0)) { - return dev_written; - } - - return *s->status !=3D VIRTIO_NET_OK; + r =3D vhost_vdpa_net_load_mac(s, n); + if (unlikely(r < 0)) { + return r; } =20 return 0; --=20 2.31.1