From nobody Tue May 21 22:25:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1662375164; cv=none; d=zohomail.com; s=zohoarc; b=i4o+oRJUqyLEe9EmO1kVPkTgKKO/uYD8WxOwMvXLBjfsyyqrdhbQLbSJAog7J7bZX5fTIshK3ZQfNY1kT+k0G+jc6JIQgfOd1phx1kSKnDp+xmkv8lE5anCtUs2uzTgbAtT+Hs05GKGQrbaaaPIXL7ZuTHuFnr3IDpIgZA+ylOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662375164; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=r/cfW6vgytWrTxSi6+sDaeWt5A6r9iTW8kf35ywd6Pk=; b=DReqJELB++TUZtqv9ku0n4JgV5NjDUqDEx0MQh1nOg0/vJcuOjsIG5piPVBh8ggqcGUlViSm/TGVRNROED9dV+mYPaamx27oVEs9V0D93KoptKzWha+Qsqb6B1+yiKiiiAw4GJVuLtvDGQj5HGZL37JS2Px8+2hZ3vC2OeBjlS8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662375164862374.1511455887189; Mon, 5 Sep 2022 03:52:44 -0700 (PDT) Received: from localhost ([::1]:44490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oV9id-0001GK-CQ for importer@patchew.org; Mon, 05 Sep 2022 06:52:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV96u-00066A-K6 for qemu-devel@nongnu.org; Mon, 05 Sep 2022 06:13:44 -0400 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]:52768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oV96s-0004KE-SF for qemu-devel@nongnu.org; Mon, 05 Sep 2022 06:13:44 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA0B05D520; Mon, 5 Sep 2022 10:13:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9DE7713A66; Mon, 5 Sep 2022 10:13:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8PZDJNPLFWOlPwAAMHmgww (envelope-from ); Mon, 05 Sep 2022 10:13:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662372819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=r/cfW6vgytWrTxSi6+sDaeWt5A6r9iTW8kf35ywd6Pk=; b=PLJGszmYbH7DL474TTwFdHqdnhB76gzgCc7u5fnL1hGzQE4uUFUMeBcL3tsbhifDyfiehO N3OUSqKQ3BHLqsG9Y77q0IsoSKbUjRFyUEnsnZpxqKbMyYHM2lWz4uXF9WMDNX4VWJt8uY o0INAkWrMFKDNcfiPnzlaiZJQ0VS9DY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662372819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=r/cfW6vgytWrTxSi6+sDaeWt5A6r9iTW8kf35ywd6Pk=; b=wTamrQpM9isauGjGSI3z2eWmK6v9/kuRoMbo0Ea/rv5iKmfpD7XiUYWopoJzQTCp8AMsbZ lZ6e80EMt3BpiYBQ== From: Claudio Fontana To: Richard Henderson , Paolo Bonzini Cc: Claudio Fontana , qemu-devel@nongnu.org Subject: [PATCH] accel: print an error message and exit if plugin not loaded Date: Mon, 5 Sep 2022 12:13:32 +0200 Message-Id: <20220905101332.1986-1-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1662375166744100001 Content-Type: text/plain; charset="utf-8" If module_load_one, module_load_file fail for any reason (permissions, plugin not installed, ...), we need to provide some notificat= ion to the user to understand that this is happening; otherwise the errors reported on initialization will make no sense to the user. Signed-off-by: Claudio Fontana --- accel/accel-softmmu.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/accel/accel-softmmu.c b/accel/accel-softmmu.c index 67276e4f52..807708ee86 100644 --- a/accel/accel-softmmu.c +++ b/accel/accel-softmmu.c @@ -66,15 +66,21 @@ void accel_init_ops_interfaces(AccelClass *ac) { const char *ac_name; char *ops_name; + ObjectClass *oc; AccelOpsClass *ops; =20 ac_name =3D object_class_get_name(OBJECT_CLASS(ac)); g_assert(ac_name !=3D NULL); =20 ops_name =3D g_strdup_printf("%s" ACCEL_OPS_SUFFIX, ac_name); - ops =3D ACCEL_OPS_CLASS(module_object_class_by_name(ops_name)); + oc =3D module_object_class_by_name(ops_name); + if (!oc) { + error_report("fatal: could not find module object of type \"%s\", " + "plugin might not be loaded correctly", ops_name); + exit(EXIT_FAILURE); + } g_free(ops_name); - + ops =3D ACCEL_OPS_CLASS(oc); /* * all accelerators need to define ops, providing at least a mandatory * non-NULL create_vcpu_thread operation. --=20 2.26.2