From nobody Thu Dec 18 13:29:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1662103195; cv=none; d=zohomail.com; s=zohoarc; b=hiWKknKA3Uv+RAwItFEidH7tF8En8kGmd7O3JP11eaVs7i7SIIGL/yiaOx/PCRYY1uCxEd/LTIvWcygd1ahcZkH+mEpft+PRJwn+OO8dHm7vNq8GHHpB/TAw09x4CyJrj/09AlQfbKdhWDMjSuYtXM1vDWpU+9FsEdRWWd+ujmk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662103195; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3CO8o09Cbv3EhQM8RnEVZK+OtlOPIn1lTkOLHv1CnTE=; b=W5zsRrwlF/h5kxLCaRIGUF+JOaUd+/tstzznMBjnRuHvC5atRCDd2MeZJerhZhyoNZfpCrPs/Ux2VH5rtENGrsPJR3LnPNX1FcavmvC6jYEf1+DkCaKaA6Y/4j9srLAun9hIzUO1NM2tVs8HpLHufXwnXb28M8mmDJFnNnSdK8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662103195704327.99567477716926; Fri, 2 Sep 2022 00:19:55 -0700 (PDT) Received: from localhost ([::1]:50820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU0y2-0007wX-7M for importer@patchew.org; Fri, 02 Sep 2022 03:19:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU0O2-0007e5-S6 for qemu-devel@nongnu.org; Fri, 02 Sep 2022 02:42:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU0O1-0004wj-CJ for qemu-devel@nongnu.org; Fri, 02 Sep 2022 02:42:42 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-550-iu3V1kjHMnS-ylObdgQ0PQ-1; Fri, 02 Sep 2022 02:41:57 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A14C29AA386; Fri, 2 Sep 2022 06:41:57 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-152.pek2.redhat.com [10.72.12.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0CBB1415137; Fri, 2 Sep 2022 06:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662100960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3CO8o09Cbv3EhQM8RnEVZK+OtlOPIn1lTkOLHv1CnTE=; b=X3wV3vFnZH5SfC9IR+zJMX82JmsIRFzj5HFR7fgz+ZXQAT/ZwsuWJ+W+GiTuRv5Ak2Uxbw RDzbTmIsfsSvxdzQBbMO49rLGcC14qF0AbliTUvEzyO1nccFtUYAM6J9iK4NV7ayEtaMlE kT8IDn1C7pQ8k1S2vPuSjHum6pjqWAg= X-MC-Unique: iu3V1kjHMnS-ylObdgQ0PQ-1 From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Lei Yang , Jason Wang Subject: [PULL 04/21] vdpa: Remove SVQ vring from iova_tree at shutdown Date: Fri, 2 Sep 2022 14:41:21 +0800 Message-Id: <20220902064138.56468-5-jasowang@redhat.com> In-Reply-To: <20220902064138.56468-1-jasowang@redhat.com> References: <20220902064138.56468-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1662103197801100001 From: Eugenio P=C3=A9rez Although the device will be reset before usage, the right thing to do is to clean it. Reported-by: Lei Yang Fixes: 34e3c94eda ("vdpa: Add custom IOTLB translations to SVQ") Signed-off-by: Eugenio P=C3=A9rez Signed-off-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 87e0ad3..e16e0e2 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -898,6 +898,12 @@ static bool vhost_vdpa_svq_unmap_ring(struct vhost_vdp= a *v, =20 size =3D ROUND_UP(result->size, qemu_real_host_page_size()); r =3D vhost_vdpa_dma_unmap(v, result->iova, size); + if (unlikely(r < 0)) { + error_report("Unable to unmap SVQ vring: %s (%d)", g_strerror(-r),= -r); + return false; + } + + vhost_iova_tree_remove(v->iova_tree, *result); return r =3D=3D 0; } =20 --=20 2.7.4