From nobody Mon Feb 9 20:32:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662051351; cv=none; d=zohomail.com; s=zohoarc; b=Zc96ErbNLoNBVvz5rXLMfzhc7wCHt2pCEugnlK4veBP8Wah35/Hz9T5vmLdy91UdxVpPYldsBzDv8nAPo3V/YXQNl4imOy23N+k6uCDAqTXujjC01XQThMOA4QxrFaAsKhQK69mF5ybhk7D67KbPSTwTc9rgotQy1Vt7y9A3xKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662051351; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Tq7c8yKqxSyAFEmOm4dcRmVPkGIjGIdrC1sBrJkCEEI=; b=lulAZsyglyvXgfLpvZLf6/yo3ZTX9/zn1JxxLjMYxic/XmhqVHua/JcAx+NPVtIb0Hpjd6Rl0YNM6GVaObfsbsTxmESL5RI9RsSzO4mTCbHSzjjUYIl/AB+tzbMnmfhF6guxHoNOts6JdDdl2MxPMxbjudtjudj+xh0jetz1sSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662051351544140.77262351744992; Thu, 1 Sep 2022 09:55:51 -0700 (PDT) Received: from localhost ([::1]:56240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTnTq-0001Gs-HV for importer@patchew.org; Thu, 01 Sep 2022 12:55:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTn2B-00022l-KR for qemu-devel@nongnu.org; Thu, 01 Sep 2022 12:27:15 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:43638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTn1z-0001Vo-ET for qemu-devel@nongnu.org; Thu, 01 Sep 2022 12:27:04 -0400 Received: by mail-ed1-x52c.google.com with SMTP id c59so17069584edf.10 for ; Thu, 01 Sep 2022 09:27:03 -0700 (PDT) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id p6-20020aa7d306000000b00447c0dcbb99sm1587672edq.83.2022.09.01.09.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 09:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Tq7c8yKqxSyAFEmOm4dcRmVPkGIjGIdrC1sBrJkCEEI=; b=CVSiw0JQLzw3T+OHlUhrC7lQuIuFEw4lwAspkjitxVs0qdqE6GgQ2CMqR3tA4tUx5y SaSJYiI3CA9dNMX2cgvSQIHWi4bcsvxTCJcIgZw8AFyGpGxQ7smwgHSNMw0o07aUOI3v M7obzpTPWVv7hBy5jNHIrFO3RVMlSJoS5YEvNOhQtX6I7q3JZ+1UhCdtIuOkImF5gf9Z O5kjwVc+qtjvTClaeGVqnzPWDLa63O+Cu4nTmSoZSsqkSZEShvdZhPjQndBvQZaZ1dlB 8nTWSKvLH2RTo/ETDPfMjQ4lz4En9soVXsfqTkBG5H9/3xD1MGxDSF+6BvNr4qwkXLtE /tDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Tq7c8yKqxSyAFEmOm4dcRmVPkGIjGIdrC1sBrJkCEEI=; b=JvYfJDHHKL6gIWxXq7fy7GF7pyzrB6BYseqBJSI/KCuNeloGqyDi3IY+5pDrhp83CI 6ECLy+X0Vt2+td9tGNS4o3/B4og4nX0QGBV2BHxpRu0ysv9JXikxJItGcsepiQ/BHGrb SKeg/Qpy6xY0Vv6g/rA2Rjsyr+18tZl/EGQusYSDtcI3GN/NaslJyE6eEiZYzgBGBbea rhkGXbvOWLnBNvq0WN88dEUmpjBNUzdoKsSIF/pMEg8QhRhhhgMawKy3sCpYL4hqxbkg t1mTViHGa2YwD9oKCqpAeqhZGny4HzsyafATjo8VHIelriREXsXkmRTG6tYvpqm9aB9k hA1w== X-Gm-Message-State: ACgBeo34kSepj83He67XiCMZEQoKAg6I5vK+Dv98x1gydRJTQ9CTYrPC gaM16NzxpMg5bVhU/j71lBm//6lDde4= X-Google-Smtp-Source: AA6agR5uFc3bocwDDeQN3R4b2nQ0kA42NWZsWwLrhO6AlKR/6l1zD6DdLmak9RhiZrXpyASczdLeZw== X-Received: by 2002:a05:6402:e96:b0:443:a086:e3e8 with SMTP id h22-20020a0564020e9600b00443a086e3e8mr30216722eda.330.1662049621964; Thu, 01 Sep 2022 09:27:01 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paolo Bonzini , Eduardo Habkost , Richard Henderson , Jiaxun Yang , Ani Sinha , Igor Mammedov , Marcel Apfelbaum , "Michael S. Tsirkin" , Bernhard Beschow Subject: [PATCH 15/42] hw/isa/piix3: Prefer pci_address_space() over get_system_memory() Date: Thu, 1 Sep 2022 18:25:46 +0200 Message-Id: <20220901162613.6939-16-shentey@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220901162613.6939-1-shentey@gmail.com> References: <20220901162613.6939-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=shentey@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1662051353453100001 Content-Type: text/plain; charset="utf-8" get_system_memory() accesses global state while pci_address_space() uses whatever has been passed to the device instance, so avoid the global. Moreover, PIIX4 uses pci_address_space() here as well. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/piix3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index 0350f70706..f8fcd47e24 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -302,7 +302,7 @@ static void pci_piix3_realize(PCIDevice *dev, Error **e= rrp) PCIBus *pci_bus =3D pci_get_bus(dev); ISABus *isa_bus; =20 - isa_bus =3D isa_bus_new(DEVICE(d), get_system_memory(), + isa_bus =3D isa_bus_new(DEVICE(d), pci_address_space(dev), pci_address_space_io(dev), errp); if (!isa_bus) { return; --=20 2.37.3