From nobody Tue Feb 10 11:33:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1662025569; cv=none; d=zohomail.com; s=zohoarc; b=RhrIv5wq7SQFXrOchpFRBPKd7adSLHzkiHm0vSyJXvNXUPyHGeQWjkuzcyPS9jSQPDQ+a7qBQWCvgeOolSLEeXy41/sqZV74GtuIYUQ8g3Urn6jfGwIOOvdyjhXvnHOWSpC2lWxpcIlaqZ/LkItGnZ6WQh+vHmaAvfH9bv6R8RM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662025569; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q13/GHV+Xl8QBDunQf5t+2hX57RWEOLNs/wV+ka6jmc=; b=H2+8LYOp3diBefX4sF8YcdujrMjTyDD7NNYTI519ayxCjYMlT0YsgFVQYPfgZDEhvAmYZu+p+KlP69SqhQUzxXyAVP4qj+ycB7GSx4oll9iBCD9kV3XUH1hMu4bmjqLNbncM6KfATu0Dhd99HVxuwYw3xjZvoMahswlaG9vOSZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1662025569258261.87937117603417; Thu, 1 Sep 2022 02:46:09 -0700 (PDT) Received: from localhost ([::1]:48072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTglz-0005Nr-Pr for importer@patchew.org; Thu, 01 Sep 2022 05:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTg2U-0000P2-9r for qemu-devel@nongnu.org; Thu, 01 Sep 2022 04:59:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTg2Q-0004vj-Rv for qemu-devel@nongnu.org; Thu, 01 Sep 2022 04:59:04 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-JMJyuIRoOJ-mYMy-vBLycA-1; Thu, 01 Sep 2022 04:58:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A87841C0690A; Thu, 1 Sep 2022 08:58:57 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E2272026D4C; Thu, 1 Sep 2022 08:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662022742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q13/GHV+Xl8QBDunQf5t+2hX57RWEOLNs/wV+ka6jmc=; b=GsuRU+o6grOl1A87sRSG/IGnEwlrGEKj9on279lN8hZuhm2PzNQPWmjvsaT6MHieGJDzga hNqm5krDNWN0XZ3FJSjo3MrMNj4alwHXbdVwaSdC0BoSjx30VQQesUb/G+vo1JxzMzmnDk VpA3tViSB/oMfH4yXFkk96eLVpgDAdU= X-MC-Unique: JMJyuIRoOJ-mYMy-vBLycA-1 From: Victor Toso To: qemu-devel@nongnu.org Cc: Eric Blake , Markus Armbruster , John Snow , Michael Roth Subject: [PATCH v2 08/10] qapi: fix examples of blockdev-add with qcow2 Date: Thu, 1 Sep 2022 10:58:38 +0200 Message-Id: <20220901085840.22520-9-victortoso@redhat.com> In-Reply-To: <20220901085840.22520-1-victortoso@redhat.com> References: <20220901085840.22520-1-victortoso@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1662025570585100001 Content-Type: text/plain; charset="utf-8" The examples use "qcow2" driver with the wrong member name for BlockdevRef alternate type. This patch changes all wrong member names from "file" to "data-file" which is the correct member name in BlockdevOptionsQcow2 for the BlockdevRef field. Problem was noticed when using the example as a test case for Go bindings. Signed-off-by: Victor Toso --- qapi/block-core.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 882b266532..f21fa235f2 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1541,8 +1541,8 @@ # -> { "execute": "blockdev-add", # "arguments": { "driver": "qcow2", # "node-name": "node1534", -# "file": { "driver": "file", -# "filename": "hd1.qcow2" }, +# "data-file": { "driver": "file", +# "filename": "hd1.qcow2" }, # "backing": null } } # # <- { "return": {} } @@ -4378,7 +4378,7 @@ # "arguments": { # "driver": "qcow2", # "node-name": "test1", -# "file": { +# "data-file": { # "driver": "file", # "filename": "test.qcow2" # } @@ -4395,7 +4395,7 @@ # "cache": { # "direct": true # }, -# "file": { +# "data-file": { # "driver": "file", # "filename": "/tmp/test.qcow2" # }, @@ -4477,7 +4477,7 @@ # "arguments": { # "driver": "qcow2", # "node-name": "node0", -# "file": { +# "data-file": { # "driver": "file", # "filename": "test.qcow2" # } --=20 2.37.2