From nobody Tue Feb 10 00:23:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661556391; cv=none; d=zohomail.com; s=zohoarc; b=fyaYlrcKR6gSl4HKWiWCs9VHIr9lBP9PyvzsvhrSPzY5VflkIQ/ryhD33dbvSKhnmtxGAO0Ls+T6ABcOzdxG13qVWZ80yG+1f7UliSgdgfkrvANTgpgSPPz3pj0uVmhbh3pRzJzcDCNzRZVgXT8CAdrbh45Rn78cePbn4Wl2aCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661556391; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OoHj0LaqAZEbzfPId1kM7cw3m7eW7SNwOHuk0WbTBQ8=; b=l6RW0xBCnOf9OXmjcY3cdeOqeo+9Z34vob7cNvDkY4mSO9key9CC9h7DSEm8K8Seclk54UgHrqFRdL2ChtfRxu1Rmosw0Ed3uoUyNudlee4xITAPK4Q3t3IIYs8F6wxXObl6zwRmQZ4C5RE6LC7wvQQLYGsRr8SkxUEskVhcxCk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166155639176442.85145930565409; Fri, 26 Aug 2022 16:26:31 -0700 (PDT) Received: from localhost ([::1]:60720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRiib-0001N1-Qc for importer@patchew.org; Fri, 26 Aug 2022 19:26:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRiVj-0007GD-Ui for qemu-devel@nongnu.org; Fri, 26 Aug 2022 19:13:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRiVP-0007qe-KP for qemu-devel@nongnu.org; Fri, 26 Aug 2022 19:13:11 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-673-xOufiQrvMIeRRCbc-5FRMg-1; Fri, 26 Aug 2022 19:12:39 -0400 Received: by mail-ed1-f69.google.com with SMTP id y20-20020a056402359400b00447a871c48fso1863206edc.3 for ; Fri, 26 Aug 2022 16:12:38 -0700 (PDT) Received: from goa-sendmail ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.gmail.com with ESMTPSA id q18-20020a17090676d200b00730860b6c43sm1387051ejn.173.2022.08.26.16.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 16:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661555560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OoHj0LaqAZEbzfPId1kM7cw3m7eW7SNwOHuk0WbTBQ8=; b=JJGT/EjJG+Y7J57Z3T9JbyboSV1hyX8llf0gxgLg5zEy83bOKc5UK1as73RJL9oIl6YcSH b+J1hDx8Zctyy+VwbJb47YEr5oJMtJhitHCxjEWkhOxlZs+9Uw0VhhBkYGW0QPX6LPSC0k cic070fa8UoFkE+L6IcuFL3uWoQ3mC4= X-MC-Unique: xOufiQrvMIeRRCbc-5FRMg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=OoHj0LaqAZEbzfPId1kM7cw3m7eW7SNwOHuk0WbTBQ8=; b=srrKpRAyKkoTI/wkFZKBiLsdXHptu6mS17pEJ1cMapDt/1ndlFMzPquwMGnybTocvd Ey/QZrHrSuHq1HB1oZ42hx3GVvhQ/5fXvkplGvfOHIYTLdymj3t8GYmMArkr4pKzwvHM +eA1nxYb6h+qGzX+PzaT4vRax8oekBFxZQZ7VuhXs+T7/wYROJH2ANywSM5ODDhBQBPK hG3XjC/PpzQAWvP8CCEKjV2SmvHdhfCjRhB9yX6/i1Tk0LhzFXIEsIVWkC0nbqhptlp1 lj2TvBCRJo6xc+u7sivOgfV8y1hq6OI9Z4SeesyW+Rp1YRNdlRRCm/7aDKZq3Ou8Pm9v 5VTg== X-Gm-Message-State: ACgBeo0vDj0UYJOQJs+iD6sX+gARufuoU2MRPx+7whYKWQp4Qb+C3R7p Tl54li+K6F/pkLuQDc1rSRy4amqRVdO9nz1p6a62XOfhwlveh/6jzKZFOboJ7gd8Bueutdzsn+j YbgZdLgamirV/bdf5AdN1YunNSaKkMw5t8ZvfE3cFxm00xDV3j0enIT15mkbVOpnI4Pw= X-Received: by 2002:a05:6402:1745:b0:448:116b:12fb with SMTP id v5-20020a056402174500b00448116b12fbmr1446997edx.421.1661555557279; Fri, 26 Aug 2022 16:12:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR5cEcdw3ybKm0akVerCDOiGkZBlyMWPJoANj+o762T1vKPs6Yf2HTAK1eDikPYKryv+VE0wUA== X-Received: by 2002:a05:6402:1745:b0:448:116b:12fb with SMTP id v5-20020a056402174500b00448116b12fbmr1446978edx.421.1661555556872; Fri, 26 Aug 2022 16:12:36 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, paul@nowt.org Subject: [PATCH 14/23] i386: Misc integer AVX helper prep Date: Sat, 27 Aug 2022 01:11:55 +0200 Message-Id: <20220826231204.201395-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220826231204.201395-1-pbonzini@redhat.com> References: <20220826231204.201395-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661556393105100001 Content-Type: text/plain; charset="utf-8" From: Paul Brook More preparatory work for AVX support in various integer vector helpers No functional changes to existing helpers. Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-13-paul@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 164 +++++++++++++++++++++--------------------- 1 file changed, 80 insertions(+), 84 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 8395733432..9ea763cad2 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -384,19 +384,22 @@ SSE_HELPER_W(helper_pavgw, FAVG) =20 void glue(helper_pmuludq, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) { - d->Q(0) =3D (uint64_t)s->L(0) * (uint64_t)d->L(0); -#if SHIFT =3D=3D 1 - d->Q(1) =3D (uint64_t)s->L(2) * (uint64_t)d->L(2); -#endif + Reg *v =3D d; + int i; + + for (i =3D 0; i < (1 << SHIFT); i++) { + d->Q(i) =3D (uint64_t)s->L(i * 2) * (uint64_t)v->L(i * 2); + } } =20 void glue(helper_pmaddwd, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) { + Reg *v =3D d; int i; =20 for (i =3D 0; i < (2 << SHIFT); i++) { - d->L(i) =3D (int16_t)s->W(2 * i) * (int16_t)d->W(2 * i) + - (int16_t)s->W(2 * i + 1) * (int16_t)d->W(2 * i + 1); + d->L(i) =3D (int16_t)s->W(2 * i) * (int16_t)v->W(2 * i) + + (int16_t)s->W(2 * i + 1) * (int16_t)v->W(2 * i + 1); } } =20 @@ -410,32 +413,24 @@ static inline int abs1(int a) } } #endif + void glue(helper_psadbw, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) { - unsigned int val; + Reg *v =3D d; + int i; =20 - val =3D 0; - val +=3D abs1(d->B(0) - s->B(0)); - val +=3D abs1(d->B(1) - s->B(1)); - val +=3D abs1(d->B(2) - s->B(2)); - val +=3D abs1(d->B(3) - s->B(3)); - val +=3D abs1(d->B(4) - s->B(4)); - val +=3D abs1(d->B(5) - s->B(5)); - val +=3D abs1(d->B(6) - s->B(6)); - val +=3D abs1(d->B(7) - s->B(7)); - d->Q(0) =3D val; -#if SHIFT =3D=3D 1 - val =3D 0; - val +=3D abs1(d->B(8) - s->B(8)); - val +=3D abs1(d->B(9) - s->B(9)); - val +=3D abs1(d->B(10) - s->B(10)); - val +=3D abs1(d->B(11) - s->B(11)); - val +=3D abs1(d->B(12) - s->B(12)); - val +=3D abs1(d->B(13) - s->B(13)); - val +=3D abs1(d->B(14) - s->B(14)); - val +=3D abs1(d->B(15) - s->B(15)); - d->Q(1) =3D val; -#endif + for (i =3D 0; i < (1 << SHIFT); i++) { + unsigned int val =3D 0; + val +=3D abs1(v->B(8 * i + 0) - s->B(8 * i + 0)); + val +=3D abs1(v->B(8 * i + 1) - s->B(8 * i + 1)); + val +=3D abs1(v->B(8 * i + 2) - s->B(8 * i + 2)); + val +=3D abs1(v->B(8 * i + 3) - s->B(8 * i + 3)); + val +=3D abs1(v->B(8 * i + 4) - s->B(8 * i + 4)); + val +=3D abs1(v->B(8 * i + 5) - s->B(8 * i + 5)); + val +=3D abs1(v->B(8 * i + 6) - s->B(8 * i + 6)); + val +=3D abs1(v->B(8 * i + 7) - s->B(8 * i + 7)); + d->Q(i) =3D val; + } } =20 void glue(helper_maskmov, SUFFIX)(CPUX86State *env, Reg *d, Reg *s, @@ -452,20 +447,24 @@ void glue(helper_maskmov, SUFFIX)(CPUX86State *env, R= eg *d, Reg *s, =20 void glue(helper_movl_mm_T0, SUFFIX)(Reg *d, uint32_t val) { + int i; + d->L(0) =3D val; d->L(1) =3D 0; -#if SHIFT =3D=3D 1 - d->Q(1) =3D 0; -#endif + for (i =3D 1; i < (1 << SHIFT); i++) { + d->Q(i) =3D 0; + } } =20 #ifdef TARGET_X86_64 void glue(helper_movq_mm_T0, SUFFIX)(Reg *d, uint64_t val) { + int i; + d->Q(0) =3D val; -#if SHIFT =3D=3D 1 - d->Q(1) =3D 0; -#endif + for (i =3D 1; i < (1 << SHIFT); i++) { + d->Q(i) =3D 0; + } } #endif =20 @@ -1068,26 +1067,21 @@ uint32_t glue(helper_movmskpd, SUFFIX)(CPUX86State = *env, Reg *s) uint32_t glue(helper_pmovmskb, SUFFIX)(CPUX86State *env, Reg *s) { uint32_t val; + int i; =20 val =3D 0; - val |=3D (s->B(0) >> 7); - val |=3D (s->B(1) >> 6) & 0x02; - val |=3D (s->B(2) >> 5) & 0x04; - val |=3D (s->B(3) >> 4) & 0x08; - val |=3D (s->B(4) >> 3) & 0x10; - val |=3D (s->B(5) >> 2) & 0x20; - val |=3D (s->B(6) >> 1) & 0x40; - val |=3D (s->B(7)) & 0x80; -#if SHIFT =3D=3D 1 - val |=3D (s->B(8) << 1) & 0x0100; - val |=3D (s->B(9) << 2) & 0x0200; - val |=3D (s->B(10) << 3) & 0x0400; - val |=3D (s->B(11) << 4) & 0x0800; - val |=3D (s->B(12) << 5) & 0x1000; - val |=3D (s->B(13) << 6) & 0x2000; - val |=3D (s->B(14) << 7) & 0x4000; - val |=3D (s->B(15) << 8) & 0x8000; -#endif + for (i =3D 0; i < (1 << SHIFT); i++) { + uint8_t byte =3D 0; + byte |=3D (s->B(8 * i + 0) >> 7); + byte |=3D (s->B(8 * i + 1) >> 6) & 0x02; + byte |=3D (s->B(8 * i + 2) >> 5) & 0x04; + byte |=3D (s->B(8 * i + 3) >> 4) & 0x08; + byte |=3D (s->B(8 * i + 4) >> 3) & 0x10; + byte |=3D (s->B(8 * i + 5) >> 2) & 0x20; + byte |=3D (s->B(8 * i + 6) >> 1) & 0x40; + byte |=3D (s->B(8 * i + 7)) & 0x80; + val |=3D byte << (8 * i); + } return val; } =20 @@ -1632,46 +1626,48 @@ SSE_HELPER_V(helper_blendvpd, Q, 2, FBLENDVPD) =20 void glue(helper_ptest, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) { - uint64_t zf =3D (s->Q(0) & d->Q(0)) | (s->Q(1) & d->Q(1)); - uint64_t cf =3D (s->Q(0) & ~d->Q(0)) | (s->Q(1) & ~d->Q(1)); + uint64_t zf =3D 0, cf =3D 0; + int i; =20 + for (i =3D 0; i < 1 << SHIFT; i++) { + zf |=3D (s->Q(i) & d->Q(i)); + cf |=3D (s->Q(i) & ~d->Q(i)); + } CC_SRC =3D (zf ? 0 : CC_Z) | (cf ? 0 : CC_C); } =20 -#define SSE_HELPER_F(name, elem, num, F) \ - void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ - { \ - if (num > 2) { \ - if (num > 4) { \ - d->elem(7) =3D F(7); \ - d->elem(6) =3D F(6); \ - d->elem(5) =3D F(5); \ - d->elem(4) =3D F(4); \ - } \ - d->elem(3) =3D F(3); \ - d->elem(2) =3D F(2); \ - } \ - d->elem(1) =3D F(1); \ - d->elem(0) =3D F(0); \ +#define SSE_HELPER_F(name, elem, num, F) \ + void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ + { \ + int n =3D num; \ + for (int i =3D n; --i >=3D 0; ) { \ + d->elem(i) =3D F(i); \ + } \ } =20 -SSE_HELPER_F(helper_pmovsxbw, W, 8, (int8_t) s->B) -SSE_HELPER_F(helper_pmovsxbd, L, 4, (int8_t) s->B) -SSE_HELPER_F(helper_pmovsxbq, Q, 2, (int8_t) s->B) -SSE_HELPER_F(helper_pmovsxwd, L, 4, (int16_t) s->W) -SSE_HELPER_F(helper_pmovsxwq, Q, 2, (int16_t) s->W) -SSE_HELPER_F(helper_pmovsxdq, Q, 2, (int32_t) s->L) -SSE_HELPER_F(helper_pmovzxbw, W, 8, s->B) -SSE_HELPER_F(helper_pmovzxbd, L, 4, s->B) -SSE_HELPER_F(helper_pmovzxbq, Q, 2, s->B) -SSE_HELPER_F(helper_pmovzxwd, L, 4, s->W) -SSE_HELPER_F(helper_pmovzxwq, Q, 2, s->W) -SSE_HELPER_F(helper_pmovzxdq, Q, 2, s->L) +#if SHIFT > 0 +SSE_HELPER_F(helper_pmovsxbw, W, 4 << SHIFT, (int8_t) s->B) +SSE_HELPER_F(helper_pmovsxbd, L, 2 << SHIFT, (int8_t) s->B) +SSE_HELPER_F(helper_pmovsxbq, Q, 1 << SHIFT, (int8_t) s->B) +SSE_HELPER_F(helper_pmovsxwd, L, 2 << SHIFT, (int16_t) s->W) +SSE_HELPER_F(helper_pmovsxwq, Q, 1 << SHIFT, (int16_t) s->W) +SSE_HELPER_F(helper_pmovsxdq, Q, 1 << SHIFT, (int32_t) s->L) +SSE_HELPER_F(helper_pmovzxbw, W, 4 << SHIFT, s->B) +SSE_HELPER_F(helper_pmovzxbd, L, 2 << SHIFT, s->B) +SSE_HELPER_F(helper_pmovzxbq, Q, 1 << SHIFT, s->B) +SSE_HELPER_F(helper_pmovzxwd, L, 2 << SHIFT, s->W) +SSE_HELPER_F(helper_pmovzxwq, Q, 1 << SHIFT, s->W) +SSE_HELPER_F(helper_pmovzxdq, Q, 1 << SHIFT, s->L) +#endif =20 void glue(helper_pmuldq, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) { - d->Q(0) =3D (int64_t)(int32_t) d->L(0) * (int32_t) s->L(0); - d->Q(1) =3D (int64_t)(int32_t) d->L(2) * (int32_t) s->L(2); + Reg *v =3D d; + int i; + + for (i =3D 0; i < 1 << SHIFT; i++) { + d->Q(i) =3D (int64_t)(int32_t) v->L(2 * i) * (int32_t) s->L(2 * i); + } } =20 #define FCMPEQQ(d, s) (d =3D=3D s ? -1 : 0) --=20 2.37.1