From nobody Tue Feb 10 03:39:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661556524; cv=none; d=zohomail.com; s=zohoarc; b=KOWrW9CvWZ1SPZNXsyDvIZ0fqCU/a9WSb4GRVnl6vI6WGCyCJr6XYGjDnpsee38BsCppgbTiQunCeGAlDuYTL09NBKDlJScPa+xlJb47sdePhwqj0PTc8Q7dhDD6vb8/3LjnD0AlAn96Auqmto+wrbBSxkQ1vugdKL71R3E0e5s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661556524; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vLmD0zmrzApy3raDGv/uUpAiWJQdUPxyPzWTBxnFFXI=; b=Ts8yBRcqJAgDKllYMUiHJXXSKh8fq0ANlYMDmWdovS2wHB0440zkLh39xdgGMBpROAoS5eEQG21PkNMnxOcHIFifoNRMxhDKGTt3DmunpqkJZGn2s88uylldOXkN3OMii8UjVDvbFfFSdR7er6EUnsUp23zwBh456jFkSWjwUpM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661556524095870.2521896411068; Fri, 26 Aug 2022 16:28:44 -0700 (PDT) Received: from localhost ([::1]:55226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRikk-0006fD-1w for importer@patchew.org; Fri, 26 Aug 2022 19:28:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRiVi-0007EH-Iz for qemu-devel@nongnu.org; Fri, 26 Aug 2022 19:13:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRiVG-0007qV-Mv for qemu-devel@nongnu.org; Fri, 26 Aug 2022 19:13:10 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-651-4kMN76ZmO0K_d6xYtrfsHg-1; Fri, 26 Aug 2022 19:12:32 -0400 Received: by mail-ed1-f71.google.com with SMTP id b13-20020a056402350d00b0043dfc84c533so1842512edd.5 for ; Fri, 26 Aug 2022 16:12:32 -0700 (PDT) Received: from goa-sendmail ([93.56.160.208]) by smtp.gmail.com with ESMTPSA id ch4-20020a0564021bc400b00445d760fc69sm1970009edb.50.2022.08.26.16.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 16:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661555553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vLmD0zmrzApy3raDGv/uUpAiWJQdUPxyPzWTBxnFFXI=; b=C3etWHFOqB8gm7R3Zx4VJHHiiASiEAbQGyZ9j9fOH6JE2qOEaGeUec9XcVH00oQaCvptEc U+YMcL6dIyzHrEJQ7uqvkMUAM2/fKKbhouRVsU+mx24yZB8YTItcZCYJDFicABuIeoehRm 5JQahjwIw4T4jwfjOkNVZt98msp98dE= X-MC-Unique: 4kMN76ZmO0K_d6xYtrfsHg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vLmD0zmrzApy3raDGv/uUpAiWJQdUPxyPzWTBxnFFXI=; b=4qJXBYoFiu2ZU/Jm4b2CTWHYlWxME5h86cK64LK2I4zDR+qZNGA4TSyFJ4EdRBCEHQ /6/AMxMKOQjSxzcmJmtmakm5vA2zG47TyTJKCLtkn1Q+s5+z29lXIDK4VCwJmXFFBtN1 gT6Tt/t1a4otlJK6TQBy34GdfmDYsmxQk/UxRBYw+DpbL9nMkBIOCZW9DxKVkkgyRuD1 ZNgnha0EJrSVlDW0UeqkKqM2EFoVKQw4nZ8oWwpr5MEEjOZxnLpecYW9pz6f4lMQbNcH btqVIAJWPoAKZbeDdLcsFFb0rdU/SwDeh3on1HyHc798XnAfWF+Kuw8R/E6PDvb+uCgD al9g== X-Gm-Message-State: ACgBeo1P84zpzHaay7wT0Sp4SkMDg8C11E59FILuBFBHyXEIrdgrJIB5 5SC7W65mshVdXvar1UPNoX33YI5dSs9ijY0b1bZ78YGj6kNFWO78D1QWgD9J5ajFJXdW/4eKOda ktwod1tv8KXf6xK8SFvv0E3KY8Q0Sf21t6bW8J0uBc49w2LvyU+gg8kgxjq+zYHxSf60= X-Received: by 2002:a05:6402:5cd:b0:446:5965:f4af with SMTP id n13-20020a05640205cd00b004465965f4afmr8310324edx.12.1661555550910; Fri, 26 Aug 2022 16:12:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR6wg1uBEmKVv/jrvOVhg2pF6L3yIoy/aoH31LeyYmTWQx0EFQbMQSnlYxA7J/UjHCa/SwI8YA== X-Received: by 2002:a05:6402:5cd:b0:446:5965:f4af with SMTP id n13-20020a05640205cd00b004465965f4afmr8310306edx.12.1661555550531; Fri, 26 Aug 2022 16:12:30 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, paul@nowt.org Subject: [PATCH 13/23] i386: Rewrite simple integer vector helpers Date: Sat, 27 Aug 2022 01:11:54 +0200 Message-Id: <20220826231204.201395-14-pbonzini@redhat.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220826231204.201395-1-pbonzini@redhat.com> References: <20220826231204.201395-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661556525751100001 Content-Type: text/plain; charset="utf-8" From: Paul Brook Rewrite the "simple" vector integer helpers in preperation for AVX support. While the current code is able to use the same prototype for unary (a =3D F(b)) and binary (a =3D F(b, c)) operations, future changes will cau= se them to diverge. No functional changes to existing helpers Signed-off-by: Paul Brook Message-Id: <20220424220204.2493824-12-paul@nowt.org> Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 83 +++++++++++++++---------------------------- 1 file changed, 28 insertions(+), 55 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 8c745f5cab..8395733432 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -223,63 +223,36 @@ void glue(helper_pslldq, SUFFIX)(CPUX86State *env, Re= g *d, Reg *c) } #endif =20 -#define SSE_HELPER_B(name, F) \ +#define SSE_HELPER_1(name, elem, num, F) \ void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ { \ - d->B(0) =3D F(d->B(0), s->B(0)); \ - d->B(1) =3D F(d->B(1), s->B(1)); \ - d->B(2) =3D F(d->B(2), s->B(2)); \ - d->B(3) =3D F(d->B(3), s->B(3)); \ - d->B(4) =3D F(d->B(4), s->B(4)); \ - d->B(5) =3D F(d->B(5), s->B(5)); \ - d->B(6) =3D F(d->B(6), s->B(6)); \ - d->B(7) =3D F(d->B(7), s->B(7)); \ - XMM_ONLY( \ - d->B(8) =3D F(d->B(8), s->B(8)); \ - d->B(9) =3D F(d->B(9), s->B(9)); \ - d->B(10) =3D F(d->B(10), s->B(10)); \ - d->B(11) =3D F(d->B(11), s->B(11)); \ - d->B(12) =3D F(d->B(12), s->B(12)); \ - d->B(13) =3D F(d->B(13), s->B(13)); \ - d->B(14) =3D F(d->B(14), s->B(14)); \ - d->B(15) =3D F(d->B(15), s->B(15)); \ - ) \ - } + int n =3D num; \ + for (int i =3D 0; i < n; i++) { \ + d->elem(i) =3D F(s->elem(i)); \ + } \ + } + +#define SSE_HELPER_2(name, elem, num, F) \ + void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ + { \ + Reg *v =3D d; \ + int n =3D num; \ + for (int i =3D 0; i < n; i++) { \ + d->elem(i) =3D F(v->elem(i), s->elem(i)); \ + } \ + } + +#define SSE_HELPER_B(name, F) \ + SSE_HELPER_2(name, B, 8 << SHIFT, F) =20 #define SSE_HELPER_W(name, F) \ - void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ - { \ - d->W(0) =3D F(d->W(0), s->W(0)); \ - d->W(1) =3D F(d->W(1), s->W(1)); \ - d->W(2) =3D F(d->W(2), s->W(2)); \ - d->W(3) =3D F(d->W(3), s->W(3)); \ - XMM_ONLY( \ - d->W(4) =3D F(d->W(4), s->W(4)); \ - d->W(5) =3D F(d->W(5), s->W(5)); \ - d->W(6) =3D F(d->W(6), s->W(6)); \ - d->W(7) =3D F(d->W(7), s->W(7)); \ - ) \ - } + SSE_HELPER_2(name, W, 4 << SHIFT, F) =20 #define SSE_HELPER_L(name, F) \ - void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ - { \ - d->L(0) =3D F(d->L(0), s->L(0)); \ - d->L(1) =3D F(d->L(1), s->L(1)); \ - XMM_ONLY( \ - d->L(2) =3D F(d->L(2), s->L(2)); \ - d->L(3) =3D F(d->L(3), s->L(3)); \ - ) \ - } + SSE_HELPER_2(name, L, 2 << SHIFT, F) =20 #define SSE_HELPER_Q(name, F) \ - void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) \ - { \ - d->Q(0) =3D F(d->Q(0), s->Q(0)); \ - XMM_ONLY( \ - d->Q(1) =3D F(d->Q(1), s->Q(1)); \ - ) \ - } + SSE_HELPER_2(name, Q, 1 << SHIFT, F) =20 #if SHIFT =3D=3D 0 static inline int satub(int x) @@ -1538,12 +1511,12 @@ void glue(helper_phsubsw, SUFFIX)(CPUX86State *env,= Reg *d, Reg *s) MOVE(*d, r); } =20 -#define FABSB(_, x) (x > INT8_MAX ? -(int8_t)x : x) -#define FABSW(_, x) (x > INT16_MAX ? -(int16_t)x : x) -#define FABSL(_, x) (x > INT32_MAX ? -(int32_t)x : x) -SSE_HELPER_B(helper_pabsb, FABSB) -SSE_HELPER_W(helper_pabsw, FABSW) -SSE_HELPER_L(helper_pabsd, FABSL) +#define FABSB(x) (x > INT8_MAX ? -(int8_t)x : x) +#define FABSW(x) (x > INT16_MAX ? -(int16_t)x : x) +#define FABSL(x) (x > INT32_MAX ? -(int32_t)x : x) +SSE_HELPER_1(helper_pabsb, B, 8 << SHIFT, FABSB) +SSE_HELPER_1(helper_pabsw, W, 4 << SHIFT, FABSW) +SSE_HELPER_1(helper_pabsd, L, 2 << SHIFT, FABSL) =20 #define FMULHRSW(d, s) (((int16_t) d * (int16_t)s + 0x4000) >> 15) SSE_HELPER_W(helper_pmulhrsw, FMULHRSW) --=20 2.37.1