From nobody Mon May 13 12:24:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661208087; cv=none; d=zohomail.com; s=zohoarc; b=Jsk/UWOtHTfpOOrZTlHhIXhZyxo98D1lAOnyqG5rloPXCO31cD438pMiMTYrUNZOmwHI/SC8eKO0LEBUkQyWw/DV1r5f200r/UX6HipSwg4artw1A5iZZjdIPcuzXpgeedPoRprUN/qgjztTR5yM+KSeByu9ACVUXzCAVtjUzXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661208087; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FxBKtNdKCbvnEBi8NC2mirytLCYQG5plUdqkpMMvZXU=; b=A139rfJCQOgaQBLMobcMOb4xECu7jncQ8vrxblCpY+ktEr1QhUYNQdDfAI5Frp0Z7rtkSti8heRcIGKo8Zg6zZVVWgxPzunO/X0Wb5YcFQywpWxFw2cY/jfIQwn0hJWO5PG74xynaJ4yHhe/WtgMj8y0YMbxPVAOyVGJZjVuF5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661208087077102.83382118977352; Mon, 22 Aug 2022 15:41:27 -0700 (PDT) Received: from localhost ([::1]:44354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQG6o-0005tj-2c for importer@patchew.org; Mon, 22 Aug 2022 18:41:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQG31-000329-CF for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:31 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:40858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQG2y-0006YA-Ot for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:31 -0400 Received: by mail-pl1-x634.google.com with SMTP id x23so11207231pll.7 for ; Mon, 22 Aug 2022 15:37:28 -0700 (PDT) Received: from stoup.. ([71.212.157.236]) by smtp.gmail.com with ESMTPSA id z6-20020a63e106000000b0042a2777550dsm7017419pgh.47.2022.08.22.15.37.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 15:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=FxBKtNdKCbvnEBi8NC2mirytLCYQG5plUdqkpMMvZXU=; b=BJoIhenf+6spGMQNp1eAc1VMAmjwjprGfLbqyetbzetd6+06/9lOoA9oLQ+36Xh7fq qSalRs2ef/AKgcymgCYo3cfy8hGDuJ4DRLfV1xXi/OgAlmhRxZV6k4huG6cCnQK6++A8 z8p5P+QH008DllxjaiSspdOm74rHAw5n0GTop1k1j5XwCHdf3xD4eSH8zBWQYg0Vd7EQ A1edkmDThcB8TId7qOwQD9aVL51LV2zfTZpiPvQCrlotbQ0l17l1Kk0j27Y4uZIj0RIv 975o1Y0LHa+vjurbmdtYzVMw9vNlSsiK9aYQ9M35wBlnVuamSxGdjypq1TsYWw8rgv7v WWXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=FxBKtNdKCbvnEBi8NC2mirytLCYQG5plUdqkpMMvZXU=; b=xZXRu5kmvRwCYs7emge6otjxnWV/hhwN7MgPKoukhwpD+4NiRujqaW7gFBMo8odjyz 2Qz/LMbr3EI4Res4s7WRXvIZqdhy/Z9coQsif6tMubequMuJiQjlj5XZKoAiVXZ979wE jSVx8FWrB5wwJYk03qbxV1fEJBwYvjKq2cR6sbm5QxrvxGFSWbGlshAIlIu7wM8gzlpx 9+shEPY/n73qdIo4iGdZjYMMBu4soeTJ4BHJxvgsljFYYS+K7DNj03yHeOlrRlwqAzj/ tcgwLLEZhyPxVVGkUerpxL06bGXV1/F6PNWh2cSfcYHwW5wl62NaFZ5taKwXYQjaipAO fG5g== X-Gm-Message-State: ACgBeo0iCIvR6C54PkecAbLkwaw/tc9z7YNyw4q6Kmli23h5cKfvq2Cc 3JBI9gtYCoo78bMW5kl1MlN+U2LK1qU6NQ== X-Google-Smtp-Source: AA6agR7e+ogvLMCJtLR+1hDfjZ5zHXqs9fjEWmeXlGoz4YVJKOCgHBr68F/zmxzqCTLq0pDSPmzPbQ== X-Received: by 2002:a17:902:7845:b0:16e:d647:a66c with SMTP id e5-20020a170902784500b0016ed647a66cmr21513613pln.64.1661207847248; Mon, 22 Aug 2022 15:37:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/6] target/i386: Define XMMReg and access macros Date: Mon, 22 Aug 2022 15:37:17 -0700 Message-Id: <20220822223722.1697758-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822223722.1697758-1-richard.henderson@linaro.org> References: <20220822223722.1697758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661208087422100001 Content-Type: text/plain; charset="utf-8" This will be used for proper endian adjustments of gvec xmm ops. Signed-off-by: Richard Henderson --- target/i386/cpu.h | 53 +++++++++++++++++++++++++++++++++++++---------- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 82004b65b9..81e5abed86 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1233,18 +1233,33 @@ typedef struct SegmentCache { uint32_t flags; } SegmentCache; =20 -#define MMREG_UNION(n, bits) \ - union n { \ - uint8_t _b_##n[(bits)/8]; \ - uint16_t _w_##n[(bits)/16]; \ - uint32_t _l_##n[(bits)/32]; \ - uint64_t _q_##n[(bits)/64]; \ - float32 _s_##n[(bits)/32]; \ - float64 _d_##n[(bits)/64]; \ - } +typedef union MMXReg { + uint8_t _b_MMXReg[64 / 8]; + uint16_t _w_MMXReg[64 / 16]; + uint32_t _l_MMXReg[64 / 32]; + uint64_t _q_MMXReg[64 / 64]; + float32 _s_MMXReg[64 / 32]; + float64 _d_MMXReg[64 / 64]; +} MMXReg; =20 -typedef MMREG_UNION(ZMMReg, 512) ZMMReg; -typedef MMREG_UNION(MMXReg, 64) MMXReg; +typedef union XMMReg { + uint8_t _b_XMMReg[128 / 8]; + uint16_t _w_XMMReg[128 / 16]; + uint32_t _l_XMMReg[128 / 32]; + uint64_t _q_XMMReg[128 / 64]; + float32 _s_XMMReg[128 / 32]; + float64 _d_XMMReg[128 / 64]; +} XMMReg; + +typedef union ZMMReg { + uint8_t _b_ZMMReg[512 / 8]; + uint16_t _w_ZMMReg[512 / 16]; + uint32_t _l_ZMMReg[512 / 32]; + uint64_t _q_ZMMReg[512 / 64]; + float32 _s_ZMMReg[512 / 32]; + float64 _d_ZMMReg[512 / 64]; + XMMReg _x_ZMMReg[512 / 128]; +} ZMMReg; =20 typedef struct BNDReg { uint64_t lb; @@ -1267,6 +1282,14 @@ typedef struct BNDCSReg { #define ZMM_S(n) _s_ZMMReg[15 - (n)] #define ZMM_Q(n) _q_ZMMReg[7 - (n)] #define ZMM_D(n) _d_ZMMReg[7 - (n)] +#define ZMM_X(n) _x_ZMMReg[3 - (n)] + +#define XMM_B(n) _b_XMMReg[15 - (n)] +#define XMM_W(n) _w_XMMReg[7 - (n)] +#define XMM_L(n) _l_XMMReg[3 - (n)] +#define XMM_S(n) _s_XMMReg[3 - (n)] +#define XMM_Q(n) _q_XMMReg[1 - (n)] +#define XMM_D(n) _d_XMMReg[1 - (n)] =20 #define MMX_B(n) _b_MMXReg[7 - (n)] #define MMX_W(n) _w_MMXReg[3 - (n)] @@ -1279,6 +1302,14 @@ typedef struct BNDCSReg { #define ZMM_S(n) _s_ZMMReg[n] #define ZMM_Q(n) _q_ZMMReg[n] #define ZMM_D(n) _d_ZMMReg[n] +#define ZMM_X(n) _x_ZMMReg[n] + +#define XMM_B(n) _b_XMMReg[n] +#define XMM_W(n) _w_XMMReg[n] +#define XMM_L(n) _l_XMMReg[n] +#define XMM_S(n) _s_XMMReg[n] +#define XMM_Q(n) _q_XMMReg[n] +#define XMM_D(n) _d_XMMReg[n] =20 #define MMX_B(n) _b_MMXReg[n] #define MMX_W(n) _w_MMXReg[n] --=20 2.34.1 From nobody Mon May 13 12:24:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661208199; cv=none; d=zohomail.com; s=zohoarc; b=fTMpZPL9URzrzcJ9wGQeoF8WE6a9nUxuDP7hqGtCfBfYcz2D7zXNtxDQeHu/Az4iy3IZ/uYXL19nnsDOkerIBVEVD2iHGG1lXJksDVQNgmTOj/HTtaFY9qADNhwtndGQTR5I1m7lMGpfgSSHuIvAkqOANxxBYkvPSbWHoJYzZzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661208199; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4u95VxfqvBGod4zfdlpuG3vmFuF0V5wI5kkybhZ/c/k=; b=IDsc/AvcqCRpztVbeSY5V90S7T2FrG9qN440O7v86/3e7Q4DJQeTBuHO88b312sS530TZFFsM1H1IqfvTsjwt6lfMDyTi0QqqO/V3D+tnVqqcOma/fG5xSs5/g4ycO0AVDGQZL98ap3H4tf3OyXAouLla54bXdyciRpQE8Kcx8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661208199416392.95740346035313; Mon, 22 Aug 2022 15:43:19 -0700 (PDT) Received: from localhost ([::1]:51442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQG8b-0001Np-Af for importer@patchew.org; Mon, 22 Aug 2022 18:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQG32-00034J-9O for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:32 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:41626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQG30-0006YO-GI for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:31 -0400 Received: by mail-pf1-x42c.google.com with SMTP id g129so8410110pfb.8 for ; Mon, 22 Aug 2022 15:37:29 -0700 (PDT) Received: from stoup.. ([71.212.157.236]) by smtp.gmail.com with ESMTPSA id z6-20020a63e106000000b0042a2777550dsm7017419pgh.47.2022.08.22.15.37.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 15:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=4u95VxfqvBGod4zfdlpuG3vmFuF0V5wI5kkybhZ/c/k=; b=e44agr79+ksY9xUEWeQcKZFPe/NEHxa/+yQc2tUUNBEHnVevKeDmnGYymZd01kjBR5 EbOYZ27up46hYthFJWFsTGz86hWJzPvM59ntdwbtZ4eUWzq+o+hfBvJN1Pfa2963J7/2 Jl7D2+CTBPjzDCdeXUpJlhdjJbq1s67h6dPw4MuHtWwS4uIgDK2+opCBQn8wZwEcrYgY YWoe71upGZCh8Z1PXtmt8OGgTXMWRzZvGR9BrsZY/ZkvgfZqc59KSNDAfS4SKC61l9Y/ DsWKqCqk9OjJqFE6SSk44a3CJ0Hz/xbDidMSCul8+8NLBp+QytBysbsQnFdAyrJCFypw t1TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=4u95VxfqvBGod4zfdlpuG3vmFuF0V5wI5kkybhZ/c/k=; b=7V8s+inB2NnCk2lxBBp9F0Ne5tE5GinrDRGJeSu4D9t/LxG0ED8AdsZcIYj14A7EJa KIcIJi8X1/rauG4nZ/5aCvACzM171Ls7Xyn3JkXhrGh8Whsl5RaUdmH2s86BprebD40/ flkpJEIj0MNblol5YXwTe9MDlFJs3vHPF15vA5jhNgU55dH52IkF+Kf3YgXx0QWlyHGA M0WCn//Wu6J2NuQYVXjMOISrKMfIHZRFCLUqJ+XvGNhBNRznBKz9evyuwBqIRx766UE5 iqgvVJVnhhmHIpbt0aCLPe0OPjc3Xlk/tMKU1Fh3uxkOb/2PJPW6tmBoB5xZvpUNQESh TYgQ== X-Gm-Message-State: ACgBeo1Gtpy9sMOvSA6EEDWc/+zed26Emx37DaqfM4FNJX451cdajcfE mhbcZEkUVUWpSAE92GNYRfMqh2gTReAxXQ== X-Google-Smtp-Source: AA6agR7tx685T9ZNS967PMQ50pv4V8A5TnsgdrlMNDCddz0qT53CRk6PUro13cy9RQYiwsnQS2WmIw== X-Received: by 2002:a63:e242:0:b0:421:9053:8923 with SMTP id y2-20020a63e242000000b0042190538923mr18217579pgj.283.1661207848543; Mon, 22 Aug 2022 15:37:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/6] target/i386: Use tcg gvec for gen_op_movo Date: Mon, 22 Aug 2022 15:37:18 -0700 Message-Id: <20220822223722.1697758-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822223722.1697758-1-richard.henderson@linaro.org> References: <20220822223722.1697758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661208199860100001 Content-Type: text/plain; charset="utf-8" Low hanging fruit, using gvec to move 16 bytes. Signed-off-by: Richard Henderson --- target/i386/cpu.h | 4 ++-- target/i386/tcg/translate.c | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 81e5abed86..dbc9a99a3b 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1587,8 +1587,8 @@ typedef struct CPUArchState { float_status mmx_status; /* for 3DNow! float ops */ float_status sse_status; uint32_t mxcsr; - ZMMReg xmm_regs[CPU_NB_REGS =3D=3D 8 ? 8 : 32]; - ZMMReg xmm_t0; + ZMMReg xmm_regs[CPU_NB_REGS =3D=3D 8 ? 8 : 32] QEMU_ALIGNED(16); + ZMMReg xmm_t0 QEMU_ALIGNED(16); MMXReg mmx_t0; =20 uint64_t opmask_regs[NB_OPMASK_REGS]; diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index b7972f0ff5..c1f1f6f66b 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -23,6 +23,7 @@ #include "disas/disas.h" #include "exec/exec-all.h" #include "tcg/tcg-op.h" +#include "tcg/tcg-op-gvec.h" #include "exec/cpu_ldst.h" #include "exec/translator.h" =20 @@ -2753,10 +2754,8 @@ static inline void gen_sto_env_A0(DisasContext *s, i= nt offset) =20 static inline void gen_op_movo(DisasContext *s, int d_offset, int s_offset) { - tcg_gen_ld_i64(s->tmp1_i64, cpu_env, s_offset + offsetof(ZMMReg, ZMM_Q= (0))); - tcg_gen_st_i64(s->tmp1_i64, cpu_env, d_offset + offsetof(ZMMReg, ZMM_Q= (0))); - tcg_gen_ld_i64(s->tmp1_i64, cpu_env, s_offset + offsetof(ZMMReg, ZMM_Q= (1))); - tcg_gen_st_i64(s->tmp1_i64, cpu_env, d_offset + offsetof(ZMMReg, ZMM_Q= (1))); + int xmm_ofs =3D offsetof(ZMMReg, ZMM_X(0)); + tcg_gen_gvec_mov(MO_64, d_offset + xmm_ofs, s_offset + xmm_ofs, 16, 16= ); } =20 static inline void gen_op_movq(DisasContext *s, int d_offset, int s_offset) --=20 2.34.1 From nobody Mon May 13 12:24:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661208548; cv=none; d=zohomail.com; s=zohoarc; b=ndFfCJebZLlh7iYCFHe00gaXZ3co5VmGNuMVYJGLbzxwJSnL5opmCFtxR18M8Y9nCWFv9L01qZUvewPjfrrc9BSe3FJY43yWqeToJTkmcLEWwkrbWcv7WpVvn5gpir6zMB3ckgrLz5R1nn/HNRDbeXUv9VT4C3ivALI0ljnvqfI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661208548; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EK3yRg39diAjmCX4EAql2g9bvhe617TvOwEsTXwV/fE=; b=LxL6WRePB5DIfwIEEz9R0eHlhNjjv1P045dqPg4pmTjPd7XgVGrF1X5NKsbzjC3gEV94lxQSurovbD78GWSpXvN+ljjG81NgjOzn+0jwyF9n6GRPWiyhwp6EowMKUlkoAHdF3ycO7jcQuHTSJ9QCDNOvhlpfaUD+tUsLDV/36nQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661208548276267.74906822334003; Mon, 22 Aug 2022 15:49:08 -0700 (PDT) Received: from localhost ([::1]:55768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQGEE-0006Ef-P4 for importer@patchew.org; Mon, 22 Aug 2022 18:49:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQG33-000372-JP for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:33 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:40702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQG31-0006Z2-NK for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:33 -0400 Received: by mail-pg1-x535.google.com with SMTP id w13so5587718pgq.7 for ; Mon, 22 Aug 2022 15:37:31 -0700 (PDT) Received: from stoup.. ([71.212.157.236]) by smtp.gmail.com with ESMTPSA id z6-20020a63e106000000b0042a2777550dsm7017419pgh.47.2022.08.22.15.37.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 15:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=EK3yRg39diAjmCX4EAql2g9bvhe617TvOwEsTXwV/fE=; b=rIFMTY9tRkvDWsO48iwrM/l9SLt6hrQa3xuR/FZ1A9a4j5/E7NmyQFG6YXXE7N9EJZ ibg/Le0drVoc0xdkpWc1DLnhVn2ShtMl+MGUpm6mzCAdFVMteqxDuD0kdcYgKt/DwX9V RgJQSS1DWI/sHJ6i/l561UFvRtQN9eVDl1+SfXwdMAStwat37QF5hn9KwPfRtYh/VplB yS20Do69ZgTHTMBOdldspRGPpR5nbK3toOuYQL8u/bj1bt34C6KE2UCIJjJS9bNjQdTY YMUENYRULKWdlEX5ZDFlUL+HYygC7X83uGeiDYStHKTjbQuf3yaQcxX6TXhHpCaD++d6 sCiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=EK3yRg39diAjmCX4EAql2g9bvhe617TvOwEsTXwV/fE=; b=foqous/Oay4PEk018kYsaz2z4L0S9+qFTXubWgVIWdtURY7azOp7mvuyZnvz7MN/Ll j5aRXj6ghJgNcU+jb70mxhcwofHMrZkXFFJOTpGY6jtWgsl8Oc+wGwnGRTPgSLKxM94N PoIMw1U/3AssCX1JBzyvB76QbsSh9Dja/2bU9q2KqiVQLdlRR6oVH30NZPnOTjiXlGHA DfTrGH/XQLlVWinu63oR0iru0l7G8IjUboZSIsDqjEjpiaFiLJRxy0xeDH08hv8KWeFZ AYGjLxyH/EVKIMzQRl47W3dsgcoF2/QQoA8/fNIaE+ifQ0S7y5dxLX7P0DL31z9e5c9L LXYQ== X-Gm-Message-State: ACgBeo3y82Q6tyg9XbSZmzkrkzVMKNy8p/uYqlp1huA0aLrE1pICicUF MF6cl+RN2Dtt6pCv/IHRhTaAkeqb/FQePA== X-Google-Smtp-Source: AA6agR5s7dPepRGY39t23Y/Gnz0a1z9Nn/jlBfp6xSXbXqUFv3QQvjPtrkOu4TE3NIaroszGb5UWdA== X-Received: by 2002:a63:ea11:0:b0:41d:9296:21e6 with SMTP id c17-20020a63ea11000000b0041d929621e6mr17985407pgi.603.1661207850346; Mon, 22 Aug 2022 15:37:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/6] target/i386: Use tcg gvec for pcmp{eq,gt}* Date: Mon, 22 Aug 2022 15:37:19 -0700 Message-Id: <20220822223722.1697758-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822223722.1697758-1-richard.henderson@linaro.org> References: <20220822223722.1697758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661208549843100001 Content-Type: text/plain; charset="utf-8" As pcmpeqb is used by strlen et al, this is the highest overhead sse operation, at 2.5%. It's simple to include the other compares at the same time. Signed-off-by: Richard Henderson --- target/i386/ops_sse.h | 8 -------- target/i386/ops_sse_header.h | 8 -------- target/i386/tcg/translate.c | 31 +++++++++++++++++++++++++------ 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 535440f882..94440a9dc5 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -420,14 +420,6 @@ SSE_HELPER_Q(helper_pandn, FANDN) SSE_HELPER_Q(helper_por, FOR) SSE_HELPER_Q(helper_pxor, FXOR) =20 -SSE_HELPER_B(helper_pcmpgtb, FCMPGTB) -SSE_HELPER_W(helper_pcmpgtw, FCMPGTW) -SSE_HELPER_L(helper_pcmpgtl, FCMPGTL) - -SSE_HELPER_B(helper_pcmpeqb, FCMPEQ) -SSE_HELPER_W(helper_pcmpeqw, FCMPEQ) -SSE_HELPER_L(helper_pcmpeql, FCMPEQ) - SSE_HELPER_W(helper_pmullw, FMULLW) #if SHIFT =3D=3D 0 SSE_HELPER_W(helper_pmulhrw, FMULHRW) diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index cef28f2aae..b9f957daf8 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -91,14 +91,6 @@ SSE_HELPER_Q(pandn, FANDN) SSE_HELPER_Q(por, FOR) SSE_HELPER_Q(pxor, FXOR) =20 -SSE_HELPER_B(pcmpgtb, FCMPGTB) -SSE_HELPER_W(pcmpgtw, FCMPGTW) -SSE_HELPER_L(pcmpgtl, FCMPGTL) - -SSE_HELPER_B(pcmpeqb, FCMPEQ) -SSE_HELPER_W(pcmpeqw, FCMPEQ) -SSE_HELPER_L(pcmpeql, FCMPEQ) - SSE_HELPER_W(pmullw, FMULLW) #if SHIFT =3D=3D 0 SSE_HELPER_W(pmulhrw, FMULHRW) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index c1f1f6f66b..467d018b68 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2847,9 +2847,9 @@ static const SSEFunc_0_epp sse_op_table1[256][4] =3D { [0x61] =3D MMX_OP2(punpcklwd), [0x62] =3D MMX_OP2(punpckldq), [0x63] =3D MMX_OP2(packsswb), - [0x64] =3D MMX_OP2(pcmpgtb), - [0x65] =3D MMX_OP2(pcmpgtw), - [0x66] =3D MMX_OP2(pcmpgtl), + [0x64] =3D { SSE_DUMMY, SSE_DUMMY }, /* pcmpgtb */ + [0x65] =3D { SSE_DUMMY, SSE_DUMMY }, /* pcmpgtw */ + [0x66] =3D { SSE_DUMMY, SSE_DUMMY }, /* pcmpgtl */ [0x67] =3D MMX_OP2(packuswb), [0x68] =3D MMX_OP2(punpckhbw), [0x69] =3D MMX_OP2(punpckhwd), @@ -2866,9 +2866,9 @@ static const SSEFunc_0_epp sse_op_table1[256][4] =3D { [0x71] =3D { SSE_SPECIAL, SSE_SPECIAL }, /* shiftw */ [0x72] =3D { SSE_SPECIAL, SSE_SPECIAL }, /* shiftd */ [0x73] =3D { SSE_SPECIAL, SSE_SPECIAL }, /* shiftq */ - [0x74] =3D MMX_OP2(pcmpeqb), - [0x75] =3D MMX_OP2(pcmpeqw), - [0x76] =3D MMX_OP2(pcmpeql), + [0x74] =3D { SSE_DUMMY, SSE_DUMMY }, /* pcmpeqb */ + [0x75] =3D { SSE_DUMMY, SSE_DUMMY }, /* pcmpeqw */ + [0x76] =3D { SSE_DUMMY, SSE_DUMMY }, /* pcmpeql */ [0x77] =3D { SSE_DUMMY }, /* emms */ [0x78] =3D { NULL, SSE_SPECIAL, NULL, SSE_SPECIAL }, /* extrq_i, inser= tq_i */ [0x79] =3D { NULL, gen_helper_extrq_r, NULL, gen_helper_insertq_r }, @@ -4415,6 +4415,9 @@ static void gen_sse(CPUX86State *env, DisasContext *s= , int b, return; } } else { + int vec_len =3D is_xmm ? 16 : 8; + int xmm_ofs =3D is_xmm ? offsetof(ZMMReg, ZMM_X(0)) : 0; + /* generic MMX or SSE operation */ switch(b) { case 0x70: /* pshufx insn */ @@ -4532,6 +4535,22 @@ static void gen_sse(CPUX86State *env, DisasContext *= s, int b, sse_fn_eppt =3D (SSEFunc_0_eppt)sse_fn_epp; sse_fn_eppt(cpu_env, s->ptr0, s->ptr1, s->A0); break; + case 0x64: /* pcmpgtb */ + case 0x65: /* pcmpgtw */ + case 0x66: /* pcmpgtl */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_cmp(TCG_COND_GT, b - 0x64, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; + case 0x74: /* pcmpeqb */ + case 0x75: /* pcmpeqw */ + case 0x76: /* pcmpeql */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_cmp(TCG_COND_EQ, b - 0x74, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; default: tcg_gen_addi_ptr(s->ptr0, cpu_env, op1_offset); tcg_gen_addi_ptr(s->ptr1, cpu_env, op2_offset); --=20 2.34.1 From nobody Mon May 13 12:24:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661208280; cv=none; d=zohomail.com; s=zohoarc; b=FBstt0fK9YuPR9w9rt8nojxpEDo5Li8qDTincu3cRj63zZjGoz8vBZ19lqaXyt53jokaXFKNC+SqDvG8MzNs8IXAeC+zl4EV4TQ8IXWZysHRkuXG+fiY5nmjkacz9C8YeIGFSDYbDZ3/oWrg6qeg/SS2SfyEB/o/rey/UT0vlL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661208280; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7wrpwlAhlqlwE5ooXTHHegH9n59t020a14KTAhU8r2Q=; b=WdAaDUoVQEZcO5DWtGJNCSQmG2zFThDArC4aWI9CcnHqsQFV6BdVBeZ0hJUS3hJ7Q+H+dhHYByAo2WN6trGXM4uiyEEFPHWRdxwn72TLGEWW8E3pApbB0KFTTcOzn6xGBjixfO+QcVpJCRYmXiO2I38+jVxPeNp8IpibqmqVujM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661208280014142.1147283705924; Mon, 22 Aug 2022 15:44:40 -0700 (PDT) Received: from localhost ([::1]:46544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQG9u-0002px-W1 for importer@patchew.org; Mon, 22 Aug 2022 18:44:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQG34-0003B2-Qg for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:34 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:46597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQG33-0006ZQ-1K for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:34 -0400 Received: by mail-pl1-x62f.google.com with SMTP id jm11so11190073plb.13 for ; Mon, 22 Aug 2022 15:37:32 -0700 (PDT) Received: from stoup.. ([71.212.157.236]) by smtp.gmail.com with ESMTPSA id z6-20020a63e106000000b0042a2777550dsm7017419pgh.47.2022.08.22.15.37.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 15:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=7wrpwlAhlqlwE5ooXTHHegH9n59t020a14KTAhU8r2Q=; b=XtBe98nsakyDV3jWy3Ag9QQ9t7eeMOIt2JIZ8Xeb8KWDdNKCNOZEtMW1plc86tYCCQ Wjyq6vTk+2ZPu5HJKXXkWt/+FVdDa1SjHf2eDnCHrpOOp7490DIRnDO7dMnGeT7sbYM/ qQdVdEhBlz57A067F5uPwvFIGKHLFkNkgTaVTJf2z+F6BKfvkyWqb0Y7AVxmXk19V0Q4 YeMopaVqgRY1kNpki043ow7RjEV6nO2LeaWdKJxpkzXl+47T5b9MwmeWux4TtalZ/wvX MxitfFxQMJrKONxqCry1jOByAVlLzNuCV6WJE5g7q9e+1oV4wudtHl0kYfr1KMGmOL25 PIXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=7wrpwlAhlqlwE5ooXTHHegH9n59t020a14KTAhU8r2Q=; b=6xmBDix1jhPRTmAokxd5v7IOTCpSNIagnq3AW5wVEAO+hyOMioRlV/MToV+395Lir/ klynwm9XaCbML+kGxHlEFRJg1P0jtj08dE1rcshM2Zhxz6iKOj3QR0N7Bpm2CG5mrBPt XN5159lrQggS7+1i+uBd0IMPMxAZyxZL0xoNnRTkmx/2+1AHvzY00BaF7gvCD6aE5zTC eTHFjaCK43igA0VgfHLrWYotG1LXhxXA6ktT/t87chVVncctnD0UyRAUTzw2PAptcmT2 UexFKMtT2rsF5gj7pctEa6dxQbNpSKsg79/HEkRd71iozEOf3oclArfJLu5Mp4PtLDCS tw+g== X-Gm-Message-State: ACgBeo3epLKjmaZ3FD17lbZOLgYIkTK/T6OLKDGLeInDL1amlge2f5sC LcYWiF5lxf8i1pukl+8354vkbLmiOBKjdg== X-Google-Smtp-Source: AA6agR5HMvkuGy4MDQJHmrFiD59jahklX75RI6p7PsdbVVs+fUVUEr5PZF7fXe6og4o/WXbBzTpA6w== X-Received: by 2002:a17:903:244c:b0:171:59be:6762 with SMTP id l12-20020a170903244c00b0017159be6762mr21667906pls.20.1661207851581; Mon, 22 Aug 2022 15:37:31 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 4/6] target/i386: Use tcg gvec for p{add,sub}* Date: Mon, 22 Aug 2022 15:37:20 -0700 Message-Id: <20220822223722.1697758-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822223722.1697758-1-richard.henderson@linaro.org> References: <20220822223722.1697758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661208280331100001 Content-Type: text/plain; charset="utf-8" Since psubb is the second highest overhead sse operation, at 0.9%. It's simple to include add and the other sizes at the same time. Signed-off-by: Richard Henderson --- target/i386/ops_sse.h | 10 --------- target/i386/ops_sse_header.h | 10 --------- target/i386/tcg/translate.c | 39 ++++++++++++++++++++++++++++-------- 3 files changed, 31 insertions(+), 28 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 94440a9dc5..6f035b5c16 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -389,16 +389,6 @@ static inline int satsw(int x) #define FAVG(a, b) (((a) + (b) + 1) >> 1) #endif =20 -SSE_HELPER_B(helper_paddb, FADD) -SSE_HELPER_W(helper_paddw, FADD) -SSE_HELPER_L(helper_paddl, FADD) -SSE_HELPER_Q(helper_paddq, FADD) - -SSE_HELPER_B(helper_psubb, FSUB) -SSE_HELPER_W(helper_psubw, FSUB) -SSE_HELPER_L(helper_psubl, FSUB) -SSE_HELPER_Q(helper_psubq, FSUB) - SSE_HELPER_B(helper_paddusb, FADDUB) SSE_HELPER_B(helper_paddsb, FADDSB) SSE_HELPER_B(helper_psubusb, FSUBUB) diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index b9f957daf8..da630fbc40 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -60,16 +60,6 @@ DEF_HELPER_3(glue(pslldq, SUFFIX), void, env, Reg, Reg) #define SSE_HELPER_Q(name, F)\ DEF_HELPER_3(glue(name, SUFFIX), void, env, Reg, Reg) =20 -SSE_HELPER_B(paddb, FADD) -SSE_HELPER_W(paddw, FADD) -SSE_HELPER_L(paddl, FADD) -SSE_HELPER_Q(paddq, FADD) - -SSE_HELPER_B(psubb, FSUB) -SSE_HELPER_W(psubw, FSUB) -SSE_HELPER_L(psubl, FSUB) -SSE_HELPER_Q(psubq, FSUB) - SSE_HELPER_B(paddusb, FADDUB) SSE_HELPER_B(paddsb, FADDSB) SSE_HELPER_B(psubusb, FSUBUB) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 467d018b68..2a8ea3369a 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2882,7 +2882,7 @@ static const SSEFunc_0_epp sse_op_table1[256][4] =3D { [0xd1] =3D MMX_OP2(psrlw), [0xd2] =3D MMX_OP2(psrld), [0xd3] =3D MMX_OP2(psrlq), - [0xd4] =3D MMX_OP2(paddq), + [0xd4] =3D { SSE_DUMMY, SSE_DUMMY }, /* paddq */ [0xd5] =3D MMX_OP2(pmullw), [0xd6] =3D { NULL, SSE_SPECIAL, SSE_SPECIAL, SSE_SPECIAL }, [0xd7] =3D { SSE_SPECIAL, SSE_SPECIAL }, /* pmovmskb */ @@ -2919,13 +2919,13 @@ static const SSEFunc_0_epp sse_op_table1[256][4] = =3D { [0xf6] =3D MMX_OP2(psadbw), [0xf7] =3D { (SSEFunc_0_epp)gen_helper_maskmov_mmx, (SSEFunc_0_epp)gen_helper_maskmov_xmm }, /* XXX: casts */ - [0xf8] =3D MMX_OP2(psubb), - [0xf9] =3D MMX_OP2(psubw), - [0xfa] =3D MMX_OP2(psubl), - [0xfb] =3D MMX_OP2(psubq), - [0xfc] =3D MMX_OP2(paddb), - [0xfd] =3D MMX_OP2(paddw), - [0xfe] =3D MMX_OP2(paddl), + [0xf8] =3D { SSE_DUMMY, SSE_DUMMY }, /* psubb */ + [0xf9] =3D { SSE_DUMMY, SSE_DUMMY }, /* psubw */ + [0xfa] =3D { SSE_DUMMY, SSE_DUMMY }, /* psubl */ + [0xfb] =3D { SSE_DUMMY, SSE_DUMMY }, /* psubq */ + [0xfc] =3D { SSE_DUMMY, SSE_DUMMY }, /* paddb */ + [0xfd] =3D { SSE_DUMMY, SSE_DUMMY }, /* paddw */ + [0xfe] =3D { SSE_DUMMY, SSE_DUMMY }, /* paddl */ }; =20 static const SSEFunc_0_epp sse_op_table2[3 * 8][2] =3D { @@ -4551,6 +4551,29 @@ static void gen_sse(CPUX86State *env, DisasContext *= s, int b, tcg_gen_gvec_cmp(TCG_COND_EQ, b - 0x74, op1_offset, op1_offset, op2_offset, vec_len, vec_len); break; + case 0xf8: /* psubb */ + case 0xf9: /* psubw */ + case 0xfa: /* psubl */ + case 0xfb: /* psubq */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_sub(b - 0xf8, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; + case 0xfc: /* paddb */ + case 0xfd: /* paddw */ + case 0xfe: /* paddl */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_add(b - 0xfc, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; + case 0xd4: /* paddq */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_add(MO_64, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; default: tcg_gen_addi_ptr(s->ptr0, cpu_env, op1_offset); tcg_gen_addi_ptr(s->ptr1, cpu_env, op2_offset); --=20 2.34.1 From nobody Mon May 13 12:24:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661208794; cv=none; d=zohomail.com; s=zohoarc; b=eJbHfq5s+r2S1aSZRFTTNOrM66Be71IdIvD0GYRrV9dv4iO/WHRJoVb8JoDVukYwswZ5AKzcqD+7do/c1OuTxOy0ZiJ7I666eR3PKj5xZ1USHvujcw//b/3TK5BstOwJN30pVXI9RJMjTCX25GfDQXLoseHPV9ni4QnoigD8v/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661208794; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=X2jvrMtbYp1eNI0Clq6mipibH+5GoGu45vlAlcjZM8M=; b=mnsH18zhzIvyGHFAve7uybnkfy2dLU62TLTxI8GNENbsXtsD8Xkwq2uvKKKRyBbszMxYLzuwIHSfcjna3W+9yYQIGvUN7P68XMpnnokhxvqWYKLwHANGFCiNFcnNO5oMJZAEPoQsiq3HAE7Tn3ZKPHVaAF3QpHB+kWYScxBzIlk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661208794714555.646664919437; Mon, 22 Aug 2022 15:53:14 -0700 (PDT) Received: from localhost ([::1]:39590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQGID-0005fJ-Fy for importer@patchew.org; Mon, 22 Aug 2022 18:53:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQG35-0003Dg-Uo for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:35 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:36739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQG34-0006Zb-56 for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:35 -0400 Received: by mail-pl1-x62c.google.com with SMTP id c2so11227321plo.3 for ; Mon, 22 Aug 2022 15:37:33 -0700 (PDT) Received: from stoup.. ([71.212.157.236]) by smtp.gmail.com with ESMTPSA id z6-20020a63e106000000b0042a2777550dsm7017419pgh.47.2022.08.22.15.37.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 15:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=X2jvrMtbYp1eNI0Clq6mipibH+5GoGu45vlAlcjZM8M=; b=XFXOHvGzuFkLFYj0FQaPgKgdZG/A1Vs5if281+9hJUAe03KaOrny5IZbyn+G9FcMVh QyT5HYVoLd54rl8cUUJLX0BX2tKTCRyReTYYfIY2Y8mYqrgzBWWD87mroqI8nTguti7S XdL5V8TO2NArCg2ZY8lsVnGh4z22AfHf20z20gOULU2tQHHkI5QqAcgRihrp3/W62n/J A4OpQtIW6Q6t5nuCqKmXSaEnE0id731kSad3Gh9XfuBmFgT82FuxeCrggPeFxM5Ctoh2 Xd0GWuP6xkxn8zFYkFshRNYJqx19Chi5bDxuAn9/M0dHxo0VDk8cDiDUVi6ORHG8gNhd rxYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=X2jvrMtbYp1eNI0Clq6mipibH+5GoGu45vlAlcjZM8M=; b=qEB6+5l5OXmY+JmlASztKo0HwAWWvpbYEitKGvWbShGM3Yxo8wOw4+h5y3ghyGe034 Fs4UfK/xZ9ZWShKaZjPzTJbzCw86tYuyJn17EmR/t8a1vxp/hZGl1wX0E29328c9eUg1 s2dGWD1SV/ssTcusyTeECh6XICDDOYrfTou69Bdu7jzLvTc045DzEUbaJ1zAb1VCcrIm azg6s911/szng/WZQ+xOYqTXAFwu22MbT/AtCpnJjLP3BQGqXSWD1cDNYX3TFwBcu8hA 0UPbZbU68tEbPfpIryF93qiVwIQ2lMlsviPrJAR6eYSUf+4FiR2uY/wKVaa1Pm3nVOTB 8BcQ== X-Gm-Message-State: ACgBeo1eWghD/tYlPmacUFtgio+HyreoBilaIJFKpkR+P/EGusBya5Hw jMjjsB4oUVnomoZQCAPjGJN3vQFIJFKuSQ== X-Google-Smtp-Source: AA6agR6l1QFwgzC5BNTZxaHkjGv/MjqCQ7p191FF3YaFJr2YstB/mVWr1/tDxNLAfjaysV3bVghOzQ== X-Received: by 2002:a17:902:f64f:b0:172:a790:320a with SMTP id m15-20020a170902f64f00b00172a790320amr21896045plg.149.1661207852658; Mon, 22 Aug 2022 15:37:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 5/6] target/i386: Use tcg gvec for pand, pandn, por, pxor Date: Mon, 22 Aug 2022 15:37:21 -0700 Message-Id: <20220822223722.1697758-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822223722.1697758-1-richard.henderson@linaro.org> References: <20220822223722.1697758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661208796931100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson --- target/i386/ops_sse.h | 5 ---- target/i386/ops_sse_header.h | 5 ---- target/i386/tcg/translate.c | 45 +++++++++++++++++++++++++++++------- 3 files changed, 37 insertions(+), 18 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 6f035b5c16..b21f315f37 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -405,11 +405,6 @@ SSE_HELPER_B(helper_pmaxub, FMAXUB) SSE_HELPER_W(helper_pminsw, FMINSW) SSE_HELPER_W(helper_pmaxsw, FMAXSW) =20 -SSE_HELPER_Q(helper_pand, FAND) -SSE_HELPER_Q(helper_pandn, FANDN) -SSE_HELPER_Q(helper_por, FOR) -SSE_HELPER_Q(helper_pxor, FXOR) - SSE_HELPER_W(helper_pmullw, FMULLW) #if SHIFT =3D=3D 0 SSE_HELPER_W(helper_pmulhrw, FMULHRW) diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index da630fbc40..542701720e 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -76,11 +76,6 @@ SSE_HELPER_B(pmaxub, FMAXUB) SSE_HELPER_W(pminsw, FMINSW) SSE_HELPER_W(pmaxsw, FMAXSW) =20 -SSE_HELPER_Q(pand, FAND) -SSE_HELPER_Q(pandn, FANDN) -SSE_HELPER_Q(por, FOR) -SSE_HELPER_Q(pxor, FXOR) - SSE_HELPER_W(pmullw, FMULLW) #if SHIFT =3D=3D 0 SSE_HELPER_W(pmulhrw, FMULHRW) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 2a8ea3369a..d25d914d63 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2820,10 +2820,10 @@ static const SSEFunc_0_epp sse_op_table1[256][4] = =3D { [0x51] =3D SSE_FOP(sqrt), [0x52] =3D { gen_helper_rsqrtps, NULL, gen_helper_rsqrtss, NULL }, [0x53] =3D { gen_helper_rcpps, NULL, gen_helper_rcpss, NULL }, - [0x54] =3D { gen_helper_pand_xmm, gen_helper_pand_xmm }, /* andps, and= pd */ - [0x55] =3D { gen_helper_pandn_xmm, gen_helper_pandn_xmm }, /* andnps, = andnpd */ - [0x56] =3D { gen_helper_por_xmm, gen_helper_por_xmm }, /* orps, orpd */ - [0x57] =3D { gen_helper_pxor_xmm, gen_helper_pxor_xmm }, /* xorps, xor= pd */ + [0x54] =3D { SSE_DUMMY, SSE_DUMMY }, /* andps, andpd */ + [0x55] =3D { SSE_DUMMY, SSE_DUMMY }, /* andnps, andnpd */ + [0x56] =3D { SSE_DUMMY, SSE_DUMMY }, /* orps, orpd */ + [0x57] =3D { SSE_DUMMY, SSE_DUMMY }, /* xorps, xorpd */ [0x58] =3D SSE_FOP(add), [0x59] =3D SSE_FOP(mul), [0x5a] =3D { gen_helper_cvtps2pd, gen_helper_cvtpd2ps, @@ -2889,11 +2889,11 @@ static const SSEFunc_0_epp sse_op_table1[256][4] = =3D { [0xd8] =3D MMX_OP2(psubusb), [0xd9] =3D MMX_OP2(psubusw), [0xda] =3D MMX_OP2(pminub), - [0xdb] =3D MMX_OP2(pand), + [0xdb] =3D { SSE_DUMMY, SSE_DUMMY }, /* pand */ [0xdc] =3D MMX_OP2(paddusb), [0xdd] =3D MMX_OP2(paddusw), [0xde] =3D MMX_OP2(pmaxub), - [0xdf] =3D MMX_OP2(pandn), + [0xdf] =3D { SSE_DUMMY, SSE_DUMMY }, /* pandn */ [0xe0] =3D MMX_OP2(pavgb), [0xe1] =3D MMX_OP2(psraw), [0xe2] =3D MMX_OP2(psrad), @@ -2905,11 +2905,11 @@ static const SSEFunc_0_epp sse_op_table1[256][4] = =3D { [0xe8] =3D MMX_OP2(psubsb), [0xe9] =3D MMX_OP2(psubsw), [0xea] =3D MMX_OP2(pminsw), - [0xeb] =3D MMX_OP2(por), + [0xeb] =3D { SSE_DUMMY, SSE_DUMMY }, /* por */ [0xec] =3D MMX_OP2(paddsb), [0xed] =3D MMX_OP2(paddsw), [0xee] =3D MMX_OP2(pmaxsw), - [0xef] =3D MMX_OP2(pxor), + [0xef] =3D { SSE_DUMMY, SSE_DUMMY }, /* pxor */ [0xf0] =3D { NULL, NULL, NULL, SSE_SPECIAL }, /* lddqu */ [0xf1] =3D MMX_OP2(psllw), [0xf2] =3D MMX_OP2(pslld), @@ -4535,6 +4535,35 @@ static void gen_sse(CPUX86State *env, DisasContext *= s, int b, sse_fn_eppt =3D (SSEFunc_0_eppt)sse_fn_epp; sse_fn_eppt(cpu_env, s->ptr0, s->ptr1, s->A0); break; + case 0x54: /* andps, andpd */ + case 0xdb: /* pand */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_and(MO_64, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; + case 0x55: /* andnps, andnpd */ + case 0xdf: /* pandn */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + /* x86 inverts the first operand; tcg inverts the second. */ + tcg_gen_gvec_andc(MO_64, op1_offset, op2_offset, + op1_offset, vec_len, vec_len); + break; + case 0x56: /* orps, orpd */ + case 0xeb: /* por */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_or(MO_64, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; + case 0x57: /* xorps, xorpd */ + case 0xef: /* pxor */ + op1_offset +=3D xmm_ofs; + op2_offset +=3D xmm_ofs; + tcg_gen_gvec_xor(MO_64, op1_offset, op1_offset, + op2_offset, vec_len, vec_len); + break; case 0x64: /* pcmpgtb */ case 0x65: /* pcmpgtw */ case 0x66: /* pcmpgtl */ --=20 2.34.1 From nobody Mon May 13 12:24:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661208189; cv=none; d=zohomail.com; s=zohoarc; b=j6hh9QFpV+D4pJskedPFZTNWdkuRZeqFhTMFLKophX6cCZcu2LAc211IDryfHUhBQh7ZvRekg5TDbG12MIRDfX5iGOhiLK1VgwCBnWunvbL9xGgWY8ArOGtU9qEgi9ohhFR7NBJD/yE7e+j5pLgweWi1jL7c/C0cpNjuEpfLF0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661208189; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PxgN9VWEP3jH1n+0VfN2/ZE7ETcERcb6AXjxgYUaLFg=; b=cYg0ArQqThx7PiuKoaJIMKEClm/SDc0KifKbmaLyA/l8rZtvQMjKux39xWCpuJINNLW9LSnctkhaaC017rdeHuQ/jhf8PlTkiqQm3VfDlK7WROcCgJ5Nka8rzh0FW24N+RZSaDtIkATnM0chWCUTjpEpnRclrr2OEG4KIIsJ04I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16612081894721011.476914751993; Mon, 22 Aug 2022 15:43:09 -0700 (PDT) Received: from localhost ([::1]:45810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQG8S-00010r-AZ for importer@patchew.org; Mon, 22 Aug 2022 18:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQG3B-0003II-D0 for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:41 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:34812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQG35-0006Zs-8v for qemu-devel@nongnu.org; Mon, 22 Aug 2022 18:37:37 -0400 Received: by mail-pl1-x62b.google.com with SMTP id jl18so11226953plb.1 for ; Mon, 22 Aug 2022 15:37:34 -0700 (PDT) Received: from stoup.. ([71.212.157.236]) by smtp.gmail.com with ESMTPSA id z6-20020a63e106000000b0042a2777550dsm7017419pgh.47.2022.08.22.15.37.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 15:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=PxgN9VWEP3jH1n+0VfN2/ZE7ETcERcb6AXjxgYUaLFg=; b=uaS6tREJEBYF4e0nqq1HZyBrhYMXsfJ3Q3/P2BU5pHfDrzDHPkzgdt/BAi/HKl16Ys 32pbWLHqpYC6qGebX8jlK4NsBVR0q2zEcqYhaSvgjJzVsKnLRMLNj/w0xKDhbKjwwur7 UqxmzQ3jDIu0jdNujkbLOkf7Qxr57qFxO3O9MRuOhM1juPNu6fF1mdVTg0nZ0T5D5sVR V3NIpEv9npwrW1WjXd4q2JhC3YTmU76Sg2UKeaxsb3SJxRTpq7K81G471RVPoLyn0ZEk N46huLXvwbzaum2ZfJ7oafViqlEdMGv2+FhgMD/Ozje9moVmupnnQ2A9feaB/vuuRXEo mAhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=PxgN9VWEP3jH1n+0VfN2/ZE7ETcERcb6AXjxgYUaLFg=; b=zlE0tt0BRB7MYyQ0R/qNWTrdv/4R6OfHvx50jMUzcosJ4MfultXlUaFsszjfyB/yxV F01EnY1CroabZ14GXK5gXx/jsENMMKNWbwP2h0kREd9xDIYcDRJhl/4vv9kST9G+M3UM ktJSUUdi4kt21KtgOsLlF01lOk9Eo/XXO9/pFcSk50ynQ1oan79Bpu4hTnN1ZuflBUPb NTRubOh1T1UucBJnC2c4AMyJtcvxrhh+c2+5V4+qg7xFUHYTiX0nZDdZ0Ki3e9Y3g4Rw dJu7+ctXrZdQdfLMt5jcUOuJNb5DKrA+BrDk47JAVl2vHvsZEXX29cZwSitdtCaXGW8V W0Mw== X-Gm-Message-State: ACgBeo0MIEO37sYIyVN4psGYYfhiqpstKMnotc1ujhOjBVN42Gu4/pBY RfymJA55knhd5uhR3RhKXXkVIpvRsVZFzQ== X-Google-Smtp-Source: AA6agR7igKgYoq97aetSfx4FjXiFGrSv98Mdt/giJc6hGU1c3p7qYzZGxXmOKhluxvXGTZ3v5Umj5g== X-Received: by 2002:a17:90b:3ec9:b0:1f5:62d5:4157 with SMTP id rm9-20020a17090b3ec900b001f562d54157mr428989pjb.183.1661207854000; Mon, 22 Aug 2022 15:37:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 6/6] target/i386: Use tcg gvec ops for pmovmskb Date: Mon, 22 Aug 2022 15:37:22 -0700 Message-Id: <20220822223722.1697758-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822223722.1697758-1-richard.henderson@linaro.org> References: <20220822223722.1697758-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661208189745100001 Content-Type: text/plain; charset="utf-8" As pmovmskb is used by strlen et al, this is the third highest overhead sse operation at %0.8. Signed-off-by: Richard Henderson --- target/i386/ops_sse.h | 26 ----------- target/i386/ops_sse_header.h | 1 - target/i386/tcg/translate.c | 86 +++++++++++++++++++++++++++++++----- 3 files changed, 74 insertions(+), 39 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index b21f315f37..9f9801be63 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -1098,32 +1098,6 @@ uint32_t helper_movmskpd(CPUX86State *env, Reg *s) =20 #endif =20 -uint32_t glue(helper_pmovmskb, SUFFIX)(CPUX86State *env, Reg *s) -{ - uint32_t val; - - val =3D 0; - val |=3D (s->B(0) >> 7); - val |=3D (s->B(1) >> 6) & 0x02; - val |=3D (s->B(2) >> 5) & 0x04; - val |=3D (s->B(3) >> 4) & 0x08; - val |=3D (s->B(4) >> 3) & 0x10; - val |=3D (s->B(5) >> 2) & 0x20; - val |=3D (s->B(6) >> 1) & 0x40; - val |=3D (s->B(7)) & 0x80; -#if SHIFT =3D=3D 1 - val |=3D (s->B(8) << 1) & 0x0100; - val |=3D (s->B(9) << 2) & 0x0200; - val |=3D (s->B(10) << 3) & 0x0400; - val |=3D (s->B(11) << 4) & 0x0800; - val |=3D (s->B(12) << 5) & 0x1000; - val |=3D (s->B(13) << 6) & 0x2000; - val |=3D (s->B(14) << 7) & 0x4000; - val |=3D (s->B(15) << 8) & 0x8000; -#endif - return val; -} - void glue(helper_packsswb, SUFFIX)(CPUX86State *env, Reg *d, Reg *s) { Reg r; diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index 542701720e..d6bb10342c 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -201,7 +201,6 @@ DEF_HELPER_2(movmskps, i32, env, Reg) DEF_HELPER_2(movmskpd, i32, env, Reg) #endif =20 -DEF_HELPER_2(glue(pmovmskb, SUFFIX), i32, env, Reg) DEF_HELPER_3(glue(packsswb, SUFFIX), void, env, Reg, Reg) DEF_HELPER_3(glue(packuswb, SUFFIX), void, env, Reg, Reg) DEF_HELPER_3(glue(packssdw, SUFFIX), void, env, Reg, Reg) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index d25d914d63..5829c702d6 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2776,6 +2776,77 @@ static inline void gen_op_movq_env_0(DisasContext *s= , int d_offset) tcg_gen_st_i64(s->tmp1_i64, cpu_env, d_offset); } =20 +static void gen_pmovmskb_i64(TCGv_i64 d, TCGv_i64 s) +{ + TCGv_i64 t =3D tcg_temp_new_i64(); + + tcg_gen_andi_i64(d, s, 0x8080808080808080ull); + + /* + * After each shift+or pair: + * 0: a.......b.......c.......d.......e.......f.......g.......h....... + * 7: ab......bc......cd......de......ef......fg......gh......h....... + * 14: abcd....bcde....cdef....defg....efgh....fgh.....gh......h....... + * 28: abcdefghbcdefgh.cdefgh..defgh...efgh....fgh.....gh......h....... + * The result is left in the high bits of the word. + */ + tcg_gen_shli_i64(t, d, 7); + tcg_gen_or_i64(d, d, t); + tcg_gen_shli_i64(t, d, 14); + tcg_gen_or_i64(d, d, t); + tcg_gen_shli_i64(t, d, 28); + tcg_gen_or_i64(d, d, t); +} + +static void gen_pmovmskb_vec(unsigned vece, TCGv_vec d, TCGv_vec s) +{ + TCGv_vec t =3D tcg_temp_new_vec_matching(d); + TCGv_vec m =3D tcg_constant_vec_matching(d, MO_8, 0x80); + + /* See above */ + tcg_gen_and_vec(vece, d, s, m); + tcg_gen_shli_vec(vece, t, d, 7); + tcg_gen_or_vec(vece, d, d, t); + tcg_gen_shli_vec(vece, t, d, 14); + tcg_gen_or_vec(vece, d, d, t); + if (vece =3D=3D MO_64) { + tcg_gen_shli_vec(vece, t, d, 28); + tcg_gen_or_vec(vece, d, d, t); + } +} + +static void gen_gvec_pmovmskb(TCGv out, int s_reg, bool is_xmm) +{ + static const TCGOpcode vecop_list[] =3D { INDEX_op_shli_vec, 0 }; + static const GVecGen2 g =3D { + .fni8 =3D gen_pmovmskb_i64, + .fniv =3D gen_pmovmskb_vec, + .opt_opc =3D vecop_list, + .vece =3D MO_64, + .prefer_i64 =3D TCG_TARGET_REG_BITS =3D=3D 64 + }; + + int s_ofs =3D (is_xmm + ? offsetof(CPUX86State, xmm_regs[s_reg].ZMM_X(0)) + : offsetof(CPUX86State, fpregs[s_reg].mmx)); + int d_ofs =3D (is_xmm + ? offsetof(CPUX86State, xmm_t0.ZMM_X(0)) + : offsetof(CPUX86State, mmx_t0)); + int vec_len =3D is_xmm ? 16 : 8; + + tcg_gen_gvec_2(d_ofs, s_ofs, vec_len, vec_len, &g); + + if (is_xmm) { + TCGv t =3D tcg_temp_new(); + tcg_gen_ld8u_tl(t, cpu_env, d_ofs + offsetof(XMMReg, XMM_B(15))); + tcg_gen_ld8u_tl(out, cpu_env, d_ofs + offsetof(XMMReg, XMM_B(7))); + tcg_gen_deposit_tl(out, out, t, 8, TARGET_LONG_BITS - 8); + tcg_temp_free(t); + } else { + tcg_gen_ld8u_tl(out, cpu_env, d_ofs + offsetof(MMXReg, MMX_B(7))); + } +} + typedef void (*SSEFunc_i_ep)(TCGv_i32 val, TCGv_ptr env, TCGv_ptr reg); typedef void (*SSEFunc_l_ep)(TCGv_i64 val, TCGv_ptr env, TCGv_ptr reg); typedef void (*SSEFunc_0_epi)(TCGv_ptr env, TCGv_ptr reg, TCGv_i32 val); @@ -3742,21 +3813,12 @@ static void gen_sse(CPUX86State *env, DisasContext = *s, int b, break; case 0xd7: /* pmovmskb */ case 0x1d7: - if (mod !=3D 3) + if (mod !=3D 3) { goto illegal_op; - if (b1) { - rm =3D (modrm & 7) | REX_B(s); - tcg_gen_addi_ptr(s->ptr0, cpu_env, - offsetof(CPUX86State, xmm_regs[rm])); - gen_helper_pmovmskb_xmm(s->tmp2_i32, cpu_env, s->ptr0); - } else { - rm =3D (modrm & 7); - tcg_gen_addi_ptr(s->ptr0, cpu_env, - offsetof(CPUX86State, fpregs[rm].mmx)); - gen_helper_pmovmskb_mmx(s->tmp2_i32, cpu_env, s->ptr0); } + rm =3D (modrm & 7) | (is_xmm ? REX_B(s) : 0); reg =3D ((modrm >> 3) & 7) | REX_R(s); - tcg_gen_extu_i32_tl(cpu_regs[reg], s->tmp2_i32); + gen_gvec_pmovmskb(cpu_regs[reg], rm, is_xmm); break; =20 case 0x138: --=20 2.34.1