From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660923868; cv=none; d=zohomail.com; s=zohoarc; b=BLz0HIT6PZQXfoqWS6a74NeWqfmSoofaw3dyx8v2m3aXHLcSbA6bFJsyNs33nn+2IDFWCyCzwM5f9pDY0/nauRC1MJRImbqJAOUQcBbWURWbiKwB9iu3OekhF0+hhWieVWuxPcyubDSuY9keZ8vYOmUXt53W996aKD+jKhp8oJ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660923868; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Xeh2vqFOTw5s3hqoNhblRj1bcX1xyzRqQ8DX799pYws=; b=Tr3gHQ4LM0Os80DNw9E7JoWkU9721gNtFxvv2xTytkEB5efCGbgH+/1Ojbyx0kj3NAJ6PextkUrLa66elKHEfBA+HJuwIV2x+J/S/VtwF+axNwgM3pjqUqaDToV/8aXmjK0/ATmZh2br+VRIlDBR3t+nohKGjM5fG4KwhLKAjQY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660923868638476.38469040249333; Fri, 19 Aug 2022 08:44:28 -0700 (PDT) Received: from localhost ([::1]:40700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4Ad-0006JX-Km for importer@patchew.org; Fri, 19 Aug 2022 11:44:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP468-0005dh-1I for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:35353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP45y-00063h-3e for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:47 -0400 Received: by mail-wr1-x432.google.com with SMTP id bs25so5624730wrb.2 for ; Fri, 19 Aug 2022 08:39:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Xeh2vqFOTw5s3hqoNhblRj1bcX1xyzRqQ8DX799pYws=; b=lTiOZM14C4pzD56g9hfva+qxBUzAabBWDLJN5hR2r8kR9DGDCGl9eBb37fdOHRGpUR w8y2AR8hA3b4fZi27JxSkFjT2oprxw9C6nGqd4yjE4Eafp0//ZITFsbdfi9qyTffPTkj DbD0bFwOW28DlJGhQAVHKoBV5V8pUhAziQSFVvpctj6+hao4KHGfcWKIypYlGKrPqndn bYysnjn3QaOpgzMngCOga8dF1+atqw/eQ/PmhxwhxJ+sCw1O+oT7CLSSPpfYsUJMNM3n 5tPj4S48j7KTHY3MyJNH5kN0wlBokmlwOnr6WUgzzLa2k3OwxmEQb1WVGTklXQHczk5s 3khA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Xeh2vqFOTw5s3hqoNhblRj1bcX1xyzRqQ8DX799pYws=; b=Lb+qlxHzR14NBmm8z7gxhJWjzFFd8bqYnjn4dhC4y9tv0UkyDm/kiYvHOPE67SiimA rckkbo5jxKvM0hzTkupvgoKYcERvq2/41xoCWfcV1s9kQAaohyAQ8USUqXklKuwhaJ5h ykOcFn21d4iJRJGWCsaw/SjjjAMrdXhjW+5bQvAXpyIgQpB8sY2gO3kfBdf4NJ40KiHl dDp+O5VzSlME7Z2RAm+09N5K6ON465uutlKmGUm2A8R11knWQiTpN5Mh7N2kWfIsfLhk NvrSuWzxFb5PGeLypcD9GlwNJawpi0rs2MSyddjagymDwSBogmtGLbzomDUUCoUOQgxt +08Q== X-Gm-Message-State: ACgBeo0mvtYZCR9nnvv2v8C1iMOyb2vd4s/OsTtbVuglJtw0c1AZnG7p 5rAbLuJTuKxBx4UEkoV+1pMnDYN9fcOXAw== X-Google-Smtp-Source: AA6agR5lmc0U/0M92Vfeii6kNDiMUCRzy09lOo9WtpDoF9W4wBSwR2fq+7z2qzvwFcQ+LQrxAnsHUg== X-Received: by 2002:a05:6000:1541:b0:222:cf65:18d7 with SMTP id 1-20020a056000154100b00222cf6518d7mr4464252wry.659.1660923575950; Fri, 19 Aug 2022 08:39:35 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 01/11] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions Date: Fri, 19 Aug 2022 16:39:21 +0100 Message-Id: <20220819153931.3147384-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660923870144100001 From: Philippe Mathieu-Daud=C3=A9 Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Samuel Thibault Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- chardev/baum.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/chardev/baum.c b/chardev/baum.c index 79d618e3504..6d538808a0f 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -87,6 +87,9 @@ =20 #define BUF_SIZE 256 =20 +#define X_MAX 84 +#define Y_MAX 1 + struct BaumChardev { Chardev parent; =20 @@ -244,11 +247,11 @@ static int baum_deferred_init(BaumChardev *baum) brlapi_perror("baum: brlapi__getDisplaySize"); return 0; } - if (baum->y > 1) { - baum->y =3D 1; + if (baum->y > Y_MAX) { + baum->y =3D Y_MAX; } - if (baum->x > 84) { - baum->x =3D 84; + if (baum->x > X_MAX) { + baum->x =3D X_MAX; } =20 con =3D qemu_console_lookup_by_index(0); --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660923737; cv=none; d=zohomail.com; s=zohoarc; b=T6Th4RQub98GhqAKB8PeBfOb28ElRptr0RfkJV01LID8hvH/4M/f0TjtrtJSb7ZTIgqTxZYvbEkapD+9ah8BVlXNtJoC9Ue/2mjy2ZRPWF/o6S6nPi4SRUFRhsEOSp3efRgpuX/whIevavJ73U8f3jlYGvQYsRbd/KGg44TDpyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660923737; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=R4g5feK2z3NYihYvidLiAk+gMsDmpPE7GLZDlbfsxQI=; b=DqFIiW4e+/2J1pNMjPAkg8I0mSEUJdKKyHbaP90R4r7GhaQLI9wB3T2C6Km4VDE2zj51uv5eN29sFQG88e8RIzZ89PCPpnq6Y7Mq/3ihUP9Hiw/RQLbKXwuvBOle7C76PjJ4G9jr9Ojg0VdEZTWco7u1K/bTcgihLa2M0MZ46dI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660923737395995.2743822418998; Fri, 19 Aug 2022 08:42:17 -0700 (PDT) Received: from localhost ([::1]:50086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP48V-0000kU-CW for importer@patchew.org; Fri, 19 Aug 2022 11:42:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP468-0005fc-OO for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:50718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP461-00063r-UE for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: by mail-wm1-x334.google.com with SMTP id j26so2456067wms.0 for ; Fri, 19 Aug 2022 08:39:38 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=R4g5feK2z3NYihYvidLiAk+gMsDmpPE7GLZDlbfsxQI=; b=YL0d7agIlU3Gu7SEV4msDIQ0A9m23HFVPqhjqj/JMPAqT6no4uQchN1UFVyu5YWdFE LMJstOkLhUP7Mco5jD+wDmX9657xw4XEPf6BujjCHkEULeutXkG4gNGH5ZEWXoqRkZ3V gwFQ4ygRSDjNFhxg7FWGWYHFX6blZMANGRBscmDIBqbYo+JGkWDKWraWSU+oGzFymW3P uB3iQPrTgHiep10S5vuSqAYjwAe/Cyi85M4FLmS2yDE/pe3iUAIZILgkKut+hEk3kVcM boQcnFPCU7EM82c4KhJHmk/pNh9GdyxtqtBSEuU5cpI17ZY1WJWyoKMSz24Za0Lne2zs CDJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=R4g5feK2z3NYihYvidLiAk+gMsDmpPE7GLZDlbfsxQI=; b=xBWPCTEBPs7xm7GNU7j1/0iKXLzHqln65nZP/FTJ6pS6jDcSkED8hLNd6hZ3Ccjapb twFJKEXfe+TfWqxxCHVYcANOVg/vs0rpkP0zVa6y2lYoRuUJx+5tDukhe3q06lhJTLcN IPA43VOgyHJLeRZ64xREnR5khbWyfQmpAsN3Uw2Mgc/QyMADTUcWdEwvh7Wuk0mzjvBk OcfdBzUMPDa5Ly6NGYr+5ny6bWfKajDGigbaXAOLL9FEG5Lt/L43ZCuN+B3hJW44vR4g AgzB+5pN4wIhamIbT3oGIDd5zRSq6bV11rOotWihIIJ7V306bTKoCR7sifazqOmHNwxU gN6w== X-Gm-Message-State: ACgBeo0Rbsigv6VLf/dAqNGDJ9RUaID4V3Un76j6xRoMnQtdrI32BUSp RJyRDY5wCtw7K2dL3v7BxAkCsezjgzgicg== X-Google-Smtp-Source: AA6agR5uxSaKepDECZTaU7s2kahoWiSqgMZBG4+sR97RAyCvmo3lbjupqjNWTScpJkxscUVLSUQSvw== X-Received: by 2002:a05:600c:5010:b0:3a6:804:5b08 with SMTP id n16-20020a05600c501000b003a608045b08mr8126624wmr.10.1660923577315; Fri, 19 Aug 2022 08:39:37 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 02/11] chardev/baum: Use definitions to avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:22 +0100 Message-Id: <20220819153931.3147384-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660923738455100002 From: Philippe Mathieu-Daud=C3=A9 We know 'x * y' will be at most 'X_MAX * Y_MAX' (which is not a big value, it is actually 84). Instead of having the compiler use variable-length array, declare an array able to hold the maximum 'x * y'. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Samuel Thibault Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- chardev/baum.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/chardev/baum.c b/chardev/baum.c index 6d538808a0f..6a210ffd815 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -383,9 +383,9 @@ static int baum_eat_packet(BaumChardev *baum, const uin= t8_t *buf, int len) switch (req) { case BAUM_REQ_DisplayData: { - uint8_t cells[baum->x * baum->y], c; - uint8_t text[baum->x * baum->y]; - uint8_t zero[baum->x * baum->y]; + uint8_t cells[X_MAX * Y_MAX], c; + uint8_t text[X_MAX * Y_MAX]; + uint8_t zero[X_MAX * Y_MAX]; int cursor =3D BRLAPI_CURSOR_OFF; int i; =20 @@ -408,7 +408,7 @@ static int baum_eat_packet(BaumChardev *baum, const uin= t8_t *buf, int len) } timer_del(baum->cellCount_timer); =20 - memset(zero, 0, sizeof(zero)); + memset(zero, 0, baum->x * baum->y); =20 brlapi_writeArguments_t wa =3D { .displayNumber =3D BRLAPI_DISPLAY_DEFAULT, --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660923736; cv=none; d=zohomail.com; s=zohoarc; b=KWgQkY9sTW5rkI5lSlsVXy9GQJAOQ0GTfyFwOkRbuRyf7PE5JldmDLcNWNPByX4wKdAMEoqdoJ6vsURks/GTOHqPEHRzEyl//7rY1QlIQvSZImAyJE/HeYq1vu9VapBWJBcULcTtgot4/6B25zi4Mr01oZ3zjlwrIJ8f4gFSqvU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660923736; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wQwzIcXEd8CDalnfbzxRsvGcMSl1lPN2VEyNH0COQ4g=; b=SLmPlfbunUo3Cw8BK3rKZjN7vQPCEuWFqTyVBOl78cAfSAGSU8iLnaYTc/Kh9+5CID8E9BSytoclhVdK2phIRTSE27/TlLy51JUPY7zGWVOBAnjAN9yH4v8432Q4+wXrkn90v8XZNqHoXo8LiaVJl819S4bRmHXvgZ2p5MQ+Wy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660923735996985.5835841675486; Fri, 19 Aug 2022 08:42:15 -0700 (PDT) Received: from localhost ([::1]:50084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP48U-0000er-Md for importer@patchew.org; Fri, 19 Aug 2022 11:42:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP466-0005bE-HI for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:46 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:37840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP461-000648-6n for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:46 -0400 Received: by mail-wr1-x42c.google.com with SMTP id n7so5625006wrv.4 for ; Fri, 19 Aug 2022 08:39:39 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=wQwzIcXEd8CDalnfbzxRsvGcMSl1lPN2VEyNH0COQ4g=; b=q6HzCqbT4CxQJgU/Nb6o3oeyUw2LATV+pyhvZw383EKY1FJay+0TS8805bWHjrpxu/ BJU3gwW8rqNEiKb3G+qEkUgSNzwcX+TJ509b4Mp8LIxkwoEopizFVtsaHyje7O4mY9xL tSwCvWbM8KBJFRZ6caejCRras6d5ASizmHcmXcZFRdUprQq9h0RQz5sW5GJUEHDcwITc d7stwSNC+UFtFmAi6hlmMqygehSEhLC/J8cdeT8mgwCLt7IZ9loGRWcOnjrkG6c19MXz K7BQgYcU+JPh/5ydndEfNHZtXZE/AJ6mbXxmm0XgB2PMkHTD2gZCg/m8HgspaeS9KSxB /7Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=wQwzIcXEd8CDalnfbzxRsvGcMSl1lPN2VEyNH0COQ4g=; b=HevEyGDqVjkFtM+slIWKfG8O5Kh28DZGRxGyHgs5CVXwwWZowP58x2zn9dagbQIcfX cIk3RsXy3abXrFlGgBwh77TL/+ithN84jkVtOOIDOEsEeeRDJaiaabi0H+7KOx9cmEz1 Afa7Hjz1Wmwn1Cg5oh2x23yUHjrMPcGu3ZqCrDFGRLcC9FfuPLe8u23sHxQjiizX/CXx sCfKwrL4j/UqzSFlmUgePUnRaecqqrzvgsjW/569F7RCmXQ61XG/XK0BsrkpsymsS69d V43ZjD7xtKQwRQvgkfrqQNZvUiHQ2VY7nOFqksuhDn0wo1ljvYOyy1ANx9STmh4hRk1F okWw== X-Gm-Message-State: ACgBeo2oc7kD2tOVH3KJ/wUx1rmmuDMiuBL8OBKE9OhGp/aXaQfNvaVb s2/qoozpeYWAlirhkAuiNWBmP9lcWdLPEA== X-Google-Smtp-Source: AA6agR5QanvdtGf7E/JPhY97wj0zYeFgxNHVyHO9PRhmzvpjvlCc7RrR29G2X/25yFH3EiVy8Vn6rA== X-Received: by 2002:a5d:668c:0:b0:225:333e:15f3 with SMTP id l12-20020a5d668c000000b00225333e15f3mr3442249wru.494.1660923578689; Fri, 19 Aug 2022 08:39:38 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 03/11] chardev/baum: Avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:23 +0100 Message-Id: <20220819153931.3147384-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660923738451100001 From: Philippe Mathieu-Daud=C3=A9 Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Samuel Thibault Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- chardev/baum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/baum.c b/chardev/baum.c index 6a210ffd815..0a0d12661a4 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -299,7 +299,8 @@ static void baum_chr_accept_input(struct Chardev *chr) static void baum_write_packet(BaumChardev *baum, const uint8_t *buf, int l= en) { Chardev *chr =3D CHARDEV(baum); - uint8_t io_buf[1 + 2 * len], *cur =3D io_buf; + g_autofree uint8_t *io_buf =3D g_malloc(1 + 2 * len); + uint8_t *cur =3D io_buf; int room; *cur++ =3D ESC; while (len--) --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660924179; cv=none; d=zohomail.com; s=zohoarc; b=XHBXQk2PqF4miJALCZzeotO/QHtpGfcEnUf6hTeGidthzO/QFhdSG+MJ056PIEAZboAcPEA+9bsL33W8ueJWJrSthgknDQxAMnp9wwiVOwP3iNfk+yY+BImQbAsNBDzlRWr6bUD+NOdOHZuWue7mInoSHI4Zdll6X2Ju4wUW66Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660924179; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zg9fu5qHwdrrZhY9h0fcERwtTu8sDUqtYMAjp6fh9AE=; b=NaULvEFizPvjpwhFxLOK/pB6bMityb6dmatX8mkYO85CbpBmrQYbbRPZmeZyQIYT9r8JmUZtR60f8ici4mNmA40fRry5rr5RDlQgBqMuDog3xoJM0T7bOGgg4T4NGFDDmwJNPJqKcDfTmjObJ6ik+l3ZK0adlVaWjmD/VM/4Q3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660924179403941.2387345485038; Fri, 19 Aug 2022 08:49:39 -0700 (PDT) Received: from localhost ([::1]:48568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4Fe-0003ke-BR for importer@patchew.org; Fri, 19 Aug 2022 11:49:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP468-0005fH-L4 for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:40745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP463-00064H-IW for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: by mail-wr1-x42d.google.com with SMTP id h5so4808899wru.7 for ; Fri, 19 Aug 2022 08:39:41 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Zg9fu5qHwdrrZhY9h0fcERwtTu8sDUqtYMAjp6fh9AE=; b=gVjmmY/hxoqNMWTlk4nX/AeiWWNR626hHESiulMtw709ydBi4zvE+eZZ9EAP45cWgD C0GGnbzJOXYEN9icePhlG73AzCvExVZhHKbDh5b3FOwfhaN9whwWpvRd4Q0+qy8pn/Vb XPo/EqIblD0LOqw2HiCxSWmj+F+5NCRhZaNmf1XI+LAQpFFf9vOlihCSQqgaCR+jsMce dVQstpq44+mX7D4o0IuUWwSucL3GJOreLTWzl4Ya4a9DjxSxk0y9cIiSTLodUVrKwbIO O82pzxKNBe78L36vrQ2JUkCvNKsVtVIX7+tU7hCXaeIhPcEPXMZJRF7hzkaf8kZECil6 464Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Zg9fu5qHwdrrZhY9h0fcERwtTu8sDUqtYMAjp6fh9AE=; b=JiBXT1tcV6Ac5D+dpHCFe9TvhxB2Phq1ujXc5wswKGoLliaes4o8dvsmfA/L3lF8VR 3vOV/8iCdjjx4lfEP6zDUIteuEaUQ51ZtxVYB0fyCugURm/geBrY8A5aJm9UDg5rrHAA sjmZejmnPkDebCn9At1DWDTrhlq7IC2VmW7+TfHwGhcXXsMa1TziNd2vE7Cc3yLQysc9 JL5OLkmc0F3DR5ISuIt0me64KWeNTNCXJ4wxpsJzdue+x2CKShfy42AiO29h9mGZ46YE M5L+W/gNPolKsfW65xEUNEVAMHrTI7aHtepCIYl9vOONf9iIF7MQvfhazojRq8N2lXXB v0Eg== X-Gm-Message-State: ACgBeo0efClFe1goHFqPrrT7dFGe/QM11IMT1X+AI3y+Y2XBVAl60JZl z4UHBjnTUqDUaqIVlvPpTB5vWT4k8WmqEA== X-Google-Smtp-Source: AA6agR4ArLL1jSZaCjaGq2lLlZO17GBCUbsPBa8DewIS4jWVQAS173iTACiEc1+ZHI07BUadwB9tew== X-Received: by 2002:adf:f18d:0:b0:225:3a78:cef0 with SMTP id h13-20020adff18d000000b002253a78cef0mr1933636wro.578.1660923580049; Fri, 19 Aug 2022 08:39:40 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 04/11] io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1 Date: Fri, 19 Aug 2022 16:39:24 +0100 Message-Id: <20220819153931.3147384-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660924179877100001 From: Philippe Mathieu-Daud=C3=A9 The combined_key[... QIO_CHANNEL_WEBSOCK_GUID_LEN ...] array in qio_channel_websock_handshake_send_res_ok() expands to a call to strlen(QIO_CHANNEL_WEBSOCK_GUID), and the compiler doesn't realize the string is const, so consider combined_key[] being a variable-length array. To remove the variable-length array, we provide it a hint to the compiler by using sizeof() - 1 instead of strlen(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- io/channel-websock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 9619906ac36..fb4932ade70 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -32,7 +32,7 @@ =20 #define QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN 24 #define QIO_CHANNEL_WEBSOCK_GUID "258EAFA5-E914-47DA-95CA-C5AB0DC85B11" -#define QIO_CHANNEL_WEBSOCK_GUID_LEN strlen(QIO_CHANNEL_WEBSOCK_GUID) +#define QIO_CHANNEL_WEBSOCK_GUID_LEN (sizeof(QIO_CHANNEL_WEBSOCK_GUID) - 1) =20 #define QIO_CHANNEL_WEBSOCK_HEADER_PROTOCOL "sec-websocket-protocol" #define QIO_CHANNEL_WEBSOCK_HEADER_VERSION "sec-websocket-version" --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660923865; cv=none; d=zohomail.com; s=zohoarc; b=Xj7nDY0WENSatyYfZcVMTUhdUnch7PiUw71b+MHEG7+WkANT8Zm1bOYagdei0Zc3QEzl57jsmD01h3COHkeHx8IF7bTmS/n922KDDBa4zEmMfvN8enXBTtbdGrU0kic97iXxmHfVZaesSY7S1xftlWCMnx36Nls9zUgeIMrKnFQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660923865; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cl6TQtvSxV7arO6sC6GB32F3upDS/NEMszQzruWKRcc=; b=ePw3WGJJ5/e/uMTO8MmTlJkIG4LCn0oMyqaKOBNxMC+YE+5ykqQnwZf724nGOQV6zu9sGj+VF5//IuDt2aHCaywC2dULB2AUiQeXJGf6OzpRc7yP0m4Me4BkA3EevIaZJyoDJt2KJ2sMbCoUAJdN3yzLeHXrgWqURJHulW8DKGA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660923865029345.48378322054816; Fri, 19 Aug 2022 08:44:25 -0700 (PDT) Received: from localhost ([::1]:40698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4Aa-0006CY-0w for importer@patchew.org; Fri, 19 Aug 2022 11:44:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP468-0005eo-Gw for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:46870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP462-00064V-RT for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:48 -0400 Received: by mail-wr1-x42a.google.com with SMTP id e20so5124306wri.13 for ; Fri, 19 Aug 2022 08:39:42 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=cl6TQtvSxV7arO6sC6GB32F3upDS/NEMszQzruWKRcc=; b=GzQ3s7s/pWvsd6xhdPcB3eBKkYXcfsqDGmDVT8dxc2wkiCmXvGWd7kvqe9NWkJXLPX NKnrPdGuCVzZiA5wN2cblqU4HT9GVNWZkSOuBpCgMJtajE3JXtFpedUiX3g2BEY1OFUM ErwfA29zDJNGM5QNSaHdqZI1nqY0QiL0WkkFAwle52+JMtbAMQ/Sl8TJb9ECvT9z0saB Y8nGNDAJZTBcYs3EN54mB7+P/SZNpIAkMF+awJyvh3+mw4++mtCwfvF4AC5bGhcf1obs O7ILTvvW2eo0e4IMpM2nRn4iFbXpOIvw22+d+vagUC53fQRxrc/1/NXaHMwE6Jb1t5kA e6Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=cl6TQtvSxV7arO6sC6GB32F3upDS/NEMszQzruWKRcc=; b=MxnufD8LvmBMsSDaPp5Lx9h8HZs4Q2s/Xk+7YYQqml/Cv5rVfDZEoRjjtOFAdHlajv yyqDV+Tzxzp874FgiH0k3jVRIMihvrI5L1fXYgUB5xeNsQ1+XlrYv8GGy1Btdj1F7/Df z6wXbx1roHvEgaB4zBeCdeAcl3GNe1L63pJ5iIDV4y53SZC37xpmsV4yxRD9FOkLQu2m icaIzYN1SbwQfOpEbeYjpecTKFZkfn8Kbs9F4Mioarapb5kk9E5EWh+6Cz9uYwoziTU5 ov+YqkrCgnuanhcEIGbrCaUeiMuJSyc+ABKqfgkXWnG+9IKda5JOxvMUzofmMk5WtH17 2EAg== X-Gm-Message-State: ACgBeo1ir8E8KsMqz89a4YqseuuNHUetn+blW4r4FNcZkaJJqoR3yRxW Mftu08JwZ7OGZOD9LKTg9VNAtyH/W2NWdg== X-Google-Smtp-Source: AA6agR7o9oiM5Ax5NWGoLwW4ocg8WHS1lP829SnIBrG4qeMikWn2BpkhDwixaCAOF1QR1luBKp7KVg== X-Received: by 2002:a5d:6c6b:0:b0:225:dde:ab40 with SMTP id r11-20020a5d6c6b000000b002250ddeab40mr4611589wrz.690.1660923581387; Fri, 19 Aug 2022 08:39:41 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 05/11] hw/net/e1000e_core: Use definition to avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:25 +0100 Message-Id: <20220819153931.3147384-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660923866106100001 From: Philippe Mathieu-Daud=C3=A9 The compiler isn't clever enough to figure 'min_buf_size' is a constant, so help it by using a definitions instead. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Jason Wang Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- hw/net/e1000e_core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 208e3e0d798..82aa61fedcd 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -1622,15 +1622,16 @@ e1000e_rx_fix_l4_csum(E1000ECore *core, struct NetR= xPkt *pkt) } } =20 +/* Min. octets in an ethernet frame sans FCS */ +#define MIN_BUF_SIZE 60 + ssize_t e1000e_receive_iov(E1000ECore *core, const struct iovec *iov, int iovcnt) { static const int maximum_ethernet_hdr_len =3D (14 + 4); - /* Min. octets in an ethernet frame sans FCS */ - static const int min_buf_size =3D 60; =20 uint32_t n =3D 0; - uint8_t min_buf[min_buf_size]; + uint8_t min_buf[MIN_BUF_SIZE]; struct iovec min_iov; uint8_t *filter_buf; size_t size, orig_size; --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660924157; cv=none; d=zohomail.com; s=zohoarc; b=N8404DEkgWSYjBgpefJhJcA1QfBm0bzKURnETmdwLCPT4lBJhPIjFik0Yr7ZjZJIsh3xChOlyEk4fVEfvePPc+eflG5SVi7VZN5JXn5HSE+mIqzJxkb4/Wd+nzFVOdYH3JibxMBe37WwvD5K/GDTUEIF9CRcjpx6Ze/z6pUENKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660924157; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O0kTlYBRe8XrfOsBr0O7vJ0KUHjU8+ns6BkcrOf/Srs=; b=L9vJrsjB2y0ewWygwuL8WBN0apSuTil+yY9QZdzmgxksBONMuCqKvAj4kqGVFzWTwousmnVgcMApJXAUbRvOxWs07M3ZGiiOJWHiosTvxjNtxoAFG34rCeIdxua+yAApk1fU7xtqjoDYtSONffMhbzVPgfWOzVETZKjutHJGwj4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660924157733175.51508844496414; Fri, 19 Aug 2022 08:49:17 -0700 (PDT) Received: from localhost ([::1]:50958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4FI-0003Ud-I9 for importer@patchew.org; Fri, 19 Aug 2022 11:49:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP46A-0005iX-4b for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:50 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:42590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP464-00064f-9D for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:49 -0400 Received: by mail-wm1-x331.google.com with SMTP id l33-20020a05600c1d2100b003a645240a95so301861wms.1 for ; Fri, 19 Aug 2022 08:39:43 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=O0kTlYBRe8XrfOsBr0O7vJ0KUHjU8+ns6BkcrOf/Srs=; b=UGtuTV1t+QRxXJ4M+JwMNuCTwf/sLV+Mwn9bMwB4yodePOieFhw2G0WIVe6dEL5coy b13fdyeq65OVvEr9y9g5A/lHqGqkfP82AYbkuEI+xmu5ha/QAcboME6y1Wg3hajwsi4K cS9GRLmdcr5pBFlt+NY4VhKPlv6pbmo3tM435JrgBWtrh0Yd9SwGiwIDS8j1gSxIJjho n+decSApioxnvTFaFuMLxXAShU7Q3vHFFVY7JbW1i9zrAXuHs70iPFvDl3j50DuFOYsJ tinCK9H4YIlQjn0+w1Gl9Z935Fq17UhHFaoxzAcdJHx0tZG8uFt7/AoObgrG1YfZW5Gk qgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=O0kTlYBRe8XrfOsBr0O7vJ0KUHjU8+ns6BkcrOf/Srs=; b=GbWX3p03WEwhPmhSNPr6H+dLrG6/VhFPwgGgK4KgXPAYiexQjGj2v9LzebptJD3z4Y VO0fQmjv62YZHCSMQg5Exii88SPVgqk7/VyyXxGIhEUJjSsXabmPbxGdLNjIDRnYSmJC wKkkeazLAhBGR3ISbqEUpx5Z3S1VNluXHbJ885TKotTpRe0p5nF4R9T6PmY1SAiKVXq/ 6DdriM2WwobHkm4KML5/6uPIagfbsVQewvBTcDOuE/wIXAFztuj/qE6r8plb6mhe++KQ LswYeKVSbmyYUecviIRh5khx/VlDXzEcHNnCwjsXZ0p3hhRyYfDXrTxYFTmZQlpIokLn LzqQ== X-Gm-Message-State: ACgBeo3qiSdqCOAgj0zN4gBT0PzjPBLZm/mxIcYnNKpIT2+wgFTBTqt9 oiC0vap2Oah5LNxnGrfsTaxXCfck7OKmBQ== X-Google-Smtp-Source: AA6agR5gH8I34ZvPokMrTUVYPCruEb6H/S8MMh2sfi3OTP9DkY+TAv9WwUeBM+BvZWyA2CjOEpuP0Q== X-Received: by 2002:a05:600c:1898:b0:3a5:b467:c3ef with SMTP id x24-20020a05600c189800b003a5b467c3efmr8310912wmp.178.1660923582708; Fri, 19 Aug 2022 08:39:42 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 06/11] hw/ppc/pnv: Avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:26 +0100 Message-Id: <20220819153931.3147384-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660924159935100001 From: Philippe Mathieu-Daud=C3=A9 Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Signed-off-by: Peter Maydell Reviewed-by: Peter Maydell Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- hw/ppc/pnv.c | 4 ++-- hw/ppc/spapr.c | 8 ++++---- hw/ppc/spapr_pci_nvlink2.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index d3f77c83672..dd4101e5b65 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -137,7 +137,7 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, voi= d *fdt) int smt_threads =3D CPU_CORE(pc)->nr_threads; CPUPPCState *env =3D &cpu->env; PowerPCCPUClass *pcc =3D POWERPC_CPU_GET_CLASS(cs); - uint32_t servers_prop[smt_threads]; + g_autofree uint32_t *servers_prop =3D g_new(uint32_t, smt_threads); int i; uint32_t segs[] =3D {cpu_to_be32(28), cpu_to_be32(40), 0xffffffff, 0xffffffff}; @@ -240,7 +240,7 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, voi= d *fdt) servers_prop[i] =3D cpu_to_be32(pc->pir + i); } _FDT((fdt_setprop(fdt, offset, "ibm,ppc-interrupt-server#s", - servers_prop, sizeof(servers_prop)))); + servers_prop, sizeof(*servers_prop) * smt_threads))= ); } =20 static void pnv_dt_icp(PnvChip *chip, void *fdt, uint32_t pir, diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index bc9ba6e6dcf..28626efd479 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -177,8 +177,8 @@ static int spapr_fixup_cpu_smt_dt(void *fdt, int offset= , PowerPCCPU *cpu, int smt_threads) { int i, ret =3D 0; - uint32_t servers_prop[smt_threads]; - uint32_t gservers_prop[smt_threads * 2]; + g_autofree uint32_t *servers_prop =3D g_new(uint32_t, smt_threads); + g_autofree uint32_t *gservers_prop =3D g_new(uint32_t, smt_threads * 2= ); int index =3D spapr_get_vcpu_id(cpu); =20 if (cpu->compat_pvr) { @@ -196,12 +196,12 @@ static int spapr_fixup_cpu_smt_dt(void *fdt, int offs= et, PowerPCCPU *cpu, gservers_prop[i*2 + 1] =3D 0; } ret =3D fdt_setprop(fdt, offset, "ibm,ppc-interrupt-server#s", - servers_prop, sizeof(servers_prop)); + servers_prop, sizeof(*servers_prop) * smt_threads); if (ret < 0) { return ret; } ret =3D fdt_setprop(fdt, offset, "ibm,ppc-interrupt-gserver#s", - gservers_prop, sizeof(gservers_prop)); + gservers_prop, sizeof(*gservers_prop) * smt_threads = * 2); =20 return ret; } diff --git a/hw/ppc/spapr_pci_nvlink2.c b/hw/ppc/spapr_pci_nvlink2.c index 63b476c8f72..2a8a11be1d6 100644 --- a/hw/ppc/spapr_pci_nvlink2.c +++ b/hw/ppc/spapr_pci_nvlink2.c @@ -397,7 +397,7 @@ void spapr_phb_nvgpu_populate_pcidev_dt(PCIDevice *dev,= void *fdt, int offset, continue; } if (dev =3D=3D nvslot->gpdev) { - uint32_t npus[nvslot->linknum]; + g_autofree uint32_t *npus =3D g_new(uint32_t, nvslot->linknum); =20 for (j =3D 0; j < nvslot->linknum; ++j) { PCIDevice *npdev =3D nvslot->links[j].npdev; --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660924010; cv=none; d=zohomail.com; s=zohoarc; b=mM4IJc8kIuBteQyY+AK4uuV+lAbvS12GDSJeUAG5NZ9yA+mUOhUSE0/MQWng9stWzhOMr+LXTllb3ZneEsAHGsDRB1t29vMcQkQxoyzbOitW4e12YJ5PBBws9S4KsRxhDkGvAQ7YZ8WQSngUyeKsMUPiZRjBeCb7wKl+uBR+NT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660924010; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MdveKL4MP90EdNQkpPRlvAKQ9ASmc2UjMbS6E+1HF1Q=; b=m2MRNkoDeHDB3hsqk9QzyCRtm92CVOtx1MOZM/kpwjdnd3tiTfUfHC78/mKvK0ibsAgBV88KSW6GwZdNnvI6EPMkB7WTJr9Rk2Fnf7UwocpnBhj6gPdKgabm8ppm4IXLRUioIWX3T/ir52RpIaevft7LSTsRILAHPduCo90OZl4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660924010172564.389570969687; Fri, 19 Aug 2022 08:46:50 -0700 (PDT) Received: from localhost ([::1]:42274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4Ct-0000ad-Ti for importer@patchew.org; Fri, 19 Aug 2022 11:46:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP46D-0005lZ-Ih for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:53 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:39655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP465-00064w-Bl for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:53 -0400 Received: by mail-wr1-x435.google.com with SMTP id r16so5619823wrm.6 for ; Fri, 19 Aug 2022 08:39:44 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=MdveKL4MP90EdNQkpPRlvAKQ9ASmc2UjMbS6E+1HF1Q=; b=lihKwPGjA0DKnwXPdntU6GoO4IsgZ9k/4gQznM+g11xVB/9U9nbvIRDhzSaXbwnLY6 CUc+J+ULKLAmRls3veAO+02/NAVJSc6efljwzsZ5bfTLYzB4BJ9f4GnUkadUf9UTf341 AFiGAoBYxJXhTiXLFWaURNoDxffX9Dmyo23lSSSVN/Wm7uQ5dzMLew2qGJN1Ji5AK0uw EKtCH7aG2QI+CEEi3/AfFfTAgkRuiNHyvCwntiC3ENJfGT0AleM+ifLM7HzYxuQPwdAL D4ARWrj8jYXx+UOG2Bmn90vCyV7bHmCLBhpW0XGyxlAGfteANnv7c+ki/6iUtkKxkYXA rWQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=MdveKL4MP90EdNQkpPRlvAKQ9ASmc2UjMbS6E+1HF1Q=; b=Thbn5YsOkuiDJmr5JlTC1fXFcMcDFOB2dzwqRgdE8AaOhN+Z9W1bHpz5ZDu6yDs4mG 9s7/SfvQHj+EOiFXYtgZ6gr7DJtpKkYouj2hir4iJkPaeWBwlEBIkzDn+3YQuN/oOa4V 6d1Hsj8m9OYoCvfxumlLmdUvHJI3rRUb0pJiHkzgcrUWcFWuDF6wwz2bUGTxHU5v27vU Mccd1L7hOuELLnn79lr8P7L/Syzy7yBO4McUhBnFK/ee3pZE3Fbxlx8pLVp53xBFmwa2 o7U4MKErivL3K3d3MA8Tn8ti5pEshz3fPq2QE6RDoAARdBJZDMFw3HNBmN+bi4d2OQpc KBQA== X-Gm-Message-State: ACgBeo2rIY1L3zGR1UiV7abRTDtNxZ5B8xUukkmIRoyBIPnVokt78U4C nV2wzyBXhtFEz0u11irJfMAZ98A+K7ukMw== X-Google-Smtp-Source: AA6agR4ev68+RW+xxmy99eXOV+AlqS6M1f/wmO9AecmbCxg3txCKqDiVxs4WXWzuDt4KpTTgrXXFjg== X-Received: by 2002:a5d:4301:0:b0:21b:8af6:4a21 with SMTP id h1-20020a5d4301000000b0021b8af64a21mr4766102wrq.296.1660923583981; Fri, 19 Aug 2022 08:39:43 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 07/11] hw/intc/xics: Avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:27 +0100 Message-Id: <20220819153931.3147384-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660924010932100001 From: Philippe Mathieu-Daud=C3=A9 Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- hw/intc/xics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 5b0b4d96242..dcd021af668 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -567,8 +567,8 @@ static void ics_reset_irq(ICSIRQState *irq) static void ics_reset(DeviceState *dev) { ICSState *ics =3D ICS(dev); + g_autofree uint8_t *flags =3D g_malloc(ics->nr_irqs); int i; - uint8_t flags[ics->nr_irqs]; =20 for (i =3D 0; i < ics->nr_irqs; i++) { flags[i] =3D ics->irqs[i].flags; --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660923893; cv=none; d=zohomail.com; s=zohoarc; b=R+EcnfDxxihsRiO+vBAWmErJmryrlukkUuBMtej4z6fyBVPqrU1ADkFcWcJ4eMBkOVjdKnVa2AQ1L1DuL+7JznqUWWki+41gaOGfT0j1AQZuxtQM7kfsSwIMtcXKBFTI8Z0dQ2g73VlyaW3BQusFLt6E45A6WR/NaJK3AVtrIIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660923893; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=o0T9cbillLUVn1AQ53zgvfCfnDyIkISRz/FjBOjJIOk=; b=DugOJsufFFIKaedXHQIAwo7OMUCO+b7JavP4Il88wJJ9Q+M8FBXOsb0qr77t+yrVxHQRdEjH2agymItQqhwQXgN7qup1taPP8Kx8VJCvY4doAvEIX7NqecejUFNxm8EqDIIxIqFj/Y/D8Ekh6QMLCwlvfQ24Fii0GZp6z6FYjgA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660923893509842.5681780470045; Fri, 19 Aug 2022 08:44:53 -0700 (PDT) Received: from localhost ([::1]:51688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4B2-0007VR-FP for importer@patchew.org; Fri, 19 Aug 2022 11:44:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP46F-0005nG-Na for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:57 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:34636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP466-00065D-Pr for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:54 -0400 Received: by mail-wr1-x42f.google.com with SMTP id a4so5630379wrq.1 for ; Fri, 19 Aug 2022 08:39:46 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=o0T9cbillLUVn1AQ53zgvfCfnDyIkISRz/FjBOjJIOk=; b=AJGNqIPFvRZh9dyOzh83lCOXDOdwJuJroY0ue4jamLmE4hhHBnIkcH/YjwBoZQN04h 4FNbQqvml6gu45nz6SinqufrUu/lN/lVxmfZ6iYU9Pb0sNIkKAXE1YmjqUXE2mDG4CQA sJ6FVAEE6s1QY9yKdURXKQGJlZKvjwL9+zrIbQpF/43bX7AMcr6BcLl+y4xWTMnv9hgK 327+ygnd9SrPz1Y4xyvZFYV4vCVoGHNUdIL1myzRylCHCZrUEwLyJOaGlGn8mi+6pk3T q4rL0laq5fqN2mS4YT/UT6HzEtRjvk/GzbsQR3/jm4/24Op3TKFvLwl3Hidk24Jwa3qo YLcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=o0T9cbillLUVn1AQ53zgvfCfnDyIkISRz/FjBOjJIOk=; b=TdGYTeX6J3aIKsukaKHlNJhNn6Z0fcL7RsrslEom37qxMdPusoiRN4nG4KYNaOIYuB 9Xf6MbF0EjoRUf1WnpWXWYK9Q95p22Aw/giravgxXJzn4oxVFb6/B3H32pezlDF2Mjvt 8ggCMOHG6DhjsZnYBc7UhgLcUJZ+K8usEPWpkIQjW+n0ddAgaFCtH6FHdd97GnFdcTXi FYLi26Tge2ZTYkivRZD0I6yZ3jvnjEynac2+6ExMZjEkVq2YJ7tECDKpvbR2owi4kqst sc1iUGrtCQXwNOWKY1k/1WF4qZSf2zonzupTl3Ht8Xg58DnUVkibkoHP4IenjwkzNJjY ID7g== X-Gm-Message-State: ACgBeo1VBFmZdAXE9Q7fA+Jzg5bLNpoGzDzPyY8LV/2Y6Ee+QHNqHTF/ 76VtIganl9Bchxh23Q5S/nrg0maRNtpM1Q== X-Google-Smtp-Source: AA6agR6YJ4YKDT8h30zeUVPqRq86qt5YgiWufaFpDg1jORj8PKBChU+Kk9VbHqYsLSaPzKSGaCMYQw== X-Received: by 2002:adf:d1ea:0:b0:220:6334:25e with SMTP id g10-20020adfd1ea000000b002206334025emr4903739wrd.32.1660923585325; Fri, 19 Aug 2022 08:39:45 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 08/11] hw/i386/multiboot: Avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:28 +0100 Message-Id: <20220819153931.3147384-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660923894302100001 From: Philippe Mathieu-Daud=C3=A9 Use autofree heap allocation instead of variable-length array on the stack. Replace the snprintf() call by g_strdup_printf(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- hw/i386/multiboot.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 0a10089f14b..963e29362e4 100644 --- a/hw/i386/multiboot.c +++ b/hw/i386/multiboot.c @@ -163,6 +163,7 @@ int load_multiboot(X86MachineState *x86ms, uint8_t *mb_bootinfo_data; uint32_t cmdline_len; GList *mods =3D NULL; + g_autofree char *kcmdline =3D NULL; =20 /* Ok, let's see if it is a multiboot image. The header is 12x32bit long, so the latest entry may be 8192 - 48. = */ @@ -362,9 +363,7 @@ int load_multiboot(X86MachineState *x86ms, } =20 /* Commandline support */ - char kcmdline[strlen(kernel_filename) + strlen(kernel_cmdline) + 2]; - snprintf(kcmdline, sizeof(kcmdline), "%s %s", - kernel_filename, kernel_cmdline); + kcmdline =3D g_strdup_printf("%s %s", kernel_filename, kernel_cmdline); stl_p(bootinfo + MBI_CMDLINE, mb_add_cmdline(&mbs, kcmdline)); =20 stl_p(bootinfo + MBI_BOOTLOADER, mb_add_bootloader(&mbs, bootloader_na= me)); --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660923786; cv=none; d=zohomail.com; s=zohoarc; b=nhu2Bg1J17ZkFIvHDZqPzNSj280s6gs/iEyxtw4HxmEsDfMAydlWkAZhNuULBC6i5HmX+YoIPD+OrbIJ3wZ9VADbYcJillI4sS6YyNuZe8ix6wH2elARgNi7Z4A8pHfUPHoN/V5Px45cF9zAvNAZxNifwbD+ClUrI6zyxuxoq5k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660923786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wicKql4I/h9UnyT0qeiWtm97WB3+4GVyQ+X7NhjeYE4=; b=mnuCsxEE3I0vGg6od4kmTTA9hIcvNES0YTA5ZatG2UJf2vEZuv0LKhdgpLwfQK/PJt7AMQah/fNroIRiLyT4Eyx4+zVLOGdhPA7dHdmihO5JrpMBgO/L7AxQ/u4fwn2yl2QzQolS56CU67aMbDc0SDamrR//fm7tNi3rEfd86hs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660923786877273.4655608937119; Fri, 19 Aug 2022 08:43:06 -0700 (PDT) Received: from localhost ([::1]:46750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP49J-0003Kx-Q7 for importer@patchew.org; Fri, 19 Aug 2022 11:43:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP46C-0005lO-BM for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:53 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:39652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP468-00065d-Fz for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:52 -0400 Received: by mail-wr1-x431.google.com with SMTP id r16so5619983wrm.6 for ; Fri, 19 Aug 2022 08:39:48 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=wicKql4I/h9UnyT0qeiWtm97WB3+4GVyQ+X7NhjeYE4=; b=A3+tajuM/D+cBNz8wVn21umtZzep7yXocwXNlSjy9AmPvLeySUgvajsTefklCwaTPz A6S44opQ3e52W6gZaxmbVXXsVWsqyKcBRJZQqqSCbqw7EM1/1lnP1osx/9WeB9sAjeIG RX3Yluv1rRbWzX9Sn+kXVRiNwgwzaJ9kiiB9DxBgXo10xlV8TgEsYfLaPzPrnv6eccL/ lc7ovIH0eFtKCiIpbdAldAL9x6P6t+FB3O61h2OklmwHOO8kiPbhXtlN90u5TLASMwMh JaZG3cDHiW3MIHz0aAaKkpSHHqOma4HmFtSOxodLWFJHf4qt0l6mVo1Gi183PxgqZDeZ BbFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=wicKql4I/h9UnyT0qeiWtm97WB3+4GVyQ+X7NhjeYE4=; b=fFB2vRz7L+oJ68mW7QbqiWwH6oi5zdySSO5YpP+iyqZlNpSjz6wU6XCxHvqSpTxufc Wkcm8f/GPiO7KJ1OL8JISTW4tZbewksJLHFu8eE3xP4jvCDb7AC+HNpB+DGJ3nXMOb5I At8uM1whNb52hEwutsnUD9VAdrBN0BYanFhk2OFQUYg50Xp4ArPv7UFljoLy2m9txgZY cD6VSMTPON5U2IHOHSRy5PVhAjLu1sWLFTaiZcTeyFXohTsxDMx5QAJTiAs1fL/du8J+ CTNqqcDRROK6rC/9QwT8tZinUvpk8g4bNiePW/S61ir0slnT17Z53PGFbNFffwLM/KTC cQow== X-Gm-Message-State: ACgBeo1GBegnedj0YpyzLdhVVRLb6TC3aseAz+L3XRLmIez5LyLjxqe/ /FieC3g284WIRIxEc+dX4SNOt/m2FUgivQ== X-Google-Smtp-Source: AA6agR6dBct5DooPmF2wUlVZLk86l55DJfWxYUIfhvTjY5iU06dk3F2seoBbT8W1dOrB8u2hANiuqg== X-Received: by 2002:a5d:48c5:0:b0:225:2f99:430d with SMTP id p5-20020a5d48c5000000b002252f99430dmr4769879wrs.358.1660923586670; Fri, 19 Aug 2022 08:39:46 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 09/11] hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:29 +0100 Message-Id: <20220819153931.3147384-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660923787871100001 From: Philippe Mathieu-Daud=C3=A9 The compiler isn't clever enough to figure 'width' is a constant, so help it by using a definitions instead. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- hw/usb/hcd-ohci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 895b29fb865..5585fd32ccf 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -805,13 +805,14 @@ static int ohci_service_iso_td(OHCIState *ohci, struc= t ohci_ed *ed) return 1; } =20 +#define HEX_CHAR_PER_LINE 16 + static void ohci_td_pkt(const char *msg, const uint8_t *buf, size_t len) { bool print16; bool printall; - const int width =3D 16; int i; - char tmp[3 * width + 1]; + char tmp[3 * HEX_CHAR_PER_LINE + 1]; char *p =3D tmp; =20 print16 =3D !!trace_event_get_state_backends(TRACE_USB_OHCI_TD_PKT_SHO= RT); @@ -822,7 +823,7 @@ static void ohci_td_pkt(const char *msg, const uint8_t = *buf, size_t len) } =20 for (i =3D 0; ; i++) { - if (i && (!(i % width) || (i =3D=3D len))) { + if (i && (!(i % HEX_CHAR_PER_LINE) || (i =3D=3D len))) { if (!printall) { trace_usb_ohci_td_pkt_short(msg, tmp); break; --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660924279; cv=none; d=zohomail.com; s=zohoarc; b=MV2IKRttC28r9qjBDgqC1tX/AMO1jlRxsVPuS65IjrgZsGqUXjj/i/T2E6TcsxgrAmgKB+KPQno9GAzZ2+ODrKJdvgrMTaj8ywo06YmRWUejeTugZPjCijUXB0bCrcLgVFFUIxp9O/LW+eyUk7Cnkpcd3NKVFoId1NZ2oLtH2kk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660924279; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DXJfK+guYihDgdmOYphJLRS8QCxqYa74HNzsTOAa8r0=; b=lam3mH3+tQYtYxcdWFHdHUQa1U0kcn3SN6iMtxr3f+x0GZFOeul2P9jED2D96Lbihh2cLZ8INqPKyBtsChaTDz3RUkBnLwEIvqNHoRn+/gHydqzsUoPnOEhS6C1TeB+fSn/8ekyosDc0Db3seN9uf8pZxAImdJTnmbGyvd3aCm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660924279262263.92215055189854; Fri, 19 Aug 2022 08:51:19 -0700 (PDT) Received: from localhost ([::1]:56808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4HG-0006Y5-6k for importer@patchew.org; Fri, 19 Aug 2022 11:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP46F-0005nH-OX for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:57 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:39655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP46B-000664-FA for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:54 -0400 Received: by mail-wr1-x434.google.com with SMTP id r16so5620057wrm.6 for ; Fri, 19 Aug 2022 08:39:48 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DXJfK+guYihDgdmOYphJLRS8QCxqYa74HNzsTOAa8r0=; b=DyUMAANVNV/3+DdidR8URZyYe0tIx8aH5CKHdP8p6kD0wpb7Cuz/rmOyAtO1g5O9YI Vq/I96D+7FSyHJTK1yFKfHu1AmDHQyI2h6J4IGqtuoczYzXIOwaB+h7iPGNY00hum/j4 kGvrW4Jet4v97jVQpQHEKMWq7WgxiAgI083TyN0R8N7NDEWvK7+CMDadnZrm3TTNZbir kNrh1wIfEDT72O3Q5Bjtkkww7RQG+puWm926PM2FDHV04nR45tlBUaK8jGucP/HY2d76 4E2b3rrGtKw/jLdD2It8iVbwXYML4XZRDptsBBMsk4kwiISLpfeRbha8kmbkZdL2k8rJ yJaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DXJfK+guYihDgdmOYphJLRS8QCxqYa74HNzsTOAa8r0=; b=w2lAE55BMKcmOelL+T1dQuoXuY0GVOhYt9iPSIT80C7H7SxT1RZLHasjLE8z99MFEt k5kuQpq9W3YkaaktYKbMtTiQSjrvQ/QsuwncSH+GUm/XeYPerfIWBH7lnWO050y/811Z vL5fskjaXyHUYqRRZN6QzX5Qg555Bbh/uEGd8xb5YzEh3Msh2LeAym0OpT9hm29cGATX vNnlISK40LMnA8NeZDYUhnGBJJ0qFfF1Pv6I0o3HO8Q4nmRyZ5P+JdXBbOBUebr6oveT LcuEoIJDOWnxN+UUVfwBuk26UqRZZsFeIkqa32L3kNLi1P2e3fIOaBMvI2aLUbce5+EM aPvg== X-Gm-Message-State: ACgBeo25XQCDcCiX1aeCzOnFCuGFjpw7vUZBl2XC81J2MQdLYbv4IoD6 TYtHOhF9Zr8WhXfKptwiurWbsbQ/WvAf+g== X-Google-Smtp-Source: AA6agR57dyP1dzfOanR3Hupj+a3l3YMUK6P8LV81vQ26+VowFrOhQJ3xKpBuNcL5p3eKBDo4EJg8kA== X-Received: by 2002:a05:6000:15c3:b0:220:676e:c825 with SMTP id y3-20020a05600015c300b00220676ec825mr4565743wry.512.1660923587985; Fri, 19 Aug 2022 08:39:47 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 10/11] ui/curses: Avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:30 +0100 Message-Id: <20220819153931.3147384-11-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660924280456100001 From: Philippe Mathieu-Daud=C3=A9 Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- ui/curses.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/curses.c b/ui/curses.c index 861d63244c7..de962faa7cd 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -69,7 +69,7 @@ static void curses_update(DisplayChangeListener *dcl, int x, int y, int w, int h) { console_ch_t *line; - cchar_t curses_line[width]; + g_autofree cchar_t *curses_line =3D g_new(cchar_t, width); wchar_t wch[CCHARW_MAX]; attr_t attrs; short colors; --=20 2.25.1 From nobody Thu May 2 17:02:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1660924362; cv=none; d=zohomail.com; s=zohoarc; b=OdPXOyQaLqVEcpjOavx+W1m+R0zjfTRIjevbqh8ySo28yhl/QsD1UY9sY00IEzeSRMiaRcQcroEl9Nx79UlxYjKvnfGFWuh7QAHjLmCORp6bihzH+WkD5XO8gvJWyLf5jTZNUdGsnSZKH9uVlkiNP3nEQSNEHeedzJhIWdOK3rQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660924362; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zDPOe1uObuxexnvyi+yesTMCr3hQR4+1gwfCM4+5LO0=; b=isZhjBYbKBoxhS+A6DYvkMpG6b4gv0mNNC0TGlU86u7J0KBwMZGjSwQZlrJEoIbHPJXvDaWMi2QU3mfQpVEyVF53tmc22dmOx/k0vxTzJoWyARWRrTo0m0WCoTBQG6jh1qNBTl7NLZTloaPwZjQekFJNUiqORWWI5AZROaJHND8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660924362161179.9948118544752; Fri, 19 Aug 2022 08:52:42 -0700 (PDT) Received: from localhost ([::1]:44032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4IZ-0000lX-RO for importer@patchew.org; Fri, 19 Aug 2022 11:52:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP46D-0005le-JE for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:53 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP46A-00066e-Jt for qemu-devel@nongnu.org; Fri, 19 Aug 2022 11:39:53 -0400 Received: by mail-wr1-x436.google.com with SMTP id b5so1346653wrr.5 for ; Fri, 19 Aug 2022 08:39:50 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003a54109a6a0sm5558396wmb.3.2022.08.19.08.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 08:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=zDPOe1uObuxexnvyi+yesTMCr3hQR4+1gwfCM4+5LO0=; b=RXQ76h/CA4jXaZNLn4RwOVYu677lB4hoozg2SBc4RHoTFmiTJIej9SSYL6KQ3x0gtK iigSVbLLxoI0WM1jY7zka1QCXUXbirtltrZBy7KhZtINLjbIfccQzXx/D8iSJnaXGnjj yjccdRi7agGWSMhjEhvfxkarVciTFnCVxe2Cgvi5Y6fRFEWq/Nd16H5SOnU+KiGDZKDw EpMnKgb6SAnpfhJ7uoY0pFclRFUNh7HxkAvY8EAS7wdbYDbrbCYjaTtUdpZlHLzyFmHP 94o04J0hrNW9IsI8BrVmIg+ZXRm0drvgBrl8VxM+VBYHf3a06nImVJ3gkvdbJayN6IYg f4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=zDPOe1uObuxexnvyi+yesTMCr3hQR4+1gwfCM4+5LO0=; b=chv0h1A2Hs/ER5BEdYfs175CkmwAjIjwM7zngwD6C2uBiqrEhDTkLxwoNf/83jCpqw NicDTsDLv2hmZxHF1nmLfFxqtk1sMgPjxHpElmB+rq7MS4nuiOgdCNYWhDpOxFGi8Ada 3b3w+ppk2lMgFgEy56g5AQGpoQFEkhfZz7sEQ+tQ3a/mIJdLXGlPKj5AzIDc2WXxRyAH qgI743ObHr4E2fkWp10Mv2ALfHIynaTDEU+RpQesnFJEHgtgfAGJ8UXI+xk8OlPTANqS rq26dj9mKHfUA65jIjNB799xZ9JZByMXR1u7qYD3lLvkEjGmU1pGlfH6mC+XHzPHyT+u onsA== X-Gm-Message-State: ACgBeo3Cl0tqgcqsN2xTjzj2e0ZZkrAIUp2DqflsTfr75Sq/gYDIwyLe A1/6Z5a0YS0AjlRWSM849bGBj8H7OKJdeA== X-Google-Smtp-Source: AA6agR5A6GZoW3JsZOQPJd9YZK+EiySrV8mTBieN7MIq9baZBH1YjZY0w0pnTUVqmnlPXQpFaFAAtg== X-Received: by 2002:a5d:5711:0:b0:225:2884:cc88 with SMTP id a17-20020a5d5711000000b002252884cc88mr4537239wrv.141.1660923589234; Fri, 19 Aug 2022 08:39:49 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , Dmitry Fleytman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org Subject: [PATCH v2 11/11] tests/unit/test-vmstate: Avoid dynamic stack allocation Date: Fri, 19 Aug 2022 16:39:31 +0100 Message-Id: <20220819153931.3147384-12-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819153931.3147384-1-peter.maydell@linaro.org> References: <20220819153931.3147384-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1660924363044100001 From: Philippe Mathieu-Daud=C3=A9 Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- tests/unit/test-vmstate.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c index 72077b57800..541bb4f63e3 100644 --- a/tests/unit/test-vmstate.c +++ b/tests/unit/test-vmstate.c @@ -87,17 +87,16 @@ static void save_buffer(const uint8_t *buf, size_t buf_= size) static void compare_vmstate(const uint8_t *wire, size_t size) { QEMUFile *f =3D open_test_file(false); - uint8_t result[size]; + g_autofree uint8_t *result =3D g_malloc(size); =20 /* read back as binary */ =20 - g_assert_cmpint(qemu_get_buffer(f, result, sizeof(result)), =3D=3D, - sizeof(result)); + g_assert_cmpint(qemu_get_buffer(f, result, size), =3D=3D, size); g_assert(!qemu_file_get_error(f)); =20 /* Compare that what is on the file is the same that what we expected to be there */ - SUCCESS(memcmp(result, wire, sizeof(result))); + SUCCESS(memcmp(result, wire, size)); =20 /* Must reach EOF */ qemu_get_byte(f); --=20 2.25.1