From nobody Thu May 2 09:59:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660835277; cv=none; d=zohomail.com; s=zohoarc; b=IxOtBEveHr+cM4cCXoFtq3/F00j92X1vj45H1YffgCQcu6jEqBOzN1Qz1VBMODIwA8cB4apYMoDM0iqXTd2i3CPBmJdOp4FnvQOdOfLlfHhhBDJwqvfeYjLrR00aqVSBcRz6cAUn2eV/xWzF78DnvW+veQFyEqds8Zw40VqGuVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660835277; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZNtutvaNs+IyTdDaDfO0g848JBBjDcWXGm7EANLXEIg=; b=cawiN52YcSBTl2W95kCqc7uR7ffLHuw8vJKX9T3lnZ2bEtTAipEeWZUEbf+GtwPY+/lx9zwz6b8woFZ3kQbFr/qehu2/2E6yo+9V1GZtl8lUECxZ+KmBhyBmB4ytU/H61ojL2cHzNUjCIlkChJcVRAnuvn3lX3xKtuYkLMb4zN8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660835277284130.65974297006824; Thu, 18 Aug 2022 08:07:57 -0700 (PDT) Received: from localhost ([::1]:40196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOh7k-00038l-9q for importer@patchew.org; Thu, 18 Aug 2022 11:07:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOh1R-0003vP-Hg for qemu-devel@nongnu.org; Thu, 18 Aug 2022 11:01:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOh1O-0004cC-Kp for qemu-devel@nongnu.org; Thu, 18 Aug 2022 11:01:24 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-102-RHK2Hng5Oluj4lKQNZPu8w-1; Thu, 18 Aug 2022 11:01:17 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB16E800124; Thu, 18 Aug 2022 15:01:16 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.194.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F2A340CFD05; Thu, 18 Aug 2022 15:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660834880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNtutvaNs+IyTdDaDfO0g848JBBjDcWXGm7EANLXEIg=; b=WEdA2LQV+wWyYkoBvoTgfgPvEq9ne/DyiNchUV/6/Mtxyom2/GbjOcxG+1Ruc/Cmtdgmm+ wokCoz4f7T0WumjhKZRi1ib8Mijh2wt1x7PMOowLnP+59BGfcnerjWOSEBfbh2H37dAyJn Q/SnAIPM5tTLwe2OKzOSu6CfWPQWEWk= X-MC-Unique: RHK2Hng5Oluj4lKQNZPu8w-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Maxim Levitsky , Sean Christopherson Subject: [PATCH v1 1/2] i386: reset KVM nested state upon CPU reset Date: Thu, 18 Aug 2022 17:01:12 +0200 Message-Id: <20220818150113.479917-2-vkuznets@redhat.com> In-Reply-To: <20220818150113.479917-1-vkuznets@redhat.com> References: <20220818150113.479917-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660835278674100001 Content-Type: text/plain; charset="utf-8" Make sure env->nested_state is cleaned up when a vCPU is reset, it may be stale after an incoming migration, kvm_arch_put_registers() may end up failing or putting vCPU in a weird state. Reviewed-by: Maxim Levitsky Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm/kvm.c | 37 +++++++++++++++++++++++++++---------- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index f148a6d52fa4..4f8dacc1d4b5 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -1695,6 +1695,30 @@ static void kvm_init_xsave(CPUX86State *env) env->xsave_buf_len); } =20 +static void kvm_init_nested_state(CPUX86State *env) +{ + struct kvm_vmx_nested_state_hdr *vmx_hdr; + uint32_t size; + + if (!env->nested_state) { + return; + } + + size =3D env->nested_state->size; + + memset(env->nested_state, 0, size); + env->nested_state->size =3D size; + + if (cpu_has_vmx(env)) { + env->nested_state->format =3D KVM_STATE_NESTED_FORMAT_VMX; + vmx_hdr =3D &env->nested_state->hdr.vmx; + vmx_hdr->vmxon_pa =3D -1ull; + vmx_hdr->vmcs12_pa =3D -1ull; + } else if (cpu_has_svm(env)) { + env->nested_state->format =3D KVM_STATE_NESTED_FORMAT_SVM; + } +} + int kvm_arch_init_vcpu(CPUState *cs) { struct { @@ -2122,19 +2146,10 @@ int kvm_arch_init_vcpu(CPUState *cs) assert(max_nested_state_len >=3D offsetof(struct kvm_nested_state,= data)); =20 if (cpu_has_vmx(env) || cpu_has_svm(env)) { - struct kvm_vmx_nested_state_hdr *vmx_hdr; - env->nested_state =3D g_malloc0(max_nested_state_len); env->nested_state->size =3D max_nested_state_len; =20 - if (cpu_has_vmx(env)) { - env->nested_state->format =3D KVM_STATE_NESTED_FORMAT_VMX; - vmx_hdr =3D &env->nested_state->hdr.vmx; - vmx_hdr->vmxon_pa =3D -1ull; - vmx_hdr->vmcs12_pa =3D -1ull; - } else { - env->nested_state->format =3D KVM_STATE_NESTED_FORMAT_SVM; - } + kvm_init_nested_state(env); } } =20 @@ -2199,6 +2214,8 @@ void kvm_arch_reset_vcpu(X86CPU *cpu) /* enabled by default */ env->poll_control_msr =3D 1; =20 + kvm_init_nested_state(env); + sev_es_set_reset_vector(CPU(cpu)); } =20 --=20 2.37.1 From nobody Thu May 2 09:59:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660835064; cv=none; d=zohomail.com; s=zohoarc; b=GKxb/LRyuWkbYLAhduN4YYbMJ+cTGymKt4M1TbDgVowv6rr5Wf+7PvvpJmyEbvvmV152rlneE9SsF/5kc2wk6n9ko8j+L+bfkvT84ocvUQmz/A/OFr1fChQSKcUTfscRh+9t6mbchAIVWpYkroBcDptBAdmygBTKN4JOJ3xUfik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660835064; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UOvNvbrnmrXrNsNY3NRg79pd9QJm0H6OxC7D6UNZjGk=; b=jjziwM2aaO9eNW9YHEskGGaIZOnrSCA4IDiGioqIxqOurCXigGabk+Qcylvybyc7h+dXcDcpE+B2vF0xiUl3fHCvgkBTlteRZdIxrPAuA2aEoJS4hKvky76Mkhw21iem0Q4vK5J5n+iN7AIaltwIiTfXVTvj3eDioJy9dffxbjo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660835064865754.0487391621122; Thu, 18 Aug 2022 08:04:24 -0700 (PDT) Received: from localhost ([::1]:55946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOh4I-0006lT-Qt for importer@patchew.org; Thu, 18 Aug 2022 11:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOh1T-0003vo-71 for qemu-devel@nongnu.org; Thu, 18 Aug 2022 11:01:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:46374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOh1Q-0004h6-5S for qemu-devel@nongnu.org; Thu, 18 Aug 2022 11:01:25 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-onFacnghPzaCFH8JyJtamg-1; Thu, 18 Aug 2022 11:01:19 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC9F98DC04C; Thu, 18 Aug 2022 15:01:18 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.194.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CBE640CFD05; Thu, 18 Aug 2022 15:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660834882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UOvNvbrnmrXrNsNY3NRg79pd9QJm0H6OxC7D6UNZjGk=; b=V60jUV/QE8VZDowoxIUvZY9Mu8F0XdyEUUheDzVa2VBV0YlGI/1cUHzJDlIcR9CIqOnmL+ 5ARZETIdMpRBLviu3PuGt6Wq6Lr7pNEfyn7ciU/n5rCRdfYi9xgIeIZmO2vXb3RXWJUGR3 /unE5kjYVuWT+rkA8KgT3q/Ly2UcCCY= X-MC-Unique: onFacnghPzaCFH8JyJtamg-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Maxim Levitsky , Sean Christopherson Subject: [PATCH v1 2/2] i386: do kvm_put_msr_feature_control() first thing when vCPU is reset Date: Thu, 18 Aug 2022 17:01:13 +0200 Message-Id: <20220818150113.479917-3-vkuznets@redhat.com> In-Reply-To: <20220818150113.479917-1-vkuznets@redhat.com> References: <20220818150113.479917-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660835067106100001 Content-Type: text/plain; charset="utf-8" kvm_put_sregs2() fails to reset 'locked' CR4/CR0 bits upon vCPU reset when it is in VMX root operation. Do kvm_put_msr_feature_control() before kvm_put_sregs2() to (possibly) kick vCPU out of VMX root operation. It also seems logical to do kvm_put_msr_feature_control() before kvm_put_nested_state() and not after it, especially when 'real' nested state is set. Signed-off-by: Vitaly Kuznetsov --- target/i386/kvm/kvm.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 4f8dacc1d4b5..a1fd1f53791d 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -4529,6 +4529,18 @@ int kvm_arch_put_registers(CPUState *cpu, int level) =20 assert(cpu_is_stopped(cpu) || qemu_cpu_is_self(cpu)); =20 + /* + * Put MSR_IA32_FEATURE_CONTROL first, this ensures the VM gets out of= VMX + * root operation upon vCPU reset. kvm_put_msr_feature_control() shoul= d also + * preceed kvm_put_nested_state() when 'real' nested state is set. + */ + if (level >=3D KVM_PUT_RESET_STATE) { + ret =3D kvm_put_msr_feature_control(x86_cpu); + if (ret < 0) { + return ret; + } + } + /* must be before kvm_put_nested_state so that EFER.SVME is set */ ret =3D has_sregs2 ? kvm_put_sregs2(x86_cpu) : kvm_put_sregs(x86_cpu); if (ret < 0) { @@ -4540,11 +4552,6 @@ int kvm_arch_put_registers(CPUState *cpu, int level) if (ret < 0) { return ret; } - - ret =3D kvm_put_msr_feature_control(x86_cpu); - if (ret < 0) { - return ret; - } } =20 if (level =3D=3D KVM_PUT_FULL_STATE) { --=20 2.37.1