From nobody Tue Feb 10 02:00:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660631518; cv=none; d=zohomail.com; s=zohoarc; b=ARVFGsSuX9ULkxKjc+dYmbhhQg91+aBRdhpnMENX/A0nisiNxmfp8XiL81KtAb9tZ8KHZT6yPamZNEFTf2+lReCvR7FFOynvKYAvrfIT8E11zCjN3Rp2rzb0j2H/iVJEt1kzoYivg9SK9Js3QcEmA4Q5vSpPHIuUya9oNnSWdu0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660631518; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yMqYS1x2K+YOxm8GuxGhnoarBMz1ltJDvihoD3vL5Bo=; b=kFMW4THsDENHwuSW99JsNE4ONvAPPB0QdRsBTLfFfeJ5mql693gdwB13zm2ccyjRxmT1CtTevb7R8OhoKXZ8E7VjtJCP9fXpr9NzBMJB++EpCoTlAFv2howeU8NRIe1rswIiU5UIYI2kLvsNFmPlzFl81HMKvtY04peIoqj82ns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660631518745374.56675440618426; Mon, 15 Aug 2022 23:31:58 -0700 (PDT) Received: from localhost ([::1]:56562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNq7J-0000ow-Ia for importer@patchew.org; Tue, 16 Aug 2022 02:31:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNq1R-00064f-QS; Tue, 16 Aug 2022 02:25:53 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:46735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNq1Q-0003ap-8Q; Tue, 16 Aug 2022 02:25:53 -0400 Received: by mail-pl1-x62c.google.com with SMTP id jm11so6118530plb.13; Mon, 15 Aug 2022 23:25:51 -0700 (PDT) Received: from roots.. ([106.84.129.185]) by smtp.gmail.com with ESMTPSA id e15-20020a170902784f00b0016f1c1f50f4sm8082868pln.235.2022.08.15.23.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 23:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=yMqYS1x2K+YOxm8GuxGhnoarBMz1ltJDvihoD3vL5Bo=; b=qdPLK86+huZpooMmnOdh/EXw/m/iM4c/f0FhBr5r/CNDx8zoJ/mJXQw8Yp2EPkjwsn oG+Pdjv6OAZyy8iYzr8LHaTnIFfTgeSmQ0N9atnG9AFGhu84JKG9dCq6MtPC1AlxmZV8 DX1p7xJhkUKHruLpv+XxzVKHeLp4e5Wta7hwi+vaQIr5rtRICBN5QXbxepuZWHvfJAIU LjJyL5dkGVybJ9f2tU8wDjNBrpk816m2a/W34KMTEwu8GEmGkJvA9SIBqnZUXax814T5 w2dWP3MeeO4l63Us/7MLYnWjdKZWrsqEMwUr9LLDZNC7ZwPxAX39msMLORrIEBGXXMjC GzNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=yMqYS1x2K+YOxm8GuxGhnoarBMz1ltJDvihoD3vL5Bo=; b=WhOXaRrCYxKMa73uYZ/W1wmm9QlAZ/cTb2Sude7AVGdysF4+dGQgM5jMei3if02Wma YaIWOdegabrZboi1dtYtmVQmHvUeFDh9/4hwOakoEXeloKOg9jgQK4rlU+L1DEozxQuE /akRXEFA0pDGd14XdzZ9Y1mtmlRaOdd3MaR73gZoz+iKwSNjWwdP5Q6JSPMe3Ctc0unf 4SRrfFp2Fp9M7hLSkvRjI8lpqbn+67SePcynw0NxP26N9343rWnZprEY00c2lWLQlN3Q cAY7YdYi7s51zwSs5NS//l5egPjKA2LDbW7mg94wANwZeaobBcGSpLQkSOwKs9VpnO5J 3f3w== X-Gm-Message-State: ACgBeo38PsgLdymRI8qoHidpohcZ83oOkDdSIaEx9H8y79wRiE16OqOW BXOdBPsbNbKsk4gQqeO5m48RRoWFJoqwQQ== X-Google-Smtp-Source: AA6agR4g9aw6McAT7dxJUf2xLrPZePW3E/jyydl9L4EjrhcHSIS9CjRP04SFxt5p0rd+cxzONVF6bQ== X-Received: by 2002:a17:90b:4c89:b0:1f5:3aee:79d1 with SMTP id my9-20020a17090b4c8900b001f53aee79d1mr31709685pjb.195.1660631150481; Mon, 15 Aug 2022 23:25:50 -0700 (PDT) From: Sam Li To: qemu-devel@nongnu.org Cc: hare@suse.de, Fam Zheng , Kevin Wolf , Eric Blake , Markus Armbruster , stefanha@redhat.com, Hanna Reitz , dmitry.fomichev@wdc.com, qemu-block@nongnu.org, damien.lemoal@opensource.wdc.com, Sam Li Subject: [PATCH v7 6/8] config: add check to block layer Date: Tue, 16 Aug 2022 14:25:20 +0800 Message-Id: <20220816062522.85714-7-faithilikerun@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220816062522.85714-1-faithilikerun@gmail.com> References: <20220816062522.85714-1-faithilikerun@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=faithilikerun@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1660631520095100003 Content-Type: text/plain; charset="utf-8" Putting zoned/non-zoned BlockDrivers on top of each other is not allowed. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- block.c | 14 ++++++++++++++ block/raw-format.c | 1 + include/block/block_int-common.h | 5 +++++ 3 files changed, 20 insertions(+) diff --git a/block.c b/block.c index bc85f46eed..affe6c597e 100644 --- a/block.c +++ b/block.c @@ -7947,6 +7947,20 @@ void bdrv_add_child(BlockDriverState *parent_bs, Blo= ckDriverState *child_bs, return; } =20 + /* + * Non-zoned block drivers do not follow zoned storage constraints + * (i.e. sequential writes to zones). Refuse mixing zoned and non-zoned + * drivers in a graph. + */ + if (!parent_bs->drv->supports_zoned_children && + child_bs->bl.zoned !=3D BLK_Z_HM) { + error_setg(errp, "Cannot add a %s child to a %s parent", + child_bs->bl.zoned =3D=3D BLK_Z_HM ? "zoned" : "non-zon= ed", + parent_bs->drv->supports_zoned_children ? + "support zoned children" : "not support zoned children"= ); + return; + } + if (!QLIST_EMPTY(&child_bs->parents)) { error_setg(errp, "The node %s already has a parent", child_bs->node_name); diff --git a/block/raw-format.c b/block/raw-format.c index 6b20bd22ef..9441536819 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -614,6 +614,7 @@ static void raw_child_perm(BlockDriverState *bs, BdrvCh= ild *c, BlockDriver bdrv_raw =3D { .format_name =3D "raw", .instance_size =3D sizeof(BDRVRawState), + .supports_zoned_children =3D true, .bdrv_probe =3D &raw_probe, .bdrv_reopen_prepare =3D &raw_reopen_prepare, .bdrv_reopen_commit =3D &raw_reopen_commit, diff --git a/include/block/block_int-common.h b/include/block/block_int-com= mon.h index de44c7b6f4..4c44592b59 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -126,6 +126,11 @@ struct BlockDriver { */ bool is_format; =20 + /* + * Set to true if the BlockDriver supports zoned children. + */ + bool supports_zoned_children; + /* * Drivers not implementing bdrv_parse_filename nor bdrv_open should h= ave * this field set to true, except ones that are defined only by their --=20 2.37.1