From nobody Thu May 9 00:45:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660133940; cv=none; d=zohomail.com; s=zohoarc; b=ee0xI62xlKmT+CGxR2HOKs7KF2Dk49EYvIxDFZEDA3tN8LP1bEU+eoxtM5BqMqJbanhyTaoQNVDSl1bQC4et11rnzhwT0oOxdcFL9igBvyvn28+DW2tBh7VubfRkrZAyOknyH2m1xuOsw12eigE8G0+A9SBc1DB7Ua8RACIXYkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660133940; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=kyKowcGBl3oLP1HJlsQ1dss7fCPJLqogLlqFaLGgDMg=; b=j8z0ULFybMgIJKeS3MRBu4391JVKikk6q0r6DRFWkkIf61Yos9OF2rtXI6dNoFgTrSJKEGAz17uX9hiV+y0EtnoJo/sNuYvf21leAbfLk7UiaAbNV88ipSkFeeL8uBhyuA54U6hcabbzIz2h7ilUqFxPGE2u9U/xL3lkVn1RCns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660133940086737.5848561740391; Wed, 10 Aug 2022 05:19:00 -0700 (PDT) Received: from localhost ([::1]:33814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLkfp-000145-Nz for importer@patchew.org; Wed, 10 Aug 2022 08:18:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLkcY-00083h-5H for qemu-devel@nongnu.org; Wed, 10 Aug 2022 08:15:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLkcQ-0000bM-7V for qemu-devel@nongnu.org; Wed, 10 Aug 2022 08:15:28 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-356-pFve0XSBPiWVNjbohcn2-g-1; Wed, 10 Aug 2022 08:15:18 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3DEB1C06903; Wed, 10 Aug 2022 12:15:17 +0000 (UTC) Received: from localhost (unknown [10.39.208.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8BEAB492CA4; Wed, 10 Aug 2022 12:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660133721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kyKowcGBl3oLP1HJlsQ1dss7fCPJLqogLlqFaLGgDMg=; b=fylRVWixucTerhAK/aKbibYqIYp1qV30NU8ca09UpHI0LfUs8lz2H/NdLmeTFY+ROEHY85 XId2Mfm7NlYpJjCmGTjtvpTNrcuRgxyLqdmHARI0sK0p/3AsvA8VglcWqgSebxf8aAVtSf +2AA5ONLjuekIhm31qo2PwCe04Xpkko= X-MC-Unique: pFve0XSBPiWVNjbohcn2-g-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Markus Armbruster , Michael Roth Subject: [PATCH] tests/unit: fix a -Wformat-trunction warning Date: Wed, 10 Aug 2022 16:15:13 +0400 Message-Id: <20220810121513.1356081-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660133942246100001 From: Marc-Andr=C3=A9 Lureau ../tests/test-qobject-input-visitor.c: In function =E2=80=98test_visitor_in= _list=E2=80=99: ../tests/test-qobject-input-visitor.c:454:49: warning: =E2=80=98%d=E2=80=99= directive output may be truncated writing between 1 and 10 bytes into a re= gion of size 6 [-Wformat-truncation=3D] 454 | snprintf(string, sizeof(string), "string%d", i); | ^~ ../tests/test-qobject-input-visitor.c:454:42: note: directive argument in t= he range [0, 2147483606] 454 | snprintf(string, sizeof(string), "string%d", i); | ^~~~~~~~~~ ../tests/test-qobject-input-visitor.c:454:9: note: =E2=80=98snprintf=E2=80= =99 output between 8 and 17 bytes into a destination of size 12 454 | snprintf(string, sizeof(string), "string%d", i); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Not trying to be clever, this is called 3 times during tests, let simply use g_strdup_printf(). Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Markus Armbruster --- tests/unit/test-qobject-input-visitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/unit/test-qobject-input-visitor.c b/tests/unit/test-qobj= ect-input-visitor.c index 14329dabcf..5f614afdbf 100644 --- a/tests/unit/test-qobject-input-visitor.c +++ b/tests/unit/test-qobject-input-visitor.c @@ -447,9 +447,8 @@ static void test_visitor_in_list(TestInputVisitorData *= data, g_assert(head !=3D NULL); =20 for (i =3D 0, item =3D head; item; item =3D item->next, i++) { - char string[12]; + g_autofree char *string =3D g_strdup_printf("string%d", i); =20 - snprintf(string, sizeof(string), "string%d", i); g_assert_cmpstr(item->value->string, =3D=3D, string); g_assert_cmpint(item->value->integer, =3D=3D, 42 + i); } --=20 2.37.1