From nobody Sun May 5 12:36:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660038053; cv=none; d=zohomail.com; s=zohoarc; b=K6XbduJLx4Y9h9+HIN+kYJtDcQm2KGRXG4J5hAgMOsRItfCOZQwOqDHP0T/ahHMLriSGPQ8/JLS5vqs7HjNrHcWmCg2t+tKooJsEmGeTJ16/ME0u6ztkqbDLHe0mwnMYTsQdvjUJczHxJRRCk8RP6JxKzfi8RlFu7TLMYl8fX7E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660038053; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=0qv/asIz7SFh4YIycmnJpCCzIV1dg99knJDcS3TQPUo=; b=Fkmm867piJ8WYf3oJEfV3TnfhrbCspCwz091z2pWfbV0O1PztZlII90uXf3q0eD37e+2B4a7r3Hjsuljb8jSBtMJj+efddEBvA12teDbEmXZafQT4NvBS6sqU1ZmvHOdcGsN2kzftOWHaDV1j0vBo4KtvO0SXLOASbKOYo6+M6M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660038053181634.677201073985; Tue, 9 Aug 2022 02:40:53 -0700 (PDT) Received: from localhost ([::1]:40790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLLjH-0006pB-JJ for importer@patchew.org; Tue, 09 Aug 2022 05:40:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLLhZ-000691-H6 for qemu-devel@nongnu.org; Tue, 09 Aug 2022 05:39:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLLhW-00029B-S3 for qemu-devel@nongnu.org; Tue, 09 Aug 2022 05:39:04 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-294-Zm-TY4EQPle1m2tU7TIP5g-1; Tue, 09 Aug 2022 05:38:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 712F08041B5 for ; Tue, 9 Aug 2022 09:38:54 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4926C2026D64; Tue, 9 Aug 2022 09:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660037938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0qv/asIz7SFh4YIycmnJpCCzIV1dg99knJDcS3TQPUo=; b=AoUPW+euN/P8sSAAVsUHUCIdh+/xgWUciy4ySUaTNNskntzVnlo2ZGc2DwUO5uW4fH9IU/ HtMCrxTCiGrLuecynqv+uUsMFjGp0vOJXxXgHr7SIMh7qPWk+JkMkTMiFb8CHl+X/AV0XV 1YMYJ0/YH8nmZ9jQMWpGiUqFUF6MNV0= X-MC-Unique: Zm-TY4EQPle1m2tU7TIP5g-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Thomas Huth , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] tests/qtest: misc tweaks to readconfig Date: Tue, 9 Aug 2022 05:38:54 -0400 Message-Id: <20220809093854.168438-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660038054264100001 The property name parameter is ignored when visiting a top level type, but the obvious typo should be fixed to avoid confusion. A few indentation issues were tidied up. We can break out of the loop when finding the RNG device. Finally, close the temp FD immediately when no longer needed. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- tests/qtest/readconfig-test.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qtest/readconfig-test.c b/tests/qtest/readconfig-test.c index 2e604d7c2d..c7a9b0c7dd 100644 --- a/tests/qtest/readconfig-test.c +++ b/tests/qtest/readconfig-test.c @@ -33,13 +33,12 @@ static QTestState *qtest_init_with_config(const char *c= fgdata) g_assert_cmpint(cfgfd, >=3D, 0); =20 ret =3D qemu_write_full(cfgfd, cfgdata, strlen(cfgdata)); + close(cfgfd); if (ret < 0) { unlink(cfgpath); } g_assert_cmpint(ret, =3D=3D, strlen(cfgdata)); =20 - close(cfgfd); - args =3D g_strdup_printf("-nodefaults -machine none -readconfig %s", c= fgpath); =20 qts =3D qtest_init(args); @@ -79,7 +78,7 @@ static void test_x86_memdev(void) "size =3D \"200\""; =20 qts =3D qtest_init_with_config(cfgdata); - /* Test valid command */ + /* Test valid command */ resp =3D qtest_qmp(qts, "{ 'execute': 'query-memdev' }"); test_x86_memdev_resp(qdict_get(resp, "return")); qobject_unref(resp); @@ -96,7 +95,7 @@ static void test_spice_resp(QObject *res) =20 g_assert(res); v =3D qobject_input_visitor_new(res); - visit_type_SpiceInfo(v, "spcie", &spice, &error_abort); + visit_type_SpiceInfo(v, "spice", &spice, &error_abort); =20 g_assert(spice); g_assert(spice->enabled); @@ -114,7 +113,7 @@ static void test_spice(void) "unix =3D \"on\"\n"; =20 qts =3D qtest_init_with_config(cfgdata); - /* Test valid command */ + /* Test valid command */ resp =3D qtest_qmp(qts, "{ 'execute': 'query-spice' }"); test_spice_resp(qdict_get(resp, "return")); qobject_unref(resp); @@ -144,6 +143,7 @@ static void test_object_rng_resp(QObject *res) if (g_str_equal(obj->name, "rng0") && g_str_equal(obj->type, "child")) { seen_rng =3D true; + break; } =20 tmp =3D tmp->next; @@ -164,7 +164,7 @@ static void test_object_rng(void) "id =3D \"rng0\"\n"; =20 qts =3D qtest_init_with_config(cfgdata); - /* Test valid command */ + /* Test valid command */ resp =3D qtest_qmp(qts, "{ 'execute': 'qom-list'," " 'arguments': {'path': '/objects' }}"); --=20 2.37.1