From nobody Sun May 5 14:41:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1660035699; cv=none; d=zohomail.com; s=zohoarc; b=Fbim+1Lup+mvS8vPXCBLImeBjMxj2y7GVen5M5Rby6+042XTu+a7TfK/otEumZqHLxeiPsKkyQPno6WT1iFXfG7r3/+LcehSK5qzsbvJybgQbCNi8uuN+6r9YbEVgl+f97NBshm2ahyq0JVX1QFK2U+55QKWI0lHLc/QPQtVyRw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660035699; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=rfKEnAmAh7sYFnFgkn/yHGVKbjx9sWjzXLUQfw23fic=; b=LHUSDiJpkdh+CBO/qLk3YW+qAtO8GpfxEDDMpz73VgC3oMABRyxe/2l15cDz6nEEUgg+5rOOooqmgobJSob2FpGtH9yAIpCVwMMvzfzYGCp5kdGgL5+QgRBx4TkKZdOhC7mXcf4nlZdYjrWv0Sq9WaqisBMe3HXF5cgfmDW5VXc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1660035699927691.7886796130281; Tue, 9 Aug 2022 02:01:39 -0700 (PDT) Received: from localhost ([::1]:42636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLL7K-0004Yc-AD for importer@patchew.org; Tue, 09 Aug 2022 05:01:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLL5N-0003oP-SV for qemu-devel@nongnu.org; Tue, 09 Aug 2022 04:59:37 -0400 Received: from mga12.intel.com ([192.55.52.136]:42147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLL5J-0003sm-LZ for qemu-devel@nongnu.org; Tue, 09 Aug 2022 04:59:37 -0400 Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 01:59:26 -0700 Received: from tkid-nvme.sh.intel.com ([10.239.161.133]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 01:59:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660035573; x=1691571573; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Rfpgcc6yi6wbSw4kL/lv0dleWfbcK7oeJbgKnkViI5o=; b=Si6jo1u8EeUSMz4AM8qgmj1sakU7gCP/Oi4LmHUARjNyEq2+h7jK08sZ 17vIXIUblILXFHZ3fkck9PDQvDZren4W2MtDX1Q6IBELIL1XnSFrlJo6t t69/bOyi3xu3mN4GZcWdv+jIxbPWvrbOqyZHrhz6bq5VzbA5uce2jp8dj HhEvaRfOBdYoPCLmbW+JMtBrvbfXefJZKyrrTW4cfzAgz/TuCQHy2IHtn y3YkUve+SsmslAWFOoqY+4VKnAp/pJAN7yCZUBMkrGfbR21w7EyBNyEls RW0s4TRbTTF6msTu4Hyd3FvKp0mYBVQYEDrLTlQ8s+MQ3EbbQqA1jQMlQ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="270565066" X-IronPort-AV: E=Sophos;i="5.93,224,1654585200"; d="scan'208";a="270565066" X-IronPort-AV: E=Sophos;i="5.93,224,1654585200"; d="scan'208";a="633257587" From: Zhang Chen To: Jason Wang , Peter Maydell , Li Zhijian , qemu-dev Cc: Zhang Chen Subject: [PATCH V4] net/colo.c: Fix the pointer issue reported by Coverity. Date: Tue, 9 Aug 2022 16:44:37 +0800 Message-Id: <20220809084437.216420-1-chen.zhang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.136; envelope-from=chen.zhang@intel.com; helo=mga12.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1660035701036100001 Content-Type: text/plain; charset="utf-8" When enabled the virtio-net-pci, guest network packet will load the vnet_hdr. In COLO status, the primary VM's network packet maybe redirect to another VM, it need filter-redirect enable the vnet_hdr flag at the same time, COLO-proxy will correctly parse the original network packet. If have any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++++++++++-------- net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c index 6b0ff562ad..6930a2f4f6 100644 --- a/net/colo.c +++ b/net/colo.c @@ -44,21 +44,23 @@ int parse_packet_early(Packet *pkt) { int network_length; static const uint8_t vlan[] =3D {0x81, 0x00}; - uint8_t *data =3D pkt->data + pkt->vnet_hdr_len; + uint8_t *data =3D pkt->data; uint16_t l3_proto; ssize_t l2hdr_len; =20 - if (data =3D=3D NULL) { - trace_colo_proxy_main_vnet_info("This packet is not parsed correct= ly, " + assert(data); + + /* Check the received vnet_hdr_len then add the offset */ + if ((pkt->vnet_hdr_len > sizeof(sizeof(struct virtio_net_hdr_v1_hash))= ) || + (pkt->size < sizeof(struct eth_header) + sizeof(struct vlan_header) + + pkt->vnet_hdr_len)) { + trace_colo_proxy_main_vnet_info("This packet may be load wrong " "pkt->vnet_hdr_len", pkt->vnet_hdr= _len); return 1; } - l2hdr_len =3D eth_get_l2_hdr_length(data); + data +=3D pkt->vnet_hdr_len; =20 - if (pkt->size < ETH_HLEN + pkt->vnet_hdr_len) { - trace_colo_proxy_main("pkt->size < ETH_HLEN"); - return 1; - } + l2hdr_len =3D eth_get_l2_hdr_length(data); =20 /* * TODO: support vlan. diff --git a/net/colo.h b/net/colo.h index 8b3e8d5a83..22fc3031f7 100644 --- a/net/colo.h +++ b/net/colo.h @@ -18,6 +18,7 @@ #include "qemu/jhash.h" #include "qemu/timer.h" #include "net/eth.h" +#include "standard-headers/linux/virtio_net.h" =20 #define HASHTABLE_MAX_SIZE 16384 =20 --=20 2.25.1