From nobody Mon Feb 9 23:02:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659963791; cv=none; d=zohomail.com; s=zohoarc; b=G/Cwtmxi5sL9oLe5ZRm9FqLBW5cY+aTzkAxdiPb7Gpv8pJyWh1Mkb0HQp5alxNftfI92E6qrfFzVCudn5lHtyTT6KRYV7FrNXJ+6Ny7n7qoKsN7tP+2lPwf8Nxfs3WuxFSHYZS5JvZLD/LLXkfIPY4Z/fGsNzeUL4GXOn5mfn7M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659963791; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VUcJSPihr1CxmcurGisfq4kv3QpUdIwCLFpiSeuBEig=; b=FcBrNnMrwlUjDQKPrnaomINa2pX890ng7GvHKIa/YQLdwnx6it0S2SQE0Vyk7nYnoWOt/idqufOlu3YQOscrCLVh13Un9C0PSjxJ2yXvUTV+ijc+eBQs5hKLVkEF4BBP+1w5QWqJx2BJSRx3qNbr1jBimcAdBvRqPppuuKPMcl0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1659963791746174.14419450032813; Mon, 8 Aug 2022 06:03:11 -0700 (PDT) Received: from localhost ([::1]:39796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oL2PV-0008Pz-GD for importer@patchew.org; Mon, 08 Aug 2022 09:03:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oL2Jr-0007sl-Qs for qemu-devel@nongnu.org; Mon, 08 Aug 2022 08:57:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:56041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oL2Jq-0001gE-9C for qemu-devel@nongnu.org; Mon, 08 Aug 2022 08:57:19 -0400 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-oyvtYfukPw-PJx64uvkTVQ-1; Mon, 08 Aug 2022 08:57:16 -0400 Received: by mail-ed1-f72.google.com with SMTP id m22-20020a056402431600b0043d6a88130aso5548051edc.18 for ; Mon, 08 Aug 2022 05:57:16 -0700 (PDT) Received: from goa-sendmail ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id sd27-20020a170906ce3b00b00722e50dab2csm4964939ejb.109.2022.08.08.05.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 05:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659963437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VUcJSPihr1CxmcurGisfq4kv3QpUdIwCLFpiSeuBEig=; b=WAuCMZwE4osiNUniiZ1MqpTgX37oNPSncdHvSxhzogFItQSLWi+B3L3wTTai2iuEndW7Mc YXa174XN9NX9K+oJL4VDheo3foDeKddLHiwH9A+T3qnfCWTOJllalZ87h7LF1Dfnsh9ssu 9xHTLB5tc5nLjOf1PX5bnKxY0P0Uv1E= X-MC-Unique: oyvtYfukPw-PJx64uvkTVQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=VUcJSPihr1CxmcurGisfq4kv3QpUdIwCLFpiSeuBEig=; b=clod4IC8K4TWdaxYIFUtMrQlzoVaubqiikiVvfGBI3V6SJQK6b3HDJTLWyqhPLPHkF 6llv1PkYgSGAV3tSiZrKphWGI16B+KIvYCaDuz+OCk0eeUyggsOjwaG1htHQZFDgnghj cY+s8irpOYq/emWDQxTV5pZ5cXkcqPdzXPNEm7FFEUo8APL11ntrFlTbZgrnfqofLz2n JVN9vA/zzHPGdsRD45ajrzNa8gdYncjGNv4EbgSjOhZC+zda+GZ4UDFIuLKw1ixPaImo +p5ov/qyKaojAwN+2YYxFfSqInuPvj5Gg97XDvan5en1goNdGEGRQlGwJuZAqjnTUz3J NV/g== X-Gm-Message-State: ACgBeo1m8xc2OtkQgIES+n4bXZH40OerPY9a3CFV4lXxniq+Tzku5kS4 Oqvg3N8s2snmCEzVawHbkBCpnaWCYuSEO9Uova91ogS8cr0ywI9NV/4DSDR1AiQNy6YTwOqfts1 QaSc7LaF6maYsPkDiOb4XJA16hR5KJ/ThX/ayl3MNRM0bzFgvZllimdVOYslR+62NpsY= X-Received: by 2002:a05:6402:15a:b0:431:71b9:86f3 with SMTP id s26-20020a056402015a00b0043171b986f3mr17698378edu.249.1659963435023; Mon, 08 Aug 2022 05:57:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR7tTSyTnaXwLkQ9Pza6P5H5E+1UTr+39Kevo8oDomRp89GOaZeWo0cAqniHWM8uYziXSHyY9g== X-Received: by 2002:a05:6402:15a:b0:431:71b9:86f3 with SMTP id s26-20020a056402015a00b0043171b986f3mr17698358edu.249.1659963434712; Mon, 08 Aug 2022 05:57:14 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Markus Armbruster Subject: [PULL 4/5] vl: remove dead code in parse_memory_options() Date: Mon, 8 Aug 2022 14:57:05 +0200 Message-Id: <20220808125706.60511-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220808125706.60511-1-pbonzini@redhat.com> References: <20220808125706.60511-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659963792171100001 Content-Type: text/plain; charset="utf-8" mem_str will never be an empty string, because qemu_opt_get_size() fails if it encounters one: $ ./qemu-system-x86_64 -m size=3D qemu-system-x86_64: -m size=3D: Parameter size expects a non-negative nu= mber below 2^64 Optional suffix k, M, G, T, P or E means kilo-, mega-, giga-, tera-, pet= a- and exabytes, respectively. Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 45e919de9f..706bd7cff7 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1960,13 +1960,8 @@ static void parse_memory_options(void) prop =3D qdict_new(); =20 if (qemu_opt_get_size(opts, "size", 0) !=3D 0) { - mem_str =3D qemu_opt_get(opts, "size"); - if (!*mem_str) { - error_report("missing 'size' option value"); - exit(EXIT_FAILURE); - } - /* Fix up legacy suffix-less format */ + mem_str =3D qemu_opt_get(opts, "size"); if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) { g_autofree char *mib_str =3D g_strdup_printf("%sM", mem_str); qdict_put_str(prop, "size", mib_str); --=20 2.37.1