From nobody Thu Apr 25 16:37:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1659732953; cv=none; d=zohomail.com; s=zohoarc; b=OgrUPNl26+yjcG/buB6237KOBBoGrnfFJZRs0gsQrAtAh9T4yy726Tc+7aNrIKQ4X4I+W2j97WC6jxMbJiqLkVqjIn10BJDuYNO7a0pp+4187EsiGXqpHAjjx5y3NtCLU3VKy8SiiBL+gYgk7gMjNw1Rbe3c+abp+YuIsfixTgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659732953; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=9/tmLJws/u4CEM/BcYiDQmfD8qI7sQ+R7welU1JTEvk=; b=mSJzbhI2bTKsJuWUvLryZiCudyKFcNgaP+nHADvER7XoJdoYi7d0AC3w3OQoxe83SncW218E6s5v5JoMjQIbHdWjHHX/elKwbE0pu72xJjT9Z3yew5dM+KZQEfkgiSemWDo0Us9pVANy3uyH+/GftKcq69yK0vtM1bPT9llpRG0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1659732953831984.628342940943; Fri, 5 Aug 2022 13:55:53 -0700 (PDT) Received: from localhost ([::1]:40806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK4MJ-0007oB-3g for importer@patchew.org; Fri, 05 Aug 2022 16:55:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK4LF-0006vj-Cz; Fri, 05 Aug 2022 16:54:45 -0400 Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]:42720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oK4LD-0004CI-UX; Fri, 05 Aug 2022 16:54:45 -0400 Received: by mail-ua1-x92f.google.com with SMTP id l7so1463587ual.9; Fri, 05 Aug 2022 13:54:43 -0700 (PDT) Received: from balboa.COMFAST ([191.19.239.67]) by smtp.gmail.com with ESMTPSA id f9-20020ab014c9000000b00384ca77a9e8sm4161129uae.27.2022.08.05.13.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 13:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=9/tmLJws/u4CEM/BcYiDQmfD8qI7sQ+R7welU1JTEvk=; b=ZAioicZvx0dj4dQJb8YJvcttL+Dg5Y02YwOyYkdnsnvbZbFw4xtwuDm1jGc8pXv6bg N5Ohoz0GcNdFhac5HwWwdahcfCyboNaaowTk3CaPTe94ahKdEasojSQGiqkB5nEsUgUo L99+xPGhwv8TDWJ+b0NvM/JtMCuhV7DIcJktL0sEdRQPDLlyu6y7G/rCR8mDWXXqnv1d NYQ+SnfiGfvrZmXgSGxR1mFYKOW7xOkFrAurwA/Fz3VdMoa3wF3LKK2wIPjly1WBmP7a KJxS3qiZKwsAn1v1JKyq8qlbLoknfgBnDZBTDjUthQ//JLmJrpo53lIpF1L4yXkb+0FM xj2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=9/tmLJws/u4CEM/BcYiDQmfD8qI7sQ+R7welU1JTEvk=; b=62TCp7WpF4kuRyjp37EZatJ/0IJX74JXsdylx47ZbJdbEmJd8xhYQpHFdfBTUN6Vm/ 3VkHYHXbnU0FnTnW1f7FEdFpSsNOnvUoo4mGIwI1b9ovZrdAbNblxnV6QLMVSqnf/W+7 qrs292lIb0xn/XqqZrVbss9qHxpjWadXHh44qlVrZAAqh0yB8rMBBQe8hnIjhM5KymYs bsfYcc2M7Za9ggH758vmAfkYd8SN3Aw20thncn7VAPLdTc9r+vQweuIIHfzBSxi6YnBb 2po8+zCbba7UGKjvzVq0PJZ6Y0ORCDDDmUQ1ukgGKpiY4S8d9LeFWmNdZJGQV+JVBF2o FSqA== X-Gm-Message-State: ACgBeo0Ojg786icUu6bTh7idAASFqVeOC+RcIismVRfBAffnwZ6Wp39q 2h6cbyRFlnWXHL8UFD/lHlELHPcsgLM= X-Google-Smtp-Source: AA6agR7L9b5j5KbwF7LsCZC3MDFFipQ11w0PfX4O45wafuUhpr2VFRtCPxrjPpm5Vpstng9T+aITVw== X-Received: by 2002:ab0:7250:0:b0:383:ef47:d9cd with SMTP id d16-20020ab07250000000b00383ef47d9cdmr4139001uap.45.1659732882233; Fri, 05 Aug 2022 13:54:42 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, Daniel Henrique Barboza , BALATON Zoltan Subject: [PATCH] hw/ppc: ppc440_uc: avoid multiply overflow in dcr_write_dma() Date: Fri, 5 Aug 2022 17:54:35 -0300 Message-Id: <20220805205435.139286-1-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::92f; envelope-from=danielhb413@gmail.com; helo=mail-ua1-x92f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1659732956146100001 Content-Type: text/plain; charset="utf-8" Coverity reports a OVERFLOW_BEFORE_WIDEN issue in dcr_write_dma(). When handling the DMA0_CR switch we're doing a multiplication between two integers (count and width), and the product is assigned to an uint64_t (xferlen). The int32 product can be overflow before widened. Fix it by casting the first operand to uint64_t to force the product to be 64 bit. Fixes: Coverity CID 1490852 Fixes: 3c409c1927ef ("ppc440_uc: Basic emulation of PPC440 DMA controller") Cc: BALATON Zoltan Signed-off-by: Daniel Henrique Barboza --- hw/ppc/ppc440_uc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c index 11fdb88c22..31eeffa946 100644 --- a/hw/ppc/ppc440_uc.c +++ b/hw/ppc/ppc440_uc.c @@ -908,7 +908,7 @@ static void dcr_write_dma(void *opaque, int dcrn, uint3= 2_t val) =20 sidx =3D didx =3D 0; width =3D 1 << ((val & DMA0_CR_PW) >> 25); - xferlen =3D count * width; + xferlen =3D (uint64_t)count * width; wlen =3D rlen =3D xferlen; rptr =3D cpu_physical_memory_map(dma->ch[chnl].sa, &rl= en, false); --=20 2.36.1