From nobody Wed Apr 24 09:09:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659720253; cv=none; d=zohomail.com; s=zohoarc; b=ffilPTunb9lUyOSVJYLPz/JwnguBOJ+hRAqL1KQVNPILhpQE84unHMV3Vpc0/WAOiZFC9qjaxh9tXkxpvgg2lb4wjdsFO6Yh40pnddfLjWez+4Z0iUf6koVwAkoTLITmuNyt+3sXDiNTlyn/f/1/4ZrDqrN8tRrqinPpxX3ljfQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659720253; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=1IZcipcr7DtJT/DRpdODj7BqNtwoMoTjmO9xn9/Rf90=; b=jxAKqCws4LC2QZiCG06b3i1N8mVTGD+jWHH21kUwtbYx6TKjm4ga4KDsuG84VC1B7u6Q9uU8bYWDtkNu4sGAFoh6+esosmvZpuf+pmApr0GKZIkrdIQyWnHZxhZt20ETV4YS7Cu1nNQ7wtaDmDSuCp8J0dmZsU0wXEutsS6G5z8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1659720253831706.3047027892472; Fri, 5 Aug 2022 10:24:13 -0700 (PDT) Received: from localhost ([::1]:51152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK13U-0000Ky-Nv for importer@patchew.org; Fri, 05 Aug 2022 13:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK12Z-0007PU-To for qemu-devel@nongnu.org; Fri, 05 Aug 2022 13:23:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK12Y-0003Ae-J3 for qemu-devel@nongnu.org; Fri, 05 Aug 2022 13:23:15 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-MZeRz8OCOYursd12jTzxKQ-1; Fri, 05 Aug 2022 13:23:12 -0400 Received: by mail-ej1-f69.google.com with SMTP id gs35-20020a1709072d2300b00730e14fd76eso1397829ejc.15 for ; Fri, 05 Aug 2022 10:23:12 -0700 (PDT) Received: from goa-sendmail ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.gmail.com with ESMTPSA id p26-20020a17090653da00b0072ffbbc3341sm1738963ejo.204.2022.08.05.10.23.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 10:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659720193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1IZcipcr7DtJT/DRpdODj7BqNtwoMoTjmO9xn9/Rf90=; b=QjggJJC3hB3my08euC9j9h8b0geVmFUI8sXdVC5YLdCuYf4jEom6z0ORgr4n9oLvNqOKKC 139cDr+yLPUAc3nG2vVh2ZDslsa1YJqRlCaYCa/uEvdNdyHqca6kKlhMK5PniRS71wJHsr 77qGGkgIQRi6pcgakpe73z/HZremg2I= X-MC-Unique: MZeRz8OCOYursd12jTzxKQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc; bh=1IZcipcr7DtJT/DRpdODj7BqNtwoMoTjmO9xn9/Rf90=; b=vUSL/NtYg/mbMwxDwFjPhkwLQuHPDkZVnHKF9jt24mo8s1J5l/7GXI+49RwczGNC3S 65+bWLwg4Fpzfb40uX3sDlxp0ZgWd/zw4QE9p2UCte3xP+rrC12EeH67FEq7C1jhe4HM TdZDvGg0l+bm8xWVbxkqWtOCeMqMz+3iRmNGoHA9n6d8TpLnBPmxQ8a+ui7XVzEnMsyV vrgiJDqSmV7fz+nsxngihQjtI9hB20GH6fe34FJPGppDEzqf94Spx1F0mkNv3DqpwJGu 0jiyRdVRvl6/Jga93eMDn/NIJ1Chld0FLdN+N2fNMqDJoF2oRFzau+L72XDC9Khsqf4j 2Jag== X-Gm-Message-State: ACgBeo3rCoc3wIR1bo9tzLzYFKBTJWp0kckvXybwbAmz7NjENmPU8wT4 j9I37iSZ7mggPJmiO+AsMeLWltXhgQiBg51kxzodFPw91iHB4OdcTD182uxURpRSTKTKlCaOqGS JnEld0Of76oVCpQOemXt9/AXEMLLIURg9XLiWatNeI4pmvqvs4GehHuROa389BZXl2x0= X-Received: by 2002:a17:906:93f0:b0:730:6d25:8a1e with SMTP id yl16-20020a17090693f000b007306d258a1emr5931808ejb.431.1659720191289; Fri, 05 Aug 2022 10:23:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR7qtzOV//NDwoDRSK14EPAac/gMu23XAorXWDk9eqLYQCCYk1ECGs21fNrRx6dxD9f4DYXZrw== X-Received: by 2002:a17:906:93f0:b0:730:6d25:8a1e with SMTP id yl16-20020a17090693f000b007306d258a1emr5931798ejb.431.1659720190951; Fri, 05 Aug 2022 10:23:10 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] vl: remove dead code in parse_memory_options() Date: Fri, 5 Aug 2022 19:23:09 +0200 Message-Id: <20220805172309.553441-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659720255375100001 Content-Type: text/plain; charset="utf-8" mem_str will never be an empty string, because qemu_opt_get_size() fails if it encounters one: $ ./qemu-system-x86_64 -m size=3D qemu-system-x86_64: -m size=3D: Parameter size expects a non-negative nu= mber below 2^64 Optional suffix k, M, G, T, P or E means kilo-, mega-, giga-, tera-, pet= a- and exabytes, respectively. Signed-off-by: Paolo Bonzini Reviewed-by: Markus Armbruster --- softmmu/vl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 45e919de9f..706bd7cff7 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1960,13 +1960,8 @@ static void parse_memory_options(void) prop =3D qdict_new(); =20 if (qemu_opt_get_size(opts, "size", 0) !=3D 0) { - mem_str =3D qemu_opt_get(opts, "size"); - if (!*mem_str) { - error_report("missing 'size' option value"); - exit(EXIT_FAILURE); - } - /* Fix up legacy suffix-less format */ + mem_str =3D qemu_opt_get(opts, "size"); if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) { g_autofree char *mib_str =3D g_strdup_printf("%sM", mem_str); qdict_put_str(prop, "size", mib_str); --=20 2.37.1