From nobody Mon Feb 9 23:01:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1659431191; cv=none; d=zohomail.com; s=zohoarc; b=RUSh/wkMPA4JRnDEomcJ5MtMQmA6qrlO8OM3jQi3Wpnqg+5LzkAuJCsckU0JMZxOmPRz/oLmVpe4MeCXhFTy+5vgbP1EWHQUe07ocuGYlecqXtG1NCftIJ7+ggVH7rieWpjxCQquZwdI5V+QWysn4nEvyeRO1RyJmPCYGenMJ6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659431191; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CZOSu2WxQlnASC5gUIGVvb+ISxHsURiBpClYbCZQP4g=; b=HRJGQR9bwi+OD0T251IyQNeGuQOo6txSIYoUaIbKMutmN2AcfVknPEJODPjktpxpRr47WsnSpsYxWoDM82bBMR3tNBEY1iLfoeQESVRWgO9OgeevhZPEdK/rmzLO+fsL/y7qthclAY49AGmtK8h9mwUbaH5Ktv2mcTx+TQ4JWe0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1659431191739419.3098241613941; Tue, 2 Aug 2022 02:06:31 -0700 (PDT) Received: from localhost ([::1]:35090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oInrC-00086t-Ne for importer@patchew.org; Tue, 02 Aug 2022 05:06:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oImfT-0005Of-6L for qemu-devel@nongnu.org; Tue, 02 Aug 2022 03:50:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:60023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oImfP-0007Co-Q1 for qemu-devel@nongnu.org; Tue, 02 Aug 2022 03:50:18 -0400 Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 00:50:13 -0700 Received: from lxy-dell.sh.intel.com ([10.239.48.38]) by orsmga008.jf.intel.com with ESMTP; 02 Aug 2022 00:50:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659426615; x=1690962615; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7NLu5WePphsZ/nK7xHvWAbizNV4GW53sQRPvxgf3CyI=; b=PPItF3GaJmOidKUC2S1Rpx7ECOsad5dD444VjZLeXmXqdU5cao2XJk5g sHWhUU7bqSFSwec+YQbR8ENA1768Ufi5w+nl23OVeyJ4a2krZrhQ9cH9H H9mA+QkBBKGOCLJgXXNutFJ+2U8IHUduC2txadB/CRNY5Dt5YQrP0DIf8 hPWYBUy+WK3FTF8gTYo9Zjz5wiMcE6my1s6CBqp7cdmKhv8E5axfsb080 s2gSBSUvHpaaLvWkjGXX7LAtF/JOMhq/a8EJESgXt3Tl/yoOG6Yf5lpWm tVhOtsIvdMv4wQvM6Vb37MY493JQZrXS2h1jFoZ/venKp/8lBa9ZHhHOh A==; X-IronPort-AV: E=McAfee;i="6400,9594,10426"; a="288105778" X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="288105778" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="630604362" From: Xiaoyao Li To: Paolo Bonzini , Isaku Yamahata , Gerd Hoffmann , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , "Michael S . Tsirkin" , Marcel Apfelbaum , Cornelia Huck , Marcelo Tosatti , Laszlo Ersek , Eric Blake Cc: Connor Kuehl , erdemaktas@google.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, seanjc@google.com, xiaoyao.li@intel.com Subject: [PATCH v1 32/40] i386/tdx: Disable PIC for TDX VMs Date: Tue, 2 Aug 2022 15:47:42 +0800 Message-Id: <20220802074750.2581308-33-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220802074750.2581308-1-xiaoyao.li@intel.com> References: <20220802074750.2581308-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.120; envelope-from=xiaoyao.li@intel.com; helo=mga04.intel.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.998, HK_RANDOM_FROM=0.998, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1659431192613100001 Content-Type: text/plain; charset="utf-8" Legacy PIC (8259) cannot be supported for TDX VMs since TDX module doesn't allow directly interrupt injection. Using posted interrupts for the PIC is not a viable option as the guest BIOS/kernel will not do EOI for PIC IRQs, i.e. will leave the vIRR bit set. Hence disable PIC for TDX VMs and error out if user wants PIC. Signed-off-by: Xiaoyao Li Acked-by: Gerd Hoffmann --- target/i386/kvm/tdx.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 70c56b7ba32c..2f317a6bb55b 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -668,6 +668,13 @@ int tdx_kvm_init(MachineState *ms, Error **errp) return -EINVAL; } =20 + if (x86ms->pic =3D=3D ON_OFF_AUTO_AUTO) { + x86ms->pic =3D ON_OFF_AUTO_OFF; + } else if (x86ms->pic =3D=3D ON_OFF_AUTO_ON) { + error_setg(errp, "TDX VM doesn't support PIC"); + return -EINVAL; + } + if (!tdx_caps) { get_tdx_capabilities(); } --=20 2.27.0