From nobody Thu May 9 01:52:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bytedance.com ARC-Seal: i=1; a=rsa-sha256; t=1659403550; cv=none; d=zohomail.com; s=zohoarc; b=hyXbKNhqgJJVPPPp6M4fmX3g/umLj8jWvsvftxJqqRGA74ZBz3nddqgXVxOD3nTZe/0aT7G6Ar3wnn8Q1MIaV9BMYWsmfU4LSTKaklDJrHvz8mlrEL2Jgz+zXE6whlYfgmDh3UrRh5uJftd4M68Yr4yXBX01X7HUGFa/gTYTA1M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659403550; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dMEwAoov+izqB+yRtqlJs0q2KpV5RgF1bP+51bMfC6I=; b=nMDz0VAirbPbsgwmIJHQOIdGenQTf5LTINKNxs0CC0hPLUW7NMroGp4xcfT4yUNtmh2QoUi/nskMPpHL/yoyfMU6Q1VrDHvYLUsxnXr+CBN4GOMLuExZt7Sz3l8eGGmPk1KWXfZ4LA8savpgmsPgbI//0TLN5PiwyAFq4OU7e6w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1659403550258108.45146302918454; Mon, 1 Aug 2022 18:25:50 -0700 (PDT) Received: from localhost ([::1]:42992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIgfM-0003bg-Rk for importer@patchew.org; Mon, 01 Aug 2022 21:25:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIgcv-0002BD-3D for qemu-devel@nongnu.org; Mon, 01 Aug 2022 21:23:17 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:35620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIgco-00068F-As for qemu-devel@nongnu.org; Mon, 01 Aug 2022 21:23:13 -0400 Received: by mail-pf1-x429.google.com with SMTP id c139so12184552pfc.2 for ; Mon, 01 Aug 2022 18:23:09 -0700 (PDT) Received: from always-x1.bytedance.net ([61.120.150.72]) by smtp.gmail.com with ESMTPSA id r19-20020a63fc53000000b0040d22243295sm8289865pgk.79.2022.08.01.18.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 18:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dMEwAoov+izqB+yRtqlJs0q2KpV5RgF1bP+51bMfC6I=; b=BG+J82KCbXn7ED3HhRnjOlCNfP4KXhzYhJSlTcaWT0l+465+OqWfFa+b5vPap3HiUj dKiUj3yO+Zv4dkNgPpqgdk8t5/xA05bnagM6nOdZUvP261lQBF20I7f5hlgfB9rMsXAP KOYKWaXgKeXylNXVqhBsV+vrjY8Eoe8Rk+6wdHeFtHSDooDiH1Ilx9cUD0BVOhsPF4UO ATR2sHHYmGJQpxQJU164w43GEkAau2jVfJZNf1rp3vMczG6er2uCrItFvP7LY8YcrnK2 LYmGH4u3VdqpZz/DLiBZz/QDzwuLLgUKnvVp2gguVu+tBJi/nXEOzDZz2nm0boxZzUQ2 38Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dMEwAoov+izqB+yRtqlJs0q2KpV5RgF1bP+51bMfC6I=; b=LiNmzC7XKf9abicQJVLCECYpVpg2pPB17HruAw5B/uE7afKmqENIyEFJJdad3aRj+z 0MjR1Fvm+IzeSu1eMaocef8oH9s+mGD+/KpzsRc8CKA15slZckCbLzaBdxFqmNBtyeIY gsog/SAY+Woo1ezm4F9oKXvO/Fqu9HtLxm+eRVaWh8ZlrqUVm+QLp8qVD8OPZFj0WCFw HS4vKIGOF4nbLjulz6aidz0vqLifs3xo1mZbhqZeb4QMQhUnLBhXIl2/rO625q37LJFD GNC4vo1VzPPR4boyG2E+a2SmUmBTib6jciWEDJPsbwQhdG50nbhfbNwtoGwW1MyqHJqH N9JQ== X-Gm-Message-State: AJIora86xMnGbOMjcGJqCDFH1yyMB6mSgnOiicl0/GXwv14QfGlfRs86 Lk0pzyJnF0mKLOGDb1vDFUWIlg== X-Google-Smtp-Source: AGRyM1vlnXBeIk50LT9ja4mnYq2frD+jXZzU4otD+lcYqDYi/TtneqJwPcSeFKzeC5F+MQ3vty42Rw== X-Received: by 2002:a05:6a00:1901:b0:4fa:fa9e:42e6 with SMTP id y1-20020a056a00190100b004fafa9e42e6mr18719533pfi.1.1659403389049; Mon, 01 Aug 2022 18:23:09 -0700 (PDT) From: zhenwei pi To: dgilbert@redhat.com, armbru@redhat.com Cc: qemu-devel@nongnu.org, darren.kenny@oracle.com, zhenwei pi Subject: [PATCH v3 1/1] monitor: Support specified vCPU registers Date: Tue, 2 Aug 2022 09:17:56 +0800 Message-Id: <20220802011756.1227808-2-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220802011756.1227808-1-pizhenwei@bytedance.com> References: <20220802011756.1227808-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=pizhenwei@bytedance.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bytedance-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1659403552521100001 Content-Type: text/plain; charset="utf-8" Originally we have to get all the vCPU registers and parse the specified one. To improve the performance of this usage, allow user specified vCPU id to query registers. Run a VM with 16 vCPU, use bcc tool to track the latency of 'hmp_info_registers': 'info registers -a' uses about 3ms; 'info registers 12' uses about 150us. Cc: Darren Kenny Signed-off-by: zhenwei pi Reviewed-by: Markus Armbruster --- hmp-commands-info.hx | 8 +++++--- monitor/misc.c | 10 ++++++++-- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 188d9ece3b..dee072ac37 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -100,9 +100,11 @@ ERST =20 { .name =3D "registers", - .args_type =3D "cpustate_all:-a", - .params =3D "[-a]", - .help =3D "show the cpu registers (-a: all - show register i= nfo for all cpus)", + .args_type =3D "cpustate_all:-a,vcpu:i?", + .params =3D "[-a|vcpu]", + .help =3D "show the cpu registers (-a: all - show register i= nfo for all cpus;" + " vcpu: specific vCPU to query; show the current CPU= 's registers if" + " no argument is specified)", .cmd =3D hmp_info_registers, }, =20 diff --git a/monitor/misc.c b/monitor/misc.c index 3d2312ba8d..74f7c4ea36 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -307,6 +307,7 @@ int monitor_get_cpu_index(Monitor *mon) static void hmp_info_registers(Monitor *mon, const QDict *qdict) { bool all_cpus =3D qdict_get_try_bool(qdict, "cpustate_all", false); + int vcpu =3D qdict_get_try_int(qdict, "vcpu", -1); CPUState *cs; =20 if (all_cpus) { @@ -315,13 +316,18 @@ static void hmp_info_registers(Monitor *mon, const QD= ict *qdict) cpu_dump_state(cs, NULL, CPU_DUMP_FPU); } } else { - cs =3D mon_get_cpu(mon); + cs =3D vcpu >=3D 0 ? qemu_get_cpu(vcpu) : mon_get_cpu(mon); =20 if (!cs) { - monitor_printf(mon, "No CPU available\n"); + if (vcpu >=3D 0) { + monitor_printf(mon, "\nCPU#%d not available\n", vcpu); + } else { + monitor_printf(mon, "No CPU available\n"); + } return; } =20 + monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); cpu_dump_state(cs, NULL, CPU_DUMP_FPU); } } --=20 2.20.1