From nobody Fri Sep 20 22:14:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659019306; cv=none; d=zohomail.com; s=zohoarc; b=ibdvMEoBQETcPtzuFPB8qzALHfpwNRMn8vJKaeZ1OoDPvYO2CK4+Vtj40LMfJZpFjDoTpgBsNYQEdLRvT02Wssw3lIrbRsJx7jeBHpAvMcRmP3mSK7so3WMdHEBtMrf+sTHMxoY6GnJkH8M2I7P6t0a4S84mPBiTJKEa/R6EaM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659019306; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=fglnNCosP9QgBJWtrBjvGJmWv4b9V9TVGXzTPP4S5WY=; b=gAC7z0AgV4wwYMAe+Jo5H/UotvoZSEmVX2nRSC3NqDWYqsqhCaXdYjtrQryVteN8CeBC8QrgHftMc8U5SKwziwzwckhevny060uw50gXopFSfD+TMVvfsL2OowpXqfp1+1NYTXDbevjKYz40zo0gxBxqlIkKwviCbtsnFJ4whuw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165901930665092.7456584945453; Thu, 28 Jul 2022 07:41:46 -0700 (PDT) Received: from localhost ([::1]:55816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oH4hs-0005JD-Bu for importer@patchew.org; Thu, 28 Jul 2022 10:41:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4Rn-0007EQ-Ev for qemu-devel@nongnu.org; Thu, 28 Jul 2022 10:25:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4Rg-00024c-Mm for qemu-devel@nongnu.org; Thu, 28 Jul 2022 10:25:03 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-248-q5mOU6PBO_aqT1DD5oCukQ-1; Thu, 28 Jul 2022 10:24:57 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7C9941019C8E; Thu, 28 Jul 2022 14:24:56 +0000 (UTC) Received: from gondolin.fritz.box (unknown [10.39.193.162]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C73418EB7; Thu, 28 Jul 2022 14:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659018298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fglnNCosP9QgBJWtrBjvGJmWv4b9V9TVGXzTPP4S5WY=; b=iRrZyL8T/iCE6BNR0g6FHEpOwFKwhV1cMCUEMUcWVrwzhom0f5u+/sLw8oek0ZUtIN0FDc iaZFzcvpWmQ2WLXkEIZ/ZSKD8o/yzTciIIeUySJlOekYwMMm9CNJz5387hWvYhLCSEgYkp kFxtfyj5Vkq5pbNfc49Qjs37YTWhuHo= X-MC-Unique: q5mOU6PBO_aqT1DD5oCukQ-1 From: Cornelia Huck To: Paolo Bonzini , Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Cornelia Huck Subject: [PATCH for-7.1?] kvm: don't use perror() without useful errno Date: Thu, 28 Jul 2022 16:24:46 +0200 Message-Id: <20220728142446.438177-1-cohuck@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659019308520100001 Content-Type: text/plain; charset="utf-8" perror() is designed to append the decoded errno value to a string. This, however, only makes sense if we called something that actually sets errno prior to that. For the callers that check for split irqchip support that is not the case, and we end up with confusing error messages that end in "success". Use error_report() instead. Signed-off-by: Cornelia Huck Reviewed-by: Richard Henderson --- Not sure if that is still 7.1 material; on the one hand, it's a small fix; on the other hand, it has been like that forever... I've kept the Arm-specific message in place, although it might be redundant. --- accel/kvm/kvm-all.c | 2 +- target/arm/kvm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 99aede73b7cb..6955c0b23a22 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2265,7 +2265,7 @@ static void kvm_irqchip_create(KVMState *s) ret =3D kvm_arch_irqchip_create(s); if (ret =3D=3D 0) { if (s->kernel_irqchip_split =3D=3D ON_OFF_AUTO_ON) { - perror("Split IRQ chip mode not supported."); + error_report("Split IRQ chip mode not supported."); exit(1); } else { ret =3D kvm_vm_ioctl(s, KVM_CREATE_IRQCHIP); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 4339e1cd6e08..e5c1bd50d29b 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -959,7 +959,7 @@ void kvm_arch_init_irq_routing(KVMState *s) int kvm_arch_irqchip_create(KVMState *s) { if (kvm_kernel_irqchip_split()) { - perror("-machine kernel_irqchip=3Dsplit is not supported on ARM."); + error_report("-machine kernel_irqchip=3Dsplit is not supported on = ARM."); exit(1); } =20 --=20 2.35.3