From nobody Tue Feb 10 13:01:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659009860; cv=none; d=zohomail.com; s=zohoarc; b=I4wbnL4SeHAApMUfQ8aTPy/yYF88VpPaF1gnD+BBXlBT2ck9kV0PH80bc5xrxo8HIcndjp0JYD1seoFbRIkQTHsZu1RtrqIp2oWWilkYWicuQ2YwEj+VWIVktmpzNKonDUvuRfe+bw+n+gXhnVdoWey/dPaI+2qW+kiNLFn8V1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659009860; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EDNsgNORhf5MUfZCXD5Dgxbpg5HCOhY3hdxecTLw2cA=; b=DqN+yBH8uKXl/kQ4tnmS8pPrrIcqeGB5yiM1CtoVtJ2SI4sJMLwww3LxIzyE6MuoSuJGE8uMxB5XfPth3ti04GjadOTdpfsA/VKB6d1mi0c8yaZcnv8OAIcJJC/RvObpox0xtF7qCwPvwokxBVh+G3g0sAZ7he3rA/0Us78y4A8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1659009860450601.7869574460492; Thu, 28 Jul 2022 05:04:20 -0700 (PDT) Received: from localhost ([::1]:50048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oH2FW-0004O9-W7 for importer@patchew.org; Thu, 28 Jul 2022 08:04:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH2Ba-0001Mi-4v for qemu-devel@nongnu.org; Thu, 28 Jul 2022 08:00:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH2BT-0001ig-Lj for qemu-devel@nongnu.org; Thu, 28 Jul 2022 08:00:11 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-4RCJgOFFMG6ywvFr9K1pwg-1; Thu, 28 Jul 2022 08:00:03 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 092C7185A7A4; Thu, 28 Jul 2022 12:00:03 +0000 (UTC) Received: from secure.mitica (unknown [10.39.192.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DB5D90A11; Thu, 28 Jul 2022 12:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659009606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EDNsgNORhf5MUfZCXD5Dgxbpg5HCOhY3hdxecTLw2cA=; b=ZoJzAsk/ugeuaTepgpiq4ZsFV7U5JsxdEb+YANIi08DxJFVRbAeSgCgsmgiRjONXA9dKCm Y6S04Z7kEZyzgsQt1j/+Tp9JWOTOfY/BPpAdMaNjKF7UIGGAZC1s9gSToBEGNw2SVoH2nC lpGtDNxDby/BrjluKqGpmMF5AbPWtdw= X-MC-Unique: 4RCJgOFFMG6ywvFr9K1pwg-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Juan Quintela , "Dr. David Alan Gilbert" , Eduardo Habkost , Yanan Wang Subject: [PATCH v2 1/6] multifd: Create property multifd-sync-after-each-section Date: Thu, 28 Jul 2022 13:59:52 +0200 Message-Id: <20220728115957.5554-2-quintela@redhat.com> In-Reply-To: <20220728115957.5554-1-quintela@redhat.com> References: <20220728115957.5554-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659009861868100003 Content-Type: text/plain; charset="utf-8" We used to synchronize all channels at the end of each RAM section sent. That is not needed, so preparing to only synchronize once every full round in latests patches. Notice that we initialize the property as true. We will change the default when we introduce the new mechanism. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Rename each-iteration to after-each-section Signed-off-by: Juan Quintela --- migration/migration.h | 6 ++++++ hw/core/machine.c | 1 + migration/migration.c | 11 ++++++++++- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.h b/migration/migration.h index cdad8aceaa..6abd2a51f5 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -373,6 +373,11 @@ struct MigrationState { * This save hostname when out-going migration starts */ char *hostname; + /* + * Synchronize channels after each section is sent. + * We used to do that on the past, but it is suboptimal. + */ + bool multifd_sync_after_each_section; }; =20 void migrate_set_state(int *state, int old_state, int new_state); @@ -415,6 +420,7 @@ int migrate_multifd_channels(void); MultiFDCompression migrate_multifd_compression(void); int migrate_multifd_zlib_level(void); int migrate_multifd_zstd_level(void); +bool migrate_multifd_sync_after_each_section(void); =20 #ifdef CONFIG_LINUX bool migrate_use_zero_copy_send(void); diff --git a/hw/core/machine.c b/hw/core/machine.c index a673302cce..9645a25f8f 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -43,6 +43,7 @@ GlobalProperty hw_compat_7_0[] =3D { { "arm-gicv3-common", "force-8-bit-prio", "on" }, { "nvme-ns", "eui64-default", "on"}, + { "migration", "multifd-sync-after-each-section", "on"}, }; const size_t hw_compat_7_0_len =3D G_N_ELEMENTS(hw_compat_7_0); =20 diff --git a/migration/migration.c b/migration/migration.c index e03f698a3c..ebca4f2d8a 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2592,6 +2592,13 @@ bool migrate_use_multifd(void) return s->enabled_capabilities[MIGRATION_CAPABILITY_MULTIFD]; } =20 +bool migrate_multifd_sync_after_each_section(void) +{ + MigrationState *s =3D migrate_get_current(); + + return s->multifd_sync_after_each_section; +} + bool migrate_pause_before_switchover(void) { MigrationState *s; @@ -4384,7 +4391,9 @@ static Property migration_properties[] =3D { DEFINE_PROP_STRING("tls-creds", MigrationState, parameters.tls_creds), DEFINE_PROP_STRING("tls-hostname", MigrationState, parameters.tls_host= name), DEFINE_PROP_STRING("tls-authz", MigrationState, parameters.tls_authz), - + /* We will change to false when we introduce the new mechanism */ + DEFINE_PROP_BOOL("multifd-sync-after-each-section", MigrationState, + multifd_sync_after_each_section, true), /* Migration capabilities */ DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE), DEFINE_PROP_MIG_CAP("x-rdma-pin-all", MIGRATION_CAPABILITY_RDMA_PIN_AL= L), --=20 2.37.1