From nobody Sat May 18 17:15:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658998027198295.33160843549194; Thu, 28 Jul 2022 01:47:07 -0700 (PDT) Received: from localhost ([::1]:52590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGzAg-0007d0-6F for importer@patchew.org; Thu, 28 Jul 2022 04:47:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGypn-0006l8-6E; Thu, 28 Jul 2022 04:25:32 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGypl-000568-0o; Thu, 28 Jul 2022 04:25:30 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 42EF35C00B1; Thu, 28 Jul 2022 04:25:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Jul 2022 04:25:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Jul 2022 04:25:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1658996727; x= 1659083127; bh=cNoN8LNT9AHPwJ3o1o7zjURXDf9IvCRTtK/qRAs5ixg=; b=D UHyLrViIY0DDzzvwl6UVDUa3rC6GD9avBXDF8YyuYIxOh5CykCJbkbHUnNoro9+A usXSuxULDSg5TN/8tS1IRAfW2/vogcvYsqe813JHVk2sIKgeG1embzx8hs6Q5GHx zuI8zvnW9SLFgXCERIlRO99LGtpW6NQV6h+wVm9V8mHccPBkODo4KLSoakHnL5ht vslfxl+oERn800urCMdEee7hZSOl40wzofpYkjwRyB9DAlj+poh0o/snie3CsTWf xeae572Ig+2o5YDZRLTou0kpYD9bkM0tNsfFTAOaGsnTD7Qcsm8AX3eu0G10fgvA c4DR/6nnK/H12/flblmpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658996727; x=1659083127; bh=cNoN8LNT9AHPw J3o1o7zjURXDf9IvCRTtK/qRAs5ixg=; b=ujVAilo1sTX9FYt2sR2Y3xnsGkLTI tU43j8I+W2imLfL7J0zXALYoDh2r7xzKVdyQAE8aKKZCjVvlBALGPRTKB2wv6xLZ UlPANcdorvJjmOH3A+ZNbMSSzaDetA4lyctp9uT8vI5RJXQd9VRQ8qvLkH0VAt/q yme31WhyMiranTYe/hAc3Fx6GgDVZEtiHEoo07aR5XgwkorA4+ybbkJlB6o8l4BM xZDe0x2VDzio3Oxb1YgGLx3qhUvQ2u17NSidGKOe4rM+SgmuO7LGeZojBymmj8sY upKRvxhb74AgY9F75r28y5sXPUoQShPVkwD6kMXiClwAtXdjxNj2N1ayQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddufedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgr uhhsucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrg htthgvrhhnpeejgfeilefgieevheekueevheehkeefveegiefgheefgfejjeehffefgedu jedugeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail From: Klaus Jensen To: qemu-devel@nongnu.org Cc: Klaus Jensen , Keith Busch , qemu-block@nongnu.org, Jinhao Fan , Klaus Jensen Subject: [PATCH for-7.1 1/3] hw/nvme: skip queue processing if notifier is cleared Date: Thu, 28 Jul 2022 10:25:20 +0200 Message-Id: <20220728082522.3161739-2-its@irrelevant.dk> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220728082522.3161739-1-its@irrelevant.dk> References: <20220728082522.3161739-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.26; envelope-from=its@irrelevant.dk; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1658998027781100003 Content-Type: text/plain; charset="utf-8" From: Klaus Jensen While it is safe to process the queues when they are empty, skip it if the event notifier callback was invoked spuriously. Signed-off-by: Klaus Jensen Reviewed-by: Jinhao Fan Reviewed-by: Keith Busch --- hw/nvme/ctrl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 533ad14e7a61..8aa73b048d51 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4238,7 +4238,9 @@ static void nvme_cq_notifier(EventNotifier *e) NvmeCQueue *cq =3D container_of(e, NvmeCQueue, notifier); NvmeCtrl *n =3D cq->ctrl; =20 - event_notifier_test_and_clear(&cq->notifier); + if (!event_notifier_test_and_clear(e)) { + return; + } =20 nvme_update_cq_head(cq); =20 @@ -4275,7 +4277,9 @@ static void nvme_sq_notifier(EventNotifier *e) { NvmeSQueue *sq =3D container_of(e, NvmeSQueue, notifier); =20 - event_notifier_test_and_clear(&sq->notifier); + if (!event_notifier_test_and_clear(e)) { + return; + } =20 nvme_process_sq(sq); } --=20 2.36.1 From nobody Sat May 18 17:15:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658997899084869.4640766461529; Thu, 28 Jul 2022 01:44:59 -0700 (PDT) Received: from localhost ([::1]:51906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGz8b-00078Y-2r for importer@patchew.org; Thu, 28 Jul 2022 04:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGypo-0006lG-GI; Thu, 28 Jul 2022 04:25:32 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGypl-00056K-NN; Thu, 28 Jul 2022 04:25:32 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8E9025C012E; Thu, 28 Jul 2022 04:25:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Jul 2022 04:25:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Jul 2022 04:25:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1658996728; x= 1659083128; bh=nYqfJ7+crZM6z3I641lq7GZ6e+yrbv2WVMTmsY1y7FY=; b=a LVO3FmIZDF9PG6thJoAnd5R7ISaT5Psax2UNHXSXJNTps/geZLpzdTWeA/VfvDQL Dt6+nc6GnQijWL612+kF5udtvYlATSOJz6lQt0WsKHj4TpBpE7rgrcyI0vExkc3P glRb8I6ng09TbW+sq6w90CgzcxPHnD9qXAxjxgdKTLPMb3vZ6eItYMSeQCVcmdZj rkQECFnYLqcUcQ1W9M6nmSgza/yKArtJdwklO4MU3ONBtnA0xncvpbDX5XDRx1l4 x2vuZbwHVx15MYT+JkFTyn6qP1YA67jc+1V/nUcy2qJEI3s9rMx0JkLHF7T8g7VM xEcOwGpGA5/r9gOfxxfsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658996728; x=1659083128; bh=nYqfJ7+crZM6z 3I641lq7GZ6e+yrbv2WVMTmsY1y7FY=; b=22tUAkJTSTSET+sSQ3DHu3v6l52Qk P4bK2xSxbJMHad2+HmKdWJqnI4VqJrlhuzRA5WCDdL9+TbSZjZwudnJZgAHnNOgw kKeiVbMW5tmdvHNawfY8gDqCP/jaFq7jMJsxwsur8EXgreDAccnMKKcS/m0rChfD wo2Ew3ZUf6QkCttjxap7EwYcIoxDO6G1aZrfHSAzfb9jLH0134PllN9qqhhhKP1M /1A1qemylVAIfhtk51hUWVNV7Z7tlKs/Wc+3niRaRQJsDemAFq8N7d6S70BOPPq8 6mBHMlFUsa3NIWvFZV1UzSywrqv/WRpnzir5li069lzM/5AovVFgo+4PA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddufedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgr uhhsucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrg htthgvrhhnpeejgfeilefgieevheekueevheehkeefveegiefgheefgfejjeehffefgedu jedugeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail From: Klaus Jensen To: qemu-devel@nongnu.org Cc: Klaus Jensen , Keith Busch , qemu-block@nongnu.org, Jinhao Fan , Klaus Jensen Subject: [PATCH for-7.1 2/3] hw/nvme: unregister the event notifier handler on the main loop Date: Thu, 28 Jul 2022 10:25:21 +0200 Message-Id: <20220728082522.3161739-3-its@irrelevant.dk> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220728082522.3161739-1-its@irrelevant.dk> References: <20220728082522.3161739-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.26; envelope-from=its@irrelevant.dk; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1658997900821100003 Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Make sure the notifier handler is unregistered in the main loop prior to cleaning it up. Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") Signed-off-by: Klaus Jensen Reviewed-by: Jinhao Fan Reviewed-by: Keith Busch --- hw/nvme/ctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 8aa73b048d51..70b454eedbd8 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4311,6 +4311,7 @@ static void nvme_free_sq(NvmeSQueue *sq, NvmeCtrl *n) if (sq->ioeventfd_enabled) { memory_region_del_eventfd(&n->iomem, 0x1000 + offset, 4, false, 0, &sq->notif= ier); + event_notifier_set_handler(&sq->notifier, NULL); event_notifier_cleanup(&sq->notifier); } g_free(sq->io_req); @@ -4701,6 +4702,7 @@ static void nvme_free_cq(NvmeCQueue *cq, NvmeCtrl *n) if (cq->ioeventfd_enabled) { memory_region_del_eventfd(&n->iomem, 0x1000 + offset, 4, false, 0, &cq->notif= ier); + event_notifier_set_handler(&cq->notifier, NULL); event_notifier_cleanup(&cq->notifier); } if (msix_enabled(&n->parent_obj)) { --=20 2.36.1 From nobody Sat May 18 17:15:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658998793321357.4451400437539; Thu, 28 Jul 2022 01:59:53 -0700 (PDT) Received: from localhost ([::1]:60428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGzN1-00058w-CX for importer@patchew.org; Thu, 28 Jul 2022 04:59:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGypp-0006lx-LE; Thu, 28 Jul 2022 04:25:33 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGypm-00056T-NC; Thu, 28 Jul 2022 04:25:32 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EF2225C0101; Thu, 28 Jul 2022 04:25:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Jul 2022 04:25:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Jul 2022 04:25:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1658996729; x= 1659083129; bh=KTzK8E5gzeTlKbKFz6fyG0Vav/HosNd9Ec7IsCZgxHw=; b=w pAJEa/1ercIEV2dfUqfkwEzX+aRskkwRyoFEUw+hisUAtWsl45jwvyjRGLtK0oOC JupB7Tj5XfWtnjc/C+2WE/k3TmULPSak16esjva2u7YmAzxf/M9G1w29EM1Aoue8 sXFZZRwxefMB01vWB26SjDKOSKnmAlHaQc05mNvwWhw1hFG2Yql83NZEHaUgWvzI vPR8m0HfPWZ3LRU//2fLy7c90xf1pwy8Ti/lpB53buWkTKZMltrfETXzbDp8Oi0s lIAs1dLkDYjP8Bb7CUzFSN9R1J/0oB+NrpvtKEXLmAXsnN7YoZVcw3nKygNUO2fj 5G7ps9peHtSwakFGgTgGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658996729; x=1659083129; bh=KTzK8E5gzeTlK bKFz6fyG0Vav/HosNd9Ec7IsCZgxHw=; b=043tpLARxdTVBknr25lmuw4wNJ5LZ ANSGXqTWz9MlzkoDMoXIZD+hdJFYqTrCbIr9Xm86rbnkOUYqU0RIrbe5heJAY+uF 6F+Sq9Me2We7i9ARccV4NPsDuAyAjGIwsydOM0cnOLeWtXgFglw31fJv81BgWGWe KuyS4bpJd2UNlnadh6jor/xvwC5qEG6VgQKuDxknrzcwlGCYHpTrV9G+ytjDOrrR 5VuKMZH3Qep9+bOqCpFylh0mKUy5yQp29HEMNx9G7kLcQlcJNqdh91YRFz+h4Uvd KIqexVjeFYUNEubedD3ewLPWdQ8+OJDm1jPpofkAvC6rqN3SRwb9ND/YQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddufedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgr uhhsucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrg htthgvrhhnpeejgfeilefgieevheekueevheehkeefveegiefgheefgfejjeehffefgedu jedugeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail From: Klaus Jensen To: qemu-devel@nongnu.org Cc: Klaus Jensen , Keith Busch , qemu-block@nongnu.org, Jinhao Fan , Klaus Jensen Subject: [PATCH for-7.1 3/3] hw/nvme: do not enable ioeventfd by default Date: Thu, 28 Jul 2022 10:25:22 +0200 Message-Id: <20220728082522.3161739-4-its@irrelevant.dk> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220728082522.3161739-1-its@irrelevant.dk> References: <20220728082522.3161739-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.26; envelope-from=its@irrelevant.dk; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1658998795387100001 Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Do not enable ioeventfd by default. Let the feature mature a bit before we consider enabling it by default. Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") Signed-off-by: Klaus Jensen Reviewed-by: Jinhao Fan Reviewed-by: Keith Busch --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 70b454eedbd8..87aeba056499 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -7670,7 +7670,7 @@ static Property nvme_props[] =3D { DEFINE_PROP_UINT8("vsl", NvmeCtrl, params.vsl, 7), DEFINE_PROP_BOOL("use-intel-id", NvmeCtrl, params.use_intel_id, false), DEFINE_PROP_BOOL("legacy-cmb", NvmeCtrl, params.legacy_cmb, false), - DEFINE_PROP_BOOL("ioeventfd", NvmeCtrl, params.ioeventfd, true), + DEFINE_PROP_BOOL("ioeventfd", NvmeCtrl, params.ioeventfd, false), DEFINE_PROP_UINT8("zoned.zasl", NvmeCtrl, params.zasl, 0), DEFINE_PROP_BOOL("zoned.auto_transition", NvmeCtrl, params.auto_transition_zones, true), --=20 2.36.1