From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849003; cv=none; d=zohomail.com; s=zohoarc; b=lXQg9E8Da8DvmwwiWycjeW3gA/dfpMVEfQ4UZLmlJY7mu8AqGnWo0G+ZEVP1Qa/2yCFEJXWvcKLF5u0egJV9JWRUfUdnpGvqyuPlEcd6eTkQO1Lx9R/ZDdvZ4yxstMtg+Xgono1cInIEtlofzifa/HLZDH4Aa+d6lavoj6uyZaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849003; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MAULpYRElXb/JnZHgFpotDF/VeeWBZVTrWblujY9hI4=; b=Vt4opgyfg8iqQJuawh8AFXOe2L7YMtGD2dVzwV6r9OtdD/GtFrLix3UXqpOPVlSusF7ozUsVuD4HCQQ+Y2kxjXZMyABdposi/KhjOy+1rBPDaWLbrOsIO3eHxsZU7zEsKriJSNKHLWMMXpWOnLiCX1eBmawzFwwuqrpVVTD8I4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849003067855.2333999439273; Tue, 26 Jul 2022 08:23:23 -0700 (PDT) Received: from localhost ([::1]:38932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMP2-0000j1-AM for importer@patchew.org; Tue, 26 Jul 2022 11:23:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMB-0006Nf-2v for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:23 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:44859) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMM6-00062e-DR for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:20 -0400 Received: by mail-wm1-x332.google.com with SMTP id b21-20020a05600c4e1500b003a32bc8612fso8356982wmq.3 for ; Tue, 26 Jul 2022 08:20:17 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=MAULpYRElXb/JnZHgFpotDF/VeeWBZVTrWblujY9hI4=; b=GoGfcSZoxmH6tRjVbHuGdyzDkyLC7pfEo7cjdC0k86XdSXoRDOCvp4PLJ8BKRvHoZw v8rmY76TuW5hFNHkooLXzJIljNDDohx8bNM0v90PdZzLNVxDskRcNBm6f+hpJkU2zS2P EXCVTxneGqQazaoceWJGfmTNsTKps3YNSWq0CSXxFVW1uvPscOyuJlr/l4D4CekALQwe smys15L8Kum9/9qLFeYxgsDJZfKKy+pWzyQyjLYxuuox16Q6010JBWIi8GTCMN0T0M5p XtkrUHNyVyxeKXpOYpvi2GWS+gXJ4OexH68Fbbw9MrnjozYmTUQ4ogWDe3ZeFjTdDqgW gu2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MAULpYRElXb/JnZHgFpotDF/VeeWBZVTrWblujY9hI4=; b=YdfEZ1fUtK1IWo5uK7gBouXrdWt0qthiVlVfkFcWBZptm9EliRRxgCGIsp7Xl/EQQS GJMaX+MPYw4HuNabQaX021XsEIiBSIUiWDKh3uokDJ/yieG2sIDujK25TaZ3tQhereJj MZSnpBV+T9ZBi9UoeFlWJf/Oa/KVabQOWxDNSJGXDuBq0Lpksvdidz2nY0vpx4Mm7lr5 k0+XwPF1CSYEBYEyjh54IFJO94JeYVDk4wrE4HoAqiZSFuO1VYsZ9KzIXW9C/usPycko ZHEsbfTrhKYiJNnbZgcn2bw6AJINC0UWKee5dodxGCPjv0jmKEue/LikzoBBWV2YC02E 2Odw== X-Gm-Message-State: AJIora/exv5SLLkbjzMjmWNPFUZZlF+4ggGiAhKYMW0mqejWt1UazNKn DpB4B2b/zDTwCgrjJZ8Dmf5RtcRn8jPV4Q== X-Google-Smtp-Source: AGRyM1vrRET8dUYRSJ0uNHCTgr/ecwbgK9b+6ShaSp5pmEkErD2dE7XKeSHhLdKt8L9ARaQWHGM6Ig== X-Received: by 2002:a05:600c:a03:b0:39e:4f0c:938c with SMTP id z3-20020a05600c0a0300b0039e4f0c938cmr12290904wmp.145.1658848816399; Tue, 26 Jul 2022 08:20:16 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 1/9] scripts/coverity-scan/COMPONENTS.md: Add loongarch component Date: Tue, 26 Jul 2022 16:20:04 +0100 Message-Id: <20220726152012.1631158-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849005454100001 Content-Type: text/plain; charset="utf-8" Add the component regex for the new loongarch target. Signed-off-by: Peter Maydell Acked-by: Paolo Bonzini Message-id: 20220718142310.16013-2-peter.maydell@linaro.org --- scripts/coverity-scan/COMPONENTS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/CO= MPONENTS.md index de2eb962416..a61d011d9a4 100644 --- a/scripts/coverity-scan/COMPONENTS.md +++ b/scripts/coverity-scan/COMPONENTS.md @@ -143,3 +143,6 @@ testlibs =20 tests ~ (/qemu)?(/tests/.*) + +loongarch + ~ (/qemu)?((/include)?/hw/(loongarch/.*|.*/loongarch.*)|/target/loongarc= h/.*) --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849212; cv=none; d=zohomail.com; s=zohoarc; b=GeqlwPE4jdNLmKhXP6gCwclfyTv4YkouUnEeCI6uIPLMc1AyOKzuZ1+pJgNkyL3kLC2TP3nKInwfrkNipcO44lCjKdnbHq8UeMRiHZ2M2wI0c6vYVFsZcR4gaktXrYj2dz1bEg436jpQpO3NrIDeq0tG3a4KLNFPPu77+jDSed8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849212; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ey2A/ataBvQCviganlANpFwD3PZb1j/1pS05PcMDR9A=; b=fLVRYuecoQHFeClsyI4VApq2YL5CK6u+7yuTToxJhcDlQxRYc1wmd5NZhRQElwpMVEl/Y3oMA4PpFPfSgREg+pcOZwdDNv4vauwo78B3KZ7V/83aimvdDXWYmIB6ysnTrjnFvlJFWd/C2xVpkJgmyHzegUGl9mSKLaBR60AeRMI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849212811913.6439385665074; Tue, 26 Jul 2022 08:26:52 -0700 (PDT) Received: from localhost ([::1]:47290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMSR-0006Oj-Kc for importer@patchew.org; Tue, 26 Jul 2022 11:26:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMD-0006Nv-Dw for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:25 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:33489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMM7-00062i-3B for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:23 -0400 Received: by mail-wm1-x336.google.com with SMTP id a18-20020a05600c349200b003a30de68697so1149631wmq.0 for ; Tue, 26 Jul 2022 08:20:18 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Ey2A/ataBvQCviganlANpFwD3PZb1j/1pS05PcMDR9A=; b=oGYB/00/qxQ+aB5ZIL7hPc1MkryipGMmfiKR2ErMGJLSCj+s9nq/X6NGlPFBBew8hs kCvMAmA3oy8hFsLMWxC60ypvXeY5HnUdHt8KL7jNHwF2yeNu5S1AiOsSPhi0TlKNYfyq bGrGAI5AWsctMa9AfpQSpz5PX9II8GM4FKQFQCmLIsQESVsJhWSjxfih5Ys8Qz6T+yNp RNDWfC9Ed3Jbg2iPGztGlPOHvnj6UirXDnE2XzWjaQjTqZumBbUrKbz7ul09lKXzvmec J4p2PetrfJo3IhTYAPwz3OTKrIZCNPjgPoXq6QX/AE/yRKoKj08469TacJpXwqvg0e0I TrAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ey2A/ataBvQCviganlANpFwD3PZb1j/1pS05PcMDR9A=; b=mbVI9TT0qXvklL0DthSzgH1az+bWQOG9u5G/Tr+z7c1ePqXQwss/k7oNneJCEMT7QP ICnz4PS/Qz/p3Om/jd5EaGgGo0meIaPNXUTCIQm6WM/i4BlMOYyMbIkouhWCe+zsRX+Q Sg17FcOorHqwne4WnB7PErnvfTfvLgi0Yw/vTSB0AG+lmOebjWnz6XRSH16moF2V2V6x m0YkeD4jX4adwcq2yVlCQXQI1mbk8B3R+njBm4IQS0w6n8MZKFGFPwEn0llYB+ybLtLN idz1AhhdGVvilD2ygNr7Rji8un9SGbCRkrcB3HFPofbCglRkwM6HmAT1rPcymKzk3Adb KsCQ== X-Gm-Message-State: AJIora+1QrtRxDQxQH6syVcv3ixIslp8LrVgnCHL212UJivPiHYbwbT7 h2zgSIdRpTFyJK5kUTEQ5WPkISa5R5aLcA== X-Google-Smtp-Source: AGRyM1tPElYMbwBsJ8ZGLg0iuS6IEHBXyAfMunMAbXO8ozhkZsjGtT0JwaF3AdVt5/eF7cdAD4kjog== X-Received: by 2002:a1c:3541:0:b0:3a2:e2e2:d80e with SMTP id c62-20020a1c3541000000b003a2e2e2d80emr12672473wma.184.1658848817427; Tue, 26 Jul 2022 08:20:17 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/9] scripts/coverity-scan/COMPONENTS.md: Update slirp component info Date: Tue, 26 Jul 2022 16:20:05 +0100 Message-Id: <20220726152012.1631158-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849213135100001 Content-Type: text/plain; charset="utf-8" Update the regex for the slirp component now that it lives solely inside /slirp/, and note that it should be ignored in Coverity analysis (because it's a separate upstream project now, and they run Coverity on it themselves). Signed-off-by: Peter Maydell Acked-by: Paolo Bonzini Message-id: 20220718142310.16013-3-peter.maydell@linaro.org --- scripts/coverity-scan/COMPONENTS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/CO= MPONENTS.md index a61d011d9a4..3aad9cdfaf4 100644 --- a/scripts/coverity-scan/COMPONENTS.md +++ b/scripts/coverity-scan/COMPONENTS.md @@ -108,8 +108,8 @@ qemu-ga scsi ~ (/qemu)?(/scsi/.*|/hw/scsi/.*|/include/hw/scsi/.*) =20 -slirp - ~ (/qemu)?(/.*slirp.*) +slirp (component should be ignored in analysis) + ~ (/qemu)?(/slirp/.*) =20 tcg ~ (/qemu)?(/accel/tcg/.*|/replay/.*|/(.*/)?softmmu.*) --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849077; cv=none; d=zohomail.com; s=zohoarc; b=e806kk6LQDLYNzDnqNigPlGDjKGXeWSDIU/oWjmOzf+m5wxEAkcUwxbLmAlRup8+BDUUQ+LuRaMKXxfz+wQg4qzeQJaIkU1qequfVCNuFqdIrM+nsYS4klcMcyuS2585FPgQqw8hT6oPx7nVUYLhrAtT9JhfQA2A0uvrX4Xz7Hs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849077; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7vIR8LJZ8u7IRlc0GXx+4QrCXzRdLBy6u8yi1hPp0UE=; b=Xz39hmetQwPZq7r+HHxseYoTBu+Afz2F8Ue9LGh3PNlc/zok0ctPyXBsl3kzj2nvMdCcYjrTK7w2JeQQhUPG6fYxLX80qmARTQHRz3EhL3ingX0Kas82at2PZhJodAn2vhsLmaSaEvFPVkl5OF0bdmOX2HkdkFCXskjX2kl+US4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849077346779.182217034674; Tue, 26 Jul 2022 08:24:37 -0700 (PDT) Received: from localhost ([::1]:42074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMQG-0002pu-5m for importer@patchew.org; Tue, 26 Jul 2022 11:24:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMD-0006Ny-Fb for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:25 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:42686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMA-00062o-M7 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:25 -0400 Received: by mail-wm1-x334.google.com with SMTP id 8-20020a05600c024800b003a2fe343db1so8366862wmj.1 for ; Tue, 26 Jul 2022 08:20:19 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=7vIR8LJZ8u7IRlc0GXx+4QrCXzRdLBy6u8yi1hPp0UE=; b=MHm2Y9BGb19f84rVZb2skA/p8PswnjpAKEcDm/HX3MphLgTjxwtr3Z6rKpbTrZBjOw ez3wTBKUYBw2V55USDgxApOBj9CoC3yzH2iEBN5GgN+ZDCFvq4SsM0PoHwho5KWjShCj S2ek+Qp0H4zmLB4MAI83R9lMu8Ou8JeRQ3K2PIO1Wz+D1ckPHSUI25RwI4FFe5BNRQ2W oTkVZAHvjnecN20wlVy7Rn+zdWJ3m4Yc16KsTb3tbndXoLg9GRuzXCJ+pVDc52R+6iRo eAxtq5THi7gWBwqcrNZ//MHxCfcIuZjzwe11SYzLcrdGdKBGzqNhtoAdP7JWOvVkoAXi docA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7vIR8LJZ8u7IRlc0GXx+4QrCXzRdLBy6u8yi1hPp0UE=; b=S971ALgK/6BPzDuPrPsf8G7ZkKMnX+/l2l442cStq4aM8burI9TNln3X0usUzgvamQ QIwjA01QSKV2u4OcJHi4ELgn6V1V3G+IN3IWoNtRo5kZSuyKwLtbM3XHAkWc8j2QM6A7 Is0bSVONUPn+lfcXbIGYqBcE9CYPUpGoX2JtL2yJT1h6vLpkiLpJe8kkuf+HedZ48TSW 9jsv/Q8Crwx+qXX5xdcRAjG9FHaLtXdK4nV8r+MgzVuyPiaoeFCgxoGEyb47SFXiRMAs /VuG46MJnH1nx8fZCan+uk3yAwiMYQRli4QlrtJuqJfE9BLtpJQ4n9FIvhOQn2d6fZJh +9Og== X-Gm-Message-State: AJIora8BbZIlDtVmPpoyqBIDkvaWVaUKPxOiwZbYFjQRawUNqGOuKlPR 6OakzkY1R/+Rvb+40ZUdpATE1jLzxq3/Jw== X-Google-Smtp-Source: AGRyM1ugZn7CyZsRutXAk8ekjSJg0bUm9sKeD+JoABvIKaKkdm3aDH7/3//BfreIBhXPwHSpNXUjnQ== X-Received: by 2002:a05:600c:154a:b0:3a3:2fae:9bae with SMTP id f10-20020a05600c154a00b003a32fae9baemr13072029wmg.23.1658848818355; Tue, 26 Jul 2022 08:20:18 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 3/9] target/arm: Add MO_128 entry to pred_esz_masks[] Date: Tue, 26 Jul 2022 16:20:06 +0100 Message-Id: <20220726152012.1631158-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849079453100001 Content-Type: text/plain; charset="utf-8" In commit 7390e0e9ab8475, we added support for SME loads and stores. Unlike SVE loads and stores, these include handling of 128-bit elements. The SME load/store functions call down into the existing sve_cont_ldst_elements() function, which uses the element size MO_* value as an index into the pred_esz_masks[] array. Because this code path now has to handle MO_128, we need to add an extra element to the array. This bug was spotted by Coverity because it meant we were reading off the end of the array. Resolves: Coverity CID 1490539, 1490541, 1490543, 1490544, 1490545, 1490546, 1490548, 1490549, 1490550, 1490551, 1490555, 1490557, 1490558, 1490560, 1490561, 1490563 Fixes: 7390e0e9ab8475 ("target/arm: Implement SME LD1, ST1") Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20220718100144.3248052-1-peter.maydell@linaro.org --- target/arm/cpu.h | 2 +- target/arm/translate-sve.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index e890ee074d3..5168e3d837e 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -3387,7 +3387,7 @@ static inline uint64_t *aa64_vfp_qreg(CPUARMState *en= v, unsigned regno) } =20 /* Shared between translate-sve.c and sve_helper.c. */ -extern const uint64_t pred_esz_masks[4]; +extern const uint64_t pred_esz_masks[5]; =20 /* Helper for the macros below, validating the argument type. */ static inline MemTxAttrs *typecheck_memtxattrs(MemTxAttrs *x) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 41f8b12259e..621a2abb22f 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -529,9 +529,10 @@ static void do_predtest(DisasContext *s, int dofs, int= gofs, int words) } =20 /* For each element size, the bits within a predicate word that are active= . */ -const uint64_t pred_esz_masks[4] =3D { +const uint64_t pred_esz_masks[5] =3D { 0xffffffffffffffffull, 0x5555555555555555ull, - 0x1111111111111111ull, 0x0101010101010101ull + 0x1111111111111111ull, 0x0101010101010101ull, + 0x0001000100010001ull, }; =20 static bool trans_INVALID(DisasContext *s, arg_INVALID *a) --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849575; cv=none; d=zohomail.com; s=zohoarc; b=ZK3yXPqjcZRD+3vjejqDmy0A3HLT1pocD8+Gd2GfqB3rGvGGfiQ1Era9zEcMELzo1QlkqiXt8XUKA/zrlWp7dnqshlGtulkqd4sSHEf59X6c1Li7sLCusXAIdrYqmku2k/p5VQQYKCoirlPm/egKvtXN/Nm4oo1JyyK1Dk2z3R8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849575; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=N6+ztaKWxKiaj7O7Q3eQxFwJtwwHvO1y0ZcflvRK1lM=; b=L3jeylo0p93HpS+OqYilt8iDOyeXNaCcBCDjUs6c0Hb+P01VNdUXz+0cCjvRWgTpCrbGr9EEWoCG5ITKt8VObizcrFKGc7cgTT9aortZX0czXxdo9OPfwEFycMJYjqsmx4d+2EwvtSuO8jd13FJJeChqrkMrNIzHDIfa+X49i08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849575053986.6963779166832; Tue, 26 Jul 2022 08:32:55 -0700 (PDT) Received: from localhost ([::1]:59434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMYH-0006Su-IC for importer@patchew.org; Tue, 26 Jul 2022 11:32:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMG-0006RZ-L2 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:33603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMA-00062z-MI for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: by mail-wr1-x42d.google.com with SMTP id h9so20667852wrm.0 for ; Tue, 26 Jul 2022 08:20:20 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=N6+ztaKWxKiaj7O7Q3eQxFwJtwwHvO1y0ZcflvRK1lM=; b=wNrUUwAse46VXkuSJN8mYTkeBG1xIHOQRiFbJagq9lof6c6db7UFjYGKpqdsiWq+lx jkq3rOW4M4jp5byJHbVouS1dbsqNO0eO+l39gVFaJ+Lr2F6b6whf5bblw2J0keFftOY7 L3EAdnxiK1H6aKRcCSkiFAc+FYJmDRZAO8o8KnoVh3hmrYMRBuAoCMAHq2HkQQXg+7V7 xYPmCbWlrRecp0+Lr1o+F1rLoNO8cLAPXfI//vubctRs80DMyVljOsv4/w/ERtyH/A1D uteu6p5r0Io39EgKMsyqOC2QoNm+4OjZqFCTM+lJ8Z5TPPgQ3MBIMtXK8CQtDO01OFod SQ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N6+ztaKWxKiaj7O7Q3eQxFwJtwwHvO1y0ZcflvRK1lM=; b=NKzT3ivQ/hHsMfpHA1WdE0xRJTyyn8Yy01FV4eIWW8sipAuIeYe9U1MAX3Xik2o6SF dPpw/uD3a48/Dd9SmVEgB0jtZNpkSfSx1k0v+rVo8EtpnDyCposr81A1SeeSTeH9u5pi 33rF+/eztuC+C/YLeh2iBCPjFbuZhhWrEbvpWNregeMJls1H/LwnT34U2ouok4//A+Wc QX/LUTq78YY9hPeOu0pEP7laD1He9osR+koXpyM2A56wMIR3uBGcn45ASAezBNpiVbwG XuCEvxPbaEr2zb3x/FQdnfGz3tDr5++UnhwA2zcQqNLFaoZWSoDF8ghnfzYsRU9qfefM YAPA== X-Gm-Message-State: AJIora844a6s8J61UElFsbNUIKzSan5XTdjeSibtP6QztPz82UFCRMi0 G3Us5eN1WiPT2XcHWa8jNAMa53M5rzo2wA== X-Google-Smtp-Source: AGRyM1ujMiGHh9zZ9cLExqYTeRCPz7/wrB/ggC4YrYqHtFMbA0KMJ/W5kW9UqzjEXk9nXCNel0GpVA== X-Received: by 2002:adf:d1ef:0:b0:21d:983f:4b8e with SMTP id g15-20020adfd1ef000000b0021d983f4b8emr11595443wrd.334.1658848819277; Tue, 26 Jul 2022 08:20:19 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/9] configure: Add missing POSIX-required space Date: Tue, 26 Jul 2022 16:20:07 +0100 Message-Id: <20220726152012.1631158-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849577554100001 Content-Type: text/plain; charset="utf-8" In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT=3D"$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_= action" "$git_submodules"); then ^-- SC1035: You are missing a required space after the !. and the OpenBSD shell will not correctly handle this without the space. Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update wi= th --with-git-submodules") Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Tested-by: Dr. David Alan Gilbert Message-id: 20220720152631.450903-2-peter.maydell@linaro.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 35e0b281985..dec6f030346 100755 --- a/configure +++ b/configure @@ -2425,7 +2425,7 @@ else cxx=3D fi =20 -if !(GIT=3D"$git" "$source_path/scripts/git-submodule.sh" "$git_submodules= _action" "$git_submodules"); then +if ! (GIT=3D"$git" "$source_path/scripts/git-submodule.sh" "$git_submodule= s_action" "$git_submodules"); then exit 1 fi =20 --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849222; cv=none; d=zohomail.com; s=zohoarc; b=SYW63/Ou27HCyV8h9f4EhnzdoS1QG0hTpjdzlbkO65POJ/E1Xm/+CagsrN0gNqx0ngXLlPtvFmPB2rAVjWnLpRwKgDl4FKlb/l0hzn2ZjNDd8RdpUDvfNCyNmWyWjhAMPtCrSBjq8J9tewPQ6XHVo1cboUQBqJtCl/1E8mIbtw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849222; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4EXt2WFXE+cYyllwhs3b3h+DGb3HVin2P2P0aToXQ9g=; b=O4p9xdPuHWiFrn1XpEjVIsmfS3744AWTqTrG6fEM75Cs9Xzhs/vzmr/wbtUD/stooCjsXEIMzJxdRLvzv/W86k2TjwjWpLtQuVfc9dKHymvVt4LIuO5pbcztD4h1iZL/6SY5pAhHFhJHTIjZ8DmUfBWdp48KUnApnq1Neiw+d88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849222187635.073810740991; Tue, 26 Jul 2022 08:27:02 -0700 (PDT) Received: from localhost ([::1]:47564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMSb-0006af-2u for importer@patchew.org; Tue, 26 Jul 2022 11:27:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMG-0006Ri-Ov for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:39849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMA-000633-NE for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: by mail-wr1-x42d.google.com with SMTP id d8so20534592wrp.6 for ; Tue, 26 Jul 2022 08:20:21 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=4EXt2WFXE+cYyllwhs3b3h+DGb3HVin2P2P0aToXQ9g=; b=NQnkdnNNOpifRbydF7sNu+aOYdbAErmwB1+i+S/ZluHU1e+gQ2UKskz6Z3sl5ohs8F c71b81H5X+/9klDtwv8tnWwuDJ0E6FiQYRAVRydmv0N6CYhxzWxTBAitc3HULva2Tr6e XG35INE9hc4rVUTgJXVAU79EWDIx8a4dCNfgFWx7y9xZbmUCcdebEI1BsKZP7zQvWItr M8ewAv99rM5YBe9vssrxWsElTgrX18GW/r779s9hkSOCPCWWfdKtrU1G7uw/ZMu8EwGH jhMArMVKOgZYVK0ZKTmcwg6b5a0ssaTvvZ9g5jCmwMM2RxGhfiX8OtJQMRn5fAnmvLRQ ehmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4EXt2WFXE+cYyllwhs3b3h+DGb3HVin2P2P0aToXQ9g=; b=dcc4V8Gb2CAxEKVej/TOubK2C5XX1HFCUOopWUiF8e5MQHLlyodZ3hciaIy7dC/xhh 0Ej3nxsX/ylqBYdix4MA+0V6rTO5xenk94wwbGLmhiLaAJi4kYr8wopvQNoYus9te4Yy HlIiyN1jzRwzRW+5GW2p9rgz1ioerV5KGMiK2c4knjXrvbDqAYAdF95l8QEDQjz7Lg9w 8xF68idjk1p9K8XC77NRvYMLlMJeTAz96vwhgvNKyTj9GlfrugMvBCTwpPuXC+phkeXF rOuRrojfHY4gSLOJky4s0UPaz5SEvrA1puEyqFpkVnmA8N1mh1GQ8nK7lIadjYSVd1CM CAxA== X-Gm-Message-State: AJIora9pFm+RNlq2Ih4ws305Y7fILxuABrr2nVLVBNteh5Lz5fIKUc7t wKR93kfNqPVZfr2Xi1JtO0GWZDKT3iM8lA== X-Google-Smtp-Source: AGRyM1uwneGf+K3C+3Nx0x5FzsZcaxC6KrALbV0zEuTVsAEuygb/JQmRCxe61H8HRL/n9ruj13eB2w== X-Received: by 2002:adf:f807:0:b0:21e:5094:aeb9 with SMTP id s7-20020adff807000000b0021e5094aeb9mr11520016wrp.497.1658848820103; Tue, 26 Jul 2022 08:20:20 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 5/9] configure: Add braces to clarify intent of $emu[[:space:]] Date: Tue, 26 Jul 2022 16:20:08 +0100 Message-Id: <20220726152012.1631158-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849223187100002 Content-Type: text/plain; charset="utf-8" In shell script syntax, $var[something] is not special for variable expansion: $var is expanded. However, as it can look as if it were intended to be an array element access (the correct syntax for which is ${var[something]}), shellcheck recommends using explicit braces around ${var} to clarify the intended expansion. This fixes the warning: In ./configure line 2346: if "$target_ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space:= ]]*$"; then ^-- SC1087: U= se braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-id: 20220720152631.450903-3-peter.maydell@linaro.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index dec6f030346..a56c3d921be 100755 --- a/configure +++ b/configure @@ -2343,7 +2343,7 @@ if test -n "$target_cc" && # emulation. Linux and OpenBSD/amd64 use 'elf_i386'; FreeBSD uses the = _fbsd # variant; OpenBSD/i386 uses the _obsd variant; and Windows uses i386p= e. for emu in elf_i386 elf_i386_fbsd elf_i386_obsd i386pe; do - if "$target_ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space= :]]*$"; then + if "$target_ld" -verbose 2>&1 | grep -q "^[[:space:]]*${emu}[[:spa= ce:]]*$"; then ld_i386_emulation=3D"$emu" break fi --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849880; cv=none; d=zohomail.com; s=zohoarc; b=AStTa9QCvtEL4KrbVpYeEzuSOZTbhaun7/fK6eA5P+j/u0VfPivSvXM7yOquxFhScAVS+rVvnFuVWN97MudbV65C5kEH+EJ3PlCBTrfusdeB4JwkTvUZUloVoq13hj+y0bFwViU+9soeYL1ccvMjJySixyCiID7HuvvIEeH4exc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849880; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J0a1TUw/2CURKscI5PXWjufgRvMWjB7jxGP1SOJi5DA=; b=amMhENmJy5RFv1E/LWjkprSUUO0W88XykWrOUDnaG3Bq+h0Frj1pK2hRDbBkDvTLtlt7dwyvgG2sU+8MZfFd1HzO7hPy7CqubOFTfKvMzlVJbWvoguHUOPCL1J1Q+HiRoz4DwSb/lzrZniXf+5X+i4UoJmHTJF5j24ZSgQ2dPTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849880503458.699551080491; Tue, 26 Jul 2022 08:38:00 -0700 (PDT) Received: from localhost ([::1]:35922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMdC-0001N3-9J for importer@patchew.org; Tue, 26 Jul 2022 11:37:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMI-0006SY-47 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:30 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:41482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMA-000638-MV for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: by mail-wm1-x32a.google.com with SMTP id x23-20020a05600c179700b003a30e3e7989so8382367wmo.0 for ; Tue, 26 Jul 2022 08:20:22 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=J0a1TUw/2CURKscI5PXWjufgRvMWjB7jxGP1SOJi5DA=; b=kh2gwuaq4JLh1UtwejwEMiph+xjIKqDHxFqBox++bhgmq0MSXdEB86mQVBStVxi5cP g4XnFQfslrbLR2Hwi8i2BXBf35NvX9LcDYCdVupzv2x1pzDb4tiagdqywQsXLBBR+I60 FzClmtWAlUZpKXtBPtYxKsGMhgiy4IZlYZw2gysJYj7zDDvDMIqSBzm50U0UM+43mZBX H2Kyt5X+/DxlGnloZ0P/D06AImmdE82l0yoCNmfNRVTQyqm0GKBoK5hs3ma5EgT9jfTK AEjbFro9iiyxeNGUcLruWDniTlkHFESs/BMqlPXNudtfbiwXhWbv6lcPInh83fF6P3Jb svLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J0a1TUw/2CURKscI5PXWjufgRvMWjB7jxGP1SOJi5DA=; b=j/7MHnY/xK5FPFSLoEyitifBaR01xpzJnZUoevD3S/Kbc5uKvMu7bozB67EUi0/IHC JNmJB1vH9VQE1yWnxTvwIg4FVP0N+ofLOxNjdHURhCV9TLu0qG3QRLjuuNCNZXQ58f+i jDnXNheOff7Qj798VVzKyMYEFq/45ncAYhJC47HGSlQvavPm0o9PPisitykYSGhZGVHV sAOjHZx+gzGQC9c7DvGkVw852tIb4HycrVVvi7DgNzIN3o5hb/EYvCpGX4X2aAEmJrT8 V/blSuPT5Dx3+jo9/sER9myQ9rClAh8NTojFB6N03Pp5YTKEXQNwfLsSQTO0dkvw/MY9 g1zg== X-Gm-Message-State: AJIora+/IB/HyeeFzdhMyIS58F66ERKz8QSEY3gbloVlEU/dRNg82zrI MENPazqegFkEWUz/rqDLLsG/y8x1SBI6Hg== X-Google-Smtp-Source: AGRyM1vOdzWsCTcjcZkUP6JrULT2OPkYpOh7y7wQrtteIXq3fizEQZf5J+2i+U032ROz21z+as+qdg== X-Received: by 2002:a05:600c:4e4d:b0:3a3:1fe6:6b20 with SMTP id e13-20020a05600c4e4d00b003a31fe66b20mr12679805wmq.197.1658848821268; Tue, 26 Jul 2022 08:20:21 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 6/9] configure: Don't use bash-specific string-replacement syntax Date: Tue, 26 Jul 2022 16:20:09 +0100 Message-Id: <20220726152012.1631158-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01, WEIRD_QUOTING=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849882152100001 Content-Type: text/plain; charset="utf-8" The variable string-replacement syntax ${var/old/new} is a bashism (though it is also supported by some other shells), and for instance does not work with the NetBSD /bin/sh, which complains: ../src/configure: 687: Syntax error: Bad substitution Replace it with a more portable sed-based approach, similar to what we already do in quote_sh(). Note that shellcheck also diagnoses this: In ./configure line 687: e=3D${e/'\'/'\\'} ^-----------^ SC2039: In POSIX sh, string replacement is undefined. ^-- SC1003: Want to escape a single quote? echo 'This is how it'= \''s done'. ^-- SC1003: Want to escape a single quote? echo 'This is ho= w it'\''s done'. In ./configure line 688: e=3D${e/\"/'\"'} ^----------^ SC2039: In POSIX sh, string replacement is undefined. Fixes: 8154f5e64b0cf ("meson: Prefix each element of firmware path") Signed-off-by: Peter Maydell Tested-by: Thomas Huth Message-id: 20220720152631.450903-4-peter.maydell@linaro.org --- configure | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a56c3d921be..c05205b6085 100755 --- a/configure +++ b/configure @@ -684,9 +684,10 @@ meson_option_build_array() { IFS=3D: fi for e in $1; do - e=3D${e/'\'/'\\'} - e=3D${e/\"/'\"'} - printf '"""%s""",' "$e" + printf '"""' + # backslash escape any '\' and '"' characters + printf "%s" "$e" | sed -e 's/\([\"]\)/\\\1/g' + printf '""",' done) printf ']\n' } --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849018; cv=none; d=zohomail.com; s=zohoarc; b=ebUf27GvZGNLTJuZVWAgai7D+jrk9KKJD6b69TiivTUr9wtIuePBie3Vewzc0HqQtaKyFuZ6uPw+Y3RQZDwTC/gOReFXsIvA+YAxpYy5ANoR/zBaS7C+lvL/sq1kmjFKK+7ELwvNL9Z/PIXF2cqYKDSUyEkBpxNCHGPYlINPj9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849018; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=onmBEojmdX59I7Osh+OHhyJMsX/Lk+u4yvlTQZ7RGfE=; b=mMurgtK63XyfwWuX/DJmhEK3PWqNoZ2+/ZJsl46aVd1S9A/HOYDCwB0B67FDcMh1ljz0m+n5L67uzs2FgvZoHcIpCGYZrT6IQY1p3MBAPtpZEGxtw2XHLB74VYJuh1jwLVkWrcR0mF6J50xB2BWK/mTmBkndEwJeHSdJF5oQNvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849018943489.902932809489; Tue, 26 Jul 2022 08:23:38 -0700 (PDT) Received: from localhost ([::1]:39238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMPI-0000vE-P4 for importer@patchew.org; Tue, 26 Jul 2022 11:23:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMF-0006OO-RH for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:27 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:55081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMD-00063G-69 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:26 -0400 Received: by mail-wm1-x32c.google.com with SMTP id n185so8952791wmn.4 for ; Tue, 26 Jul 2022 08:20:23 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=onmBEojmdX59I7Osh+OHhyJMsX/Lk+u4yvlTQZ7RGfE=; b=V4KOAQEkjr9b907Afki63iSTKg5sSu7Qkc6Qeb41qx+LToQr339wnDO0ZNySLtg5po 0d3Fw/0cfsttNqZN55NnhaD20ivP3Voi3EMZ3dmCB9UKfTYN/lopnYQ+kDc5qK2qz3YP jmlGOSyg6r26Se7zGSOtRsjXjLR2MMxhKQ8RFglns1eWZpYYaKnQhT5FxugISnr2UThW 8zXA5HEnIRp/HAthmKK+RfSz3wdFBFupuJvLWG+2f9KEYrSxOqIPYvNqsaQ/KrlvAmU2 2a7Ckep3yFYDpmIrsRX/IWMK04GwcqrhpDclUOKK+HHRJfJUckEYZvgjPIS1Ar6LxGh4 GswQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=onmBEojmdX59I7Osh+OHhyJMsX/Lk+u4yvlTQZ7RGfE=; b=M8+5fRcDDWFaMBVcMXEhwMhv3IKRKRt8C9XGi8OM9kjbCrAGSysnPSPnoLPzI21Ut+ ur4FUrRXSQRWn7aTNwfmCVJPw9WEhWl+q4/relYrqznWIOK1+nEotuKxYHDV4elPMv0Y J/5qHE4J9FfYHq5byYHnifToB4zyAXZFxj68daMnRRdyBV0KV0p0CCIdT93PSSpZOTwx ujh4N4Y/TY3xhXsHtp9cosk/+4BHI64+aumUHSFtPWDJzyNYJz/ZafNO1ntkFv0kr6nD HGndDOTWQqA30t+s2014+nLWCmVZa/PoTsJY/D5N4lXkEUfg5H+WN+zdd28dg5OwQF9o T7Tg== X-Gm-Message-State: AJIora86toK+z+AtOSAnIXvoY5k1UsEXYxU7HLYmkh1kP4PO5kgc9f+K jw0Ll1I+2aOHEzVxx2aP+N4izVobqFDlzg== X-Google-Smtp-Source: AGRyM1sMlOEsqpoQuvMqdhq0KJf8Dc7ODdGDYE4UzXBpddlMVp9bdXDwtmcmZlp47nBjKX8dqvFSvw== X-Received: by 2002:a1c:cc1a:0:b0:3a0:39b1:3408 with SMTP id h26-20020a1ccc1a000000b003a039b13408mr12406395wmb.157.1658848822040; Tue, 26 Jul 2022 08:20:22 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 7/9] configure: Drop dead code attempting to use -msmall-data on alpha hosts Date: Tue, 26 Jul 2022 16:20:10 +0100 Message-Id: <20220726152012.1631158-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849021133100003 Content-Type: text/plain; charset="utf-8" In commit 823eb013452e93d we moved the setting of ARCH from configure to meson.build, but we accidentally left behind one attempt to use $ARCH in configure, which was trying to add -msmall-data to the compiler flags on Alpha hosts. Since ARCH is now never set, the test always fails and we never add the flag. There isn't actually any need to use this compiler flag on Alpha: the original intent was that it would allow us to simplify our TCG codegen on that platform, but we never actually made the TCG changes that would rely on -msmall-data. Drop the effectively-dead code from configure, as we don't need it. This was spotted by shellcheck: In ./configure line 2254: case "$ARCH" in ^---^ SC2153: Possible misspelling: ARCH may not be assigned, but arc= h is. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-id: 20220720152631.450903-5-peter.maydell@linaro.org --- configure | 7 ------- 1 file changed, 7 deletions(-) diff --git a/configure b/configure index c05205b6085..d0e9a51462e 100755 --- a/configure +++ b/configure @@ -2251,13 +2251,6 @@ if test "$fortify_source" =3D "yes" ; then QEMU_CFLAGS=3D"-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3D2 $QEMU_CFLAGS" fi =20 -case "$ARCH" in -alpha) - # Ensure there's only a single GP - QEMU_CFLAGS=3D"-msmall-data $QEMU_CFLAGS" -;; -esac - if test "$have_asan" =3D "yes"; then QEMU_CFLAGS=3D"-fsanitize=3Daddress $QEMU_CFLAGS" QEMU_LDFLAGS=3D"-fsanitize=3Daddress $QEMU_LDFLAGS" --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849357; cv=none; d=zohomail.com; s=zohoarc; b=oC0Ds2VHDuANXJ3pgG7bQ2j/FtyIVDWt8shAhvsFHGV8bPzAw6u3ItyJ2AL27gfbWiKn41JfkGJgj3F83aPGsOxTQGtT5Ulh9D4IfiOZMmR+jMhyEspgxOP0A37CuanuswRArt4uk5S2+ycIBJ8+opcrDLt/LjjvhvIDbrH0h/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849357; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0ZhXnkNY51Ak8uQsgToIykxdNgR1qaaFhrhnxOotnMI=; b=H9eXhOspt/2gjcMRaHenXAJ31vq9EtQoa+T9Ph+cxflTuqXDTmzlwtBi5VNKI25ncolxq6gd/YItMcbu8NGSTu75IegUJ2nCPqQsHmsBeZv6Eu9tOYlyMEs9XfWwrOe1z4d966dSnI5BaQCliQ+tha8D0xh8nafSmuEBmQoHdsg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849357106753.8168083164475; Tue, 26 Jul 2022 08:29:17 -0700 (PDT) Received: from localhost ([::1]:54474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMUl-0002qB-4Q for importer@patchew.org; Tue, 26 Jul 2022 11:29:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMF-0006PO-O3 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:27 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:38607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMD-00063T-6l for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:27 -0400 Received: by mail-wm1-x334.google.com with SMTP id f24-20020a1cc918000000b003a30178c022so11544509wmb.3 for ; Tue, 26 Jul 2022 08:20:23 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=0ZhXnkNY51Ak8uQsgToIykxdNgR1qaaFhrhnxOotnMI=; b=rlKTRKlLGVsfdBXWgsR/5GtJeUTDisi72aya2fNJ8tgPWRzxVvuCewl1dguEjHMrN7 chjVcTfB94EWhHRbi0aHVKrNMRf1+9HoWXKPwoe9mD6G42dpR5O7prgwaSucfqivkCMx 48fUQuZ6VO/yf68iYzUfRCGOm6XBsN3lTopzG6PPDZY3lPloySQS9592JZ9eLGNz1/52 vVkBelkH+itmNIWwtZ3hglwi8u3hfZj9IgLWK6PpWz9Wvv7qPK0I+UhXlgFYOlLwx2wE wC20s9/OpEON6zw04f1MCVwmp2sGnsAgYVJnhIOLD4blq1d64B1KcxEaa1AhgaJ7eCVX usiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ZhXnkNY51Ak8uQsgToIykxdNgR1qaaFhrhnxOotnMI=; b=0xAKQzGevzyEzGyWf+KgjpVBhiIAXjoseGVMm7CuIxY9HTeWG/llyXPo1q9HT8JBmm usuec1RCjPPLYEcxjkMm1ESRmd9IeJhj3j56ZqPj9uiv9sSPf5nS9ed0xw/gBh/KPOtv 47vV8ZkoUhQ6YHqr4gjPCpNCz1Et2Btr6JsP5C1PGKDGsppZ7dutbFZaciPeWX0WVkJg DH77UICv5AjY+ugvSvjm/9wKKWIfxS1k+GymjhV6mO88GVM0z1E4tzgJ621kQ1IVf7kL Zw3J912ldACDyWnFPoFEdtxSw8ot/7lnGRKC1Q75AMkl1TfvD1tWMC/n5XYA3TelvqJ4 24zw== X-Gm-Message-State: AJIora83lpPhIovOvAC/lrx/qW9+uM6idtm2oHINvW+LXNNxMq9AXvKc ujN7fF44KCjN0mnVfUcB71g/Ru/7G8RnRA== X-Google-Smtp-Source: AGRyM1vvu4t/+eiz5bosZ/tKtcJ0J+cVfjeZu7wO2rp8XOkVGlV1tLvLUroCnYBnbV6wAaPBHF9F2A== X-Received: by 2002:a7b:ce8a:0:b0:3a3:1181:20ae with SMTP id q10-20020a7bce8a000000b003a3118120aemr12119396wmj.96.1658848822869; Tue, 26 Jul 2022 08:20:22 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 8/9] configure: Avoid '==' bashism Date: Tue, 26 Jul 2022 16:20:11 +0100 Message-Id: <20220726152012.1631158-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849359172100001 Content-Type: text/plain; charset="utf-8" The '=3D=3D' operator to test is a bashism; the standard way to copmare strings is '=3D'. This causes dash to complain: ../../configure: 681: test: linux: unexpected operator Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-id: 20220720152631.450903-6-peter.maydell@linaro.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d0e9a51462e..2c19329d58c 100755 --- a/configure +++ b/configure @@ -678,7 +678,7 @@ werror=3D"" =20 meson_option_build_array() { printf '[' - (if test "$targetos" =3D=3D windows; then + (if test "$targetos" =3D windows; then IFS=3D\; else IFS=3D: --=20 2.25.1 From nobody Thu May 16 14:53:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658849222; cv=none; d=zohomail.com; s=zohoarc; b=Am/w4t3kyp1H9L9ugBMSaDRJZRkEB5MEw64NpdC2VzkxFkpCWpSjTc80AKZYAy86/BzZNS6+5Q3iKP5wiBTXWJ6PVvnJUDt8/248Clq9cEKj/cswRgaf+E1gPmhkH634P+26KjSNLxVsbjnfN6z5dIoEtM0TZtd8kOIF7PyDu6g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658849222; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pjPZonZgIif23LZ1eMjprz1ddmRluH8DP+Iy9f6sgDM=; b=MLcRza9ytFzCd4ru8ys1BnXOh0Ro54dIlE4m0YseRl9rTsLh89RXB4liDtCt9Yo33wqUz4C/l4FfOf4vjYDipX1ofukbSi6DgWTvlTRwVHKZZZAqaCj31ZMrVeT5imH/o9QEHO9B73K3P2o7v2pKqtNB97TIjSIhzK0pGLP+2dE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658849222437294.08354936327066; Tue, 26 Jul 2022 08:27:02 -0700 (PDT) Received: from localhost ([::1]:47594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMSb-0006c4-DA for importer@patchew.org; Tue, 26 Jul 2022 11:27:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMI-0006Vg-Rl for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:35 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:51736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMD-00063j-Ey for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:30 -0400 Received: by mail-wm1-x32f.google.com with SMTP id id17so8962783wmb.1 for ; Tue, 26 Jul 2022 08:20:25 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=pjPZonZgIif23LZ1eMjprz1ddmRluH8DP+Iy9f6sgDM=; b=twyBhViCa3bdyDCbXVONj55ckcfmc3r4DYT7tfLNsRIkfzbCfJAKB/DzeVZh32s6zR O9u7FdQLu/U0wDycfsBBno2m4r9GotOpteYrkgvQG5giVR2lznftvE6j0fsr7GcXvXqP BnK31OchApsHrC6EEfAt22Ox5HB2qqu9/f4Aiob1x0eF54oL7r9kjpHn32L6rzCVqksK CGhpwq86ty127nqcoeU8JpX/WLszlqtwPL3yA67LlzsBCXlav9fnap7tJYmosW0udDwO A8u92dKK4W1NFyzvSRp6TjQMfUpjor0679LByECHoTA8voddhZwcWcTl0HmQyVa82Pms 1CZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pjPZonZgIif23LZ1eMjprz1ddmRluH8DP+Iy9f6sgDM=; b=ebI6dJfD4Bdl0Md4M/LAMW2pLl95wVEcZkL8gI+uJGYoj2fESlAAXXiWWdAtybFzNl 1W9zsHoKUn4sCBAYUnagkg+l9PS/BtDe6YIg/ahxjHuXajzHaF2C2ShU0+5O9NL66OcX oN8vhC7Te2tUQm5101CbHRtuifcDi6L58UgN5W9aS5vqGn84vxwMsj404kio2kx00sQJ 5LMO+P4OJZ0Q89Alpy0ka8IY20lCs3zatOKdgTiWBTTjQB6KAnC7Zw2qKzaE3czyfDoO 7ujUud9c42tG8tpDN7JdJww7aO5WtLu3NZ/70XwU8HfItuXMrdXGYbNom3AhLPKC1Fnl AaGA== X-Gm-Message-State: AJIora8tBdtx0KYBkqz+dBPpwoXHHA2NPoTfGxhCQJ5CMrS3+JKIXHgr LiiFxVAs6i/qZlm/dr1crOaoOzyDT3YV2A== X-Google-Smtp-Source: AGRyM1ue7scHQBSF4MsfggxCQ4F2roYGwOTlZASJMDMcH/EldUD/HFm6X+ppnq+hYIEHosrMvUhKJQ== X-Received: by 2002:a7b:ce0a:0:b0:3a3:1adf:af34 with SMTP id m10-20020a7bce0a000000b003a31adfaf34mr12306948wmc.127.1658848823710; Tue, 26 Jul 2022 08:20:23 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 9/9] hw/display/bcm2835_fb: Fix framebuffer allocation address Date: Tue, 26 Jul 2022 16:20:12 +0100 Message-Id: <20220726152012.1631158-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658849223183100001 Content-Type: text/plain; charset="utf-8" From: Alan Jian This patch fixes the dedicated framebuffer mailbox interface by removing an unneeded offset. This means that we pick the framebuffer address in the same way that we do if the guest code uses the buffer allocate mechanism of the bcm2835_property interface (case 0x00040001: /* Allocate buffer */ in bcm2835_property.c). The documentation of this mailbox interface doesn't say anything about using parts of the request buffer address to affect the chosen framebuffer address: https://github.com/raspberrypi/firmware/wiki/Mailbox-framebuffer-interface Some baremetal applications like the Screen01/Screen02 examples from Baking Pi tutorial[1] didn't work before this patch. [1] https://www.cl.cam.ac.uk/projects/raspberrypi/tutorials/os/screen01.html Signed-off-by: Alan Jian Message-id: 20220725145838.8412-1-alanjian85@outlook.com [PMM: tweaked commit message] Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/display/bcm2835_fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index 088fc3d51c5..a05277674f2 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -279,8 +279,7 @@ static void bcm2835_fb_mbox_push(BCM2835FBState *s, uin= t32_t value) newconf.xoffset =3D ldl_le_phys(&s->dma_as, value + 24); newconf.yoffset =3D ldl_le_phys(&s->dma_as, value + 28); =20 - newconf.base =3D s->vcram_base | (value & 0xc0000000); - newconf.base +=3D BCM2835_FB_OFFSET; + newconf.base =3D s->vcram_base + BCM2835_FB_OFFSET; =20 /* Copy fields which we don't want to change from the existing config = */ newconf.pixo =3D s->config.pixo; --=20 2.25.1