From nobody Tue Feb 10 05:27:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658735923; cv=none; d=zohomail.com; s=zohoarc; b=aBUYnpyUvwUaYAwRc4LpL9OBcVYOHTt7tcVfG3n73Y/IjoUov5/e+omjg7n//SRAp2F0+nGOIpiMQTdrCeHzh49WqPHNqADmxbC/fP2LRPC0P/lnZmURHhYabsMnedbwU+U2knDhyhE+i3ONM72+0YZ1kOPMO9ECxVTLB7FFcj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658735923; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8LLI7lF1oqN8Vm9tNi+9Fx98Wt9jmgsdRl942lcUWSM=; b=IDiphCSm9NVft+79S+7TrAdswmH0Z504nDDc/2tJn18PxDxp+bozjurtCapQSgSeJnSQXyQuMjgoainHZDW263YUdySR8erzo9w3GwVZfUzK4Q8IE4kyQikEuDqompfK2nNw6yXgk9Pbu5BdOTbB5+07tSah8IhLjEOGHAuQv/U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658735923240155.19343473294293; Mon, 25 Jul 2022 00:58:43 -0700 (PDT) Received: from localhost ([::1]:46412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFszB-00087i-9c for importer@patchew.org; Mon, 25 Jul 2022 03:58:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFsgS-0004Kd-5h for qemu-devel@nongnu.org; Mon, 25 Jul 2022 03:39:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFsgI-0003G6-Jg for qemu-devel@nongnu.org; Mon, 25 Jul 2022 03:39:19 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-JuqJAdMYMri8zISbG9q2cg-1; Mon, 25 Jul 2022 03:39:06 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 970DE804197; Mon, 25 Jul 2022 07:39:05 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4286A2166B26; Mon, 25 Jul 2022 07:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658734749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LLI7lF1oqN8Vm9tNi+9Fx98Wt9jmgsdRl942lcUWSM=; b=Ne7rEqlvR5AQnYZnEawZG473wQirQaZXcoD8980+7WH+i6Mpl8UhkRzvfZbTP1fpxayfhb tTv6gx8VXKHXl+5dha6HcSSAHVWoBDuh7iXQkuAeQUaiFurRcnHjj/CnT462OxWLjsvRco UNTrt/cYOealSOEJYC8YQ0pPX1dLf2E= X-MC-Unique: JuqJAdMYMri8zISbG9q2cg-1 From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Cc: Kevin Wolf , Hanna Reitz , Paolo Bonzini , John Snow , Vladimir Sementsov-Ogievskiy , Wen Congyang , Xie Changlong , Markus Armbruster , Stefan Hajnoczi , Fam Zheng , qemu-devel@nongnu.org, Emanuele Giuseppe Esposito , Vladimir Sementsov-Ogievskiy Subject: [PATCH v10 16/21] blockjob: rename notifier callbacks as _locked Date: Mon, 25 Jul 2022 03:38:50 -0400 Message-Id: <20220725073855.76049-17-eesposit@redhat.com> In-Reply-To: <20220725073855.76049-1-eesposit@redhat.com> References: <20220725073855.76049-1-eesposit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658735925348100003 Content-Type: text/plain; charset="utf-8" They all are called with job_lock held, in job_event_*_locked() Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Kevin Wolf --- blockjob.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/blockjob.c b/blockjob.c index 9ff2727025..0663faee2c 100644 --- a/blockjob.c +++ b/blockjob.c @@ -250,7 +250,8 @@ int block_job_add_bdrv(BlockJob *job, const char *name,= BlockDriverState *bs, return 0; } =20 -static void block_job_on_idle(Notifier *n, void *opaque) +/* Called with job_mutex lock held. */ +static void block_job_on_idle_locked(Notifier *n, void *opaque) { aio_wait_kick(); } @@ -370,7 +371,8 @@ static void block_job_iostatus_set_err(BlockJob *job, i= nt error) } } =20 -static void block_job_event_cancelled(Notifier *n, void *opaque) +/* Called with job_mutex lock held. */ +static void block_job_event_cancelled_locked(Notifier *n, void *opaque) { BlockJob *job =3D opaque; uint64_t progress_current, progress_total; @@ -389,7 +391,8 @@ static void block_job_event_cancelled(Notifier *n, void= *opaque) job->speed); } =20 -static void block_job_event_completed(Notifier *n, void *opaque) +/* Called with job_mutex lock held. */ +static void block_job_event_completed_locked(Notifier *n, void *opaque) { BlockJob *job =3D opaque; const char *msg =3D NULL; @@ -415,7 +418,8 @@ static void block_job_event_completed(Notifier *n, void= *opaque) msg); } =20 -static void block_job_event_pending(Notifier *n, void *opaque) +/* Called with job_mutex lock held. */ +static void block_job_event_pending_locked(Notifier *n, void *opaque) { BlockJob *job =3D opaque; =20 @@ -427,7 +431,8 @@ static void block_job_event_pending(Notifier *n, void *= opaque) job->job.id); } =20 -static void block_job_event_ready(Notifier *n, void *opaque) +/* Called with job_mutex lock held. */ +static void block_job_event_ready_locked(Notifier *n, void *opaque) { BlockJob *job =3D opaque; uint64_t progress_current, progress_total; @@ -472,11 +477,11 @@ void *block_job_create(const char *job_id, const Bloc= kJobDriver *driver, =20 ratelimit_init(&job->limit); =20 - job->finalize_cancelled_notifier.notify =3D block_job_event_cancelled; - job->finalize_completed_notifier.notify =3D block_job_event_completed; - job->pending_notifier.notify =3D block_job_event_pending; - job->ready_notifier.notify =3D block_job_event_ready; - job->idle_notifier.notify =3D block_job_on_idle; + job->finalize_cancelled_notifier.notify =3D block_job_event_cancelled_= locked; + job->finalize_completed_notifier.notify =3D block_job_event_completed_= locked; + job->pending_notifier.notify =3D block_job_event_pending_locked; + job->ready_notifier.notify =3D block_job_event_ready_locked; + job->idle_notifier.notify =3D block_job_on_idle_locked; =20 WITH_JOB_LOCK_GUARD() { notifier_list_add(&job->job.on_finalize_cancelled, --=20 2.31.1