From nobody Sat May 18 21:00:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658502281; cv=none; d=zohomail.com; s=zohoarc; b=hf1Bayv7ask8RCKReHhrLg7PSRYP9qUm8CgzA6CJ8MhjPLHan9Qgt+F76Pu8RHv2pqH7IDe86ULpwXx0PovsFUpS4nW2LTyyxBR0CZuf/KxtvVJ3mAOTRMZdqMP/ks+2s0Q1sVXHbp9utoHnrnEqAWHR71dRHuzzNgSMmv+5b0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658502281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=d2vT62F++U5vroIS8grk6pJEAjuGIeWf8eLQZjjVbYU=; b=dPCM1+IWKlyRqalp4W5VqvcoT4A7t2H0i4N9R4BscV7wcQwuK/OZdtLMnF/yNJ6RUB3PoDQfjnQPMF9pfIjf1RTP4DY8+6MBxXXlysWwVAs3s4SCl2b1BztUcBZonLDFlqxydekvxutCaRt8C0FtjD5Axc9E89PP0ya1sbOP3d8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658502281066142.27761078845413; Fri, 22 Jul 2022 08:04:41 -0700 (PDT) Received: from localhost ([::1]:34040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEuCl-0007zl-5I for importer@patchew.org; Fri, 22 Jul 2022 11:04:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEu5Z-0000TT-9J for qemu-devel@nongnu.org; Fri, 22 Jul 2022 10:57:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:43491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEu5W-0007db-BY for qemu-devel@nongnu.org; Fri, 22 Jul 2022 10:57:11 -0400 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-451-yRvb51h2NeiDyTlgwMIdAg-1; Fri, 22 Jul 2022 10:57:00 -0400 Received: by mail-qk1-f197.google.com with SMTP id bk21-20020a05620a1a1500b006b5c24695a4so3894870qkb.15 for ; Fri, 22 Jul 2022 07:57:00 -0700 (PDT) Received: from localhost.localdomain (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id y7-20020a37e307000000b006b5e6dac3b0sm3291429qki.128.2022.07.22.07.56.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Jul 2022 07:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658501829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2vT62F++U5vroIS8grk6pJEAjuGIeWf8eLQZjjVbYU=; b=aJEfbrdGsFnGazcb4w1PBV9rzbApbacoH6pk1D3Yki12XmRUGYCj0dB1TYUp8qiRkotibW +is2nw8CHjha9YGvzU18mVKUH/6rapiOFcu1+ZsW2BvHJrTjCc8xFeu0hQW6qpVA8i6pGg ZlvyVZC/u+F4axGU9CAkTwsP41hQ/VE= X-MC-Unique: yRvb51h2NeiDyTlgwMIdAg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d2vT62F++U5vroIS8grk6pJEAjuGIeWf8eLQZjjVbYU=; b=ZNkXUnwhd+i52m4a+Dl5qjmUKHeTyaVNHSYHKc+3vWCBoY4wBC1pERfrbKSmpHd5Jr IEvUpIHlpfPbiOtBdrruIiepRYDRChSeIesanc+cavN6zEZn58ex/c2AfKJyQFD7WAx4 QYYGLCEUlsoGrVudT183EZ3HJrY748ttBDvZ7GQ0lYH8+Vnu/xEWNiCdKdbPJ9lSk8zi 5SwKsIL3o7gXDEUan/orjP3I3ZLYKfywQghTDptkNagwyEpbORtTQa6KRPd4m0GRlJpP Hr6jkmGuwR0rLd+BG6GgkvuClhMCUD+UCanj1hIzr8PRoXQ+m7QejbBwSB2akYS3TyyU dkYg== X-Gm-Message-State: AJIora818e+RcHYs2VoUAAHytMnXEgSPibCmQ/rlTmcRZY28dCSOv/yt kC82jJxWROyZ14RFO3Hn2Oog7hySIl+z5WTYnAl9wHYwcFAmYhNFcCeW/9vGgXIFxTiZq+oB6QK +XL3Cp/nzw1cuMMNqsI7I9sYFnaPFLRb6biWnOBEX1yAFTGXHDGxCCg0J6tbOqnMB X-Received: by 2002:a05:622a:38f:b0:305:1ea5:4a7 with SMTP id j15-20020a05622a038f00b003051ea504a7mr391002qtx.291.1658501819498; Fri, 22 Jul 2022 07:56:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1thiuJ+qswoFD4xFAbtCp6301Qhl4BG715LvRUPntW3DB4hPVDO2Lzevw1yzcZGkVK4biCqew== X-Received: by 2002:a05:622a:38f:b0:305:1ea5:4a7 with SMTP id j15-20020a05622a038f00b003051ea504a7mr390973qtx.291.1658501819146; Fri, 22 Jul 2022 07:56:59 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: peterx@redhat.com, "Dr . David Alan Gilbert" , Thomas Huth , Leonardo Bras Soares Passos , "Daniel P . Berrange" , Juan Quintela Subject: [PATCH v2 1/2] migration-test: Use migrate_ensure_converge() for auto-converge Date: Fri, 22 Jul 2022 10:56:53 -0400 Message-Id: <20220722145654.81103-2-peterx@redhat.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220722145654.81103-1-peterx@redhat.com> References: <20220722145654.81103-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658502282396100001 Content-Type: text/plain; charset="utf-8" Thomas reported that auto-converge test will timeout on MacOS CI gatings. Use the migrate_ensure_converge() helper too in the auto-converge as when Daniel reworked the other test cases. Since both max_bandwidth / downtime_limit will not be used for converge calculations, make it simple by removing the remaining check, then we can completely remove both variables altogether, since migrate_ensure_converge is used the remaining check won't make much sense anyway. Suggested-by: Daniel P. Berrange Reported-by: Thomas Huth Signed-off-by: Peter Xu Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/qtest/migration-test.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 71595a74fd..dd50aa600c 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1776,14 +1776,6 @@ static void test_migrate_auto_converge(void) * so we need to decrease a bandwidth. */ const int64_t init_pct =3D 5, inc_pct =3D 50, max_pct =3D 95; - const int64_t max_bandwidth =3D 400000000; /* ~400Mb/s */ - const int64_t downtime_limit =3D 250; /* 250ms */ - /* - * We migrate through unix-socket (> 500Mb/s). - * Thus, expected migration speed ~=3D bandwidth limit (< 500Mb/s). - * So, we can predict expected_threshold - */ - const int64_t expected_threshold =3D max_bandwidth * downtime_limit / = 1000; =20 if (test_migrate_start(&from, &to, uri, &args)) { return; @@ -1818,8 +1810,7 @@ static void test_migrate_auto_converge(void) /* The first percentage of throttling should be equal to init_pct */ g_assert_cmpint(percentage, =3D=3D, init_pct); /* Now, when we tested that throttling works, let it converge */ - migrate_set_parameter_int(from, "downtime-limit", downtime_limit); - migrate_set_parameter_int(from, "max-bandwidth", max_bandwidth); + migrate_ensure_converge(from); =20 /* * Wait for pre-switchover status to check last throttle percentage @@ -1830,11 +1821,6 @@ static void test_migrate_auto_converge(void) /* The final percentage of throttling shouldn't be greater than max_pc= t */ percentage =3D read_migrate_property_int(from, "cpu-throttle-percentag= e"); g_assert_cmpint(percentage, <=3D, max_pct); - - remaining =3D read_ram_property_int(from, "remaining"); - g_assert_cmpint(remaining, <, - (expected_threshold + expected_threshold / 100)); - migrate_continue(from, "pre-switchover"); =20 qtest_qmp_eventwait(to, "RESUME"); @@ -1842,7 +1828,6 @@ static void test_migrate_auto_converge(void) wait_for_serial("dest_serial"); wait_for_migration_complete(from); =20 - test_migrate_end(from, to, true); } =20 --=20 2.32.0 From nobody Sat May 18 21:00:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658501942; cv=none; d=zohomail.com; s=zohoarc; b=S82jQY/RDgrVkTexF3qmFwVrHLY/e61KKoqOozVZsQMTdjZvgguzoG7/U1jILOHr1nzZuogXHWrUc2difB6mJSL/v3iCZLKMouxPC+Vz9+1a1Oe45YxFJ2JZUWyy8edG+yIR7hmkzehzDLjvk9lgnaU2UN+ySU3Q2xFO0Mmtj7Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658501942; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nDDlN3mM9HgDb+Z3x6nSHM5nxk54wtzlY3gz8F8WEMw=; b=D/H9wMBoYhoR6bwn9u+DhwRx9Q5eTCWnJoo7sregaAJb1gfkjfaJLIInbvDjbNEUrPKCaElEhsXjiGl8X1KoBd/tAdOKRPOo0FUPg9Pzj4llwjzN1PT0aQjMDhiUVPeo/7UlwLzltaZuHflMv6FkCpdH3rts1tBkrmRlkwXEvII= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658501942261555.4286683964681; Fri, 22 Jul 2022 07:59:02 -0700 (PDT) Received: from localhost ([::1]:52188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEu7I-000113-LD for importer@patchew.org; Fri, 22 Jul 2022 10:59:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEu5Q-0000KN-Nc for qemu-devel@nongnu.org; Fri, 22 Jul 2022 10:57:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:32264) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEu5P-0007cq-1Y for qemu-devel@nongnu.org; Fri, 22 Jul 2022 10:57:04 -0400 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359-6ENYXo81N3SijJ6xcocwug-1; Fri, 22 Jul 2022 10:57:01 -0400 Received: by mail-qt1-f199.google.com with SMTP id cj19-20020a05622a259300b0031f01f3933cso2972701qtb.18 for ; Fri, 22 Jul 2022 07:57:01 -0700 (PDT) Received: from localhost.localdomain (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id y7-20020a37e307000000b006b5e6dac3b0sm3291429qki.128.2022.07.22.07.56.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Jul 2022 07:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658501822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nDDlN3mM9HgDb+Z3x6nSHM5nxk54wtzlY3gz8F8WEMw=; b=GCmMpGHK/EC55A7jmOmlAlyKICzzETMH10RODfSqCJmbRECO881fkXgccuT331FpAnHQ/q 8WASVJLhXUMj9xp2Sh31LUrjeU6aM+28lXlarQOynfNiDFxWjs+tJYdifOLJy5UurU7jG/ l6EzHyoj+nblPPvN0RXCfAeMyAmKr8I= X-MC-Unique: 6ENYXo81N3SijJ6xcocwug-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nDDlN3mM9HgDb+Z3x6nSHM5nxk54wtzlY3gz8F8WEMw=; b=7T8rrvb/HLUEMk9MQ2VEiHzlP/180qsfc3Fzk2ZeJui9kP6A/vAK8GHkZlWsGHOdBb ZYd85wtu9QFYj3F+N5DEH36tUQ2rfG0+lt2sHOR6DAiDRALOI2zhpzwqQRvNW9mEhsRK ZqSd8mGPujjzL5e1FXUa0qc+mP3LURqab4idwGrVPjf37jB98jg1i7LSpmp7EaRVT2Kc 1RWjqpcdqpu/4r6S6m+LYkR2liFG0/tjsGNDNIo68t76opUcIPn5ZzM75oYuzgQNmHyF TDx+Wkovia6avquEoiMkgtBJcrEAlXLPv+alyChXpuncwFqNHc/zNGvwBLHxpPQpFC+6 1N4g== X-Gm-Message-State: AJIora9KTE9d/ZIsbnzZTpa9Sxr0zGWxwoa8ET8dH7RIkSWqD2dHaHaa XJiC2t4tGywROxI1ZJeztU/tPeqKdAtkcXhRJfxlMMbgop9b1IXo4oZjxqSXy3nuhPANQpWb5zI Vwuz4umWxPiQDzqnGAEN4xmoCL3wDblKScLEMNx+leXNF8EiuPo2UlT3Y4pi/gIIZ X-Received: by 2002:a05:620a:3709:b0:6b5:adeb:5ef0 with SMTP id de9-20020a05620a370900b006b5adeb5ef0mr196089qkb.307.1658501820696; Fri, 22 Jul 2022 07:57:00 -0700 (PDT) X-Google-Smtp-Source: AGRyM1umuczP8AH/dCCbA7tcf18WRupss9Yp337bfNs/pIot3tsR6ms1qA9qvvRAgPBOtZwVtXPxlg== X-Received: by 2002:a05:620a:3709:b0:6b5:adeb:5ef0 with SMTP id de9-20020a05620a370900b006b5adeb5ef0mr196066qkb.307.1658501820388; Fri, 22 Jul 2022 07:57:00 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: peterx@redhat.com, "Dr . David Alan Gilbert" , Thomas Huth , Leonardo Bras Soares Passos , "Daniel P . Berrange" , Juan Quintela Subject: [PATCH v2 2/2] migration-test: Allow test to run without uffd Date: Fri, 22 Jul 2022 10:56:54 -0400 Message-Id: <20220722145654.81103-3-peterx@redhat.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220722145654.81103-1-peterx@redhat.com> References: <20220722145654.81103-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658501944350100001 Content-Type: text/plain; charset="utf-8" We used to stop running all tests if uffd is not detected. However logically that's only needed for postcopy not the rest of tests. Keep running the rest when still possible. Signed-off-by: Peter Xu Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/qtest/migration-test.c | 48 +++++++++++++++++++----------------- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index dd50aa600c..8826ee4be4 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -2424,14 +2424,11 @@ int main(int argc, char **argv) { char template[] =3D "/tmp/migration-test-XXXXXX"; const bool has_kvm =3D qtest_has_accel("kvm"); + const bool has_uffd =3D ufd_version_check(); int ret; =20 g_test_init(&argc, &argv, NULL); =20 - if (!ufd_version_check()) { - return g_test_run(); - } - /* * On ppc64, the test only works with kvm-hv, but not with kvm-pr and = TCG * is touchy due to race conditions on dirty bits (especially on PPC f= or @@ -2460,13 +2457,15 @@ int main(int argc, char **argv) =20 module_call_init(MODULE_INIT_QOM); =20 - qtest_add_func("/migration/postcopy/unix", test_postcopy); - qtest_add_func("/migration/postcopy/plain", test_postcopy); - qtest_add_func("/migration/postcopy/recovery/plain", - test_postcopy_recovery); - qtest_add_func("/migration/postcopy/preempt/plain", test_postcopy_pree= mpt); - qtest_add_func("/migration/postcopy/preempt/recovery/plain", - test_postcopy_preempt_recovery); + if (has_uffd) { + qtest_add_func("/migration/postcopy/unix", test_postcopy); + qtest_add_func("/migration/postcopy/plain", test_postcopy); + qtest_add_func("/migration/postcopy/recovery/plain", + test_postcopy_recovery); + qtest_add_func("/migration/postcopy/preempt/plain", test_postcopy_= preempt); + qtest_add_func("/migration/postcopy/preempt/recovery/plain", + test_postcopy_preempt_recovery); + } =20 qtest_add_func("/migration/bad_dest", test_baddest); qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plai= n); @@ -2474,18 +2473,21 @@ int main(int argc, char **argv) #ifdef CONFIG_GNUTLS qtest_add_func("/migration/precopy/unix/tls/psk", test_precopy_unix_tls_psk); - /* - * NOTE: psk test is enough for postcopy, as other types of TLS - * channels are tested under precopy. Here what we want to test is the - * general postcopy path that has TLS channel enabled. - */ - qtest_add_func("/migration/postcopy/tls/psk", test_postcopy_tls_psk); - qtest_add_func("/migration/postcopy/recovery/tls/psk", - test_postcopy_recovery_tls_psk); - qtest_add_func("/migration/postcopy/preempt/tls/psk", - test_postcopy_preempt_tls_psk); - qtest_add_func("/migration/postcopy/preempt/recovery/tls/psk", - test_postcopy_preempt_all); + + if (has_uffd) { + /* + * NOTE: psk test is enough for postcopy, as other types of TLS + * channels are tested under precopy. Here what we want to test i= s the + * general postcopy path that has TLS channel enabled. + */ + qtest_add_func("/migration/postcopy/tls/psk", test_postcopy_tls_ps= k); + qtest_add_func("/migration/postcopy/recovery/tls/psk", + test_postcopy_recovery_tls_psk); + qtest_add_func("/migration/postcopy/preempt/tls/psk", + test_postcopy_preempt_tls_psk); + qtest_add_func("/migration/postcopy/preempt/recovery/tls/psk", + test_postcopy_preempt_all); + } #ifdef CONFIG_TASN1 qtest_add_func("/migration/precopy/unix/tls/x509/default-host", test_precopy_unix_tls_x509_default_host); --=20 2.32.0