From nobody Tue Feb 10 02:50:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658422696; cv=none; d=zohomail.com; s=zohoarc; b=frQ0ujvHv91vgaLSPT9KspOJgSpa167xVNjIEsjTUv45S31mmsIO9wBYil9VhFMJ74oDRK3x9EnzJmiYXICGY5ljxnomLhF9FkS10OUOpaCe8STx4jCcDyJEmQCWNwhsy+V73Cy6yqGWLlBddZdniM+rB6TmH8t5eqM0EVcC3Xc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658422696; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lIiy2W0UWSf+venuSMAnZOIXKxtmR9w38gfoPwZXYYY=; b=Fz38/7e8E7oQhVsANeVFXNBU4w4rlnLSCInKVcZZJnQj6dp6CY6G1Qttagpk7rbnFVzvHfWrozU7/0yNxKBhUavnNVWFZHN9rzDbo5SiKPenjgPl/Y62BRpl/wI70qQrrFrNjjwOFdzHGDrEJk98oFmIGOJSC088RQfiEUKvPkI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658422696711893.897813237525; Thu, 21 Jul 2022 09:58:16 -0700 (PDT) Received: from localhost ([::1]:45906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEZV8-0006Th-5Y for importer@patchew.org; Thu, 21 Jul 2022 12:58:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEZHB-0001qi-AN for qemu-devel@nongnu.org; Thu, 21 Jul 2022 12:43:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEZH8-0000Yg-MJ for qemu-devel@nongnu.org; Thu, 21 Jul 2022 12:43:47 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-247-A2bdxE7NPluUIKCx0PZOmw-1; Thu, 21 Jul 2022 12:43:42 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBCE229DD996; Thu, 21 Jul 2022 16:43:41 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31FA240D2962; Thu, 21 Jul 2022 16:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658421826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lIiy2W0UWSf+venuSMAnZOIXKxtmR9w38gfoPwZXYYY=; b=CGAQHwLapyGmC1D/s+2+T+6Hv57aocHokGnnn7aWWTXj84CFRFu5Gv3P6T2z1jJ8SOnzQO OpT7yfSTDhNd0GtPplSSonrwa5EU6+oxopJ/zQwu7msweJCBmYOrHiUDJE5EWgzEzc/ta2 SZnpKdOaIQhhd5QgpBnaE/BlaxvC47s= X-MC-Unique: A2bdxE7NPluUIKCx0PZOmw-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Gautam Dawar , Zhu Lingshan , Cornelia Huck , Jason Wang , Stefan Hajnoczi , Harpreet Singh Anand , Stefano Garzarella , Cindy Lu , Liuxiangdong , Parav Pandit , Eli Cohen , "Gonglei (Arei)" , "Michael S. Tsirkin" , Laurent Vivier Subject: [PATCH 2/6] vdpa: Use v->shadow_vqs_enabled in vhost_vdpa_svqs_start Date: Thu, 21 Jul 2022 18:43:27 +0200 Message-Id: <20220721164331.3328625-3-eperezma@redhat.com> In-Reply-To: <20220721164331.3328625-1-eperezma@redhat.com> References: <20220721164331.3328625-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658422698674100001 This function used to trust in v->shadow_vqs !=3D NULL to know if it must start svq or not. This is not going to be valid anymore, as qemu is going to allocate svq unconditionally (but it will only start them conditionally). Signed-off-by: Eugenio P=C3=A9rez --- hw/virtio/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 9a2daef7e3..29f8262e29 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -1019,7 +1019,7 @@ static bool vhost_vdpa_svqs_start(struct vhost_dev *d= ev) Error *err =3D NULL; unsigned i; =20 - if (!v->shadow_vqs) { + if (!v->shadow_vqs_enabled) { return true; } =20 --=20 2.31.1