From nobody Mon Apr 29 18:17:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658415204; cv=none; d=zohomail.com; s=zohoarc; b=X33MIzuIBFViNYi3qLHe6vqyBTjqNxD6bqtVrRFj7w69glTsXRm1YQHZWasN2REZXs8QbcTnV/ILHPj7RyJuryRpx7xV4/fBBUM3KXK7g+ZpN6J2eZ788ep4p2FptGVDsSgck7ssw5xQztJANgPoj9fEZgNTh89+sPknDZ3CXE0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658415204; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IE2seZL3x2Www6erRXlPQ9VA2PPtiiWtp2rXYtsXqyI=; b=cG+vgUAYTk1ocAnO/j6dMMAT9vSZVUsWXIuJ2PmPkR6iYUetHZsfUrT2rfjIjzJJlLjbNfpAfYQF08k+Vl6RSnsaF98hLSDzOyajCD+uQWrigei4+M7tM/1dVTH+JRwcC6K2J1xe8Si9ztlhCPaj4M6q6xoMC+B+51e2VfOg7Cg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658415204126325.32949816302676; Thu, 21 Jul 2022 07:53:24 -0700 (PDT) Received: from localhost ([::1]:54298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEXYI-0005zj-Ne for importer@patchew.org; Thu, 21 Jul 2022 10:53:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oERMa-0005qe-CI for qemu-devel@nongnu.org; Thu, 21 Jul 2022 04:16:58 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:45895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oERMX-00043o-9g for qemu-devel@nongnu.org; Thu, 21 Jul 2022 04:16:50 -0400 Received: by mail-pl1-x62f.google.com with SMTP id w7so1102509ply.12 for ; Thu, 21 Jul 2022 01:16:48 -0700 (PDT) Received: from alanjian85-Vostro-5490.. (36-227-58-102.dynamic-ip.hinet.net. [36.227.58.102]) by smtp.gmail.com with ESMTPSA id o71-20020a62cd4a000000b00528d11c26f2sm1054006pfg.1.2022.07.21.01.16.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 01:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IE2seZL3x2Www6erRXlPQ9VA2PPtiiWtp2rXYtsXqyI=; b=m1jj3LygaOuMhZ3gfR63I2AWGAK0FWAFbGt+Z8A7gFco7RothLOJaB04k7JFzLi1kb fXXFo3ZOb8OyTqR1gE7OrfniS092ZIgynB/PagVB0rucemOWDfv23EqRWjYXRqT7P2wq FkKFJ0mtkXdUfrxjiQ8hBY3ugqrK1adGq258s2gHeaqDqKAp11UwLxbOVFB0NJpHSjhT dWwkDBj/RM1AOPCNIYxYIfTcRUdIlPZEcTB6oJPBhvhZzAppNj0ZZExVHii+60nbp0LD BgPjBIQAax1jD+2z5xXAlALqAYw/VE9lRNLO0ItP0VkreCSdQ31cvNmKTHo7OqoC2ns+ Ne1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IE2seZL3x2Www6erRXlPQ9VA2PPtiiWtp2rXYtsXqyI=; b=KwRdnWIj+xWJA3YXMB8zNzojYy6B+J1p3cwixcwH+rFNnSBYlZeZrzgJ5j4+0Ro6nN S+JTtivVnc/3Tylf0+cDxf3+vHiROfsXI+Bqf/9uZcFEeBL3rFqmKPziEIHbBOfOINbt 2JKYsAlbkTFHngv8wzMLFmE+Tru7KUMPM3eXHJ/sNhmd2377Vu28qnWaJiCHKiQ3+OIW 4Ws1dZoTS50ES/ZM9Dy+TVSHBMSXjL/pbHk2Dy6WndVMG9u2tR2ECom07JGAfgOuC5+4 ziR/OMcayBgk+Ie9xoMP4Y6MQID4/FyHB3n2Fnpx0JgNoum8rQA2+aKJ+1TQbN7oqjGG gRaQ== X-Gm-Message-State: AJIora+vgIaxHn8yv5u7XSTS2Qb67uqS9eqZRx6S+KA7kth6Rb8vc0t9 JE5lUaGV72cMnUy5FWbeQdyd5Z2TSs8= X-Google-Smtp-Source: AGRyM1vulSjyODDjiv4bf4RU02szjC1tRg/LI/aCt4WcuJnpGRxmGtMVqeATn3wvhCrOSX+1y25ixQ== X-Received: by 2002:a17:90b:3d04:b0:1f0:693f:69c8 with SMTP id pt4-20020a17090b3d0400b001f0693f69c8mr10014585pjb.188.1658391407282; Thu, 21 Jul 2022 01:16:47 -0700 (PDT) From: alanjian85 X-Google-Original-From: alanjian85 To: qemu-devel@nongnu.org Cc: alanjian85 Subject: [PATCH] hw/display/bcm2835_fb: Remove unnecessary offset Date: Thu, 21 Jul 2022 16:15:44 +0800 Message-Id: <20220721081544.38228-1-alanjian85@outlook.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=alanjian85@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 21 Jul 2022 10:50:32 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1658415206599100001 Content-Type: text/plain; charset="utf-8" This patch fixes the framebuffer mailbox interface(marked as deprecated in official docs, but can still be fixed for emulation purposes) by removing unneeded offset to make it works like buffer allocate tag in bcm2835_property interface[1], some baremetal applications like the Screen01/Screen02 examples from Baking Pi tutorial[2] didn't work before this patch. [1] https://github.com/qemu/qemu/blob/master/hw/misc/bcm2835_property.c#L158 [2] https://www.cl.cam.ac.uk/projects/raspberrypi/tutorials/os/screen01.html Signed-off-by: alanjian85 --- hw/display/bcm2835_fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index 088fc3d51c..a05277674f 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -279,8 +279,7 @@ static void bcm2835_fb_mbox_push(BCM2835FBState *s, uin= t32_t value) newconf.xoffset =3D ldl_le_phys(&s->dma_as, value + 24); newconf.yoffset =3D ldl_le_phys(&s->dma_as, value + 28); =20 - newconf.base =3D s->vcram_base | (value & 0xc0000000); - newconf.base +=3D BCM2835_FB_OFFSET; + newconf.base =3D s->vcram_base + BCM2835_FB_OFFSET; =20 /* Copy fields which we don't want to change from the existing config = */ newconf.pixo =3D s->config.pixo; --=20 2.34.1