From nobody Mon Feb 9 10:43:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bytedance.com ARC-Seal: i=1; a=rsa-sha256; t=1658217905; cv=none; d=zohomail.com; s=zohoarc; b=atPAow5XVF10L3F9sm6reK6HXQVlAlc5sKYFkgfVAZWZNWJpBuBMab0e4lOOzGXi1cuklJ6AEm7QPjsFfKzbbzhc+hmIcETeoTQvJWUmFGqGa4nqaaV+cGCyRap3wEOThPvX/EBA22TAf9GEXFQKUuIOcniyiCKN4WOSnJUhR8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658217905; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=2pFY0fHeDSrWmFGa24W8cymcmr9ZbawTu6Ym3r4zaf8=; b=fKlEx7cWSRHc0YFTaF/nqEFzDEOHERjce/EsYEZPjUO1XrIFTOAAKwVB1NHbyjn81mqwf3JxWlj+RA36HBYcA+Xwk5sH8ivcpLD0Zjumg8QhplF6jIzIAjwlSN9M8wBmdniMYY5hojQPEi7oKKPtGUQE8sqeygd2xTbMULPw8vM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16582179049921006.0177050592025; Tue, 19 Jul 2022 01:05:04 -0700 (PDT) Received: from localhost ([::1]:38654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDiE3-0005j3-RP for importer@patchew.org; Tue, 19 Jul 2022 04:05:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDiA5-0001J2-B9 for qemu-devel@nongnu.org; Tue, 19 Jul 2022 04:00:59 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:42517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDi9x-0003KD-4y for qemu-devel@nongnu.org; Tue, 19 Jul 2022 04:00:53 -0400 Received: by mail-pl1-x62a.google.com with SMTP id 5so11253172plk.9 for ; Tue, 19 Jul 2022 01:00:48 -0700 (PDT) Received: from always-x1.bytedance.net ([61.120.150.70]) by smtp.gmail.com with ESMTPSA id x2-20020a17090a294200b001f20d9a547asm43941pjf.22.2022.07.19.01.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 01:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2pFY0fHeDSrWmFGa24W8cymcmr9ZbawTu6Ym3r4zaf8=; b=W6HZXvxZs2mbkfBtpRb457yLCC4B5XASbxVR8Pd35MFNIi8zZ5lGIyfoH5WBj+6Gyt spQrmQZzT9Gy1BPG0r1HF5o8oJETBVc+PysAZfUvRSRehLog7OuNli9+jx7bDNdjlw1T Untd4/Ke+eOo506z9B44DwtfkQJgetGILQ6xlPzyhSzrW11gAZHz5bre+sQEQZf0sku6 tzW0MhM2hhg1Py/LnNnsAVABjucpG09AtBcojpsYg5PG2Y4Y1rN0Jq596mwguTGq8Eew TMM1suFADuXbjKy3LG1yxVM5VdT7k+tTuTQaq87tTaRHECClGwiybZO75PCuEaLfywzI ZHGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2pFY0fHeDSrWmFGa24W8cymcmr9ZbawTu6Ym3r4zaf8=; b=xxToXBRmqM2ENWQxq51K3PPWcXLTQDIYTudtPk6yjvw1pNDV9251UvFPWhD3AflFNC leAe0PZsVNhZixIVMM7fUEEWf/BY/cK+I3Rr1CJRyZqsDwnixUJqUSC67aUDL5Tg6O84 26+KITIDOtZWAsctQEYqfcwxZVdB14gA1n0bwT/WOxXxP7+esEmeE1VbrHhhtN62A5Sg X1Smm/5QGs0IGYoGMcbvm/w01rpg/86O1lCsZWJq3exviKyzJ/6TGFn6vctEVhXeXZSw HCrVwIPby9RA0l9NVM5YMkkDVtFhBTu6STtEb746DjSlM+hL4tGCMYKgCjHEjHR9Y+fe cxeg== X-Gm-Message-State: AJIora9QVHm2CwzOQLipd2C4tZr5mUH4IjINSOkmXMEoHHVwwrphgmN3 Aks3Mp9T/PnZ/ILlywj5CwxiBg== X-Google-Smtp-Source: AGRyM1utFhsuEtTpNa4UFhveKO9p4FD1M2nkhNZMoTnbDF0GLJAzC7O1JO6WthssAZDjPAuwjrOldA== X-Received: by 2002:a17:902:dacb:b0:16c:4f39:f846 with SMTP id q11-20020a170902dacb00b0016c4f39f846mr30485544plx.169.1658217647168; Tue, 19 Jul 2022 01:00:47 -0700 (PDT) From: zhenwei pi To: dgilbert@redhat.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, zhenwei pi Subject: [PATCH] monitor: Support specified vCPU registers Date: Tue, 19 Jul 2022 15:55:44 +0800 Message-Id: <20220719075544.932927-1-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=pizhenwei@bytedance.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bytedance-com.20210112.gappssmtp.com) X-ZM-MESSAGEID: 1658217908148100001 Content-Type: text/plain; charset="utf-8" Originally we have to get all the vCPU registers and parse the specified one. To improve the performance of this usage, allow user specified vCPU id to query registers. Run a VM with 16 vCPU, use bcc tool to track the latency of 'hmp_info_registers': 'info registers -a' uses about 3ms; 'info register 12' uses about 150us. Signed-off-by: zhenwei pi --- hmp-commands-info.hx | 6 +++--- monitor/misc.c | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 3ffa24bd67..6023e2b5c5 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -100,9 +100,9 @@ ERST =20 { .name =3D "registers", - .args_type =3D "cpustate_all:-a", - .params =3D "[-a]", - .help =3D "show the cpu registers (-a: all - show register i= nfo for all cpus)", + .args_type =3D "cpustate_all:-a,vcpu:i?", + .params =3D "[-a] [vcpu]", + .help =3D "show the cpu registers (-a: all - show register i= nfo for all cpus; vcpu: vCPU to query)", .cmd =3D hmp_info_registers, }, =20 diff --git a/monitor/misc.c b/monitor/misc.c index 3d2312ba8d..b12309faad 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -307,6 +307,7 @@ int monitor_get_cpu_index(Monitor *mon) static void hmp_info_registers(Monitor *mon, const QDict *qdict) { bool all_cpus =3D qdict_get_try_bool(qdict, "cpustate_all", false); + int vcpu =3D qdict_get_try_int(qdict, "vcpu", -1); CPUState *cs; =20 if (all_cpus) { @@ -314,6 +315,24 @@ static void hmp_info_registers(Monitor *mon, const QDi= ct *qdict) monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); cpu_dump_state(cs, NULL, CPU_DUMP_FPU); } + } else if (vcpu >=3D 0) { + CPUState *target_cs =3D NULL; + + CPU_FOREACH(cs) { + if (cs->cpu_index =3D=3D vcpu) { + target_cs =3D cs; + break; + } + } + + if (!target_cs) { + monitor_printf(mon, "CPU#%d not available\n", vcpu); + return; + } + + monitor_printf(mon, "\nCPU#%d\n", target_cs->cpu_index); + cpu_dump_state(target_cs, NULL, CPU_DUMP_FPU); + return; } else { cs =3D mon_get_cpu(mon); =20 --=20 2.20.1