From nobody Mon Feb 9 05:41:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658214410; cv=none; d=zohomail.com; s=zohoarc; b=kH2GDczdGu2bf2rboNun+DVFu4NHNru+TMOzxEtoMdlq1g5AwDqYA7x9peUzOcCZXYaogR+Ky3gUotIdVoXxkui9oFXGjh2jSGtvgXRBHG76xxq/VzxjOu92NAfc0dt+iBk6Ng/EQN9NJrNEKzOsmB+jFPRFLXIuaoyoiwrmNHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658214410; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OI5mO5LZQ5/mmpwpAUKU/P6EZRhdpxebFDszEb7tRss=; b=Ilii3MEJpEa4vQJSqBHpqjUtFXoY775EhkaniB+AvP9gOdiZ5xhswUPVmddSc9OjmdMRTfKCNcmt6S2a3LaoBfIUYnu2YPXNfc3ihJEoJmw8S1760AWQVuvv3gWlS7tmapsGp1aDbDkPf5pJGi0WUuAaeW6lF8qznlNBAygoVvA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658214410024893.6128200814436; Tue, 19 Jul 2022 00:06:50 -0700 (PDT) Received: from localhost ([::1]:52570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDhJh-0004uT-1h for importer@patchew.org; Tue, 19 Jul 2022 03:06:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDhHM-00025I-Ui for qemu-devel@nongnu.org; Tue, 19 Jul 2022 03:04:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDhHL-0002yU-FK for qemu-devel@nongnu.org; Tue, 19 Jul 2022 03:04:24 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-298-Hx1-qLKHOU-kQyPv9s30sQ-1; Tue, 19 Jul 2022 03:04:15 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F58D85A585; Tue, 19 Jul 2022 07:04:15 +0000 (UTC) Received: from thuth.com (dhcp-192-183.str.redhat.com [10.33.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E02A404754B; Tue, 19 Jul 2022 07:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658214262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OI5mO5LZQ5/mmpwpAUKU/P6EZRhdpxebFDszEb7tRss=; b=L2wKk9v+EKjllRmsZ3TvR0tENRYliXy8SyMx/VF5qxxc5wo9aWEjr4hU67exVY4e9P5ZJC bJK6Ud4HFJMD4OytGzfL608gN5mGNFpQcTzgPxBoU4pkTA7aV7GL8zxmYVIwX6uk7LPB1L CZPZC45GZE6BCgC+Oru4Yw3iH/uvxIg= X-MC-Unique: Hx1-qLKHOU-kQyPv9s30sQ-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , John Snow , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 01/14] qga: treat get-guest-fsinfo as "best effort" Date: Tue, 19 Jul 2022 09:03:59 +0200 Message-Id: <20220719070412.16757-2-thuth@redhat.com> In-Reply-To: <20220719070412.16757-1-thuth@redhat.com> References: <20220719070412.16757-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658214411667100001 From: John Snow In some container environments, there may be references to block devices witnessable from a container through /proc/self/mountinfo that reference devices we simply don't have access to in the container, and cannot provide information about. Instead of failing the entire fsinfo command, return stub information for these failed lookups. This allows test-qga to pass under docker tests, which are in turn used by the CentOS VM tests. Signed-off-by: John Snow Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20220708153503.18864-2-jsnow@redhat.com> Signed-off-by: Thomas Huth --- qga/commands-posix.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index f18530d85f..954efed01b 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1207,7 +1207,15 @@ static void build_guest_fsinfo_for_device(char const= *devpath, =20 syspath =3D realpath(devpath, NULL); if (!syspath) { - error_setg_errno(errp, errno, "realpath(\"%s\")", devpath); + if (errno !=3D ENOENT) { + error_setg_errno(errp, errno, "realpath(\"%s\")", devpath); + return; + } + + /* ENOENT: This devpath may not exist because of container config = */ + if (!fs->name) { + fs->name =3D g_path_get_basename(devpath); + } return; } =20 --=20 2.31.1