From nobody Mon Feb 9 12:11:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657904692; cv=none; d=zohomail.com; s=zohoarc; b=JHLTqOg+Y5wJ9SBtz8bXaSiV+AqMAaqu6TGYi/4AEjvcWeq60f4XcXrEiPGly2Ng8rCemZDegvzWgN+69rIjvb8shhk1cLsPPPhfHSF5KfgUXH4sx8N7dvHPRHVAAXb088bxmttsL+g/CT8rCfLmv/+J2Q1MiKRT9bQFzHTQMkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657904692; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U1hBMVHisBrZHGpm8qv4V6Mxqwev3omPk0lBwMdbg9s=; b=mKJScieCoZvTSXZHFRnc4Om7fcW6I3qWw8ubbaWfeEzGp7Wb+KjkzwqLbleHRm/G0AbnQf8xyNd+TJfDTuwQ+WVSs47lBC68ePoCEy1EDf9UTRmIfpOlDe/wjbGgLVnQGlVKGSiPI5uarxlZk4U/Be+qjUi1gGAy1FohlssRyLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165790469269728.92548173294631; Fri, 15 Jul 2022 10:04:52 -0700 (PDT) Received: from localhost ([::1]:53914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCOkE-0002iS-8C for importer@patchew.org; Fri, 15 Jul 2022 13:04:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCOiU-0000bP-5p for qemu-devel@nongnu.org; Fri, 15 Jul 2022 13:03:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCOiQ-0003ea-1g for qemu-devel@nongnu.org; Fri, 15 Jul 2022 13:03:00 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-hfdSvlUuN-Oi3XY9eQm9-A-1; Fri, 15 Jul 2022 13:02:55 -0400 Received: by mail-ej1-f72.google.com with SMTP id sb15-20020a1709076d8f00b0072b692d938cso1693264ejc.10 for ; Fri, 15 Jul 2022 10:02:55 -0700 (PDT) Received: from goa-sendmail ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.gmail.com with ESMTPSA id h7-20020a170906828700b0072321c99b78sm2194983ejx.57.2022.07.15.10.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 10:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657904577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1hBMVHisBrZHGpm8qv4V6Mxqwev3omPk0lBwMdbg9s=; b=cD3hjUadV7+F81i7lT08XF/hTG63eoGprbCC+ih9uiqHWJPI/dn/HQIPfSTxYdu5sPPswZ WKt7srtdgsPPgmxEx9pQ8ju8px6XRUtoGfvz80LlEug2o7H+/Lg9oTP/nZIRZxIn32e+vO qBr+MwQlKAJ+879dwgSM8NGWWJBsmmE= X-MC-Unique: hfdSvlUuN-Oi3XY9eQm9-A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U1hBMVHisBrZHGpm8qv4V6Mxqwev3omPk0lBwMdbg9s=; b=PmLlENSI8Ch+aIPryZYeACLTuhc7Z5jcmZilTEDpWvoCEOP4+/L+JtyJF4POk4X1MN IMnwQDMF/kQprK3elaV0obvf2Kdh0n+mAhTXz4no8ljchaU6kvaQ9iVy0od0QpwkighY HK1QREo5OqwEvUw0WYBMbSA8zOE6yx9Epl0fvowjI6Cw2NbtGPqcc69BU2XmeLBK0oyY Aks6gdxN9lt4HWsMpaiZWMuReOHpJ4iiruz8zAVQkkKb9Cx5mwT/C89I6PBAK5e6nYy1 dYDX5WwfGhn8cFYayw6hXQBfC0NRHe00kzAW2fezWGShWX3Zb6XrEbF5opKzo8h8xXsQ 0+iw== X-Gm-Message-State: AJIora9cZ8YEZBTdqb+gMOW3Bzw+XfZiU1P5crVqPnZ9l1872ygUNrKA 6rdJMA1R2VRiYQk8cLXJ7GcOcr/OTfiYzJ3H/IZZZC5ic5QA8jjE+gU+4n2vjstHJrt+bQoe7Tn OJanmrwzHXjqqUKuHwF2kZBKAyD5AB1s3uSemHm2SgEIVoU6gmIUktGv3R5eHJssU1vA= X-Received: by 2002:aa7:c392:0:b0:43b:1f5c:391f with SMTP id k18-20020aa7c392000000b0043b1f5c391fmr12051766edq.267.1657904574138; Fri, 15 Jul 2022 10:02:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vHDRTns0Si5r5SymWLvR8FiQ7qGTHPUfJwgB2n2MizBl3szg0zi9Z4p9anZ8rgaB1YxxpHLQ== X-Received: by 2002:aa7:c392:0:b0:43b:1f5c:391f with SMTP id k18-20020aa7c392000000b0043b1f5c391fmr12051722edq.267.1657904573838; Fri, 15 Jul 2022 10:02:53 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: natto@weirdnatto.in Subject: [PATCH 1/2] monitor: add support for boolean statistics Date: Fri, 15 Jul 2022 19:02:48 +0200 Message-Id: <20220715170249.404786-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220715170249.404786-1-pbonzini@redhat.com> References: <20220715170249.404786-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657904693639100002 Content-Type: text/plain; charset="utf-8" The next version of Linux will introduce boolean statistics, which can only have 0 or 1 values. Support them in the schema and in the HMP command. Suggested-by: Amneesh Singh Signed-off-by: Paolo Bonzini --- monitor/hmp-cmds.c | 2 ++ qapi/stats.json | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index ca98df0495..e8d6963722 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2337,6 +2337,8 @@ static void print_stats_results(Monitor *mon, StatsTa= rget target, =20 if (stats_value->type =3D=3D QTYPE_QNUM) { monitor_printf(mon, ": %" PRId64 "\n", stats_value->u.scalar); + } else if (stats_value->type =3D=3D QTYPE_QBOOL) { + monitor_printf(mon, ": %s\n", stats_value->u.boolean ? "yes" := "no"); } else if (stats_value->type =3D=3D QTYPE_QLIST) { uint64List *list; int i; diff --git a/qapi/stats.json b/qapi/stats.json index 2f8bfe8fdb..cb6456c67a 100644 --- a/qapi/stats.json +++ b/qapi/stats.json @@ -38,11 +38,12 @@ # @bytes: stat reported in bytes. # @seconds: stat reported in seconds. # @cycles: stat reported in clock cycles. +# @cycles: stat is a boolean value. # # Since: 7.1 ## { 'enum' : 'StatsUnit', - 'data' : [ 'bytes', 'seconds', 'cycles' ] } + 'data' : [ 'bytes', 'seconds', 'cycles', 'boolean' ] } =20 ## # @StatsProvider: @@ -123,6 +124,7 @@ ## { 'alternate': 'StatsValue', 'data': { 'scalar': 'uint64', + 'boolean': 'bool', 'list': [ 'uint64' ] } } =20 ## --=20 2.36.1 From nobody Mon Feb 9 12:11:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657904690; cv=none; d=zohomail.com; s=zohoarc; b=TC7VU5THlUuLH6DN+xenXNSxRVu4n/Oc0IGwMqUNk5pskA9nofFkQGnsO4SKPvFhKwsBX2nbf2uAsigbFlMpVnLQ4JmZtrk4erSgNBu7WHQQAaTCr/40GKTvD4xriDXpZrRsflA5wSmpoY46mXzMQLqvtA8iSiFIx//SRIsjIwM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657904690; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RHdWC55cUPvE5A/T86wNKaY1/bkuZbeyxYtfxnHKD7k=; b=Gf3zHVi/EuOzOO4EP2S57AIvIzlu7iddb90m3Sngt2qq0D0VBCHcpdTsNRLlu/korxD6jH6ibQIODW/F7zJKRuAPRp+2decKx46ktp5xRCAedm0xJ4cepX/87cjOw8JHqICrDZKYWApZdy+b2JzkXT49XIhTVgb2g132TiPQBJU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657904690047225.56042453188206; Fri, 15 Jul 2022 10:04:50 -0700 (PDT) Received: from localhost ([::1]:53702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCOkC-0002ZI-0v for importer@patchew.org; Fri, 15 Jul 2022 13:04:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCOiT-0000bR-8o for qemu-devel@nongnu.org; Fri, 15 Jul 2022 13:03:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCOiQ-0003ee-Mc for qemu-devel@nongnu.org; Fri, 15 Jul 2022 13:03:00 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-CIt04sX0OzSwQo55f6kBQA-1; Fri, 15 Jul 2022 13:02:57 -0400 Received: by mail-ej1-f71.google.com with SMTP id qb28-20020a1709077e9c00b0072af6ccc1aeso1669686ejc.6 for ; Fri, 15 Jul 2022 10:02:56 -0700 (PDT) Received: from goa-sendmail ([93.56.169.184]) by smtp.gmail.com with ESMTPSA id f21-20020a17090631d500b0072ee7b51d9asm1678653ejf.39.2022.07.15.10.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 10:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657904578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RHdWC55cUPvE5A/T86wNKaY1/bkuZbeyxYtfxnHKD7k=; b=f0I5waNkidTr0ygV1kOkBEWuNGIFXj9bgl5XDdt5nEOTpN3vi8odCpndP0Z3krFpHGna3u BdrVkVGSkK6jNV5el5PPbj+/q7dae5fLN/6NNhFu839vgFd3yqyiDjNEzKHKvJPxoD/jTl zVt6T2visO7qHNztuHN8T2EIiBElx34= X-MC-Unique: CIt04sX0OzSwQo55f6kBQA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RHdWC55cUPvE5A/T86wNKaY1/bkuZbeyxYtfxnHKD7k=; b=NjfdKN20Vv08jLO6i9WTrd+JcUCSzmicyH2m8sDg+L3lwoJ/+DPdqLcS/4AH/Eg6Qu +iRPX5Kh2HKExFNk31H1I9SL83rTkaCxjY2JPg3tfV9gI0Ak5wPoy8HkIQN2jVK2z1D4 BXsTz77mgHusT+qlRIPI6fsnIyg87n8UFbW1aefCj7e0n4M6FavtTquYLjXBgwggCED6 paNeerLMpOfrT3eUvOsEVwRx9bTLzTPrMmOQFGXGZRvECo00ts8UGxzCpLtei4Gx0psB eIBXnMK5Id8Bz8KvMQInzvxgTpopUaeO54kRI1AJziAmRg5beSk1lN716M4Fphm+UKY6 57dg== X-Gm-Message-State: AJIora9TRnHC5nW+0GY9a7ebFOymzx+EbNpjx/gNtpIfLfQt95iRc0Hk XBGf8cKHRTY2VrqAfR0Br7M5ibCd3adsiYOg6z3D3bzidBmo9UGy2HRriaU5mUAl+3v7XNKd52c 1OVJriCnkLT+1bjP06FMhu8JtuiTllQrwFz36yGFAwqEmFKsWrjoFz4djan80c+bHMdc= X-Received: by 2002:a17:906:cc52:b0:72b:114e:c56c with SMTP id mm18-20020a170906cc5200b0072b114ec56cmr14641289ejb.144.1657904575502; Fri, 15 Jul 2022 10:02:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tCFvvkghCvPGHuCsca25QiJVQaIDwvgw9GiNU5K6ItEosvlVxKcZkh+SR0Z6EZxYmEu7hGFw== X-Received: by 2002:a17:906:cc52:b0:72b:114e:c56c with SMTP id mm18-20020a170906cc5200b0072b114ec56cmr14641260ejb.144.1657904575096; Fri, 15 Jul 2022 10:02:55 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: natto@weirdnatto.in Subject: [PATCH 2/2] kvm: add support for boolean statistics Date: Fri, 15 Jul 2022 19:02:49 +0200 Message-Id: <20220715170249.404786-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220715170249.404786-1-pbonzini@redhat.com> References: <20220715170249.404786-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657904691410100001 Content-Type: text/plain; charset="utf-8" The next version of Linux will introduce boolean statistics, which can only have 0 or 1 values. Convert them to the new QAPI fields added in the previous commit. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 10 +++++++++- linux-headers/linux/kvm.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ed8b6b896e..3a2677d065 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3743,6 +3743,7 @@ static StatsList *add_kvmstat_entry(struct kvm_stats_= desc *pdesc, case KVM_STATS_UNIT_BYTES: case KVM_STATS_UNIT_CYCLES: case KVM_STATS_UNIT_SECONDS: + case KVM_STATS_UNIT_BOOLEAN: break; default: return stats_list; @@ -3761,7 +3762,10 @@ static StatsList *add_kvmstat_entry(struct kvm_stats= _desc *pdesc, stats->name =3D g_strdup(pdesc->name); stats->value =3D g_new0(StatsValue, 1);; =20 - if (pdesc->size =3D=3D 1) { + if ((pdesc->flags & KVM_STATS_UNIT_MASK) =3D=3D KVM_STATS_UNIT_BOOLEAN= ) { + stats->value->u.boolean =3D *stats_data; + stats->value->type =3D QTYPE_QBOOL; + } else if (pdesc->size =3D=3D 1) { stats->value->u.scalar =3D *stats_data; stats->value->type =3D QTYPE_QNUM; } else { @@ -3809,6 +3813,10 @@ static StatsSchemaValueList *add_kvmschema_entry(str= uct kvm_stats_desc *pdesc, switch (pdesc->flags & KVM_STATS_UNIT_MASK) { case KVM_STATS_UNIT_NONE: break; + case KVM_STATS_UNIT_BOOLEAN: + schema_entry->value->has_unit =3D true; + schema_entry->value->unit =3D STATS_UNIT_BOOLEAN; + break; case KVM_STATS_UNIT_BYTES: schema_entry->value->has_unit =3D true; schema_entry->value->unit =3D STATS_UNIT_BYTES; diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 0d05d02ee4..f089349149 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm.h @@ -2031,6 +2031,7 @@ struct kvm_stats_header { #define KVM_STATS_UNIT_BYTES (0x1 << KVM_STATS_UNIT_SHIFT) #define KVM_STATS_UNIT_SECONDS (0x2 << KVM_STATS_UNIT_SHIFT) #define KVM_STATS_UNIT_CYCLES (0x3 << KVM_STATS_UNIT_SHIFT) +#define KVM_STATS_UNIT_BOOLEAN (0x4 << KVM_STATS_UNIT_SHIFT) #define KVM_STATS_UNIT_MAX KVM_STATS_UNIT_CYCLES =20 #define KVM_STATS_BASE_SHIFT 8 --=20 2.36.1