From nobody Mon Feb 9 00:43:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657811443; cv=none; d=zohomail.com; s=zohoarc; b=iotRPQv11VkH2l8/UoEN3zdxIgkh4CUWKLKJnldYmwbzd5WUuIgvdQsVvqrXsHy/TPsj1W4Zt/s595EOurQkSAVjvkIakxpNChrFCCqP/45rnEqGTl2IrbkS2j+GD4ZXixnj3sp/CMrpgFuExZSTEt3/EspeA9VyOVucR2hFX18= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657811443; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xHlnVLDD50+AMq+R96FEN4NDKh0OfZSxWHH0hVRtk0U=; b=HkKnUNocVWU4K3T9XF+lMyEynqd5HJiuXTSHlLg3aY/TQolBTUrvOkUGFX0YFzU82R6skdfnATQJbOvspkAh77/vOyLVc3tLMo2IJp6TcnJbykwbLaWlaX1JwjSWqSNIkrbKk+SZk7gITtscOR/Orcq8dmj1D33lTs+vniZkuY4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165781144300745.24991132161881; Thu, 14 Jul 2022 08:10:43 -0700 (PDT) Received: from localhost ([::1]:42802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC0UD-0008Cx-UZ for importer@patchew.org; Thu, 14 Jul 2022 11:10:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0RV-0005MT-Nw for qemu-devel@nongnu.org; Thu, 14 Jul 2022 11:07:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27136) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0RQ-0000Ri-08 for qemu-devel@nongnu.org; Thu, 14 Jul 2022 11:07:52 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-4Fy5zrzQNhKQdGr1GFDFhA-1; Thu, 14 Jul 2022 11:07:43 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 35EDC85A588; Thu, 14 Jul 2022 15:07:43 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D3F82166B26; Thu, 14 Jul 2022 15:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657811267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xHlnVLDD50+AMq+R96FEN4NDKh0OfZSxWHH0hVRtk0U=; b=FL2Q/ryrJXtASIGoqEgG66N+vntgsWTwIO7UwaokPGtlncGyDxsontzgFlJ8xqCQXqMbnS thXFjnfiHb7s5W1nTSO+duiadOW0IHE/i6+39hJ188lSc0nE0ssZWHu5LQywbwZ2yz0R5A UK2FumnAFesnrOGkUHHfqk1JBe9LdA0= X-MC-Unique: 4Fy5zrzQNhKQdGr1GFDFhA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, David Hildenbrand , Cornelia Huck , Richard Henderson , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/3] target/i386: display deprecation note in '-cpu help' Date: Thu, 14 Jul 2022 16:07:33 +0100 Message-Id: <20220714150735.1835166-2-berrange@redhat.com> In-Reply-To: <20220714150735.1835166-1-berrange@redhat.com> References: <20220714150735.1835166-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657811443450100001 The deprecation notes are currently only displayed at runtime when the user activates a CPU. The QMP query displays a simple flag for deprecation, while '-cpu help' displays nothing unless the deprecation info is duplicated into the 'notes' field. This changes the code so that deprecation notes are explicitly shown in '-cpu help', to assist the user in deciding what to use. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Cornelia Huck --- target/i386/cpu.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 6a57ef13af..a2c5dcfc04 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4833,10 +4833,21 @@ static void x86_cpu_list_entry(gpointer data, gpoin= ter user_data) if (!desc && cc->model && cc->model->note) { desc =3D g_strdup_printf("%s [%s]", model_id, cc->model->note); } - if (!desc) { + if (!desc && *model_id) { desc =3D g_strdup_printf("%s", model_id); } =20 + if (cc->model && cc->model->cpudef->deprecation_note) { + g_autofree char *dep =3D g_strdup_printf( + "(deprecated: %s)", cc->model->cpudef->deprecation_note); + if (desc) { + g_autofree char *olddesc =3D desc; + desc =3D g_strdup_printf("%s %s", olddesc, dep); + } else { + desc =3D g_steal_pointer(&dep); + } + } + qemu_printf("x86 %-20s %s\n", name, desc); } =20 --=20 2.36.1 From nobody Mon Feb 9 00:43:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657812290; cv=none; d=zohomail.com; s=zohoarc; b=SbnNUyjvLwqg4AObZSmmfRFmSC/Fej7phTZoF5xUQdicRtmPcOoEPoZUBQvOmli6BH+8/NDiOYlc3JpRKeY1uaCuj5yn+CVUeQkSZFZNxooLpD/RAucvn8MVcQjOwv7zhy6k4+A9xHLs6P6TatlrzTQsIPt3hMBFDbkdmukw8/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657812290; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dColUxJGXatxAW9Q/XH5UGoAXbui4Yt+06VbLyvRHCY=; b=c4z82fZBB+3I7a716JLJrF9I+/iQvIs18tFm60DjWIOrfnFOrVlmyDzFVLbO3jiu6gVfghG+zKKs7Fl3xyAtA/U9pg638tWRXjgbqSUyQNjN0cj2JHOQIrn+fA0/W6vV0AjMXyjxTQm/jvG/GrOA+JvDxn4zZk16xWepBt2mHro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657812290024941.627364089017; Thu, 14 Jul 2022 08:24:50 -0700 (PDT) Received: from localhost ([::1]:34232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC0hs-0005be-Ti for importer@patchew.org; Thu, 14 Jul 2022 11:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0Rk-00062O-3K for qemu-devel@nongnu.org; Thu, 14 Jul 2022 11:08:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:46052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0RS-0000SF-ST for qemu-devel@nongnu.org; Thu, 14 Jul 2022 11:08:07 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-JoSsyUByN6KKKiywZqlCjA-1; Thu, 14 Jul 2022 11:07:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 548AD85A589; Thu, 14 Jul 2022 15:07:45 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 907CB2166B26; Thu, 14 Jul 2022 15:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657811270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dColUxJGXatxAW9Q/XH5UGoAXbui4Yt+06VbLyvRHCY=; b=MEIuNs7F/AmIkkl3VggKRE2ebck0cOL6B3qPP/aQse0w+pw30MmtVq+SXeMlxI/m4yZaPa G2fHAyPuAYN2Rko25gavH3uTL4YT8pds1BRGNMJci+XMWMDSgmPDqB6Jhk83Z5zNHmZMLi zbkV+teD/33FylbD+v5zONcc1VNCwUs= X-MC-Unique: JoSsyUByN6KKKiywZqlCjA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, David Hildenbrand , Cornelia Huck , Richard Henderson , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/3] target/s390x: display deprecation note in '-cpu help' Date: Thu, 14 Jul 2022 16:07:34 +0100 Message-Id: <20220714150735.1835166-3-berrange@redhat.com> In-Reply-To: <20220714150735.1835166-1-berrange@redhat.com> References: <20220714150735.1835166-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657812291797100001 The deprecation notes are currently only displayed at runtime when the user activates a CPU. The QMP query displays a simple flag for deprecation, while '-cpu help' displays nothing unless the deprecation info is duplicated into the 'notes' field. This changes the code so that deprecation notes are explicitly shown in '-cpu help', to assist the user in deciding what to use. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Cornelia Huck --- target/s390x/cpu_models.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 1a562d2801..a04375896d 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -334,18 +334,36 @@ const S390CPUDef *s390_find_cpu_def(uint16_t type, ui= nt8_t gen, uint8_t ec_ga, static void s390_print_cpu_model_list_entry(gpointer data, gpointer user_d= ata) { const S390CPUClass *scc =3D S390_CPU_CLASS((ObjectClass *)data); + CPUClass *cc =3D CPU_CLASS(scc); char *name =3D g_strdup(object_class_get_name((ObjectClass *)data)); - const char *details =3D ""; + g_autoptr(GString) details =3D g_string_new("("); =20 if (scc->is_static) { - details =3D "(static, migration-safe)"; - } else if (scc->is_migration_safe) { - details =3D "(migration-safe)"; + g_string_append(details, "static"); + } + if (scc->is_migration_safe) { + if (details->len > 1) { + g_string_append(details, ", "); + } + g_string_append(details, "migration-safe"); + } + if (cc->deprecation_note) { + if (details->len > 1) { + g_string_append(details, ", "); + } + g_string_append(details, "deprecated: "); + g_string_append(details, cc->deprecation_note); + } + if (details->len > 1) { + g_string_append(details, ")"); + } + if (details->len =3D=3D 1) { + g_string_truncate(details, 0); } =20 /* strip off the -s390x-cpu */ g_strrstr(name, "-" TYPE_S390_CPU)[0] =3D 0; - qemu_printf("s390 %-15s %-35s %s\n", name, scc->desc, details); + qemu_printf("s390 %-15s %-35s %s\n", name, scc->desc, details->str); g_free(name); } =20 --=20 2.36.1 From nobody Mon Feb 9 00:43:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657812176; cv=none; d=zohomail.com; s=zohoarc; b=OG6q0HDr+xOxFX6/vHHnZbBU0IYdPsscl26B6llU3WD193il6qhLX655Kb/ycZCLKjxgNbKMfWwaLJSVjZi0dWpFgTGT6AM37xgpHQxJFtorkpEQZVXLpT1jAYFO+1mByBmEevuaiyTW5H90yGl5rqVL8Ppj73VW6OUHmU3Qpco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657812176; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yIEKp4A/euRwpuaAoyZCuunfabQKRWXCvWPVhNg11Os=; b=haEtxPmNvYB/kuaSYEM5NdTQbarK6vfMYSk+LUavJptMs5HSpz6ZgMbB2I+VIKZ8KYI/VR0juBI/b2QZhFP5oiucsTYeTAzllnn+Qh1utPCRBA78Gs9aOu7O43TB1QQePjPJJ4Qpa1qreDL1ob2dQY4UDqqP0Og55nJY3DX+HZc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657812176672226.96692127086044; Thu, 14 Jul 2022 08:22:56 -0700 (PDT) Received: from localhost ([::1]:58224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC0g2-0002fe-TY for importer@patchew.org; Thu, 14 Jul 2022 11:22:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0RX-0005Rd-9J for qemu-devel@nongnu.org; Thu, 14 Jul 2022 11:07:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:55849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC0RT-0000SJ-40 for qemu-devel@nongnu.org; Thu, 14 Jul 2022 11:07:54 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-GFH_VTacMpaoLRqyq5-QQg-1; Thu, 14 Jul 2022 11:07:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E48C31C05AE0; Thu, 14 Jul 2022 15:07:46 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C9E02166B26; Thu, 14 Jul 2022 15:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657811270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIEKp4A/euRwpuaAoyZCuunfabQKRWXCvWPVhNg11Os=; b=NYTjkNec045WL+n0gTS+qqoeIdqrI938aBb8jK/P9L1DHmrh53qsxNuOJir3F7+0OYb+yG /BBPJy0QKGmW/HmjzsVQ3rDhO4bORHipc27lzXH2KDLO09ROHTreuejziT8YAX1VM0X4tL FAahdzM1PLc4SUy4kX1s8cRigS/IFrE= X-MC-Unique: GFH_VTacMpaoLRqyq5-QQg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, David Hildenbrand , Cornelia Huck , Richard Henderson , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 3/3] target/arm: display deprecation note in '-cpu help' Date: Thu, 14 Jul 2022 16:07:35 +0100 Message-Id: <20220714150735.1835166-4-berrange@redhat.com> In-Reply-To: <20220714150735.1835166-1-berrange@redhat.com> References: <20220714150735.1835166-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657812177268100003 The deprecation notes are currently only displayed at runtime when the user activates a CPU. The QMP query displays a simple flag for deprecation, while '-cpu help' displays nothing unless the deprecation info is duplicated into the 'notes' field. This changes the code so that deprecation notes are explicitly shown in '-cpu help', to assist the user in deciding what to use. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Cornelia Huck --- target/arm/helper.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index cfcad97ce0..1a0988d8fc 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8222,12 +8222,20 @@ static gint arm_cpu_list_compare(gconstpointer a, g= constpointer b) static void arm_cpu_list_entry(gpointer data, gpointer user_data) { ObjectClass *oc =3D data; + CPUClass *cc =3D CPU_CLASS(oc); const char *typename; char *name; + g_autofree char *details =3D NULL; + + if (cc->deprecation_note) { + details =3D g_strdup_printf(" (deprecated: %s)", cc->deprecation_n= ote); + } else { + details =3D g_strdup(""); + } =20 typename =3D object_class_get_name(oc); name =3D g_strndup(typename, strlen(typename) - strlen("-" TYPE_ARM_CP= U)); - qemu_printf(" %s\n", name); + qemu_printf(" %s%s\n", name, details); g_free(name); } =20 --=20 2.36.1