From nobody Wed Dec 17 05:39:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657649831; cv=none; d=zohomail.com; s=zohoarc; b=TlvMUO9I/602upqk04btFQ4OGe55A4ob5jxX6tZjrizz/F9hijUP4l+cmZMdL6Crq2gL4Sp1g00x+jI6ppN1NyHK+xkB99BjBJTqDNoour+44HX0dsVTp0L8TM2He3Fn9+YkNO4Ev1w/xnma+12Rb7rf3tHpDtI5K1sKdRcRuc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657649831; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QBmGXqomM6EhnsPEF7zObu5OPXwCH2wsrAu/mJBtFhc=; b=PMaf6Yg82BEsm6nCOfr4Vjne8dxJK30o4b3lxCFrRKKr1izlR4AXsKTGgpBIQHR9okjjECFN4stvIRvHc53vhHGDo0Kao9DixL9Wr0A11YPkPBi7tLkMqW9dXgwlGdsmnOU2Eh4e83r5xknL7q5aj110UPLhgy5mh0mUdTMvkSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657649831122115.10496930083264; Tue, 12 Jul 2022 11:17:11 -0700 (PDT) Received: from localhost ([::1]:33118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBKRZ-00027G-Mp for importer@patchew.org; Tue, 12 Jul 2022 14:17:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBKHS-0003HP-8c for qemu-devel@nongnu.org; Tue, 12 Jul 2022 14:06:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBKHQ-0006XT-4w for qemu-devel@nongnu.org; Tue, 12 Jul 2022 14:06:41 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-474-Rzya2hu7OYuu6onAXC601w-1; Tue, 12 Jul 2022 14:06:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A0D8802D1F; Tue, 12 Jul 2022 18:06:37 +0000 (UTC) Received: from localhost (unknown [10.39.193.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3997B2166B26; Tue, 12 Jul 2022 18:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657649199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QBmGXqomM6EhnsPEF7zObu5OPXwCH2wsrAu/mJBtFhc=; b=TULAsE0u2OHiaKHerN1s27Yfcm4ElDUtdU1AGhG0J2KOucevIJERTYaegoRO0nAoG02JXz ZjKbYot4J4+h9ewaVZM3wYK2ZOnGumljFP8ELqplKSOYcKKmdjII0FOAiN7c/dV3OnWIyo TfzlxGNXHwSHazMQtxQIFDnrZvQUKqE= X-MC-Unique: Rzya2hu7OYuu6onAXC601w-1 From: Hanna Reitz To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Hanna Reitz Subject: [PULL 10/35] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty() Date: Tue, 12 Jul 2022 20:05:52 +0200 Message-Id: <20220712180617.1362407-11-hreitz@redhat.com> In-Reply-To: <20220712180617.1362407-1-hreitz@redhat.com> References: <20220712180617.1362407-1-hreitz@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657649832361100001 Content-Type: text/plain; charset="utf-8" From: Alberto Faria Use bdrv_pwrite_sync() instead of calling bdrv_pwrite() and bdrv_flush() separately. Signed-off-by: Alberto Faria Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-Id: <20220609152744.3891847-11-afaria@redhat.com> Reviewed-by: Hanna Reitz Signed-off-by: Hanna Reitz --- block/qcow2.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index f2fb54c51f..90a2dd406b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -516,12 +516,9 @@ int qcow2_mark_dirty(BlockDriverState *bs) } =20 val =3D cpu_to_be64(s->incompatible_features | QCOW2_INCOMPAT_DIRTY); - ret =3D bdrv_pwrite(bs->file, offsetof(QCowHeader, incompatible_featur= es), - sizeof(val), &val, 0); - if (ret < 0) { - return ret; - } - ret =3D bdrv_flush(bs->file->bs); + ret =3D bdrv_pwrite_sync(bs->file, + offsetof(QCowHeader, incompatible_features), + sizeof(val), &val, 0); if (ret < 0) { return ret; } --=20 2.35.3