From nobody Sat May 10 00:00:40 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
 permitted sender)
  smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
	dmarc=pass(p=none dis=none)  header.from=linaro.org
ARC-Seal: i=1; a=rsa-sha256; t=1657549430; cv=none;
	d=zohomail.com; s=zohoarc;
	b=Cqogn/qrqff+bwlFJBv8I4NcP7SAyIf7WKgpiv3Rx5z8zdj5uM/K9kka1Ndc7fO8050WNAqD/WXSJ92f3mt38XvAiXZgtyznjSf5GZrPMtwzZOEE7gIFZTf4H5d0915Ds4dm5XEDsvHaNh5cCh+f5Csf/yeHKJ43dGdzKHwglpc=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc;
	t=1657549430;
 h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=wLF084Ezdzf2ZLeUWRpU2I0inK+HajABcj7tU1hY7is=;
	b=SkXP242R9EW9XG9/kWLYNTyVgHvg8dRuVBW+MeZ5uUjV51ph3UQMxC0kDO0ckv4Fj/Ac6Try5jGseBoeJ/xLzFmlWQKtQCK9Box5pFFv6qMMZsIr8G7jHZpThgBtygZDOAHX/GNBESjI65DY5NKmdSyRHtRnsYSIeZFjeC9Fis0=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
 permitted sender)
  smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
	dmarc=pass header.from=<peter.maydell@linaro.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
 mx.zohomail.com
	with SMTPS id 16575494303921021.509591495095;
 Mon, 11 Jul 2022 07:23:50 -0700 (PDT)
Received: from localhost ([::1]:58318 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <qemu-devel-bounces+importer=patchew.org@nongnu.org>)
	id 1oAuKD-0005jo-A7
	for importer@patchew.org; Mon, 11 Jul 2022 10:23:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42956)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
 id 1oAtvf-0006dg-5w
 for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:28 -0400
Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37551)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
 id 1oAtvV-0002sV-EH
 for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:25 -0400
Received: by mail-wr1-x432.google.com with SMTP id r10so972173wrv.4
 for <qemu-devel@nongnu.org>; Mon, 11 Jul 2022 06:58:15 -0700 (PDT)
Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])
 by smtp.gmail.com with ESMTPSA id
 q123-20020a1c4381000000b00397402ae674sm7595596wma.11.2022.07.11.06.58.14
 for <qemu-devel@nongnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 11 Jul 2022 06:58:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=wLF084Ezdzf2ZLeUWRpU2I0inK+HajABcj7tU1hY7is=;
 b=g1lx7ooML7P7W/t+Y9qQnAL5svtDlOKVmWuwWkfpQyX/UtjLhUBzUNtAdZ7QYAM9hJ
 iFaQOKccnc1iFqGtsrbsYc/nVhgBKv8FCtvtnGRqHCwOTB/75y3Sk1oQ/ML7Do79eM9V
 U7RlPh7CxCveDGFVs9c+oRtnNZQYFnUHgcqKEDkt0y3ZA4RBCNfqS49NtfIYNS5i/LDR
 WlQWAWpW5qSRWuVKXFOYDf4tZFlTQug4mEGZCWJrolSji7u0PBT3+7CY8pKBaLTqGiNF
 TbYEC/9v7NkOnDyM9C2PB9Wy2joH3X4SPCY8cfyJzVbhC26kzadMFLbKFUUsq2Hp/9N6
 hr8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=wLF084Ezdzf2ZLeUWRpU2I0inK+HajABcj7tU1hY7is=;
 b=M6QUq7Z5OlOt2bfcACB2N1yV2K+0bdGfldKFX9XtmgP8BS/wWiRK5DxMG2+QAfjndt
 OYWrVBdDgspKnC0xVjcd5LCv1qwbeV/719bcS0wJOD42kyAYVcTOYJknSNWfB7TIUPIH
 hyMv4L/alULsKveqJ12ICXIYVWuPLc3Ltf5F6NLRf/oopV4Oa5OdsXf0a0NwUwwoW0X2
 4/LwIU0xZgBqCAZWhpJKH7F6kL2eJoQKPN+ad8DY89jH+O9LPrQufas4T538nbBEarzT
 Hfbqz9g+EqELQ4bHKSgPfZV0tYQZ4OVwu9eutZrag3ErdEYPUCHhMWS48xx+pB+y3o7y
 uxkw==
X-Gm-Message-State: AJIora93p6sEF2RGfcFJcgdQ8gVm8zN8gdkA0SN1X4XnlxNtxJUz00YR
 usjQchYybCyQPc9oQxRuOgnLbhpVxZcSsg==
X-Google-Smtp-Source: 
 AGRyM1t2ctr0VeBu2ljQnwkLJKkLLG776zaOfo+jOk+tlP3b2Tof5i4/td2Zs8qQn9uLsKP+IJHQjQ==
X-Received: by 2002:adf:dc0d:0:b0:21d:ea5:710f with SMTP id
 t13-20020adfdc0d000000b0021d0ea5710fmr17031328wri.48.1657547894981;
 Mon, 11 Jul 2022 06:58:14 -0700 (PDT)
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 27/45] target/arm: Implement SME integer outer product
Date: Mon, 11 Jul 2022 14:57:32 +0100
Message-Id: <20220711135750.765803-28-peter.maydell@linaro.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220711135750.765803-1-peter.maydell@linaro.org>
References: <20220711135750.765803-1-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
 as permitted sender) client-ip=209.51.188.17;
 envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
 helo=lists.gnu.org;
Received-SPF: pass client-ip=2a00:1450:4864:20::432;
 envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+importer=patchew.org@nongnu.org>
X-ZohoMail-DKIM: pass (identity @linaro.org)
X-ZM-MESSAGEID: 1657549431303100002
Content-Type: text/plain; charset="utf-8"

From: Richard Henderson <richard.henderson@linaro.org>

This is SMOPA, SUMOPA, USMOPA_s, UMOPA, for both Int8 and Int16.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220708151540.18136-28-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper-sme.h    | 16 ++++++++
 target/arm/sme.decode      | 10 +++++
 target/arm/sme_helper.c    | 82 ++++++++++++++++++++++++++++++++++++++
 target/arm/translate-sme.c | 10 +++++
 4 files changed, 118 insertions(+)

diff --git a/target/arm/helper-sme.h b/target/arm/helper-sme.h
index 4d5d05db3a0..d2d544a6961 100644
--- a/target/arm/helper-sme.h
+++ b/target/arm/helper-sme.h
@@ -129,3 +129,19 @@ DEF_HELPER_FLAGS_7(sme_fmopa_d, TCG_CALL_NO_RWG,
                    void, ptr, ptr, ptr, ptr, ptr, ptr, i32)
 DEF_HELPER_FLAGS_6(sme_bfmopa, TCG_CALL_NO_RWG,
                    void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_smopa_s, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_umopa_s, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_sumopa_s, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_usmopa_s, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_smopa_d, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_umopa_d, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_sumopa_d, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_6(sme_usmopa_d, TCG_CALL_NO_RWG,
+                   void, ptr, ptr, ptr, ptr, ptr, i32)
diff --git a/target/arm/sme.decode b/target/arm/sme.decode
index e8d27fd8a0e..628804e37a8 100644
--- a/target/arm/sme.decode
+++ b/target/arm/sme.decode
@@ -76,3 +76,13 @@ FMOPA_d         10000000 110 ..... ... ... ..... . 0 ...=
        @op_64
=20
 BFMOPA          10000001 100 ..... ... ... ..... . 00 ..        @op_32
 FMOPA_h         10000001 101 ..... ... ... ..... . 00 ..        @op_32
+
+SMOPA_s         1010000 0 10 0 ..... ... ... ..... . 00 ..      @op_32
+SUMOPA_s        1010000 0 10 1 ..... ... ... ..... . 00 ..      @op_32
+USMOPA_s        1010000 1 10 0 ..... ... ... ..... . 00 ..      @op_32
+UMOPA_s         1010000 1 10 1 ..... ... ... ..... . 00 ..      @op_32
+
+SMOPA_d         1010000 0 11 0 ..... ... ... ..... . 0 ...      @op_64
+SUMOPA_d        1010000 0 11 1 ..... ... ... ..... . 0 ...      @op_64
+USMOPA_d        1010000 1 11 0 ..... ... ... ..... . 0 ...      @op_64
+UMOPA_d         1010000 1 11 1 ..... ... ... ..... . 0 ...      @op_64
diff --git a/target/arm/sme_helper.c b/target/arm/sme_helper.c
index 302f89c30b3..f891306bb98 100644
--- a/target/arm/sme_helper.c
+++ b/target/arm/sme_helper.c
@@ -1117,3 +1117,85 @@ void HELPER(sme_bfmopa)(void *vza, void *vzn, void *=
vzm, void *vpn,
         } while (row & 15);
     }
 }
+
+typedef uint64_t IMOPFn(uint64_t, uint64_t, uint64_t, uint8_t, bool);
+
+static inline void do_imopa(uint64_t *za, uint64_t *zn, uint64_t *zm,
+                            uint8_t *pn, uint8_t *pm,
+                            uint32_t desc, IMOPFn *fn)
+{
+    intptr_t row, col, oprsz =3D simd_oprsz(desc) / 8;
+    bool neg =3D simd_data(desc);
+
+    for (row =3D 0; row < oprsz; ++row) {
+        uint8_t pa =3D pn[H1(row)];
+        uint64_t *za_row =3D &za[tile_vslice_index(row)];
+        uint64_t n =3D zn[row];
+
+        for (col =3D 0; col < oprsz; ++col) {
+            uint8_t pb =3D pm[H1(col)];
+            uint64_t *a =3D &za_row[col];
+
+            *a =3D fn(n, zm[col], *a, pa & pb, neg);
+        }
+    }
+}
+
+#define DEF_IMOP_32(NAME, NTYPE, MTYPE) \
+static uint64_t NAME(uint64_t n, uint64_t m, uint64_t a, uint8_t p, bool n=
eg) \
+{                                                                         =
  \
+    uint32_t sum0 =3D 0, sum1 =3D 0;                                      =
      \
+    /* Apply P to N as a mask, making the inactive elements 0. */         =
  \
+    n &=3D expand_pred_b(p);                                              =
    \
+    sum0 +=3D (NTYPE)(n >> 0) * (MTYPE)(m >> 0);                          =
    \
+    sum0 +=3D (NTYPE)(n >> 8) * (MTYPE)(m >> 8);                          =
    \
+    sum0 +=3D (NTYPE)(n >> 16) * (MTYPE)(m >> 16);                        =
    \
+    sum0 +=3D (NTYPE)(n >> 24) * (MTYPE)(m >> 24);                        =
    \
+    sum1 +=3D (NTYPE)(n >> 32) * (MTYPE)(m >> 32);                        =
    \
+    sum1 +=3D (NTYPE)(n >> 40) * (MTYPE)(m >> 40);                        =
    \
+    sum1 +=3D (NTYPE)(n >> 48) * (MTYPE)(m >> 48);                        =
    \
+    sum1 +=3D (NTYPE)(n >> 56) * (MTYPE)(m >> 56);                        =
    \
+    if (neg) {                                                            =
  \
+        sum0 =3D (uint32_t)a - sum0, sum1 =3D (uint32_t)(a >> 32) - sum1; =
      \
+    } else {                                                              =
  \
+        sum0 =3D (uint32_t)a + sum0, sum1 =3D (uint32_t)(a >> 32) + sum1; =
      \
+    }                                                                     =
  \
+    return ((uint64_t)sum1 << 32) | sum0;                                 =
  \
+}
+
+#define DEF_IMOP_64(NAME, NTYPE, MTYPE) \
+static uint64_t NAME(uint64_t n, uint64_t m, uint64_t a, uint8_t p, bool n=
eg) \
+{                                                                         =
  \
+    uint64_t sum =3D 0;                                                   =
    \
+    /* Apply P to N as a mask, making the inactive elements 0. */         =
  \
+    n &=3D expand_pred_h(p);                                              =
    \
+    sum +=3D (NTYPE)(n >> 0) * (MTYPE)(m >> 0);                           =
    \
+    sum +=3D (NTYPE)(n >> 16) * (MTYPE)(m >> 16);                         =
    \
+    sum +=3D (NTYPE)(n >> 32) * (MTYPE)(m >> 32);                         =
    \
+    sum +=3D (NTYPE)(n >> 48) * (MTYPE)(m >> 48);                         =
    \
+    return neg ? a - sum : a + sum;                                       =
  \
+}
+
+DEF_IMOP_32(smopa_s, int8_t, int8_t)
+DEF_IMOP_32(umopa_s, uint8_t, uint8_t)
+DEF_IMOP_32(sumopa_s, int8_t, uint8_t)
+DEF_IMOP_32(usmopa_s, uint8_t, int8_t)
+
+DEF_IMOP_64(smopa_d, int16_t, int16_t)
+DEF_IMOP_64(umopa_d, uint16_t, uint16_t)
+DEF_IMOP_64(sumopa_d, int16_t, uint16_t)
+DEF_IMOP_64(usmopa_d, uint16_t, int16_t)
+
+#define DEF_IMOPH(NAME) \
+    void HELPER(sme_##NAME)(void *vza, void *vzn, void *vzm, void *vpn,   =
   \
+                            void *vpm, uint32_t desc)                     =
   \
+    { do_imopa(vza, vzn, vzm, vpn, vpm, desc, NAME); }
+
+DEF_IMOPH(smopa_s)
+DEF_IMOPH(umopa_s)
+DEF_IMOPH(sumopa_s)
+DEF_IMOPH(usmopa_s)
+DEF_IMOPH(smopa_d)
+DEF_IMOPH(umopa_d)
+DEF_IMOPH(sumopa_d)
+DEF_IMOPH(usmopa_d)
diff --git a/target/arm/translate-sme.c b/target/arm/translate-sme.c
index c2953b22ce3..7b87a9df63c 100644
--- a/target/arm/translate-sme.c
+++ b/target/arm/translate-sme.c
@@ -361,3 +361,13 @@ TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, =
a, MO_64, gen_helper_sme_f
=20
 /* TODO: FEAT_EBF16 */
 TRANS_FEAT(BFMOPA, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_bfmopa)
+
+TRANS_FEAT(SMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_smopa_s)
+TRANS_FEAT(UMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_umopa_s)
+TRANS_FEAT(SUMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_sumopa=
_s)
+TRANS_FEAT(USMOPA_s, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_usmopa=
_s)
+
+TRANS_FEAT(SMOPA_d, aa64_sme_i16i64, do_outprod, a, MO_64, gen_helper_sme_=
smopa_d)
+TRANS_FEAT(UMOPA_d, aa64_sme_i16i64, do_outprod, a, MO_64, gen_helper_sme_=
umopa_d)
+TRANS_FEAT(SUMOPA_d, aa64_sme_i16i64, do_outprod, a, MO_64, gen_helper_sme=
_sumopa_d)
+TRANS_FEAT(USMOPA_d, aa64_sme_i16i64, do_outprod, a, MO_64, gen_helper_sme=
_usmopa_d)
--=20
2.25.1