From nobody Fri May  9 12:09:58 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
 permitted sender)
  smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
	dmarc=pass(p=none dis=none)  header.from=linaro.org
ARC-Seal: i=1; a=rsa-sha256; t=1657549864; cv=none;
	d=zohomail.com; s=zohoarc;
	b=A8oIzi35DR4a9AlZiZbVEwHN2OAAepwFEDZNy9Rw3trnVFN7Z/uawie5UajOGSJBmZeYadM2XDr/+sXCz0sxUYgvbfD3Ml1FppGPDP573aPBq1N41ouhE/J7PnbSyb2a1HEafUkRO4SBqE0rEPxg8zCXngYFR3Thd9+M05pdr+o=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc;
	t=1657549864;
 h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=Jrs2Elt6zkurq1tlTCd5KnpdSWVFVT+ucLNxgSmBuew=;
	b=Wgyyggp8ebfIi5GJcbzxgOAtHUU16nG0l2ZWaI5NKuAbuuIKjJF3BPR37czR0a9TSwLd7cGuwiTQFymrLaNsrmQWS1euZdyRyL4WcRXwPbC4CHCJPq5gszhb+Nj57SmXakExF/OQNghlfq7AmIkBlWgj+9KTvxWqOvfLN4a64ak=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass;
	spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
 permitted sender)
  smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
	dmarc=pass header.from=<peter.maydell@linaro.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
 mx.zohomail.com
	with SMTPS id 1657549864040910.2633431231704;
 Mon, 11 Jul 2022 07:31:04 -0700 (PDT)
Received: from localhost ([::1]:41904 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <qemu-devel-bounces+importer=patchew.org@nongnu.org>)
	id 1oAuRC-0006qp-TV
	for importer@patchew.org; Mon, 11 Jul 2022 10:31:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42750)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
 id 1oAtvV-0006Z1-PA
 for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:18 -0400
Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37550)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
 id 1oAtvS-0002qz-CY
 for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:17 -0400
Received: by mail-wr1-x432.google.com with SMTP id r10so971997wrv.4
 for <qemu-devel@nongnu.org>; Mon, 11 Jul 2022 06:58:12 -0700 (PDT)
Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])
 by smtp.gmail.com with ESMTPSA id
 q123-20020a1c4381000000b00397402ae674sm7595596wma.11.2022.07.11.06.58.11
 for <qemu-devel@nongnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 11 Jul 2022 06:58:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=from:to:subject:date:message-id:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=Jrs2Elt6zkurq1tlTCd5KnpdSWVFVT+ucLNxgSmBuew=;
 b=GT8KSd6fxDz6IApczFfCTGtQBw2Q7iijiLM2gM6E+KAiHsOH9986wGqM8SF816/rDA
 XgNwqpblKttN+tW6TjyaTRpuMy40MsHSeo1+NTpZxSB7qR9Xgxh0hrtWUl8rfqZAI3ZU
 ZMd72BVY/3Ig3fZCZaPxdKvz/y1Am2Dn7IEvbGr4rxYkjC3k1ItH8/npd6DzjxBBea68
 M2k+cEo+/lsuQkMghiMrdVVtccO6tGxstvO8+gEqWVZqkgCkrABZctcozwndvl11S9yC
 xA8GeaTvbApvWXA/iJqv6miJX1vwhiOcxU/mQxlUcnHkGWwuguhpWjvWLQlK2ojV62Nb
 /Grw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Jrs2Elt6zkurq1tlTCd5KnpdSWVFVT+ucLNxgSmBuew=;
 b=e0/mNvSRAu0uaPr1JloSQyF+ArM1a4wsYze5bmKPaz20RP2jZtR2brmLhXu5W68Jb5
 ewFOXRMHy5Dl+WGCNjwyKEqBPrqLI+PyZzMEJgTBJx0MUTYWFBD3E4qX6cLB0a/CjhlK
 vtrtnnyGTkbnZcFZizn6R4TMi9tTyNUOWv0zt3CO9oOvkjB0YOHs8oJdpiXlTH0X11Am
 8dufvjsQkcqjZ3f265i5Y//AZKChW8/drLpQiNgKGPLnvx1bk1ugQUs8+awOnjNYyGPP
 yghhsVwwS+Fhc8ePHjIIq38TNRYjuf9RLmvaYZBNlyPrzjAQLzukYTj0tFFeIH22DZC5
 sPJg==
X-Gm-Message-State: AJIora/uxapHApd8LeeBTNIUk/HmbeSi1vCrIu+WRTbxNubCy0NJa0A5
 uGL0zDvlSxigtEjLo42pURbcV8b8z1AmZA==
X-Google-Smtp-Source: 
 AGRyM1vQJZtokbRVFd7CGK6XAvJxHWWY3rvIdlhxh0QVIT8WIMWhgAXu0Ru1DQxmhPzm8/I+wdsSyQ==
X-Received: by 2002:a05:6000:81e:b0:21d:8811:777b with SMTP id
 bt30-20020a056000081e00b0021d8811777bmr17166950wrb.647.1657547891731;
 Mon, 11 Jul 2022 06:58:11 -0700 (PDT)
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 23/45] target/arm: Implement SME ADDHA, ADDVA
Date: Mon, 11 Jul 2022 14:57:28 +0100
Message-Id: <20220711135750.765803-24-peter.maydell@linaro.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220711135750.765803-1-peter.maydell@linaro.org>
References: <20220711135750.765803-1-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
 as permitted sender) client-ip=209.51.188.17;
 envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
 helo=lists.gnu.org;
Received-SPF: pass client-ip=2a00:1450:4864:20::432;
 envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+importer=patchew.org@nongnu.org>
X-ZohoMail-DKIM: pass (identity @linaro.org)
X-ZM-MESSAGEID: 1657549865985100001
Content-Type: text/plain; charset="utf-8"

From: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220708151540.18136-24-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper-sme.h    |  5 +++
 target/arm/sme.decode      | 11 +++++
 target/arm/sme_helper.c    | 90 ++++++++++++++++++++++++++++++++++++++
 target/arm/translate-sme.c | 31 +++++++++++++
 4 files changed, 137 insertions(+)

diff --git a/target/arm/helper-sme.h b/target/arm/helper-sme.h
index 95f6e88bdd4..753e9e624cc 100644
--- a/target/arm/helper-sme.h
+++ b/target/arm/helper-sme.h
@@ -115,3 +115,8 @@ DEF_HELPER_FLAGS_5(sme_st1q_be_h_mte, TCG_CALL_NO_WG, v=
oid, env, ptr, ptr, tl, i
 DEF_HELPER_FLAGS_5(sme_st1q_le_h_mte, TCG_CALL_NO_WG, void, env, ptr, ptr,=
 tl, i32)
 DEF_HELPER_FLAGS_5(sme_st1q_be_v_mte, TCG_CALL_NO_WG, void, env, ptr, ptr,=
 tl, i32)
 DEF_HELPER_FLAGS_5(sme_st1q_le_v_mte, TCG_CALL_NO_WG, void, env, ptr, ptr,=
 tl, i32)
+
+DEF_HELPER_FLAGS_5(sme_addha_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,=
 i32)
+DEF_HELPER_FLAGS_5(sme_addva_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,=
 i32)
+DEF_HELPER_FLAGS_5(sme_addha_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,=
 i32)
+DEF_HELPER_FLAGS_5(sme_addva_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr,=
 i32)
diff --git a/target/arm/sme.decode b/target/arm/sme.decode
index f1ebd857a57..8cb6c4053c3 100644
--- a/target/arm/sme.decode
+++ b/target/arm/sme.decode
@@ -53,3 +53,14 @@ LDST1           1110000 111     st:1 rm:5 v:1 .. pg:3 rn=
:5 0 za_imm:4  \
=20
 LDR             1110000 100 0 000000 .. 000 ..... 0 ....        @ldstr
 STR             1110000 100 1 000000 .. 000 ..... 0 ....        @ldstr
+
+### SME Add Vector to Array
+
+&adda           zad zn pm pn
+@adda_32        ........ .. ..... . pm:3 pn:3 zn:5 ... zad:2    &adda
+@adda_64        ........ .. ..... . pm:3 pn:3 zn:5 ..  zad:3    &adda
+
+ADDHA_s         11000000 10 01000 0 ... ... ..... 000 ..        @adda_32
+ADDVA_s         11000000 10 01000 1 ... ... ..... 000 ..        @adda_32
+ADDHA_d         11000000 11 01000 0 ... ... ..... 00 ...        @adda_64
+ADDVA_d         11000000 11 01000 1 ... ... ..... 00 ...        @adda_64
diff --git a/target/arm/sme_helper.c b/target/arm/sme_helper.c
index 10fd1ed910d..f1e924db748 100644
--- a/target/arm/sme_helper.c
+++ b/target/arm/sme_helper.c
@@ -828,3 +828,93 @@ DO_ST(q, _be, MO_128)
 DO_ST(q, _le, MO_128)
=20
 #undef DO_ST
+
+void HELPER(sme_addha_s)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz =3D simd_oprsz(desc) / 4;
+    uint64_t *pn =3D vpn, *pm =3D vpm;
+    uint32_t *zda =3D vzda, *zn =3D vzn;
+
+    for (row =3D 0; row < oprsz; ) {
+        uint64_t pa =3D pn[row >> 4];
+        do {
+            if (pa & 1) {
+                for (col =3D 0; col < oprsz; ) {
+                    uint64_t pb =3D pm[col >> 4];
+                    do {
+                        if (pb & 1) {
+                            zda[tile_vslice_index(row) + H4(col)] +=3D zn[=
H4(col)];
+                        }
+                        pb >>=3D 4;
+                    } while (++col & 15);
+                }
+            }
+            pa >>=3D 4;
+        } while (++row & 15);
+    }
+}
+
+void HELPER(sme_addha_d)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz =3D simd_oprsz(desc) / 8;
+    uint8_t *pn =3D vpn, *pm =3D vpm;
+    uint64_t *zda =3D vzda, *zn =3D vzn;
+
+    for (row =3D 0; row < oprsz; ++row) {
+        if (pn[H1(row)] & 1) {
+            for (col =3D 0; col < oprsz; ++col) {
+                if (pm[H1(col)] & 1) {
+                    zda[tile_vslice_index(row) + col] +=3D zn[col];
+                }
+            }
+        }
+    }
+}
+
+void HELPER(sme_addva_s)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz =3D simd_oprsz(desc) / 4;
+    uint64_t *pn =3D vpn, *pm =3D vpm;
+    uint32_t *zda =3D vzda, *zn =3D vzn;
+
+    for (row =3D 0; row < oprsz; ) {
+        uint64_t pa =3D pn[row >> 4];
+        do {
+            if (pa & 1) {
+                uint32_t zn_row =3D zn[H4(row)];
+                for (col =3D 0; col < oprsz; ) {
+                    uint64_t pb =3D pm[col >> 4];
+                    do {
+                        if (pb & 1) {
+                            zda[tile_vslice_index(row) + H4(col)] +=3D zn_=
row;
+                        }
+                        pb >>=3D 4;
+                    } while (++col & 15);
+                }
+            }
+            pa >>=3D 4;
+        } while (++row & 15);
+    }
+}
+
+void HELPER(sme_addva_d)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz =3D simd_oprsz(desc) / 8;
+    uint8_t *pn =3D vpn, *pm =3D vpm;
+    uint64_t *zda =3D vzda, *zn =3D vzn;
+
+    for (row =3D 0; row < oprsz; ++row) {
+        if (pn[H1(row)] & 1) {
+            uint64_t zn_row =3D zn[row];
+            for (col =3D 0; col < oprsz; ++col) {
+                if (pm[H1(col)] & 1) {
+                    zda[tile_vslice_index(row) + col] +=3D zn_row;
+                }
+            }
+        }
+    }
+}
diff --git a/target/arm/translate-sme.c b/target/arm/translate-sme.c
index 35c26448125..d3b9cdd5c4b 100644
--- a/target/arm/translate-sme.c
+++ b/target/arm/translate-sme.c
@@ -267,3 +267,34 @@ static bool do_ldst_r(DisasContext *s, arg_ldstr *a, G=
enLdStR *fn)
=20
 TRANS_FEAT(LDR, aa64_sme, do_ldst_r, a, gen_sve_ldr)
 TRANS_FEAT(STR, aa64_sme, do_ldst_r, a, gen_sve_str)
+
+static bool do_adda(DisasContext *s, arg_adda *a, MemOp esz,
+                    gen_helper_gvec_4 *fn)
+{
+    int svl =3D streaming_vec_reg_size(s);
+    uint32_t desc =3D simd_desc(svl, svl, 0);
+    TCGv_ptr za, zn, pn, pm;
+
+    if (!sme_smza_enabled_check(s)) {
+        return true;
+    }
+
+    /* Sum XZR+zad to find ZAd. */
+    za =3D get_tile_rowcol(s, esz, 31, a->zad, false);
+    zn =3D vec_full_reg_ptr(s, a->zn);
+    pn =3D pred_full_reg_ptr(s, a->pn);
+    pm =3D pred_full_reg_ptr(s, a->pm);
+
+    fn(za, zn, pn, pm, tcg_constant_i32(desc));
+
+    tcg_temp_free_ptr(za);
+    tcg_temp_free_ptr(zn);
+    tcg_temp_free_ptr(pn);
+    tcg_temp_free_ptr(pm);
+    return true;
+}
+
+TRANS_FEAT(ADDHA_s, aa64_sme, do_adda, a, MO_32, gen_helper_sme_addha_s)
+TRANS_FEAT(ADDVA_s, aa64_sme, do_adda, a, MO_32, gen_helper_sme_addva_s)
+TRANS_FEAT(ADDHA_d, aa64_sme_i16i64, do_adda, a, MO_64, gen_helper_sme_add=
ha_d)
+TRANS_FEAT(ADDVA_d, aa64_sme_i16i64, do_adda, a, MO_64, gen_helper_sme_add=
va_d)
--=20
2.25.1