From nobody Mon Feb 9 09:22:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657212150; cv=none; d=zohomail.com; s=zohoarc; b=RmgzwVXNoj2W8TaL5Ym7EYr/7F6dAOlJDcLI9Quda1ymfpLbkcThHBk5IplOcMvqCztsH/S+yVXZROCH/lNh/1+cgPHMb5HvhCZRlX7gtHf/zIYp1tZ35D/NvFyuQBc0m2tnBV8EljZZOseJ8ELOgsCRX1O6Q45rkcjYNqTI42g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657212150; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=92ftO/Uz7aiapJeO9mt9EgQoLeAj8kyjXGC5hIrV/4w=; b=Xy08INNoiVLjUvU51SGWsv/iPaMHY/t3P9yx8d0/YNyJ0pclhO/yxTesS6iGOYPsvINkr6Tz4Bso+JsLzauL/bUXv6a+vv/0wlrouTnqs+1x5LvcGvfKC9/ILAm+vA3Fo/jxnyJWUFazFwfW7LsJSWE30ZD631RwP/Yq5iTyZiM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657212150597499.10341812981005; Thu, 7 Jul 2022 09:42:30 -0700 (PDT) Received: from localhost ([::1]:45264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9UaC-0002vK-B9 for importer@patchew.org; Thu, 07 Jul 2022 12:42:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9UW2-0008TW-4s for qemu-devel@nongnu.org; Thu, 07 Jul 2022 12:38:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9UVp-0006p7-JI for qemu-devel@nongnu.org; Thu, 07 Jul 2022 12:38:05 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-TeflL_L-MOy-3Mt14G6zdQ-1; Thu, 07 Jul 2022 12:37:49 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 549EB383329C; Thu, 7 Jul 2022 16:37:28 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E091492C3B; Thu, 7 Jul 2022 16:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657211876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92ftO/Uz7aiapJeO9mt9EgQoLeAj8kyjXGC5hIrV/4w=; b=bkNE1Hytwpo6uq/FzMjjv8WYxx+VgmpL5l55gGLqJSLWiwI7S/wZoEPCEYQaGe5Ycr9eZ1 Lmc3mt+6QZLAgrFlMiwxn9VkFkvjzDMcjiNAg/52ygKbW/ChSM9pbXj+cWmHiRRK+VUEJS RJ+T6w7P/g44M8kdb31DTp93jPABCZo= X-MC-Unique: TeflL_L-MOy-3Mt14G6zdQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Blake , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v3 3/9] tests/style: check for mixups of bool constants with int variables Date: Thu, 7 Jul 2022 17:37:14 +0100 Message-Id: <20220707163720.1421716-4-berrange@redhat.com> In-Reply-To: <20220707163720.1421716-1-berrange@redhat.com> References: <20220707163720.1421716-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657212151202100003 The 'true' and 'false' constants should only ever be used with the 'bool' type, never 'int'. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/style.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/style.yml b/tests/style.yml index b4e7c6111f..704227d8e9 100644 --- a/tests/style.yml +++ b/tests/style.yml @@ -86,3 +86,8 @@ # A match added to the front of the regex. Useful when # 'terms' is a list of strings and a common prefix is # desired + +int_assign_bool: + files: \.c$ + prohibit: \.*=3D *(true|false)\b + message: use bool type for boolean values --=20 2.36.1