From nobody Sun Feb 8 04:34:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657136817; cv=none; d=zohomail.com; s=zohoarc; b=M/j0fE25AcAa3NBfmbNRjJT8ltQ58MR1vjUM00+3sSqej/AFJzMTdTXXUGzgL97zGw5PKzhTnns5We7lRW5QMY2S7VQr7F+l3xz/cR2i4bL3DQLLb6BZL8eXOOolqIeDTwtAJ0uSu9cVfOpBpFi9lznqbwb9OnuNsPvQR9Jnxz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657136817; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=P8HTBug/BrxsxU3MmDdqiWcYw9YTVPuLaNnZJgqOZMs=; b=KSfrk4j02ihgk9M2bb7gXT70qTKumyPzoYkRjDWnobuonA9OmXkIqThymT2QeCdCcvE6Dj5l0+UvqonrHx2AN9V9anMV1rtmWq8rk68R/8f+uwRosrKDchj9Y6yqT1kiQECKfMl1ZxlDJcXkdRP39edypXuhQLbifZ2DjgyIiL8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657136817962618.014668141776; Wed, 6 Jul 2022 12:46:57 -0700 (PDT) Received: from localhost ([::1]:49750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9AzA-0002Sb-3j for importer@patchew.org; Wed, 06 Jul 2022 15:46:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Akb-0003E2-Qs; Wed, 06 Jul 2022 15:31:56 -0400 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]:42904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9AkZ-00067E-Sv; Wed, 06 Jul 2022 15:31:53 -0400 Received: by mail-vs1-xe2b.google.com with SMTP id i186so16098743vsc.9; Wed, 06 Jul 2022 12:31:51 -0700 (PDT) Received: from balboa.ibmuc.com (201-27-97-88.dsl.telesp.net.br. [201.27.97.88]) by smtp.gmail.com with ESMTPSA id p2-20020ab01ec2000000b003828ebf6b49sm6034791uak.4.2022.07.06.12.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 12:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P8HTBug/BrxsxU3MmDdqiWcYw9YTVPuLaNnZJgqOZMs=; b=Q9T30x9UymmZ7zMV4mzTVkr3VglgfriWez5f8XH8qFQEUNq5XrT1g2QEskRehxF9Xq +rrSjNPY3aej7zNOjrwvznVgO0cvacoMJQ+E1zkv1s1QLLmey+kEidmKu5koHyYZEtqB 1PNyKs4ZqZf2lPVD/1c7irQ7IyFWRDkLil+vWr6TeRyYzMEKTnqi8Qn4ShpJIjVqZJej ulN0ayPMOpUsuVoJZai2x1YK7hakaCBYMaXFkuhvhHRdMsdX5JEqbaSSKI8kVUdosEPP KtPXvL2Hl58kDpIJpN1zVTucle0sfqjOoXnZ8HDSze8M2BqY9OgmAWEngLiXa06m7da4 NwwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P8HTBug/BrxsxU3MmDdqiWcYw9YTVPuLaNnZJgqOZMs=; b=vRhJVVTZc13KR6Q9lD7zBCoVYZT+Ud72LVxPbFkMtZ7y0uCMjavBwkeCLYN+JU6ik0 jPKBMDzvIOLe2n1s5tfLIDQ3xI0QUDvVKNmvPQQdPstK0A5XaJdTaEUIesKwnBHgcFvB D5hd2G+snWaDyHw7vs8Wln1ulWhdv3VtMYDVzqF4HwArBaGGa4xRE2Qxy/mRlcn7/tUi mVnf9rVBchMJFEeVVARbX6JFF+QmhFXwUp5DoB4lBhtMMITuDsAsbznrtVTcGg591/hi UZsif9UC2llcp+9HWPWD5+vZTBjCoNOnndKlpY++53rN4sUeWa/I/cgAxQ+asDJEfFO9 fSEg== X-Gm-Message-State: AJIora/i1ZZJxfNLgVhKKWJizkZQ+BeN+3LmMM5vLLuUfgNxZQY1sjUg qVnA/u3+QR48U0F9/seXUsBI8pUyw24= X-Google-Smtp-Source: AGRyM1vIeyvKbu/k/qzwOJQKrKnQhqWlO3Au40SAkDRVZtYCa6yH7lgTOP6C3KFczbFQ7PXJimwc8w== X-Received: by 2002:a67:ac0d:0:b0:356:a09d:b063 with SMTP id v13-20020a67ac0d000000b00356a09db063mr13956867vse.69.1657135910396; Wed, 06 Jul 2022 12:31:50 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, Daniel Henrique Barboza Subject: [PATCH v2 1/5] target/ppc/kvm.c: do not return -1 on uint64_t return Date: Wed, 6 Jul 2022 16:31:36 -0300 Message-Id: <20220706193140.468009-2-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220706193140.468009-1-danielhb413@gmail.com> References: <20220706193140.468009-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::e2b; envelope-from=danielhb413@gmail.com; helo=mail-vs1-xe2b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1657136818915100001 Content-Type: text/plain; charset="utf-8" kvmppc_read_int_dt() and kvmppc_read_int_cpu_dt() return an uint64_t, while returning -1 when an error occurs. kvmppc_read_int_cpu_dt() claims that it will return 0 if anything wrong happens, but it's returning -1 if kmvppc_find_cpu_dt() fails. The elephant in the room is that returning -1 while claiming that the return is uint64_t, results in 18446744073709551615 for the callers. This reason alone is enough to not return -1 under these circunstances. We'll still have the problem of having to deal with a '0' return that might, or might not be, an error. We'll make this distintion clear in the next patches. Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 6eed466f80..109823136d 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1907,7 +1907,7 @@ static uint64_t kvmppc_read_int_dt(const char *filena= me) =20 f =3D fopen(filename, "rb"); if (!f) { - return -1; + return 0; } =20 len =3D fread(&u, 1, sizeof(u), f); @@ -1934,7 +1934,7 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *pr= opname) uint64_t val; =20 if (kvmppc_find_cpu_dt(buf, sizeof(buf))) { - return -1; + return 0; } =20 tmp =3D g_strdup_printf("%s/%s", buf, propname); --=20 2.36.1 From nobody Sun Feb 8 04:34:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657136212; cv=none; d=zohomail.com; s=zohoarc; b=AbEJuTuFFtZar8UByb6R78DVmB6lEbwCVrn/QHaycTlixFMBtLdpJ0Chg853+jF8duD31Y9j9dlhoEIlbh6QbHzQ4//whVADcAutS520x1JTXTY9Wet9TJ1qeUuRS3pyIKCYVG5XVqqXXARFU8o/xCm0vXWzLtcMorZuX6d6Ch4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657136212; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zv+C2hnaWWyTyoVtR4hGQ7SdZfWBqLliCJNNJg9zX4Q=; b=Ne7IWIcpsqBPiyLMFBh7akMGrhFfCdiWYSdKrYDisO//vTOgLAkFR6YKTAjDUu99M/lLR92RIUeQ0UfFuwzacA3GePVqwjp3YZvpSOzlDEJwhx0n+bIa+lJJfcNf7JQTVpj9fTXyhQFZb4ZNxxRXTrfLdnVODImNMOvwsopQ490= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657136212068482.2976237642979; Wed, 6 Jul 2022 12:36:52 -0700 (PDT) Received: from localhost ([::1]:43114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9ApO-0005kL-7k for importer@patchew.org; Wed, 06 Jul 2022 15:36:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Ake-0003El-9b; Wed, 06 Jul 2022 15:31:57 -0400 Received: from mail-vk1-xa35.google.com ([2607:f8b0:4864:20::a35]:39881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9Akb-00067V-Kp; Wed, 06 Jul 2022 15:31:55 -0400 Received: by mail-vk1-xa35.google.com with SMTP id q194so671906vkb.6; Wed, 06 Jul 2022 12:31:52 -0700 (PDT) Received: from balboa.ibmuc.com (201-27-97-88.dsl.telesp.net.br. [201.27.97.88]) by smtp.gmail.com with ESMTPSA id p2-20020ab01ec2000000b003828ebf6b49sm6034791uak.4.2022.07.06.12.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 12:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zv+C2hnaWWyTyoVtR4hGQ7SdZfWBqLliCJNNJg9zX4Q=; b=l49r7UeBaDAv/4zgVLckueLuHdCWliD8YmHFf1gxFKZTlsgLJBKscHioPiE8P4TiTv Zmxp29ZMdQZdWGWlDbPWC41oZ5o9jPMxmbDvfFkb2cpkw7+XAFaLtbB/mnPhFZ0pyneS tDlCHf0HTJZpEI6KgjImY0XkLoNwnKeH11WQ/oOk30tJroe0JXGFE33l3nqkwlCqnJpp UFqYJ9Uenji1wBcrO3adzqdqtMtaAfr7B5GwdcOtANsm3ttXA9Nu6wSqQ29X5CoQQFJ/ SW1rNCZPIPREDG+cHhkDkJSbGOFw9J4yeY4+UipjeHwjf11VOSr40cDRlrrAu4oBy1bG yBOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zv+C2hnaWWyTyoVtR4hGQ7SdZfWBqLliCJNNJg9zX4Q=; b=k9pCuFRNIY/ZxyPALrmiX5IHUoRsygmUHytiDQnq8Ja0H/+cs1yFcdnWjAso7LcEI0 8e7pXVW2iZE4BZ0OkD5PGYe43O3CAT/X050AVSJKjTcEDbDYXrFqsS8wN4h1xCgdIkNJ zZkQBin8xCyWwH2GFHSAFhTpgEgXhM9xuHjZTaAZaK14fXLlyK6Q3yQJKLzs4d2H8kOg jGS2B4wFMFvhNHAFNKnGdW4iWLv+bkxZ17DMyxtxxk1k5feM4gFcvyq7VT5nL2povov8 bJuqeusE99SDmwkMqLtvUllhtjCNufJWhG8hyRFiKvI6rOoLevevmjuJFJdsmiQs+TBO IrNA== X-Gm-Message-State: AJIora84mootbIlpogvey+Vdeh6KzWMJ+jPmMyoXkuAgxGSh3NDJOz/i PiDwSJCXzJtbYx92Utle+mr4zATf+wg= X-Google-Smtp-Source: AGRyM1tK7bWVmdRQ0QD49l8sday4hVd5Wvi7DSvbp7dyhUcz9sUd+nUZFxxQlasZAZyNs5frSYupRw== X-Received: by 2002:a1f:9e53:0:b0:370:3d3c:4ca7 with SMTP id h80-20020a1f9e53000000b003703d3c4ca7mr24227635vke.40.1657135912084; Wed, 06 Jul 2022 12:31:52 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, Daniel Henrique Barboza Subject: [PATCH v2 2/5] target/ppc: add errp to kvmppc_read_int_cpu_dt() Date: Wed, 6 Jul 2022 16:31:37 -0300 Message-Id: <20220706193140.468009-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220706193140.468009-1-danielhb413@gmail.com> References: <20220706193140.468009-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::a35; envelope-from=danielhb413@gmail.com; helo=mail-vk1-xa35.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1657136212931100001 Content-Type: text/plain; charset="utf-8" The function can't just return 0 whether an error happened and call it a day. We must provide a way of letting callers know if the zero return is legitimate or due to an error. Add an Error pointer to kvmppc_read_int_cpu_dt() that will be filled with an appropriate error, if one occurs. Callers are then free to pass an Error pointer and handle it. Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 109823136d..bc17437097 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1925,15 +1925,17 @@ static uint64_t kvmppc_read_int_dt(const char *file= name) =20 /* * Read a CPU node property from the host device tree that's a single - * integer (32-bit or 64-bit). Returns 0 if anything goes wrong - * (can't find or open the property, or doesn't understand the format) + * integer (32-bit or 64-bit). Returns 0 and set errp if anything goes + * wrong (can't find or open the property, or doesn't understand the + * format) */ -static uint64_t kvmppc_read_int_cpu_dt(const char *propname) +static uint64_t kvmppc_read_int_cpu_dt(const char *propname, Error **errp) { char buf[PATH_MAX], *tmp; uint64_t val; =20 if (kvmppc_find_cpu_dt(buf, sizeof(buf))) { + error_setg(errp, "Failed to read CPU property %s", propname); return 0; } =20 @@ -1946,12 +1948,12 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *= propname) =20 uint64_t kvmppc_get_clockfreq(void) { - return kvmppc_read_int_cpu_dt("clock-frequency"); + return kvmppc_read_int_cpu_dt("clock-frequency", NULL); } =20 static int kvmppc_get_dec_bits(void) { - int nr_bits =3D kvmppc_read_int_cpu_dt("ibm,dec-bits"); + int nr_bits =3D kvmppc_read_int_cpu_dt("ibm,dec-bits", NULL); =20 if (nr_bits > 0) { return nr_bits; @@ -2336,8 +2338,8 @@ static void alter_insns(uint64_t *word, uint64_t flag= s, bool on) static void kvmppc_host_cpu_class_init(ObjectClass *oc, void *data) { PowerPCCPUClass *pcc =3D POWERPC_CPU_CLASS(oc); - uint32_t dcache_size =3D kvmppc_read_int_cpu_dt("d-cache-size"); - uint32_t icache_size =3D kvmppc_read_int_cpu_dt("i-cache-size"); + uint32_t dcache_size =3D kvmppc_read_int_cpu_dt("d-cache-size", NULL); + uint32_t icache_size =3D kvmppc_read_int_cpu_dt("i-cache-size", NULL); =20 /* Now fix up the class with information we can query from the host */ pcc->pvr =3D mfpvr(); --=20 2.36.1 From nobody Sun Feb 8 04:34:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657137203; cv=none; d=zohomail.com; s=zohoarc; b=ES/TmbL1FFhlRT/pBq+VBklTBujLWDOro4N39Cvv+ZYfnHQZRbNNWdGidkSD69cob60ikm3E52epAzzMkWz0uAF54MzTcBBZLphQ/pP7oAyCa3Sx+CSgmiQPBHjG5KHbwLj1P5AYxnlJPWFD1qRyPDoers68D60NaJR9klaq/m0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657137203; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i/LMMGPQ7xLb10MBpUuhhIbs+RytHagc/2nRY+hrpBc=; b=ZbCe5cSiv381ulrKofawZLs3MkdqThiOING5hWObB60ayU+XVMsPRxauRPXeSgMddWrmGVW2jaNjcZQBY/BrT5nl9HSL1Sa2Y7we64yjg96EcHU6SGc7ntvzX45DuJAUCkccvYTd8x2r8Hluc4ZebHYT/JUctfUA13iAlbz+DaE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657137203394537.6511175901778; Wed, 6 Jul 2022 12:53:23 -0700 (PDT) Received: from localhost ([::1]:55314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9B5M-0006jn-VB for importer@patchew.org; Wed, 06 Jul 2022 15:53:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Aki-0003HC-DB; Wed, 06 Jul 2022 15:32:06 -0400 Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:42529) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9Ake-00067t-Bh; Wed, 06 Jul 2022 15:31:57 -0400 Received: by mail-vk1-xa30.google.com with SMTP id r184so1085426vkg.9; Wed, 06 Jul 2022 12:31:55 -0700 (PDT) Received: from balboa.ibmuc.com (201-27-97-88.dsl.telesp.net.br. [201.27.97.88]) by smtp.gmail.com with ESMTPSA id p2-20020ab01ec2000000b003828ebf6b49sm6034791uak.4.2022.07.06.12.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 12:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i/LMMGPQ7xLb10MBpUuhhIbs+RytHagc/2nRY+hrpBc=; b=maNxiGubTYfEXngTAHeyvLh2tW/acAkB5BQ7qlGCvgdMfLABKMSLCOFYr0pp8gudDR VlbKPipKAgvTPWEFAm6o288BPRJIWYcpuLPpczYxKqMaE2Fii9mQzxKi3xWuira65cQw V+lVZfLGhs02jhadFdn1+1sh42jNbaJnKQ4hbFNH6lCZgPjHdW+/SlGCFfu9yaXguK/d Ws0C2fFqhqp/oB2xE5e7qRTHvXU74DYOy1AlpzxthXsBgvzsNDaYI7uoJuOiOtpkG5OI 80EA98fAvGaNK8k7H3lcP2ypCNphxrecsLkgMhlI8jAqyXMQoDlokDJF8EdaSifc7TFg AWlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i/LMMGPQ7xLb10MBpUuhhIbs+RytHagc/2nRY+hrpBc=; b=5kOtHwFi+te25tVuybeM7HNd0ETHR3tdpNU12ODXzXGj08Jd059+Veuov1BgSMF9+M RgpofbvFillQxUpg4aqM/0vSC6DecKIJZ/sjkr4Hsk+61urE5+oog3iCksWObTYl5NCd RX1GS4OffZw0ncn0xOTihD7otw6MoO93CMSFsqse1Cvlcnnyf5qzXzAMPCI/VJYBuO5u fwDPi3Jlv8wA7gOOSHNLEUn8oxlYvCoD/d9o9KsdLzDpWjW8ib8sGHZVVzyUCLbt2Wpo +qePji0GoZzas2ydyzYPGLr0/fZyRXYAaff5XrhHGRU7Yq6QKl490SQXx2mkEZzVvAR+ 3kSQ== X-Gm-Message-State: AJIora9qZimGqHstB9UBXnV0tDMHNaJL2eUPRqSOsdhvTaeCJEyTy0sB VbgHj6qVte10EDL3aejFRi4H6nmjceo= X-Google-Smtp-Source: AGRyM1t6eV36gGl5hUN4b8b+7X/UmSAM+qhEJAit+sBP6OLggabRX2HUHf7swkIF+AhVma5aER4Gjg== X-Received: by 2002:ac5:ccf2:0:b0:370:b800:bfc0 with SMTP id k18-20020ac5ccf2000000b00370b800bfc0mr18521286vkn.15.1657135914458; Wed, 06 Jul 2022 12:31:54 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, jianchunfu , Daniel Henrique Barboza Subject: [PATCH v2 3/5] target/ppc: Add error reporting when opening file fails Date: Wed, 6 Jul 2022 16:31:38 -0300 Message-Id: <20220706193140.468009-4-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220706193140.468009-1-danielhb413@gmail.com> References: <20220706193140.468009-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::a30; envelope-from=danielhb413@gmail.com; helo=mail-vk1-xa30.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1657137205043100001 From: jianchunfu Add error reporting before return when opening file fails in kvmppc_read_int_dt(). Signed-off-by: jianchunfu Reviewed-by: C=C3=A9dric Le Goater [danielhb: use error_setg() instead of fprintf] Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index bc17437097..7611e9ccf6 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1896,7 +1896,7 @@ static int kvmppc_find_cpu_dt(char *buf, int buf_len) return 0; } =20 -static uint64_t kvmppc_read_int_dt(const char *filename) +static uint64_t kvmppc_read_int_dt(const char *filename, Error **errp) { union { uint32_t v32; @@ -1907,6 +1907,7 @@ static uint64_t kvmppc_read_int_dt(const char *filena= me) =20 f =3D fopen(filename, "rb"); if (!f) { + error_setg(errp, "Error opening %s: %s", filename, strerror(errno)= ); return 0; } =20 @@ -1940,7 +1941,7 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *pr= opname, Error **errp) } =20 tmp =3D g_strdup_printf("%s/%s", buf, propname); - val =3D kvmppc_read_int_dt(tmp); + val =3D kvmppc_read_int_dt(tmp, errp); g_free(tmp); =20 return val; --=20 2.36.1 From nobody Sun Feb 8 04:34:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657136849; cv=none; d=zohomail.com; s=zohoarc; b=kP13fg9ftOEo5cBICfnP3HXL42W5z7UTtuyHb2VHeTDgKzmRCVGa81tHC9cnl72N/778eyI3Y0ek1yt/IixqOv8ozqvqkKh26IoiVM/ZFkmLx+6G6EC3R69Xwq77Rwz9/tnZvzwuiZ3vU1rjIcLNheQzgBEAMm4KpcWLs3QhIbE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657136849; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SzbsEb73BXpa6gMReMERwR04DzXaL19I57Pb6iUf4nQ=; b=Rm9sLZF6hNTouSbbxuf4z26Tc+leP0ADvPI5PgA1504kZIvjKQyrDyrODV7y9TugwZ1xUcNtnIZHGmTv7r05IZUz1PYllzlH4Y9naqKcT3HTZmirP2S8MdgeMItTFEJbdmVdk8pcCzpcEajo2yB1eWsTsUWkTRB+Sf8VZbbXQwg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657136849428652.9537559895866; Wed, 6 Jul 2022 12:47:29 -0700 (PDT) Received: from localhost ([::1]:49998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Azf-0002g2-7I for importer@patchew.org; Wed, 06 Jul 2022 15:47:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Akj-0003Hw-Tj; Wed, 06 Jul 2022 15:32:06 -0400 Received: from mail-vk1-xa33.google.com ([2607:f8b0:4864:20::a33]:36422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9Akh-00068D-MV; Wed, 06 Jul 2022 15:32:01 -0400 Received: by mail-vk1-xa33.google.com with SMTP id m188so7887410vkm.3; Wed, 06 Jul 2022 12:31:57 -0700 (PDT) Received: from balboa.ibmuc.com (201-27-97-88.dsl.telesp.net.br. [201.27.97.88]) by smtp.gmail.com with ESMTPSA id p2-20020ab01ec2000000b003828ebf6b49sm6034791uak.4.2022.07.06.12.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 12:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SzbsEb73BXpa6gMReMERwR04DzXaL19I57Pb6iUf4nQ=; b=apcOFQq+4xEkK9wdWgih/1zrkO9JO9NoE/GlEDpglS+RKmy5jQnp1FfK1enHi1vIV8 SQJko1iCfJQ/lRPJO6S2Vzlhegdb60c65icR4Xm3SYmKxqPN7wMTnBYh0IeopmY16lFJ gZsyoBKVfvaWb9nBM/dBcJtKAD5qfORN634LvtZFXd0/z+zrCBVrQidz4PzSpBfnCQIt HcyLVwdPz4R/uX+HFVff6uq4m/PiGr74rR0vUC7A1OwnJIRg/Mv9jAe8twrSk6c1Qf52 L8VmBQO89zCJEsTISANlwTrnCjCWrwiplftKzq6Q9dQYPYe1mFTkHJvJiNkhsax14wIJ b6MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SzbsEb73BXpa6gMReMERwR04DzXaL19I57Pb6iUf4nQ=; b=StpjwfLmioFch/q27QQ9si53Ek3OZ0tetrbueoC9CjkXYQLZBrPhWcNRBml1XNurXP ji9ZQW5+CSC8Fg7kRBk2xCAP95Hc5naTgGdIkSt19jS/ntBkjw8H5dFd37R+AH9Pv0wG 0czWQOO4jrn949UCl1iNk/l5uvEV+Hbx2c2QBSmuHhpPT4jbu5FQnzZzYG+GCTH0JZFE PZanVE3Z3bEcCW44HdJBNOs27jfn36OdZvWDRn0akc9KlffhbmekJGycLYc4fZfDrsMT kkxV7F7DcKabu8MlnqySHcdG3EWUdVb72zjct44mxGFOfubikjF48u/lSHumVve3mwaE Y5Eg== X-Gm-Message-State: AJIora96DMcaklqLKqhxqIG1KgVcniK7A7kh/Beaxe1eOjgVYAm55D9k vZ4eaEkwamSGtecpRSC9THnjmesmjTI= X-Google-Smtp-Source: AGRyM1ufTzoGbWAB1Ll21l0JwsFamZicXTrueKNTIPQVsSR5thH0W+yStsr3hwmdvlmC5rgsjzNApg== X-Received: by 2002:a1f:3055:0:b0:373:f1e0:aa57 with SMTP id w82-20020a1f3055000000b00373f1e0aa57mr8563359vkw.36.1657135916528; Wed, 06 Jul 2022 12:31:56 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, Daniel Henrique Barboza Subject: [PATCH v2 4/5] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt() Date: Wed, 6 Jul 2022 16:31:39 -0300 Message-Id: <20220706193140.468009-5-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220706193140.468009-1-danielhb413@gmail.com> References: <20220706193140.468009-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::a33; envelope-from=danielhb413@gmail.com; helo=mail-vk1-xa33.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1657136850896100001 Content-Type: text/plain; charset="utf-8" This spares us a g_free() call. Let's also not use 'val' and return the value of kvmppc_read_int_dt() directly. Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 7611e9ccf6..c218380eb7 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1932,8 +1932,8 @@ static uint64_t kvmppc_read_int_dt(const char *filena= me, Error **errp) */ static uint64_t kvmppc_read_int_cpu_dt(const char *propname, Error **errp) { - char buf[PATH_MAX], *tmp; - uint64_t val; + g_autofree char *tmp =3D NULL; + char buf[PATH_MAX]; =20 if (kvmppc_find_cpu_dt(buf, sizeof(buf))) { error_setg(errp, "Failed to read CPU property %s", propname); @@ -1941,10 +1941,8 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *p= ropname, Error **errp) } =20 tmp =3D g_strdup_printf("%s/%s", buf, propname); - val =3D kvmppc_read_int_dt(tmp, errp); - g_free(tmp); =20 - return val; + return kvmppc_read_int_dt(tmp, errp); } =20 uint64_t kvmppc_get_clockfreq(void) --=20 2.36.1 From nobody Sun Feb 8 04:34:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657136217; cv=none; d=zohomail.com; s=zohoarc; b=f9V+fCZjNPJzHLmHZ6Z6zP+VrwjDbTylzwb3m6cvxCFezt4ILSRBYZ3Y8Pa8inf4HqrdUndBooz+CooDvU2+NLOdKmsZ66KUebS8V4tviGTL3LbIhXtzjJqM7A1PbNsKWaBbnv/6xz+VEG1/cuYA3wwCKStiFnBFmhD90G8vXn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657136217; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=asn4YzwX5mBIX1qiRMLgANcS1JnrdHbUQq3YD07AP3I=; b=QdT30QMOKOPGSHNsN8tn9I7VJTSnohhdSNkXMDRVOJwZPw16yMkniIwGyyCKMumtQIokz7CT/kSrEr7VJ1FfrrrYWB/pP4u0dz/RntgxBahzJpMWWdU8gcuyrjH9oKowijww8Ld0iAcy3oc0qsD0Wo77Ap2zqgc6XQbffAhBnEE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657136217160665.7375006107602; Wed, 6 Jul 2022 12:36:57 -0700 (PDT) Received: from localhost ([::1]:43276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9ApT-0005rw-Nh for importer@patchew.org; Wed, 06 Jul 2022 15:36:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Akl-0003Hx-2I; Wed, 06 Jul 2022 15:32:12 -0400 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]:35400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9Aki-00068K-H0; Wed, 06 Jul 2022 15:32:02 -0400 Received: by mail-ua1-x92d.google.com with SMTP id s3so3964283uaq.2; Wed, 06 Jul 2022 12:31:58 -0700 (PDT) Received: from balboa.ibmuc.com (201-27-97-88.dsl.telesp.net.br. [201.27.97.88]) by smtp.gmail.com with ESMTPSA id p2-20020ab01ec2000000b003828ebf6b49sm6034791uak.4.2022.07.06.12.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 12:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=asn4YzwX5mBIX1qiRMLgANcS1JnrdHbUQq3YD07AP3I=; b=q4jqDVug9z/qMpFh7w5UpRCbFEpoYTUGTkJOcaff2PA3+DoVcsSbnmbnWA6TFK5Ra9 eq+wNityOhZjbOdPnkqC6ZzSpmLypht8BSE+eQgEMZ/dmbZ8TGqdDJ4sTjCbLEmurBzy gF+Ko0y0BwQtatVuQR09mXWJUrSOT5CxsiFJPPJIeCMr7ubYiUdEooxLYmFFyEbGvxwQ lnQHZaryK2rzyGHkXXXjPJEdpMB7grvNjdagpWSDA4dzdZ4vUybFzT/n8X9zVoH2bjDh k5vwQ29kKiDg/Dx+8nS8UV/d1sHmUMVU2nqg+PGOz9cImu8yBcF1NuD2LC75d5HZsSfl xXeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=asn4YzwX5mBIX1qiRMLgANcS1JnrdHbUQq3YD07AP3I=; b=oXC+ix/o/En0NTmwotGZ0ndpfJfTMDEk3oB8CFkPfuuDaauGuCu4uTGk3qSMpLXuEI AMWH5KkVq77k8JFNbkJ0TjgOqBRk6RjOvVbeoG9A0H2KzOWRr2Y4iuN7B8qba2/IyufG mqtYEfi+9gQ6qIrV6eAZomJhWB7755CPTic8PAP9LqlSCKB0pA4S5Q1iKM4s4NUsvDlk 5NZKSx8wLpswgdjvJEQEzVvl6BjS46yfQkw/CoSA77Bc5xTnRpNvkQwKdqnfxi82DNL0 AWGJ9U5IDUNWzG8v8oe8vkdN0Rq4UY9RQ5FG8vBwmZn+vA16wir8t3ahSUwcaUoAr2YS mnYQ== X-Gm-Message-State: AJIora/ZyET2awECwkIXTJrn7dQR6SuZ2Lsk96qrxBvYmArhfDWg8yKz pAqZZokd/8ltPIFUDqlHxJVIFXEWkk8= X-Google-Smtp-Source: AGRyM1unTgxBTM2gBCvkVxk6WznNvX80kaC4PTMBNxBW8i7ddPyjXbrIPQCFVIB7AzcoWedpI8VYgw== X-Received: by 2002:ab0:298e:0:b0:382:982e:9ba8 with SMTP id u14-20020ab0298e000000b00382982e9ba8mr8576762uap.36.1657135917987; Wed, 06 Jul 2022 12:31:57 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, Daniel Henrique Barboza Subject: [PATCH v2 5/5] target/ppc: exit(1) on failure in kvmppc_get_clockfreq() Date: Wed, 6 Jul 2022 16:31:40 -0300 Message-Id: <20220706193140.468009-6-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220706193140.468009-1-danielhb413@gmail.com> References: <20220706193140.468009-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::92d; envelope-from=danielhb413@gmail.com; helo=mail-ua1-x92d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1657136218827100001 Content-Type: text/plain; charset="utf-8" When running under KVM accel it is expected to have 'clock-frequency' in the DT. Not having this attribute is too risky for both the machine emulation and userspace. We have a way of telling whether this error scenario might happen or not via kvmppc_read_int_cpu_dt() now being able to report errors. From now on, when running KVM, we will assume that 'clock-frequency' will always be present in the DT. Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index c218380eb7..d9febb2c63 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1945,9 +1945,24 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *p= ropname, Error **errp) return kvmppc_read_int_dt(tmp, errp); } =20 +/* + * Read the clock-frequency from the DT. On error (e.g. + * 'clock-frequency' is not present in the DT) will + * report an error and exit(1). + */ uint64_t kvmppc_get_clockfreq(void) { - return kvmppc_read_int_cpu_dt("clock-frequency", NULL); + Error *local_err =3D NULL; + int ret; + + ret =3D kvmppc_read_int_cpu_dt("clock-frequency", &local_err); + + if (local_err) { + error_report_err(local_err); + exit(1); + } + + return ret; } =20 static int kvmppc_get_dec_bits(void) --=20 2.36.1