From nobody Mon Feb 9 08:58:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657045675; cv=none; d=zohomail.com; s=zohoarc; b=jb7I5ebbHmdhgQnIRTYabrFkCYg15BizeMUDn7VS5/pJ6cxArfJaa0Sv6XwCg0TO9eh94c6g9GzdrdVIt8vGVzHlZm+d9EZqYel3HQL2yk+EIqXAnj3ZCrmNzX2Eu3yg4g8kHDD5zeDy4LNS9jA+8QNWfGFbfwJmVCEA1IE7js0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657045675; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XmwmLhUmlwIDWCw+0ivyrH1wTzr3gQ8u6NCTrCLrXOg=; b=IbedHr0Lcv1dvMhi8wIBZpoMsoG97/4Qd0ktXZk3+x6Te1Zq0nOFK7S4z2O/GsWbAxhDCl3iyaZuWl10tsMmJBitTQY2FaqqjwSk+6I5el5CgUbzLvicIDOMNGi7PzceOI/ECdeukpXR0Q9DG3L9pQbu4eKaUGr2iip7l6fBK84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657045675827108.48136356940518; Tue, 5 Jul 2022 11:27:55 -0700 (PDT) Received: from localhost ([::1]:37950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8nH8-0002GB-LQ for importer@patchew.org; Tue, 05 Jul 2022 14:27:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8n8z-0007b9-Dv for qemu-devel@nongnu.org; Tue, 05 Jul 2022 14:19:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8n8w-00013y-6Q for qemu-devel@nongnu.org; Tue, 05 Jul 2022 14:19:28 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-a7s6WvOOMUW549GUbzfvKA-1; Tue, 05 Jul 2022 14:19:24 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 126C5803D57 for ; Tue, 5 Jul 2022 18:19:24 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.192.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 350A440CFD05; Tue, 5 Jul 2022 18:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657045165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XmwmLhUmlwIDWCw+0ivyrH1wTzr3gQ8u6NCTrCLrXOg=; b=SyopUQnxqhY9UDNk/9EaHEdbujo6XckEKsOLwxkBA/FGB8gyfMMWBhPiVXkcilzqlY7uLw 2dtCOY6Uvg1yhTSE/AHIJfwzcV495Kr3dLXCudeZ8ZrDNtZdmISC5vZfl37x4DtucpRtTN S/sxcJzAYCdgQj1zL44mNDe66GCoJaI= X-MC-Unique: a7s6WvOOMUW549GUbzfvKA-1 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Eric Blake , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Markus Armbruster , "Dr. David Alan Gilbert" , Paolo Bonzini , Jason Wang , Stefano Brivio , Laurent Vivier Subject: [PATCH v6 06/13] net: stream: Don't ignore EINVAL on netdev socket connection Date: Tue, 5 Jul 2022 20:19:01 +0200 Message-Id: <20220705181908.1375601-7-lvivier@redhat.com> In-Reply-To: <20220705181908.1375601-1-lvivier@redhat.com> References: <20220705181908.1375601-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657045677087100003 From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier Reviewed-by: Daniel P. Berrang=C3=A9 --- net/stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/stream.c b/net/stream.c index 0851e90becca..e8afbaca50b6 100644 --- a/net/stream.c +++ b/net/stream.c @@ -363,8 +363,7 @@ static int net_stream_client_init(NetClientState *peer, if (errno =3D=3D EINTR || errno =3D=3D EWOULDBLOCK) { /* continue */ } else if (errno =3D=3D EINPROGRESS || - errno =3D=3D EALREADY || - errno =3D=3D EINVAL) { + errno =3D=3D EALREADY) { break; } else { error_setg_errno(errp, errno, "can't connect socket"); --=20 2.36.1