From nobody Sun Feb 8 14:22:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657043402; cv=none; d=zohomail.com; s=zohoarc; b=CHZYFjaySBUGqsT50suO9OvlAcOt99HofdrSagoRiV+Y0py/sNjmxeSLzoDQy8zceO4PRN9I6RtIQSKKW5CsiTs2oho0WWKJb2jPJfCiA3C1XcDKI7zCRTqRKHYmEcIEXvnhySz3Bj4e1fhAg17iaAsr8N8DEgk4Evr/ObsVZ+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657043402; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SSes/FhWI5qBh7kJUMkZm4Cbowh1bM/8HBDqcohlVJ8=; b=Kx8fMmHcevXhVGskwkuWvQNm4BR6v5jY61c/0TDKV9G9w8xPYgctrkx2+Pq97TyNxQMa9nmvfO78GV6UX0xy59cusbUUsaWOi8hzVZY3pZytHGZD8rWeGNA32yivToHZJvGCUN5pL7PlwO+aAqmn/mprq4D9KrAe5Dl0aNXra4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657043402149689.5265557358715; Tue, 5 Jul 2022 10:50:02 -0700 (PDT) Received: from localhost ([::1]:34966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8mgS-0003kz-IA for importer@patchew.org; Tue, 05 Jul 2022 13:50:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8med-000332-Cz for qemu-devel@nongnu.org; Tue, 05 Jul 2022 13:48:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8mea-00051E-TO for qemu-devel@nongnu.org; Tue, 05 Jul 2022 13:48:06 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610-P282z4gUP6mlKeDRVxSQKA-1; Tue, 05 Jul 2022 13:48:00 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A15B802D1C; Tue, 5 Jul 2022 17:48:00 +0000 (UTC) Received: from f35-work.redhat.com (unknown [10.39.193.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA75140336E; Tue, 5 Jul 2022 17:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657043283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SSes/FhWI5qBh7kJUMkZm4Cbowh1bM/8HBDqcohlVJ8=; b=QslHNloAXRgAai1QSCoxTCwd2IM8K6lBPTB31bkQ/xqINABT1bWb9xJbwiCGYa22O3WoYu X7jm3ZJITW5BRIOZ2Wzt5NGIb3pYQ/aoYkqWZ4FO41wuHXUO6EzOkVsJE+WoN1wooKt+CK RhxskHaZB7IuxLsZM33iaYVRaqJXPGA= X-MC-Unique: P282z4gUP6mlKeDRVxSQKA-1 From: Mauro Matteo Cascella To: qemu-devel@nongnu.org Cc: mcascell@redhat.com, soulchen8650@gmail.com, kraxel@redhat.com Subject: [PATCH] usb/hcd-xhci: check slotid in xhci_wakeup_endpoint() Date: Tue, 5 Jul 2022 19:47:34 +0200 Message-Id: <20220705174734.2348829-1-mcascell@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mcascell@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657043403641100001 Content-Type: text/plain; charset="utf-8" This prevents an OOB read (followed by an assertion failure in xhci_kick_ep) when slotid > xhci->numslots. Reported-by: Soul Chen Signed-off-by: Mauro Matteo Cascella --- hw/usb/hcd-xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 0cd0a5e540..cecf8a0d96 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3269,7 +3269,8 @@ static void xhci_wakeup_endpoint(USBBus *bus, USBEndp= oint *ep, =20 DPRINTF("%s\n", __func__); slotid =3D ep->dev->addr; - if (slotid =3D=3D 0 || !xhci->slots[slotid-1].enabled) { + if (slotid =3D=3D 0 || slotid > xhci->numslots || + !xhci->slots[slotid-1].enabled) { DPRINTF("%s: oops, no slot for dev %d\n", __func__, ep->dev->addr); return; } --=20 2.35.3