From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657019394; cv=none; d=zohomail.com; s=zohoarc; b=BLBjzPJC90XxSrIVT6evR0uop3OU389e3fH9kCnuuzzUxD2LXTg+ODKu58XYAc5ONhNSz35dqW4qSO1MODOWEDPNL+WuJ5/CwPTW+zgXsLnlm4ms7qLcRox1X5g85MoOJDdifKqjBKe3g1IIn3zPg+hidLBqMUxlm7MHsYWm5xg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657019394; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CEQI5Tzq0ISDeB3fX3wDve+phtrCx3JrMsFA2JUk8Bg=; b=dqrI8BufZBcGVB7HPvyC9qQqbtdb/yVXIRu+JYLkVKSL7B8OBvIkbP7jaECLa0EctSsMzLQFDM2Jn8GYP/N1miL1CHVQQyJZHsKEQDrhugyL5N2c47kBPzT7aYLepfNVbzDGDJuazrAHvx+4LaNLXTbrTo6E7X6dcMWEW9MphxQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657019394646971.0884432753788; Tue, 5 Jul 2022 04:09:54 -0700 (PDT) Received: from localhost ([::1]:48830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8gRF-0007EV-Dt for importer@patchew.org; Tue, 05 Jul 2022 07:09:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gHp-0006ox-1v for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:09 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:36691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gHm-0000fN-Tk for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:08 -0400 Received: by mail-pf1-x42c.google.com with SMTP id 3so1053429pfx.3 for ; Tue, 05 Jul 2022 04:00:05 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CEQI5Tzq0ISDeB3fX3wDve+phtrCx3JrMsFA2JUk8Bg=; b=j/W8qN2KdHSPSKGm8jTEQw1hQi/siLuI4jZja+5czS9oCjdLqSvwH0PGtowTpR7coX YJZDfcJaSjVfPxS/dxc8nHDlphSg9v7HrsKEH2znPGIZf/xlxvGQRBW7Wq8yxEk2Y+FV VG8fDJT1IoMt9yLSMNt+Lka6OEJ71nGyzValy5HeccadNVzij5tbV7gk8mA1Vp7ccpK5 v0YwX72qoouk0IpQjTLO0y56JyN2tsFohGwBVZcgoErvKhqmYiiKhBpOKX/3GqTpodDY bnnWtGpBgqvDGmmzbTcSy7uC3njk7HcDESBOdgwC2iFKhdZPk9vTYVBZp6rSbwE6Cd6z YJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CEQI5Tzq0ISDeB3fX3wDve+phtrCx3JrMsFA2JUk8Bg=; b=JsfeYtM43q/Rm1XjUvrtEo4PzAMPsEAZo6LXYcdS2NvzNOiPH4AmAiVcCJl+h7DkKK hrqX1d4wjXKA6dj/j/ygUoNHp/nPySCU+YBK8DcYOy8fNGezRMqaJO6glJMksCJqXmcA BH2dvIlJiu1JCdoT+Ln/O8VSnIZt8hUR58bvEv/Ebz02au4v2FDCTO0Hpc6n1/NGIIdJ D8MOBltbGz+CDcefN0xzEO/aaq87pHIpjO3qZf0TO7KlC/dDLpe7+8pkLDyeQfdudRlZ EGEzUfGZ80GjzgXXAshDiYKyaRUxpRynrxYnZvI+JDuy2hofVFu49SgbMmVVHpq3lCyr VvMw== X-Gm-Message-State: AJIora+uY3SuVQlh0yuHOirgsRYfOicnT4f03PCZPdI8ecmKhe9FmC3M Fp1oGQPNioA75TyE8kBchmN8Uy2WS5dQJ97w X-Google-Smtp-Source: AGRyM1sOKpCUCaywuoHKbVBFH5imDXzhvb/3pKP12jfzzOSCiMjtslQKcXUmBVDrvKDNm/17wDez+Q== X-Received: by 2002:a05:6a00:150a:b0:525:3030:fe41 with SMTP id q10-20020a056a00150a00b005253030fe41mr41275481pfu.37.1657018804943; Tue, 05 Jul 2022 04:00:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Song Gao , Thomas Huth Subject: [PULL 1/6] hw/rtc/ls7a_rtc: Drop unused inline functions Date: Tue, 5 Jul 2022 16:29:51 +0530 Message-Id: <20220705105957.1144514-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657019395865100001 Content-Type: text/plain; charset="utf-8" Remove toy_val_to_time_mon and toy_val_to_time_year as unused, to avoid a build failure with clang. Remove all of the other inline markers too so that this does not creep back in. Reviewed-by: Song Gao Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson --- hw/rtc/ls7a_rtc.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/hw/rtc/ls7a_rtc.c b/hw/rtc/ls7a_rtc.c index e8b75701e4..1f9e38a735 100644 --- a/hw/rtc/ls7a_rtc.c +++ b/hw/rtc/ls7a_rtc.c @@ -86,46 +86,31 @@ struct LS7ARtcState { }; =20 /* switch nanoseconds time to rtc ticks */ -static inline uint64_t ls7a_rtc_ticks(void) +static uint64_t ls7a_rtc_ticks(void) { return qemu_clock_get_ns(rtc_clock) * LS7A_RTC_FREQ / NANOSECONDS_PER_= SECOND; } =20 /* switch rtc ticks to nanoseconds */ -static inline uint64_t ticks_to_ns(uint64_t ticks) +static uint64_t ticks_to_ns(uint64_t ticks) { return ticks * NANOSECONDS_PER_SECOND / LS7A_RTC_FREQ; } =20 -static inline bool toy_enabled(LS7ARtcState *s) +static bool toy_enabled(LS7ARtcState *s) { return FIELD_EX32(s->cntrctl, RTC_CTRL, TOYEN) && FIELD_EX32(s->cntrctl, RTC_CTRL, EO); } =20 -static inline bool rtc_enabled(LS7ARtcState *s) +static bool rtc_enabled(LS7ARtcState *s) { return FIELD_EX32(s->cntrctl, RTC_CTRL, RTCEN) && FIELD_EX32(s->cntrctl, RTC_CTRL, EO); } =20 -/* parse toy value to struct tm */ -static inline void toy_val_to_time_mon(uint64_t toy_val, struct tm *tm) -{ - tm->tm_sec =3D FIELD_EX32(toy_val, TOY, SEC); - tm->tm_min =3D FIELD_EX32(toy_val, TOY, MIN); - tm->tm_hour =3D FIELD_EX32(toy_val, TOY, HOUR); - tm->tm_mday =3D FIELD_EX32(toy_val, TOY, DAY); - tm->tm_mon =3D FIELD_EX32(toy_val, TOY, MON) - 1; -} - -static inline void toy_val_to_time_year(uint64_t toy_year, struct tm *tm) -{ - tm->tm_year =3D toy_year; -} - /* parse struct tm to toy value */ -static inline uint64_t toy_time_to_val_mon(struct tm *tm) +static uint64_t toy_time_to_val_mon(const struct tm *tm) { uint64_t val =3D 0; =20 @@ -137,7 +122,7 @@ static inline uint64_t toy_time_to_val_mon(struct tm *t= m) return val; } =20 -static inline void toymatch_val_to_time(LS7ARtcState *s, uint64_t val, str= uct tm *tm) +static void toymatch_val_to_time(LS7ARtcState *s, uint64_t val, struct tm = *tm) { qemu_get_timedate(tm, s->offset_toy); tm->tm_sec =3D FIELD_EX32(val, TOY_MATCH, SEC); --=20 2.34.1 From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657020201; cv=none; d=zohomail.com; s=zohoarc; b=km+IjKKvL5hVK+NMl/yljLJn+UMXUQ7HKaqFE5nm4l30CTJo3hM2VQdJbY4vy3Rp8qHA5YFb/laVqL55TDPplPlXtK2rBi5xMuemzwNPdBqBfdOzR5/qBVIXwVXN94q8qIJNjwM4G0fMAhbfEPriwz4kqMKLrrVrizh61FtM+8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657020201; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z9HYnLroahrDAazMWts4PSFEzXJdvqtXFJupFoU2vN8=; b=ZRpRODPQCOoWHhWSfdzPvXypbDOPKlasTHCn/mypL4psuPJfqI3rdqmZG8/5a0/pgNqBB1ZopYHAyiEwCd1CB7u1NHBOjFNP67g73NlznHaSW99r83R2nmSNfgC912OwVqlUi4pSJBz4Myc7yyQRCOE+ad0/l0gc+oX0YdDtOvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657020201245160.857976675965; Tue, 5 Jul 2022 04:23:21 -0700 (PDT) Received: from localhost ([::1]:42340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8geF-0006CT-BO for importer@patchew.org; Tue, 05 Jul 2022 07:23:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gI6-0006wB-TR for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:26 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:39682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gHq-0000gQ-Uf for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:16 -0400 Received: by mail-pg1-x533.google.com with SMTP id q82so3900570pgq.6 for ; Tue, 05 Jul 2022 04:00:10 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z9HYnLroahrDAazMWts4PSFEzXJdvqtXFJupFoU2vN8=; b=dmooeY8oKJC/tJFBYkHpFo2ZVveFReLyXeuP5A2o5EkB7uwFfta93HEVsZzB3GN+5k bCA4IAJWKuSntcy4eqi1x+PHNtXhkpvQSSNO+a8mD3lfJFLW0Hk0m7f0w2TjY7a+xb4J BKkagPj9MbXxfNeCCV1z90k7/m7B36yrRTj7fbBRReIQAj0JtJepnhXksnwyozFw4FsP +AvPxGhCSDaOmGkxfzk1vqsziiuKxbEIMgnGNIUftqeoqHL82D/GnWXcluA8mD67radq r0QhEm0Po3ri4KBXp5rGmAxJikxzR/rgKaKc1CQdVQTekMWZPY7f30GA7NG3g2QZK7Pn YiIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z9HYnLroahrDAazMWts4PSFEzXJdvqtXFJupFoU2vN8=; b=NBpDRYNQ3srUD1NcE8tsenzbYo5r2ON8jyzfElLDDd68AirNauaj/xhTBz9hVa/Clw trxScUrEe7S/JYNHDwnwQiEn5SL+ONNvoEyQPm8DJ+BP0y1Dk+aAdBiES+29ZAYgmtWE 9aHjOwoTPTZ/0tPLPblgZWAOYlHEwsi++PZ1AVk+12X34nvU0WzlnX7MPOpRt21xptYr luMU6n0ah+os0xuav2EDfYsXUfWBhp+EovO/bQ3NIeRBMNHJPZJOD15/2VcaNC1uSwp7 iZQedLJ0hdZui60yaritG/GlbYywOLRotkA0OoCs9U358WPJA0Jeflh0K3h2bgtzXZTj tyRg== X-Gm-Message-State: AJIora9z6sYm8ev7VO8EpjLUqJ0GNLEjPi7TuECCzfEMozxrEfuM2/bt UXNX3XkQvmuxitcMPA1HU+qo6+Xn0fQyMbqw X-Google-Smtp-Source: AGRyM1vXJHhXNyaLKWPfSGkJgueKVo8ySdY+uRwyDSpeJt7VU1+Ypr0GnqE7eoATHy62L2KpcStqwQ== X-Received: by 2002:a62:542:0:b0:525:a313:fe28 with SMTP id 63-20020a620542000000b00525a313fe28mr41719723pff.73.1657018809463; Tue, 05 Jul 2022 04:00:09 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Song Gao Subject: [PULL 2/6] target/loongarch: Clean up tlb when cpu reset Date: Tue, 5 Jul 2022 16:29:53 +0530 Message-Id: <20220705105957.1144514-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657020205384100001 Content-Type: text/plain; charset="utf-8" From: Song Gao We should make sure that tlb is clean when cpu reset. Signed-off-by: Song Gao Message-Id: <20220705070950.2364243-1-gaosong@loongson.cn> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson --- target/loongarch/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index d2d4667a34..e21715592a 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -479,6 +479,7 @@ static void loongarch_cpu_reset(DeviceState *dev) =20 #ifndef CONFIG_USER_ONLY env->pc =3D 0x1c000000; + memset(env->tlb, 0, sizeof(env->tlb)); #endif =20 restore_fp_status(env); --=20 2.34.1 From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657019642; cv=none; d=zohomail.com; s=zohoarc; b=BOM6m/oqEweNORexLuJQWTNu4tq9JsiIxGbN1H34PFJMeDpkOxk2BArBqibrhbestJQeDrJWSF1zz4Xjgv+3XNvR77Z4a+xD7zONM7AL3Y+26NmahPVlgw6wN3EEjHlE6GOuryn78L/vcKkykQm03lSLDYeBLFDvGMoz7eW1uJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657019642; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ky07ThqARHiFkhWeIFBW8AVKAgEQoX250iifcE1+G+E=; b=Y/R4epQI89HeXy4FrO9cNsOPVvpgB5yHi2pcgjs0/9gsBXpu/2jxBCIAqcCbgHinmY9mJ70LUTUDd1GAy2ZSBchGgZ8g4U+H/XdCbRwsgj/+5a9dt0Kus0R3JMNq9Nr0poSLcvkOedd8ByDrCagefWrcjrRpc6xdM8x4vcxU8BE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657019642249466.2079819449583; Tue, 5 Jul 2022 04:14:02 -0700 (PDT) Received: from localhost ([::1]:56896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8gVE-0004vn-Ab for importer@patchew.org; Tue, 05 Jul 2022 07:14:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gI0-0006wC-3n for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:26 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:37728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gHt-0000hU-B7 for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:17 -0400 Received: by mail-pl1-x633.google.com with SMTP id k14so10696698plh.4 for ; Tue, 05 Jul 2022 04:00:12 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ky07ThqARHiFkhWeIFBW8AVKAgEQoX250iifcE1+G+E=; b=KmtB3jfzz+e1Wg51/pnc8hIK7nGZDNyHlF7SF6Xyjwe3WHxEg0PE1psm6Uca243pLX mrPEyuRnSQ/uEacyX7/0nIhewkth3BQZgoptzfwoFZ/zZL+EMoIRPS/71xVZQUnPQjU9 OBOcC8wo2wnk1E+HZS5KALz4mIetaCAXLvtHMCf8heoFvrqtRwkf2tI+ozERf72Qs+dZ WNAVXvuLGGW4Ew/fmozyTlFmVIdL9RO8KgQTYZeGxAqNNpPoBh9jZSbLxkYPM+a3DI5N Ga8bx79bWKbffHSI0v86qrRyv0imKKZBuyrb1+p7iHnsBEU3hHRwmtnjNgOrki/+rkCX M03Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ky07ThqARHiFkhWeIFBW8AVKAgEQoX250iifcE1+G+E=; b=PlqV1qd9xV30rxe6qHhxa4yTy8eQwJKZAfHYLCN2osrz9cftbQ/C2FiNuoqmXYHN9H Ss1ylGTJj6lhW1IKgkC7DzCtZ+DrpMV1QLdxhwCIU0sfC4006Nqav3d43WPnY8tnLyY9 SAS5PZfmY2uAaLFSbmwJ/xlDe9tsUwWABjgK48IKLq2qreY9mU4mwcwyss62BFtRk2nG MqknzRc6kyoX74qVIrjaZL0zHvqsVB8cf+yFLcX1AuX84gyzPKJOV/rs7pdRHY6syF/R eRG4kFtlGURMILK6nCocOKWZr7mSvaVzSI7prKar5NueqTU+pBP5kDt6ziPu9Z0O/64g MODQ== X-Gm-Message-State: AJIora8WVtJEf5cdKeiNp0Q2g/ETauak7UjCHucchO33wVs5wJGzFiNA lKy9PPp86UmgR8U2kV9IV7AolGHnd/lllzx4 X-Google-Smtp-Source: AGRyM1vdVrE6wWXJkw7QAoqcSmFDDoO5q1NhrAVCbjaae0l2L40gpCR+DQrJx2V903RPhQ77ozDh5g== X-Received: by 2002:a17:902:d2c4:b0:16a:5c48:8312 with SMTP id n4-20020a170902d2c400b0016a5c488312mr41318856plc.45.1657018811905; Tue, 05 Jul 2022 04:00:11 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Song Gao Subject: [PULL 3/6] scripts/qemu-binfmt-conf: Add LoongArch to qemu_get_family() Date: Tue, 5 Jul 2022 16:29:54 +0530 Message-Id: <20220705105957.1144514-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657019643818100001 Content-Type: text/plain; charset="utf-8" From: Song Gao qemu_get_family() needs to add LoongArch support. Signed-off-by: Song Gao Message-Id: <20220705065943.2353930-1-gaosong@loongson.cn> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 1f4e2cd19d..6ef9f118d9 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scripts/qemu-binfmt-conf.sh @@ -171,6 +171,9 @@ qemu_get_family() { riscv*) echo "riscv" ;; + loongarch*) + echo "loongarch" + ;; *) echo "$cpu" ;; --=20 2.34.1 From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657020139; cv=none; d=zohomail.com; s=zohoarc; b=B33qdeABdPcc1eLHZ+u2m7JXBdLrPelZyHEFsjJCyIza/TP2StvBE4EqzUphoNGkEGr+e/iOmThnEpA8PuyEahk+q/7qGMenOWtzGKuabyepWxjvEyHLbCbcB3a+TATG5PwymgyvKQogawfcPi3Y698AGc4/KqPCZ6Fj8+KYx20= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657020139; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y9T0Dgh+y//OTwBqoQX1MWiwDSflPGnZ8HYkylQu7wI=; b=B+1EEtolmXLwlw4YXa17yDBIItocglRKLOMfnqooNo0r5O4lY6CPHVmkJW1T8bRXHycfSUjUBZw3oFGhXuTMHZvvf6dH76w4Yzc1Bx60YaAM9mwGIKQjBLdoWYmQ9EouKZR92N2Y5IhvgnvOId0IAb3jKF9bqsWh+yw9zWYujBc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657020139166699.4374029472965; Tue, 5 Jul 2022 04:22:19 -0700 (PDT) Received: from localhost ([::1]:39908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8gdF-0004TS-VI for importer@patchew.org; Tue, 05 Jul 2022 07:22:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gI1-0006wD-3Y for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:26 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:41800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gHv-0000i1-Oj for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:20 -0400 Received: by mail-pl1-x629.google.com with SMTP id j12so3900026plj.8 for ; Tue, 05 Jul 2022 04:00:15 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y9T0Dgh+y//OTwBqoQX1MWiwDSflPGnZ8HYkylQu7wI=; b=EQU3B7LxNZnUFF7ESH7A/1GhSlgrkBgDNDuRfCBJXoM+VAUv18YshTvRl8ZAAuDBMl HcLjUy8aLVpiB9e3TuqkjEoo9VqX2R/Kaz31Ucw/I56rEk6TqqMJvCZyiOvyFGN3sIeF coCxsORuLHRAwlDpZMzSF59JRpeF6GttLcBOAgL/5UrvV/zBgc+5A69Pdz3JA6mY7LQe W+BQww2Ieup1b4er5VkIFN3jtktnyYb6m/0uTgPPdaYZTWpPTT/5/kb9fEirRpU9IPcH XdNSKApqRV4wPVI5LmXS8XbU8WRucojlbThLeEQ3mcC/1Z40kLajdeNvln84lDJ9VS96 ounQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y9T0Dgh+y//OTwBqoQX1MWiwDSflPGnZ8HYkylQu7wI=; b=TRq77//GX/YM7Gp2wYyTfm26c7IICvXEGcGWADXxt7gq5JgOnV3TTIVNrZiJY9vPAg xhcaSD285KNSJo7m6r9EjXQIzeVs+cIQqtLGEaQE3I3j95OLHcaOrZ1/ASYW8tOHm7Sv 6T98nnuGawIdOkpWub52UQur0BP+h4m8atcOF47coIBOf8nF92ei3JbvT4Bd+7rYZmOk FgyMafEZLtP1JVwcrcoEcdKeN2M0h0J5EzXcMeV5bjHJHYPbUhOyhA69zG8iakpJKRJe 4UJYsAyQ+Gs89hyJVhQrmIx2cB/yDHSfRQtOQ/UUZUH8Q2FqjefieICPgsh2PTvRZcad T2xg== X-Gm-Message-State: AJIora/jRYfXkQGpzgLZekt9W7Qqer4gbQeW/3x8SAec3Rx9hPtgxRPB s5Oh0HN9s5AW+x01JDb9OqKNCXTrPauVUPb0 X-Google-Smtp-Source: AGRyM1vk+l+yrTSt3CNPYZs13Y+pRUqgbaL9l9oZ4x6hYFYcnAjLyUjVCs/8lhRDaJJe4SVxbGmMnw== X-Received: by 2002:a17:902:f543:b0:16a:54c6:78c0 with SMTP id h3-20020a170902f54300b0016a54c678c0mr39498075plf.22.1657018814491; Tue, 05 Jul 2022 04:00:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Song Gao , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PULL 4/6] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Date: Tue, 5 Jul 2022 16:29:55 +0530 Message-Id: <20220705105957.1144514-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657020140634100001 There is nothing in this environment variable that cannot be done better with -d flags. There is nothing special about TCI that warrants this hack. Moreover, it does not compile -- remove it. Reported-by: Song Gao Reviewed-by: Song Gao Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 5 ----- tcg/tci/tcg-target.c.inc | 7 ------- 2 files changed, 12 deletions(-) diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h index 033e613f24..ceb36c4f7a 100644 --- a/tcg/tci/tcg-target.h +++ b/tcg/tci/tcg-target.h @@ -53,11 +53,6 @@ # error Unknown pointer size for tci target #endif =20 -#ifdef CONFIG_DEBUG_TCG -/* Enable debug output. */ -#define CONFIG_DEBUG_TCG_INTERPRETER -#endif - /* Optional instructions. */ =20 #define TCG_TARGET_HAS_bswap16_i32 1 diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index 98337c567a..f3d7441e06 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.inc @@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int cou= nt) =20 static void tcg_target_init(TCGContext *s) { -#if defined(CONFIG_DEBUG_TCG_INTERPRETER) - const char *envval =3D getenv("DEBUG_TCG"); - if (envval) { - qemu_set_log(strtol(envval, NULL, 0)); - } -#endif - /* The current code uses uint8_t for tcg operations. */ tcg_debug_assert(tcg_op_defs_max <=3D UINT8_MAX); =20 --=20 2.34.1 From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657019934; cv=none; d=zohomail.com; s=zohoarc; b=d3U9msYIdgPfvKlIWiWK23JsOuzU4zXWEwxS6JKEVsSNzO0p3IZTZoGjSlTdYA4TeRjQOlARkAGwlYUAnf5LWHr9CkVsOvZPQMIbypG8Y/gzYdXBtmnYs2GMJPvt42OHx0VNoy0cbHijEHUCvr5vCuPpMy4N+CfkKC0woktpKGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657019934; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AohpMsSvo2wFsE5mlCbRYktMX9SmmQeeRLqLmCJ9PEc=; b=RSjChRj9Rg3O+IZan42EWlGYcsaMkKUniHXME5Q5nndkkz4z4WEeuEBa97OjYTrC1Ci2aW0v4NaP50HtXtDGZ2jWZIuIkpsbnWHpbdBi+GTn/GOWccGn1kbVS8dpDUQymCHjCLNuXoYb3zbJr+WCjdDqunrtO0yhcS1a2ww6TWs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657019934187280.50901571322515; Tue, 5 Jul 2022 04:18:54 -0700 (PDT) Received: from localhost ([::1]:35994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8gZw-0001dm-QQ for importer@patchew.org; Tue, 05 Jul 2022 07:18:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gI5-0006wF-Us for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:26 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:38657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gHz-0000iF-SI for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:24 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 89-20020a17090a09e200b001ef7638e536so8160466pjo.3 for ; Tue, 05 Jul 2022 04:00:17 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AohpMsSvo2wFsE5mlCbRYktMX9SmmQeeRLqLmCJ9PEc=; b=QbM+VBO/4m9rXFV9gTIQvNTzkO0Kcfq0sbNYO2SQVX3LGgd4orATukT7fW0kFO5wNa GvQCqf9bu37Z0fotiIo1lpJdlr2b43K/HRkLir9/XCQD9SNHQQ9HQr3NlcpwTyLGNhq1 QdPuO0/d9KR7QZkf0dnAEkkuY+vG0Q5durlQOnbGERfQLmukNgWvlYJuVuava+W3gCJ4 g7NmqG0j4L5gvcv2DroJrsnCrVaPLZy0+eUJVQpfuaFerZMypU20apLu4LqJJ39E2eg5 WeOtrKf99cqPvggxadZsbCb1rdgJahttPHIuN07UvCxM1nyU9oDGyC3vZUjlR7DhF7n1 QlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AohpMsSvo2wFsE5mlCbRYktMX9SmmQeeRLqLmCJ9PEc=; b=dwFP+wW4sOKxt2U++HE1diG9WEhTq39FleKvbUFt2vH//KSOBAmdZCfmH7W8+fwOHs vVZM/OPLvB8nE6p5alnZZaSP8eKtkZqp4HD0nMoGtS8iaZgu3bVxArFd8bKDBZfp9w3g ecRNlA1iba4Qd4eeTkUIkOY9i6/yrMPx4KRjbO8Wk2sqHLMLRQISN9CugQk8JmFZbrMg e6+nLKNIVGz5huBMAiDoA2Ih1xhu3phyv0Jr2l4/Mhf+GLkht4S+o9MwvpCtLGsvgIqC SP2kMK18/0O6DjR4yifey7YUNQz+kJ6/f+yzn8RNiWEBc9qfEGtTU55pp0bwTyD+kWPV oJFw== X-Gm-Message-State: AJIora97h5UOh4nHybRLnaZ8XUKAIPWB7EYJnRxymZSA3q53n7TCwcrc C+rayg9FjDoj8v9UtSA7nQ0SyOQu9wBpBE9l X-Google-Smtp-Source: AGRyM1tAolWC62S5SOh4pOmn4V2QGGkQ2gTYUJKEVg/tBfLsZrulvwILGwKW033CSXRhzxkdAjMBwA== X-Received: by 2002:a17:902:7893:b0:16a:6d44:2556 with SMTP id q19-20020a170902789300b0016a6d442556mr39564318pll.166.1657018816798; Tue, 05 Jul 2022 04:00:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Xiaojuan Yang Subject: [PULL 5/6] hw/intc/loongarch_ipi: Fix ipi device access of 64bits Date: Tue, 5 Jul 2022 16:29:56 +0530 Message-Id: <20220705105957.1144514-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657019935548100001 Content-Type: text/plain; charset="utf-8" From: Xiaojuan Yang In general loongarch ipi device, 32bit registers is emulated, however for anysend/mailsend device only 64bit register access is supported. So separate the ipi memory region into two regions, including 32 bits and 64 bits. Signed-off-by: Xiaojuan Yang Message-Id: <20220705064901.2353349-2-yangxiaojuan@loongson.cn> Signed-off-by: Richard Henderson --- include/hw/intc/loongarch_ipi.h | 7 +++--- hw/intc/loongarch_ipi.c | 38 +++++++++++++++++++++++++++------ hw/loongarch/loongson3.c | 5 ++++- 3 files changed, 39 insertions(+), 11 deletions(-) diff --git a/include/hw/intc/loongarch_ipi.h b/include/hw/intc/loongarch_ip= i.h index 996ed7ea93..0ee48fca55 100644 --- a/include/hw/intc/loongarch_ipi.h +++ b/include/hw/intc/loongarch_ipi.h @@ -24,8 +24,9 @@ #define IOCSR_MAIL_SEND 0x48 #define IOCSR_ANY_SEND 0x158 =20 -/* IPI system memory address */ -#define IPI_SYSTEM_MEM 0x1fe01000 +#define MAIL_SEND_ADDR (SMP_IPI_MAILBOX + IOCSR_MAIL_SEND) +#define MAIL_SEND_OFFSET 0 +#define ANY_SEND_OFFSET (IOCSR_ANY_SEND - IOCSR_MAIL_SEND) =20 #define MAX_IPI_CORE_NUM 4 #define MAX_IPI_MBX_NUM 4 @@ -46,7 +47,7 @@ typedef struct IPICore { struct LoongArchIPI { SysBusDevice parent_obj; MemoryRegion ipi_iocsr_mem[MAX_IPI_CORE_NUM]; - MemoryRegion ipi_system_mem[MAX_IPI_CORE_NUM]; + MemoryRegion ipi64_iocsr_mem[MAX_IPI_CORE_NUM]; }; =20 #endif diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c index 66bee93675..b8b1b9cd53 100644 --- a/hw/intc/loongarch_ipi.c +++ b/hw/intc/loongarch_ipi.c @@ -150,12 +150,6 @@ static void loongarch_ipi_writel(void *opaque, hwaddr = addr, uint64_t val, case IOCSR_IPI_SEND: ipi_send(val); break; - case IOCSR_MAIL_SEND: - mail_send(val); - break; - case IOCSR_ANY_SEND: - any_send(val); - break; default: qemu_log_mask(LOG_UNIMP, "invalid write: %x", (uint32_t)addr); break; @@ -172,6 +166,32 @@ static const MemoryRegionOps loongarch_ipi_ops =3D { .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 +/* mail send and any send only support writeq */ +static void loongarch_ipi_writeq(void *opaque, hwaddr addr, uint64_t val, + unsigned size) +{ + addr &=3D 0xfff; + switch (addr) { + case MAIL_SEND_OFFSET: + mail_send(val); + break; + case ANY_SEND_OFFSET: + any_send(val); + break; + default: + break; + } +} + +static const MemoryRegionOps loongarch_ipi64_ops =3D { + .write =3D loongarch_ipi_writeq, + .impl.min_access_size =3D 8, + .impl.max_access_size =3D 8, + .valid.min_access_size =3D 8, + .valid.max_access_size =3D 8, + .endianness =3D DEVICE_LITTLE_ENDIAN, +}; + static void loongarch_ipi_init(Object *obj) { int cpu; @@ -187,8 +207,12 @@ static void loongarch_ipi_init(Object *obj) lams =3D LOONGARCH_MACHINE(machine); for (cpu =3D 0; cpu < MAX_IPI_CORE_NUM; cpu++) { memory_region_init_io(&s->ipi_iocsr_mem[cpu], obj, &loongarch_ipi_= ops, - &lams->ipi_core[cpu], "loongarch_ipi_iocsr", 0= x100); + &lams->ipi_core[cpu], "loongarch_ipi_iocsr", 0= x48); sysbus_init_mmio(sbd, &s->ipi_iocsr_mem[cpu]); + + memory_region_init_io(&s->ipi64_iocsr_mem[cpu], obj, &loongarch_ip= i64_ops, + &lams->ipi_core[cpu], "loongarch_ipi64_iocsr= ", 0x118); + sysbus_init_mmio(sbd, &s->ipi64_iocsr_mem[cpu]); qdev_init_gpio_out(DEVICE(obj), &lams->ipi_core[cpu].irq, 1); } } diff --git a/hw/loongarch/loongson3.c b/hw/loongarch/loongson3.c index 403dd91e11..15fddfc4f5 100644 --- a/hw/loongarch/loongson3.c +++ b/hw/loongarch/loongson3.c @@ -230,7 +230,10 @@ static void loongarch_irq_init(LoongArchMachineState *= lams) /* IPI iocsr memory region */ memory_region_add_subregion(&env->system_iocsr, SMP_IPI_MAILBOX, sysbus_mmio_get_region(SYS_BUS_DEVICE(= ipi), - cpu)); + cpu * 2)); + memory_region_add_subregion(&env->system_iocsr, MAIL_SEND_ADDR, + sysbus_mmio_get_region(SYS_BUS_DEVICE(= ipi), + cpu * 2 + 1)); /* extioi iocsr memory region */ memory_region_add_subregion(&env->system_iocsr, APIC_BASE, sysbus_mmio_get_region(SYS_BUS_DEVICE(exti= oi), --=20 2.34.1 From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657020271; cv=none; d=zohomail.com; s=zohoarc; b=hArn+4eC/o18IUZAuKYqH4ROGMF5Y8YzllmpBGPsOXVIgf2bRCQRbQE/rXh9HqGlPE5skc8iwYsec17BaFkIl+cr4jZZNZykvBg/i9H6htV321qmZK1ee5p68SPCQ2Yf0tjKJYSecuf+zn3I2U9FQWwLO5ytMqxfumEQ8/7MQWk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657020271; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=l2yErBWzj5ESCHU8EEDRL6D/1bAkAZGvE1eyYa7hP9s=; b=L7CbSWmvY9c4rLvc7FSbOvVukenByrb0i3rCXcmziv7juXnRuGrnVt0Q+TXKStXxBYnZoHWY2mx5D+wo6hA3xSbBK9ws+jtdKGWjW1/CEt7gCKq8vAFa5fQbNYB82QHjrgnHHv1JvWwGQbhI8r0z473ZIEiN+YR7XPy3YeEHirQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657020271027489.3605772000028; Tue, 5 Jul 2022 04:24:31 -0700 (PDT) Received: from localhost ([::1]:45754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8gfN-00008t-Q0 for importer@patchew.org; Tue, 05 Jul 2022 07:24:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gI5-0006wH-Ut for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:26 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:53143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gI0-0000jX-T9 for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:24 -0400 Received: by mail-pj1-x102e.google.com with SMTP id fz10so5705231pjb.2 for ; Tue, 05 Jul 2022 04:00:20 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l2yErBWzj5ESCHU8EEDRL6D/1bAkAZGvE1eyYa7hP9s=; b=L4pE2MJ4f1tjX8pmM0ptFwGkw2raZ3UFH2QlkNjOhkv1wPRYa2iQgochHgiOgaJKlQ Gsc0iPkLL5vRO9vGOffuWpYOzAv6meBujVNhsP7Dxy6aUD4jM5bTVc4O6RcQxhIfo7rw mc6T7dkZ0TsGsXeDMgSZ6Krh1AurPHH6SbyL2Lkw938P+qMCSZZBMnu/HKp/xHzdErVM pyXTRLtJdn5PKa+kVZwAehYvaVpYalh39BXqgJNyQtBVBoTD5fvrI25Cl1os2ZTFlLRr mIGCtlLi6brqjp8zPmY8DzplupPN5XWCoaueBMzUZ/PiRsl+nOri6W574JBuRyTIUhoF Agaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l2yErBWzj5ESCHU8EEDRL6D/1bAkAZGvE1eyYa7hP9s=; b=xUpkeWjpGjopkkgmWDmofbmlMlPB4z26M5LQTwNKlR8UvqxxitjC7RZlZUkGZneLes 9ysTudOQOBBJe+uSTFrRlwauzdRTvgju2fWacEn7KQ2fhDdXOMZr8qRRRR+pk/J2n9uD oB6T65i01Uw3Pm9pH32tK5aCWPYl+pQ8jUEa8ERTbl1Ec1arNMlbm7z/z9Z3J5BSi7VQ E+DSFnVd3pyfQWS1HT0MFuWrNg1E/HbBW09Lxx/Y+HvRvv8kWLNRP22iQDTc1V7Y7JTJ ihuwPogZ89a46efR5OW7TgWnw0DpwNgPo+3tyNYe0i2HTbVMaIFF2LHQd3daxn7IJHKS 4OXQ== X-Gm-Message-State: AJIora9rxFSpv465VTDvYM4SP3HHRea7wADcXzeKVcmP7QcbXihVyxYm NVdtUeKDVhLvJWNSqalxApfi03PqfxtYCpul X-Google-Smtp-Source: AGRyM1sgVONXjs3G1Mc+JzqXL9TYkfqHdKkrfXDqNgihbRtG/I348fs4JMR70EJxyxaJONH7X6hiGA== X-Received: by 2002:a17:903:2614:b0:16b:d519:d1e2 with SMTP id jd20-20020a170903261400b0016bd519d1e2mr16800847plb.93.1657018819671; Tue, 05 Jul 2022 04:00:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Xiaojuan Yang Subject: [PULL 6/6] hw/intc/loongarch_ipi: Fix mail send and any send function Date: Tue, 5 Jul 2022 16:29:57 +0530 Message-Id: <20220705105957.1144514-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657020273238100001 Content-Type: text/plain; charset="utf-8" From: Xiaojuan Yang By the document of ipi mailsend device, byte is written only when the mask = bit is 0. The original code discards mask bit and overwrite the data always, th= is patch fixes the issue. Signed-off-by: Xiaojuan Yang Message-Id: <20220705064901.2353349-3-yangxiaojuan@loongson.cn> Signed-off-by: Richard Henderson --- hw/intc/loongarch_ipi.c | 54 +++++++++++++++++++++++------------------ 1 file changed, 31 insertions(+), 23 deletions(-) diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c index b8b1b9cd53..4f3c58f872 100644 --- a/hw/intc/loongarch_ipi.c +++ b/hw/intc/loongarch_ipi.c @@ -50,35 +50,45 @@ static uint64_t loongarch_ipi_readl(void *opaque, hwadd= r addr, unsigned size) return ret; } =20 -static int get_ipi_data(target_ulong val) +static void send_ipi_data(CPULoongArchState *env, target_ulong val, target= _ulong addr) { - int i, mask, data; + int i, mask =3D 0, data =3D 0; =20 - data =3D val >> 32; - mask =3D (val >> 27) & 0xf; - - for (i =3D 0; i < 4; i++) { - if ((mask >> i) & 1) { - data &=3D ~(0xff << (i * 8)); + /* + * bit 27-30 is mask for byte writing, + * if the mask is 0, we need not to do anything. + */ + if ((val >> 27) & 0xf) { + data =3D address_space_ldl(&env->address_space_iocsr, addr, + MEMTXATTRS_UNSPECIFIED, NULL); + for (i =3D 0; i < 4; i++) { + /* get mask for byte writing */ + if (val & (0x1 << (27 + i))) { + mask |=3D 0xff << (i * 8); + } } } - return data; + + data &=3D mask; + data |=3D (val >> 32) & ~mask; + address_space_stl(&env->address_space_iocsr, addr, + data, MEMTXATTRS_UNSPECIFIED, NULL); } =20 static void ipi_send(uint64_t val) { int cpuid, data; CPULoongArchState *env; + CPUState *cs; + LoongArchCPU *cpu; =20 cpuid =3D (val >> 16) & 0x3ff; /* IPI status vector */ data =3D 1 << (val & 0x1f); - qemu_mutex_lock_iothread(); - CPUState *cs =3D qemu_get_cpu(cpuid); - LoongArchCPU *cpu =3D LOONGARCH_CPU(cs); + cs =3D qemu_get_cpu(cpuid); + cpu =3D LOONGARCH_CPU(cs); env =3D &cpu->env; loongarch_cpu_set_irq(cpu, IRQ_IPI, 1); - qemu_mutex_unlock_iothread(); address_space_stl(&env->address_space_iocsr, 0x1008, data, MEMTXATTRS_UNSPECIFIED, NULL); =20 @@ -86,23 +96,23 @@ static void ipi_send(uint64_t val) =20 static void mail_send(uint64_t val) { - int cpuid, data; + int cpuid; hwaddr addr; CPULoongArchState *env; + CPUState *cs; + LoongArchCPU *cpu; =20 cpuid =3D (val >> 16) & 0x3ff; addr =3D 0x1020 + (val & 0x1c); - CPUState *cs =3D qemu_get_cpu(cpuid); - LoongArchCPU *cpu =3D LOONGARCH_CPU(cs); + cs =3D qemu_get_cpu(cpuid); + cpu =3D LOONGARCH_CPU(cs); env =3D &cpu->env; - data =3D get_ipi_data(val); - address_space_stl(&env->address_space_iocsr, addr, - data, MEMTXATTRS_UNSPECIFIED, NULL); + send_ipi_data(env, val, addr); } =20 static void any_send(uint64_t val) { - int cpuid, data; + int cpuid; hwaddr addr; CPULoongArchState *env; =20 @@ -111,9 +121,7 @@ static void any_send(uint64_t val) CPUState *cs =3D qemu_get_cpu(cpuid); LoongArchCPU *cpu =3D LOONGARCH_CPU(cs); env =3D &cpu->env; - data =3D get_ipi_data(val); - address_space_stl(&env->address_space_iocsr, addr, - data, MEMTXATTRS_UNSPECIFIED, NULL); + send_ipi_data(env, val, addr); } =20 static void loongarch_ipi_writel(void *opaque, hwaddr addr, uint64_t val, --=20 2.34.1 From nobody Tue Feb 10 10:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1657019668; cv=none; d=zohomail.com; s=zohoarc; b=IBGD7GiGB8rlgtsUaK1JngTCnYqD0J396LE4krv4y0sg991o59jwV7VLiFUVElphZRb/bPbweeTVCf0oEQKKOtzzahqtQjbIXvSpndQfiYaGjfIBBOTylzzOgLw0uj1L17JM/Ddz/xBkM93PzPMIoNKYTyetDhvxTmsNARpwVSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657019668; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cb/72d2FcQmj3zj3zP3mY08HLs4aMXys8/KVOUFQofg=; b=epNzq+csiM8RAJNTAg9hiebrugSxb8Lxp1rsJCmSTpEM1C9qjkMlLCoanvJRW4ySOTQ5eEAI0Q+QlHVm4/EKfhZKvpMdvY7iDvmr/1CcSa82UbZtBDleSwf7vMm9/AuBdCAGGJbf5W1n08rWde29vE0EMr8+1vIjTt1g6DZz2VM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1657019668515655.693244046933; Tue, 5 Jul 2022 04:14:28 -0700 (PDT) Received: from localhost ([::1]:58282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8gVe-0005rN-KQ for importer@patchew.org; Tue, 05 Jul 2022 07:14:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8gHs-0006t6-53 for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:12 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:33755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8gHo-0000fV-KP for qemu-devel@nongnu.org; Tue, 05 Jul 2022 07:00:11 -0400 Received: by mail-pf1-x42b.google.com with SMTP id n12so11234743pfq.0 for ; Tue, 05 Jul 2022 04:00:08 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id d18-20020a170903231200b0016bf7981d0bsm508454plh.86.2022.07.05.04.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 04:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cb/72d2FcQmj3zj3zP3mY08HLs4aMXys8/KVOUFQofg=; b=mVKMpvJChQOAkaM3IfHVisIBF5KDEj6nXN5i52Iqx5BL7Avk58y6BpkTAqHvaacwEQ YrGV41aVFv+sQTCZg1aQzYHZ7VMNLEK3uzFAe/qO1FSnYlsEG5CLRAUQ/iLwXUW4CE+5 zQ+bUAw98S6edzpCU3GY5PrurZnP9RSq9X7aaiWtWObHdUzVLMdSLy7TR2nN54IcK5yV AczwanNBDTI/3OW/X13zkadprMRuf2Ls5xjAP/UVEig4Q5E1iMe0S/SFb2dK/FfcQXxA 8NkWCIwK/W4AT3wAH9ikSf9l6QMRAbXe24px/4zBfmwiJHOvMtHjX5EmGgEywzO+and8 qQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cb/72d2FcQmj3zj3zP3mY08HLs4aMXys8/KVOUFQofg=; b=DtBWQ0J3TlgHOJA5vNRg1uzsIGnZ2p1Jzsq9ALXuJhi4gUvVp0EAwCCf3yjbM/vyOB jh0w2iYOM9eh/GK3ny28nycuG81o0nmbs9V5HAZHYTZvZj04bKh9kTDIDBFsFIH/qrod q7e2HYd+xHw3Sk661waWerlG+2Q+qX7LAMcIQBocPd0cc29u0Ck5Of/ctdOsxAH6nphS tu1tZV5DphOwG9of1fUK6muNlc8WdcH5bg3yt8VDn+ptcP+QNMj8uHtEf+0gm1qX3LdP tLVjyLsVyO0PaEirfIvReyYAFltJ21ibc+Y1GxSpXmXj/AfaTOjYk5098OaxU4Dmyvs3 FE1w== X-Gm-Message-State: AJIora8PBb7HHi4Fo8xBVSqYupgqZEEfA/NxGzPC9QX5fUYknzdRNy9C 0LZ1Jvl/uNjNSzMvFAm/VmSavFhZwEWCJXOx X-Google-Smtp-Source: AGRyM1tE2dWvbm5lw030EDAGKwt6L49aVoJlbdb0XC/6IHfDX3kkJDC9IR8diNJ4MPSQCtzgx5ZeiA== X-Received: by 2002:a05:6a00:1410:b0:528:5a5a:d846 with SMTP id l16-20020a056a00141000b005285a5ad846mr14619647pfu.9.1657018807217; Tue, 05 Jul 2022 04:00:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Song Gao Subject: [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Date: Tue, 5 Jul 2022 16:29:52 +0530 Message-Id: <20220705105957.1144514-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705105957.1144514-1-richard.henderson@linaro.org> References: <20220705105957.1144514-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1657019669806100001 Content-Type: text/plain; charset="utf-8" There is nothing in this environment variable that cannot be done better with -d flags. There is nothing special about TCI that warrants this hack. Moreover, it does not compile -- remove it. Reported-by: Song Gao Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.h | 5 ----- tcg/tci/tcg-target.c.inc | 7 ------- 2 files changed, 12 deletions(-) diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h index 033e613f24..ceb36c4f7a 100644 --- a/tcg/tci/tcg-target.h +++ b/tcg/tci/tcg-target.h @@ -53,11 +53,6 @@ # error Unknown pointer size for tci target #endif =20 -#ifdef CONFIG_DEBUG_TCG -/* Enable debug output. */ -#define CONFIG_DEBUG_TCG_INTERPRETER -#endif - /* Optional instructions. */ =20 #define TCG_TARGET_HAS_bswap16_i32 1 diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index 98337c567a..f3d7441e06 100644 --- a/tcg/tci/tcg-target.c.inc +++ b/tcg/tci/tcg-target.c.inc @@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int cou= nt) =20 static void tcg_target_init(TCGContext *s) { -#if defined(CONFIG_DEBUG_TCG_INTERPRETER) - const char *envval =3D getenv("DEBUG_TCG"); - if (envval) { - qemu_set_log(strtol(envval, NULL, 0)); - } -#endif - /* The current code uses uint8_t for tcg operations. */ tcg_debug_assert(tcg_op_defs_max <=3D UINT8_MAX); =20 --=20 2.34.1