From nobody Tue Feb 10 20:07:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1656415659613625.7982589866984; Tue, 28 Jun 2022 04:27:39 -0700 (PDT) Received: from localhost ([::1]:53478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o69Na-0007rl-Er for importer@patchew.org; Tue, 28 Jun 2022 07:27:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o69Dc-0003lV-Tm for qemu-devel@nongnu.org; Tue, 28 Jun 2022 07:17:20 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:46700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o69Db-0003Ak-0I for qemu-devel@nongnu.org; Tue, 28 Jun 2022 07:17:20 -0400 Received: by mail-pj1-x1031.google.com with SMTP id h9-20020a17090a648900b001ecb8596e43so12286038pjj.5 for ; Tue, 28 Jun 2022 04:17:18 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id a8-20020a654188000000b003fd4831e6fesm9079283pgq.70.2022.06.28.04.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 04:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w6sA15MForuaAbeYWpiX93UQp8+cxumrK25JuRIu/m4=; b=IOzbJ02nBmlOJihZ38QTs2VsuwRlAU4cIvO6kJbgEhrGNihV/CXIG4TqxWyJLu6fTn K23lC4ulbfSoazLAa6owD9CR5vrjKwBAgjVn4RsdImhAGNXmJDnagKtPH3o4Nw08JYrM QFN1zZYUQyjoxfzLybMYxHJJSQ6RFqVSXE1yImQozmR9NOpXpWUj/ijc+rEbdGh7yyBo JTj8FuMl464gJ8Hs1RXe52ESKg5dKEE1fJOYypi1NJ8+gViKLXIfPro9KPgQExgYcPk9 bEOrvECr7T3xRPtIoVQnw1KMmZ26yJkBYz5QUljb5Hfci31aEgxefXASphTUAJJo/zhJ Wx2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w6sA15MForuaAbeYWpiX93UQp8+cxumrK25JuRIu/m4=; b=2udH4hius1EKkwjsfDHB1LJn/L9dMGROT0niaM8Lhyu5t+KslrxkATX/G7VM5j77jZ vG41kh4wbjryzYXo+By9I2IJXa7naOSG1xVLphb6SA1vleVXoKtE3QTD4TMkMSm3A1Jf 0d/NyakFZkyEYssJ7PNjBujsrmB7R4Nx4ve5dmcNhbHVPmv6ZpjaMfqU6bl8PDAb9S7J 4BtKjEUkEDpO9gn7amDg2fi5eVsFgzG6zYpRqF06rUo5ZCKsLZyKeCyhnE1SKHqgEB+G a14fk72Ylu3fqhg7DQ1ICAgmLl/JCZUtRr7+um3VuKxaxNJimNvsKMVxE5avQ2h9dL2y nooA== X-Gm-Message-State: AJIora+BLw1S/gLJmBgfNBihSz7K6pqH73xVt+FMTIccFj6GVHHnh/P4 NB/tk6b52BEggKWYD/wVZyrhU8wQa2yPdw== X-Google-Smtp-Source: AGRyM1u3Qp2Io1BQfFcnz0UdUhLBiUu2NpP/DyzAQNdtEOaJG8t1CjcQpuNLny/K2yOzAa/He2Apvg== X-Received: by 2002:a17:90a:c782:b0:1ec:eea2:4236 with SMTP id gn2-20020a17090ac78200b001eceea24236mr21127996pjb.20.1656415038236; Tue, 28 Jun 2022 04:17:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: f4bug@amsat.org, alex.bennee@linaro.org, jiaxun.yang@flygoat.com, aleksandar.rikalo@syrmia.com Subject: [PATCH v5 3/8] target/mips: Use semihosting/syscalls.h Date: Tue, 28 Jun 2022 16:46:56 +0530 Message-Id: <20220628111701.677216-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220628111701.677216-1-richard.henderson@linaro.org> References: <20220628111701.677216-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1656415661025100001 Content-Type: text/plain; charset="utf-8" This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/sysemu/mips-semi.c | 219 +++++++++++++---------------- 1 file changed, 95 insertions(+), 124 deletions(-) diff --git a/target/mips/tcg/sysemu/mips-semi.c b/target/mips/tcg/sysemu/mi= ps-semi.c index 93c9d3d0b3..5b78cf21a7 100644 --- a/target/mips/tcg/sysemu/mips-semi.c +++ b/target/mips/tcg/sysemu/mips-semi.c @@ -20,9 +20,11 @@ #include "qemu/osdep.h" #include "cpu.h" #include "qemu/log.h" +#include "exec/gdbstub.h" #include "semihosting/softmmu-uaccess.h" #include "semihosting/semihost.h" #include "semihosting/console.h" +#include "semihosting/syscalls.h" #include "internal.h" =20 typedef enum UHIOp { @@ -121,101 +123,79 @@ static void report_fault(CPUMIPSState *env) abort(); } =20 -static int errno_mips(int host_errno) +static void uhi_cb(CPUState *cs, uint64_t ret, int err) { - /* Errno values taken from asm-mips/errno.h */ - switch (host_errno) { - case 0: return 0; - case ENAMETOOLONG: return 78; -#ifdef EOVERFLOW - case EOVERFLOW: return 79; -#endif -#ifdef ELOOP - case ELOOP: return 90; -#endif - default: return EINVAL; - } -} + CPUMIPSState *env =3D cs->env_ptr; =20 -static int copy_stat_to_target(CPUMIPSState *env, const struct stat *src, - target_ulong vaddr) -{ - hwaddr len =3D sizeof(struct UHIStat); - UHIStat *dst =3D lock_user(VERIFY_WRITE, vaddr, len, 0); - if (!dst) { +#define E(N) case E##N: err =3D UHI_E##N; break + + switch (err) { + case 0: + break; + E(PERM); + E(NOENT); + E(INTR); + E(BADF); + E(BUSY); + E(EXIST); + E(NOTDIR); + E(ISDIR); + E(INVAL); + E(NFILE); + E(MFILE); + E(FBIG); + E(NOSPC); + E(SPIPE); + E(ROFS); + E(NAMETOOLONG); + default: + err =3D UHI_EINVAL; + break; + case EFAULT: report_fault(env); } =20 - dst->uhi_st_dev =3D tswap16(src->st_dev); - dst->uhi_st_ino =3D tswap16(src->st_ino); - dst->uhi_st_mode =3D tswap32(src->st_mode); - dst->uhi_st_nlink =3D tswap16(src->st_nlink); - dst->uhi_st_uid =3D tswap16(src->st_uid); - dst->uhi_st_gid =3D tswap16(src->st_gid); - dst->uhi_st_rdev =3D tswap16(src->st_rdev); - dst->uhi_st_size =3D tswap64(src->st_size); - dst->uhi_st_atime =3D tswap64(src->st_atime); - dst->uhi_st_mtime =3D tswap64(src->st_mtime); - dst->uhi_st_ctime =3D tswap64(src->st_ctime); -#ifdef _WIN32 - dst->uhi_st_blksize =3D 0; - dst->uhi_st_blocks =3D 0; -#else - dst->uhi_st_blksize =3D tswap64(src->st_blksize); - dst->uhi_st_blocks =3D tswap64(src->st_blocks); -#endif - unlock_user(dst, vaddr, len); - return 0; +#undef E + + env->active_tc.gpr[2] =3D ret; + env->active_tc.gpr[3] =3D err; } =20 -static int get_open_flags(target_ulong target_flags) +static void uhi_fstat_cb(CPUState *cs, uint64_t ret, int err) { - int open_flags =3D 0; + QEMU_BUILD_BUG_ON(sizeof(UHIStat) < sizeof(struct gdb_stat)); =20 - if (target_flags & UHIOpen_RDWR) { - open_flags |=3D O_RDWR; - } else if (target_flags & UHIOpen_WRONLY) { - open_flags |=3D O_WRONLY; - } else { - open_flags |=3D O_RDONLY; + if (!err) { + CPUMIPSState *env =3D cs->env_ptr; + target_ulong addr =3D env->active_tc.gpr[5]; + UHIStat *dst =3D lock_user(VERIFY_WRITE, addr, sizeof(UHIStat), 1); + struct gdb_stat s; + + if (!dst) { + report_fault(env); + } + + memcpy(&s, dst, sizeof(struct gdb_stat)); + memset(dst, 0, sizeof(UHIStat)); + + dst->uhi_st_dev =3D tswap16(be32_to_cpu(s.gdb_st_dev)); + dst->uhi_st_ino =3D tswap16(be32_to_cpu(s.gdb_st_ino)); + dst->uhi_st_mode =3D tswap32(be32_to_cpu(s.gdb_st_mode)); + dst->uhi_st_nlink =3D tswap16(be32_to_cpu(s.gdb_st_nlink)); + dst->uhi_st_uid =3D tswap16(be32_to_cpu(s.gdb_st_uid)); + dst->uhi_st_gid =3D tswap16(be32_to_cpu(s.gdb_st_gid)); + dst->uhi_st_rdev =3D tswap16(be32_to_cpu(s.gdb_st_rdev)); + dst->uhi_st_size =3D tswap64(be64_to_cpu(s.gdb_st_size)); + dst->uhi_st_atime =3D tswap64(be32_to_cpu(s.gdb_st_atime)); + dst->uhi_st_mtime =3D tswap64(be32_to_cpu(s.gdb_st_mtime)); + dst->uhi_st_ctime =3D tswap64(be32_to_cpu(s.gdb_st_ctime)); + dst->uhi_st_blksize =3D tswap64(be64_to_cpu(s.gdb_st_blksize)); + dst->uhi_st_blocks =3D tswap64(be64_to_cpu(s.gdb_st_blocks)); + + unlock_user(dst, addr, sizeof(UHIStat)); } =20 - open_flags |=3D (target_flags & UHIOpen_APPEND) ? O_APPEND : 0; - open_flags |=3D (target_flags & UHIOpen_CREAT) ? O_CREAT : 0; - open_flags |=3D (target_flags & UHIOpen_TRUNC) ? O_TRUNC : 0; - open_flags |=3D (target_flags & UHIOpen_EXCL) ? O_EXCL : 0; - - return open_flags; -} - -static int write_to_file(CPUMIPSState *env, target_ulong fd, - target_ulong vaddr, target_ulong len) -{ - int num_of_bytes; - void *dst =3D lock_user(VERIFY_READ, vaddr, len, 1); - if (!dst) { - report_fault(env); - } - - num_of_bytes =3D write(fd, dst, len); - - unlock_user(dst, vaddr, 0); - return num_of_bytes; -} - -static int read_from_file(CPUMIPSState *env, target_ulong fd, - target_ulong vaddr, target_ulong len) -{ - int num_of_bytes; - void *dst =3D lock_user(VERIFY_WRITE, vaddr, len, 0); - if (!dst) { - report_fault(env); - } - - num_of_bytes =3D read(fd, dst, len); - - unlock_user(dst, vaddr, len); - return num_of_bytes; + uhi_cb(cs, ret, err); } =20 static int copy_argn_to_target(CPUMIPSState *env, int arg_num, @@ -260,68 +240,59 @@ static int copy_argn_to_target(CPUMIPSState *env, int= arg_num, =20 void mips_semihosting(CPUMIPSState *env) { + CPUState *cs =3D env_cpu(env); target_ulong *gpr =3D env->active_tc.gpr; const UHIOp op =3D gpr[25]; char *p, *p2; =20 switch (op) { case UHI_exit: - qemu_log("UHI(%d): exit(%d)\n", op, (int)gpr[4]); + gdb_exit(gpr[4]); exit(gpr[4]); + case UHI_open: - GET_TARGET_STRING(p, gpr[4]); - if (!strcmp("/dev/stdin", p)) { - gpr[2] =3D 0; - } else if (!strcmp("/dev/stdout", p)) { - gpr[2] =3D 1; - } else if (!strcmp("/dev/stderr", p)) { - gpr[2] =3D 2; - } else { - gpr[2] =3D open(p, get_open_flags(gpr[5]), gpr[6]); - gpr[3] =3D errno_mips(errno); + { + int ret =3D -1; + + GET_TARGET_STRING(p, gpr[4]); + if (!strcmp("/dev/stdin", p)) { + ret =3D 0; + } else if (!strcmp("/dev/stdout", p)) { + ret =3D 1; + } else if (!strcmp("/dev/stderr", p)) { + ret =3D 2; + } + FREE_TARGET_STRING(p, gpr[4]); + + /* FIXME: reusing a guest fd doesn't seem correct. */ + if (ret >=3D 0) { + gpr[2] =3D ret; + break; + } + + semihost_sys_open(cs, uhi_cb, gpr[4], 0, gpr[5], gpr[6]); } - FREE_TARGET_STRING(p, gpr[4]); break; + case UHI_close: - if (gpr[4] < 3) { - /* ignore closing stdin/stdout/stderr */ - gpr[2] =3D 0; - return; - } - gpr[2] =3D close(gpr[4]); - gpr[3] =3D errno_mips(errno); + semihost_sys_close(cs, uhi_cb, gpr[4]); break; case UHI_read: - gpr[2] =3D read_from_file(env, gpr[4], gpr[5], gpr[6]); - gpr[3] =3D errno_mips(errno); + semihost_sys_read(cs, uhi_cb, gpr[4], gpr[5], gpr[6]); break; case UHI_write: - gpr[2] =3D write_to_file(env, gpr[4], gpr[5], gpr[6]); - gpr[3] =3D errno_mips(errno); + semihost_sys_write(cs, uhi_cb, gpr[4], gpr[5], gpr[6]); break; case UHI_lseek: - gpr[2] =3D lseek(gpr[4], gpr[5], gpr[6]); - gpr[3] =3D errno_mips(errno); + semihost_sys_lseek(cs, uhi_cb, gpr[4], gpr[5], gpr[6]); break; case UHI_unlink: - GET_TARGET_STRING(p, gpr[4]); - gpr[2] =3D remove(p); - gpr[3] =3D errno_mips(errno); - FREE_TARGET_STRING(p, gpr[4]); + semihost_sys_remove(cs, uhi_cb, gpr[4], 0); break; case UHI_fstat: - { - struct stat sbuf; - memset(&sbuf, 0, sizeof(sbuf)); - gpr[2] =3D fstat(gpr[4], &sbuf); - gpr[3] =3D errno_mips(errno); - if (gpr[2]) { - return; - } - gpr[2] =3D copy_stat_to_target(env, &sbuf, gpr[5]); - gpr[3] =3D errno_mips(errno); - } + semihost_sys_fstat(cs, uhi_fstat_cb, gpr[4], gpr[5]); break; + case UHI_argc: gpr[2] =3D semihosting_get_argc(); break; --=20 2.34.1