From nobody Tue Feb 10 22:56:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1656268582372188.7520916033708; Sun, 26 Jun 2022 11:36:22 -0700 (PDT) Received: from localhost ([::1]:58056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5X7M-0008TM-Ti for importer@patchew.org; Sun, 26 Jun 2022 14:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5WSB-0005Zc-AE for qemu-devel@nongnu.org; Sun, 26 Jun 2022 13:53:47 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:45310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5WS4-0000xD-HY for qemu-devel@nongnu.org; Sun, 26 Jun 2022 13:53:42 -0400 Received: from [2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab] (helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5WMD-0007KY-Tc; Sun, 26 Jun 2022 18:47:41 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UrTrhI4ZHDBVA3zY3jrVw/QjkSmppvXZMjErcrPy788=; b=Ni3kDYj/vKAs7g+7wkkcIQ6RDJ RqKQVB16ek3rnaKa+pz/J4M7W3e75tkFpesgABK83tjuHLoMrl5drZiiS9G4d5kHqZogP/tTxSmtG m6XnjC87yLo9EJJrhB18gbXpdhHCHj2zZkIcThL5sgxwxpECb8/LQ2pwvt/lxBJ+hZGJKRc+n/8L3 kGZjGbDsfLpyNXAHRIPUOyFVrShxgU2pE6xZk63ywH09dh8X1vRDh6QGX2aRORCHh9z/QwpiPi60w AQ9/8DMgKoaSy8MLOKlJEq+Rc+jimDXnMMqwu6AI2toZ51wUug8QsepIkTNMjzPt7h3KoFx7Wc7n8 51Oq6a2rIdqW5gW1n9SE7sPd7agm0Q5fwxzL8V29lrPYzUgYqr7UCmr50Nfp5avrzhz7EXBRPm4Hr 4B7iyM1DxS7nxhkqQVlAClOrYVwkgxHSDL5ipRI+SJgMx9ebZ4OEd4HXPT2F4y/wbdu4y6zpWC8cL SVlO2n+GegUXEcqsVUd4zc1kn2wPR49QXIyzDK3tYqwXq/lwdrgLdbUKv8Q+Kom61WLoujMpVWwV4 VvfTMLjDdAsuwbVZRiE4fxjwIyqRvIGlUFqu6BHll9YUfBjXBmLEA5uMhdOamI8z4NaU4iUC2lyyo RXqoI5QrDo7GprqwQ4lZucpxWVOvq7OSaSLXZQDB4=; From: Mark Cave-Ayland To: richard.henderson@linaro.org, qemu-devel@nongnu.org Date: Sun, 26 Jun 2022 18:45:27 +0100 Message-Id: <20220626174531.969187-52-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220626174531.969187-1-mark.cave-ayland@ilande.co.uk> References: <20220626174531.969187-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 51/55] pckbd: add i8042_reset() function to I8042 device X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1656268583572100001 Content-Type: text/plain; charset="utf-8" This means that it is no longer necessary to call qemu_register_reset() man= ually within i8042_realizefn(). Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220624134109.881989-52-mark.cave-ayland@ilande.co.uk> --- hw/input/pckbd.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index ee306428a3..ff76c0636d 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -808,6 +808,14 @@ static const MemoryRegionOps i8042_cmd_ops =3D { .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 +static void i8042_reset(DeviceState *dev) +{ + ISAKBDState *s =3D I8042(dev); + KBDState *ks =3D &s->kbd; + + kbd_reset(ks); +} + static void i8042_initfn(Object *obj) { ISAKBDState *isa_s =3D I8042(obj); @@ -854,7 +862,6 @@ static void i8042_realizefn(DeviceState *dev, Error **e= rrp) s->throttle_timer =3D timer_new_us(QEMU_CLOCK_VIRTUAL, kbd_throttle_timeout, s); } - qemu_register_reset(kbd_reset, s); } =20 static void i8042_build_aml(AcpiDevAmlIf *adev, Aml *scope) @@ -900,6 +907,7 @@ static void i8042_class_initfn(ObjectClass *klass, void= *data) AcpiDevAmlIfClass *adevc =3D ACPI_DEV_AML_IF_CLASS(klass); =20 device_class_set_props(dc, i8042_properties); + dc->reset =3D i8042_reset; dc->realize =3D i8042_realizefn; dc->vmsd =3D &vmstate_kbd_isa; adevc->build_dev_aml =3D i8042_build_aml; --=20 2.30.2