From nobody Tue May 21 14:23:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655906760; cv=none; d=zohomail.com; s=zohoarc; b=ZduB7RXkeyQgKsfhnIoA2GF3eUPvQ73+NNeyLaqV7QpLjO/+Nu97L0wyfVcctm/rkPoyO97tfGApK6lqwYio539VBPqFQpcckjsH5MdJr1RI/1/U3/JWn66MuBv4Nq0iXyeoxJUq3HXy4Ot405rSLyfHeYkIfkfiQ8svmMkUhg4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655906760; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=LIWjinE2AJh0qaz5Kku0jJs1fQUMaBcf4Q9GPcpSMDI=; b=lUnp3e765Vy0rqKhsDravtsf3Tr6aj/B85Ld93r80HfkqaGz0jYLy8fu3LJf6mL3pD70pM+RLq8Q3jZR7nlRT3OpdVUYJocwBwEmFvci+IjBTPs2frjMvh6CTwGetTtf1XfLgJZM6CqPVGw42Byu+g1kpyvAnmpiAxTqnkjd1Xg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655906760178224.57523788032677; Wed, 22 Jun 2022 07:06:00 -0700 (PDT) Received: from localhost ([::1]:58564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o40zW-0008Eo-Nj for importer@patchew.org; Wed, 22 Jun 2022 10:05:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o40xP-0007Lv-Je for qemu-devel@nongnu.org; Wed, 22 Jun 2022 10:03:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:52858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o40xH-0001hA-3o for qemu-devel@nongnu.org; Wed, 22 Jun 2022 10:03:47 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-WjjHLPqIPSuh1Q6j6DUjSA-1; Wed, 22 Jun 2022 10:03:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 316068117B0; Wed, 22 Jun 2022 14:03:33 +0000 (UTC) Received: from thuth.com (unknown [10.39.193.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C4FE1121314; Wed, 22 Jun 2022 14:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655906618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LIWjinE2AJh0qaz5Kku0jJs1fQUMaBcf4Q9GPcpSMDI=; b=agZA0NdQrC99CMe2/pcAxjHAckHNtBBB5FR033zUu1vbW+sEISH3tTKOIQk80elYJ9hTM3 7O3SnKEnDuQCtd+K9dbAZQvLdBhldJ87xY1UAHFypa0x0IrcsOy6WamCoAM4BF6VQYubXp BgIdEjNo9Ec/aANl1xGzklMZR17X+L8= X-MC-Unique: WjjHLPqIPSuh1Q6j6DUjSA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Riku Voipio Cc: Michael Tokarev , qemu-trivial@nongnu.org, Paolo Bonzini Subject: [PATCH] common-user: Only compile the common user code if have_user is set Date: Wed, 22 Jun 2022 16:03:28 +0200 Message-Id: <20220622140328.383961-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655906762212100001 Content-Type: text/plain; charset="utf-8" There is no need to waste cycles here if we only compile the system binaries or tools. Additionally, this change is even a hard requirement for building the tools on systems that do not have an entry in the common-user/host/ folder (since common-user/meson.build is trying to add such a path via the include_directories() command). Reported-by: Michael Tokarev Signed-off-by: Thomas Huth Reviewed-by: Zhang Chen --- common-user/meson.build | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/common-user/meson.build b/common-user/meson.build index 26212dda5c..ac9de5b9e3 100644 --- a/common-user/meson.build +++ b/common-user/meson.build @@ -1,3 +1,7 @@ +if not have_user + subdir_done() +endif + common_user_inc +=3D include_directories('host/' / host_arch) =20 user_ss.add(files( --=20 2.31.1