From nobody Tue Feb 10 23:33:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655896181188159.19398628964984; Wed, 22 Jun 2022 04:09:41 -0700 (PDT) Received: from localhost ([::1]:48930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3yEt-0005Uu-NX for importer@patchew.org; Wed, 22 Jun 2022 07:09:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3y03-0005O0-HG; Wed, 22 Jun 2022 06:54:19 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:37914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3y01-0005VE-1i; Wed, 22 Jun 2022 06:54:18 -0400 Received: from [2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab] (helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3xyl-000CTX-AW; Wed, 22 Jun 2022 11:53:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fR1Oy9W+Xu92DlbOOc7CXAQKUKAY9ogsV4xn/aN/XAA=; b=KL5uDnneGOL89itqx0uBQYJEpe fxZNBFOTWSSTPw0XaIlYQlX0LB3TFXsfTHJRhHBAi1roK08Wbx+lwtPy7mIt66NWTssJtoff/0T+F i3/WJmAMKr1o5Tz6ksX96hJCBI4ag0/bjJEbGCJ+fUia4AkAobbydlQC1bRJ+pxrRi3x3q7ctKOgB VGkJNDSNgsyHHieJAG/Sr0x/Ij+GX7uJtQ2VqOaU6SbgGKLTu7u8DDezGQh4czTEZXChYavBWdeET C4Rkxav93n4f8+R6h+pCPpmT8gp/7w6kvuVFG7brAZyuJIpDaZB2nh3XvHaIbRRhAsCvUH6zl7lnV OrQOhmRyTsz3FJw7bp4uUbnGDcbHVd15LkxySZY4j/B4Jfkk5UiG2exCRgOZGWEjKeO599IPqGrfO Mey2VnoRkGHkHUNlYSUjqo7LznqSURsst4TnoZ5BHJWi9jCZwCpUQ5xZbTEX09nieNq4dSZES/4ul YCYTj0zoNqwjggvGHsePIwNteb2LGImgDUZ9yZzeGbtQ/v+PSpHspXvnzA6G+Le3vBR1qRLJ9xs87 6qeeYeHEomqpxsvwoCKa7S/yF6z3t99c57+0OpbDMe+quPuvCc+HmBZNO8Co/cBVgloUMnSCAKBK5 lLk74cQ0QbajzJZwdSP+ALTRyfqWzdzoLlY9yBEF0=; From: Mark Cave-Ayland To: pbonzini@redhat.com, laurent@vivier.eu, fam@euphon.net, qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Wed, 22 Jun 2022 11:53:11 +0100 Message-Id: <20220622105314.802852-12-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220622105314.802852-1-mark.cave-ayland@ilande.co.uk> References: <20220622105314.802852-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v3 11/14] scsi-disk: allow the MODE_PAGE_R_W_ERROR AWRE bit to be changeable for CDROM drives X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1655896182997100001 Content-Type: text/plain; charset="utf-8" A/UX sends a MODE_PAGE_R_W_ERROR command with the AWRE bit set to 0 when en= umerating CDROM drives. Since the bit is currently hardcoded to 1 then indicate that = the AWRE bit can be changed (even though we don't care about the value) so that the MODE_PAGE_R_W_ERROR page can be set successfully. Signed-off-by: Mark Cave-Ayland --- hw/scsi/scsi-disk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index b225ec1a4c..3659583e13 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1188,6 +1188,10 @@ static int mode_sense_page(SCSIDiskState *s, int pag= e, uint8_t **p_outbuf, case MODE_PAGE_R_W_ERROR: length =3D 10; if (page_control =3D=3D 1) { /* Changeable Values */ + if (s->qdev.type =3D=3D TYPE_ROM) { + /* Automatic Write Reallocation Enabled */ + p[0] =3D 0x80; + } break; } p[0] =3D 0x80; /* Automatic Write Reallocation Enabled */ --=20 2.30.2