From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550419; cv=none; d=zohomail.com; s=zohoarc; b=bZx98CiUeJjeivGtYQOobDl759SdlLQqABW9LwSO0HrbIekpHOXatBgZ/faCjpua7wm463YVnaQZp9BegPBj/LN2waw3M/LFJ5covXrTVMZ41SFkPtQBjuDYhB27REwkbdlsQjcFuHvMnB4etxX+/Igy0z6BZBYZX+9+hjyMEoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550419; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2sjQ1PEwzNrRmTof4HPK2BqFxFXmrYidB2rpovzMR6g=; b=eGJQPbLzMVGdTVWD4/AAUgQ2CDAJnQfdGsosfvXUIxf2XzeFhUQteN4K9TXpHJ5zR82NFIansUlkKF6ZO+iqCB2gGnt/WmaWmPYMW2VYWpKDWDmn11y5AYsW1gmlGitVFcp9fRkVUoAEfU859zPynmlRBPX1GO0O63uN5CYM0RU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165555041971027.498186117623163; Sat, 18 Jun 2022 04:06:59 -0700 (PDT) Received: from localhost ([::1]:52362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WI6-0007aZ-Of for importer@patchew.org; Sat, 18 Jun 2022 07:06:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDW-0007jc-Bm; Sat, 18 Jun 2022 07:02:14 -0400 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:34305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDU-0005eK-PB; Sat, 18 Jun 2022 07:02:14 -0400 Received: by mail-oi1-x230.google.com with SMTP id v4so8262636oiv.1; Sat, 18 Jun 2022 04:02:12 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2sjQ1PEwzNrRmTof4HPK2BqFxFXmrYidB2rpovzMR6g=; b=V31fQxUc1dwhbiRBeg84ecEnhvrNwUtPousqozfxcxjQP4ClvuN9KWKhTz7eAD1KSD EolkqbEFRCiYOeM34Z6f+ADmZaw0Ci3Bl7W3DwzGkao+4WbdWgLX5Zwzzqp6rA/trNZC 7nNX+lOIKjEeOsEgPqB1GUi6agS8obKkU0Rm0T6irDPa/aoqf3S7AUhOY1aSW5fnN40u w6lJfarf4ubIFexts4k3dUtSgwDhrJghgrczuZG84g3cinh1YOvCt0HXa52/5Cs/L5k8 9uUX8CKpV8PCujf46cS8RPUpOUKEJUoQkZerD/18/KkPmQNHUQtrbnEpNCMkC8+u9KaO EF+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2sjQ1PEwzNrRmTof4HPK2BqFxFXmrYidB2rpovzMR6g=; b=y3tHdog/amjljG4gRVXDzChqEs/VYvnN/wU8MCg3sy5GKlYezGRq6wPI3MCLD3wYYG /qotg0ygeW3bSbvUL2KJ5rqOGJXArJwm1fvSx8cPUd5iwiVNDC2GP8BoLqH45db4+40J 0wSXciHjeeDMmlFD7HpVj6Goqov2sKthbWuy1VxsQeb+BN3MX10MM1M6hOuzG7vVN5E5 uBymuAl10Ze4i0mROAvlZUV9pGdkCu8Ge3yxLHi5BB5yEq/wldw5uH1UdKMbgPsvByLz WDdwgG2zrdqdkeuHGy7BWah6FoWF49XGC1z/o/lP216bdJY2RcizccJlnNbLa3WyGkee w0UQ== X-Gm-Message-State: AJIora8jsyZkT73VSp7STBQKwuwzQFHlBHOQWY7FdhV1mtKa4z0Rn0Lv 3bCLbpPkINCNzUHeIHlQrN1kw8h0XBg= X-Google-Smtp-Source: AGRyM1uzqWc1Dla/1PXl2448IsG5N/Dlmrci15Z8/KaeRiqrbrf8sE2CG91pPc9seOUGSG3H6lWkdw== X-Received: by 2002:a05:6808:bce:b0:332:9584:dfd4 with SMTP id o14-20020a0568080bce00b003329584dfd4mr2741501oik.216.1655550131079; Sat, 18 Jun 2022 04:02:11 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 1/9] ppc/pnv: move root port attach to pnv_phb4_realize() Date: Sat, 18 Jun 2022 08:01:54 -0300 Message-Id: <20220618110202.87735-2-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550420545100001 Creating a root port is something related to the PHB, not the PEC. It also makes the logic more in line with what pnv-phb3 does. Reviewed-by: Frederic Barrat Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb4.c | 4 ++++ hw/pci-host/pnv_phb4_pec.c | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 6594016121..23ad8de7ee 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1547,6 +1547,7 @@ static void pnv_phb4_instance_init(Object *obj) static void pnv_phb4_realize(DeviceState *dev, Error **errp) { PnvPHB4 *phb =3D PNV_PHB4(dev); + PnvPhb4PecClass *pecc =3D PNV_PHB4_PEC_GET_CLASS(phb->pec); PCIHostState *pci =3D PCI_HOST_BRIDGE(dev); XiveSource *xsrc =3D &phb->xsrc; int nr_irqs; @@ -1583,6 +1584,9 @@ static void pnv_phb4_realize(DeviceState *dev, Error = **errp) pci_setup_iommu(pci->bus, pnv_phb4_dma_iommu, phb); pci->bus->flags |=3D PCI_BUS_EXTENDED_CONFIG_SPACE; =20 + /* Add a single Root port if running with defaults */ + pnv_phb_attach_root_port(pci, pecc->rp_model); + /* Setup XIVE Source */ if (phb->big_phb) { nr_irqs =3D PNV_PHB4_MAX_INTs; diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c index 8b7e823fa5..c9aaf1c28e 100644 --- a/hw/pci-host/pnv_phb4_pec.c +++ b/hw/pci-host/pnv_phb4_pec.c @@ -130,9 +130,6 @@ static void pnv_pec_default_phb_realize(PnvPhb4PecState= *pec, if (!sysbus_realize(SYS_BUS_DEVICE(phb), errp)) { return; } - - /* Add a single Root port if running with defaults */ - pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb), pecc->rp_model); } =20 static void pnv_pec_realize(DeviceState *dev, Error **errp) --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550325; cv=none; d=zohomail.com; s=zohoarc; b=Q7nfTnaGLdeBdLtHXSIrfrtdG9QEcMvDyBe5yYoicA4B71ng+eZk0GhTug1wFAqGw5TPrGj2IBt5LV6fHcKpz4N3Q1bqxI9ioK0/aPg/P2s3IK4rGpxohRZXsf84CMIxJIvewpZC6ygqwjby05TD8M8R2Uz7sBIFG2uJRaRXcBI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550325; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3kbu4UrA5HIu+Wok8xije/iW/kzvjSDna/SqQrFKhpE=; b=e2ysoSOmkEgBONuMCgJqhSSyrFumGXYaY0utaYF+ZdTdCwebLFSDyZfuG6U82PAkF7mgja5sVHe+hBi9k4QBZ0t0RWg/AZKSundOn+rvXNaknHk7fqUBO5OTmwAEqls1nVvjvTmjkeU4lZQopZSHOgYnPih1UBy+ZPusp15Nx8s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655550325310393.78276946330243; Sat, 18 Jun 2022 04:05:25 -0700 (PDT) Received: from localhost ([::1]:46526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WGa-0003Yb-Au for importer@patchew.org; Sat, 18 Jun 2022 07:05:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDY-0007oM-Dv; Sat, 18 Jun 2022 07:02:16 -0400 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]:35573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDW-0005ea-NN; Sat, 18 Jun 2022 07:02:16 -0400 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-100eb6f7782so8454311fac.2; Sat, 18 Jun 2022 04:02:14 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3kbu4UrA5HIu+Wok8xije/iW/kzvjSDna/SqQrFKhpE=; b=jPWlh1I1kAv/nLxLgfN8+yLv/hWpUrktFfqpWaYTiKRVqAkKwMmPvrUthOaDOV9/Hz LxRt44rkbb+gk6SnPNdcLbwkqBkCv7HV0RKXjEWIMyK4IUzHhSKSepxfpOeFLmiJT8Zp 8o+jWZiopGfDN0+h4eAzh0jVlXXtHXlnsAbkq5KCNiANdDKIML35r1d555p7LAE0uFjM +NMWm5jm+jGleb5mrqzXtoVCFhsNo3rWBhVg/uywxJ1/0IqthiN7QFV4haXPFSSRnLc6 CHbbfsLXwMlwTizYu3qV8f4siH5ZiSzkS5QgH93YOYZ9Fpi7N9BJgeZDbv0v8axvroaE H/Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3kbu4UrA5HIu+Wok8xije/iW/kzvjSDna/SqQrFKhpE=; b=G9zM7WDP2DSZb67sEZwPArDWXTAxdHPDDD+4+wat68wFMILKpvJRuCnQ53EqiwIJmu NHVqqyNs6UcwDY7yOgeou0RM9R9bDPdYrKKt5+VCtowi5l+EXf9pPignw4nNpp4Z0QzN j5snwopctKPiai4KH6BDFNxyrWxGg1AgyucjHKgkqx9QkWS6TxApVdOk4GkKrV9jBFPX pC8UrNWEtAz4qTOhSLZTSEe+OsIsFqA8PMWQgogbAywm0jpUu+ORy+hySOW75DFv74xB UkkIZwXIjv4Rk/6z9oqLF4yOHYSkWm6pye0+sFoz5qcbLGQqfuTdX0TAfHHK4GF/D5tG IKew== X-Gm-Message-State: AJIora+RfoQ1AQEzwMOUI7xKJR32eNkCFS2S/7YEYkxnUHLxnTHLhgYX aWigqUn4q99x5ZxfFTyQx/dEXj/KIEY= X-Google-Smtp-Source: AGRyM1sjKfUtzg26GsgapALbF4MrLCTO/uaOB0fD/N8VOOJfGbRmF2jLUPbhouZiZJPCeG3ybFHqBQ== X-Received: by 2002:a05:6870:d349:b0:f5:e9ea:5200 with SMTP id h9-20020a056870d34900b000f5e9ea5200mr13978649oag.235.1655550133087; Sat, 18 Jun 2022 04:02:13 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 2/9] ppc/pnv: attach phb3/phb4 root ports in QOM tree Date: Sat, 18 Jun 2022 08:01:55 -0300 Message-Id: <20220618110202.87735-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::29; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x29.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550326250100001 At this moment we leave the pnv-phb3(4)-root-port unattached in QOM: /unattached (container) (...) /device[2] (pnv-phb3-root-port) /bus master container[0] (memory-region) /bus master[0] (memory-region) /pci_bridge_io[0] (memory-region) /pci_bridge_io[1] (memory-region) /pci_bridge_mem[0] (memory-region) /pci_bridge_pci[0] (memory-region) /pci_bridge_pref_mem[0] (memory-region) /pci_bridge_vga_io_hi[0] (memory-region) /pci_bridge_vga_io_lo[0] (memory-region) /pci_bridge_vga_mem[0] (memory-region) /pcie.0 (PCIE) Let's make changes in pnv_phb_attach_root_port() to attach the created root ports to its corresponding PHB. This is the result afterwards: /pnv-phb3[0] (pnv-phb3) /lsi (ics) /msi (phb3-msi) /msi32[0] (memory-region) /msi64[0] (memory-region) /pbcq (pnv-pbcq) (...) /phb3_iommu[0] (pnv-phb3-iommu-memory-region) /pnv-phb3-root.0 (pnv-phb3-root) /pnv-phb3-root-port[0] (pnv-phb3-root-port) /bus master container[0] (memory-region) /bus master[0] (memory-region) /pci_bridge_io[0] (memory-region) /pci_bridge_io[1] (memory-region) /pci_bridge_mem[0] (memory-region) /pci_bridge_pci[0] (memory-region) /pci_bridge_pref_mem[0] (memory-region) /pci_bridge_vga_io_hi[0] (memory-region) /pci_bridge_vga_io_lo[0] (memory-region) /pci_bridge_vga_mem[0] (memory-region) /pcie.0 (PCIE) Reviewed-by: Frederic Barrat Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb3.c | 2 +- hw/pci-host/pnv_phb4.c | 2 +- hw/ppc/pnv.c | 7 ++++++- include/hw/ppc/pnv.h | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c index 26ac9b7123..4ba660f8b9 100644 --- a/hw/pci-host/pnv_phb3.c +++ b/hw/pci-host/pnv_phb3.c @@ -1052,7 +1052,7 @@ static void pnv_phb3_realize(DeviceState *dev, Error = **errp) =20 pci_setup_iommu(pci->bus, pnv_phb3_dma_iommu, phb); =20 - pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb), TYPE_PNV_PHB3_ROOT_PORT= ); + pnv_phb_attach_root_port(pci, TYPE_PNV_PHB3_ROOT_PORT, phb->phb_id); } =20 void pnv_phb3_update_regions(PnvPHB3 *phb) diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 23ad8de7ee..ffd9d8a947 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1585,7 +1585,7 @@ static void pnv_phb4_realize(DeviceState *dev, Error = **errp) pci->bus->flags |=3D PCI_BUS_EXTENDED_CONFIG_SPACE; =20 /* Add a single Root port if running with defaults */ - pnv_phb_attach_root_port(pci, pecc->rp_model); + pnv_phb_attach_root_port(pci, pecc->rp_model, phb->phb_id); =20 /* Setup XIVE Source */ if (phb->big_phb) { diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 7c08a78d6c..40e0cbd84d 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -1190,9 +1190,14 @@ static void pnv_chip_icp_realize(Pnv8Chip *chip8, Er= ror **errp) } =20 /* Attach a root port device */ -void pnv_phb_attach_root_port(PCIHostState *pci, const char *name) +void pnv_phb_attach_root_port(PCIHostState *pci, const char *name, int ind= ex) { PCIDevice *root =3D pci_new(PCI_DEVFN(0, 0), name); + g_autofree char *default_id =3D g_strdup_printf("%s[%d]", name, index); + const char *dev_id =3D DEVICE(root)->id; + + object_property_add_child(OBJECT(pci->bus), dev_id ? dev_id : default_= id, + OBJECT(root)); =20 pci_realize_and_unref(root, pci->bus, &error_fatal); } diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h index 86cb7d7f97..033890a23f 100644 --- a/include/hw/ppc/pnv.h +++ b/include/hw/ppc/pnv.h @@ -189,7 +189,7 @@ DECLARE_INSTANCE_CHECKER(PnvChip, PNV_CHIP_POWER10, TYPE_PNV_CHIP_POWER10) =20 PowerPCCPU *pnv_chip_find_cpu(PnvChip *chip, uint32_t pir); -void pnv_phb_attach_root_port(PCIHostState *pci, const char *name); +void pnv_phb_attach_root_port(PCIHostState *pci, const char *name, int ind= ex); =20 #define TYPE_PNV_MACHINE MACHINE_TYPE_NAME("powernv") typedef struct PnvMachineClass PnvMachineClass; --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550380; cv=none; d=zohomail.com; s=zohoarc; b=WOR+RkCZXQGzuZrj3ZZD9tqngHxeQAC/Iu4mnI+j1IYErd2xuQ9n9ohqthCgieC43uJHuu6Vl6uG1wh13jRWCYUvxhZoTcKnSKPyRm+Oe9l82H8D6e5op1zT8+YGM/iFaJxrrEOls99QJ+3S6QF+vcVbqQAhgxUnNkjg5611Urk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550380; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Eckipunu8DdgKOEbpsdAZWxd3eae/mTpVb8Dq8go+VI=; b=AT76fPP3M0t7RXHajAZGJ+/RxRWLvjtTwjyLeqqwJR958UfErK3BqnVDkTyGUbF4hDnigtFhPOg7k62JFg67cN+cZFn2Ova8zy+tXQsTKvPXlJD5LLi6jn1PbRcfpNJBF+zsiyZE3RMMckj1e0QuREZWYHtbjrA8PZ2gMEQPkhc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165555038009581.32950424909654; Sat, 18 Jun 2022 04:06:20 -0700 (PDT) Received: from localhost ([::1]:50728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WHS-0006SS-HX for importer@patchew.org; Sat, 18 Jun 2022 07:06:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDa-0007qd-LF; Sat, 18 Jun 2022 07:02:21 -0400 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]:38560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDY-0005es-UE; Sat, 18 Jun 2022 07:02:18 -0400 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-101b4f9e825so3991009fac.5; Sat, 18 Jun 2022 04:02:16 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Eckipunu8DdgKOEbpsdAZWxd3eae/mTpVb8Dq8go+VI=; b=RETRNzPxKDV02DAxTF1uPFVsGVRUqYFa7YwCWoFTN/cvX8ML/yMDwgFI/eyP+gJmFz 2dui/f81frGxdxP4tagXrrGQpD0BJhztpe6S9mB/d79Fi0FT4QPONUGsma6D5N99mRwN Pt7N0XlluhDtOjXBXl+KxCKTGVEHMZrl5OesUU8cTFVcixTKT3+8aG1V5q3O55/evWHF PQiVaKMikBYJwEhJaGFAeyC/Q7rWxtBOk8HY8R2FEHLX3MaTljwRhpBimdEJuwFMwrO0 Tz1ygdCjfXQD+FGmC8uyLoJKD/Ox6Z9bnIqaLrAur98ehyTXiRtoYKnzEZ5Vdger6sId 0GGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Eckipunu8DdgKOEbpsdAZWxd3eae/mTpVb8Dq8go+VI=; b=fKICW05bsY6SRIy5YmxcFviQ+m6EVM1/BNEuWCx4bHpWGI0RvXy0OzJASlnmwvU+b3 hBKCBRtwNLGSLwQcDxC8xyH+8Qsoe82+j9MrCgA3kOkNKAIjrOs1H1UFhjQX1bw33NRO 0CExEEtyvg2nDVPQqoL7i9avtPptqh+MP0fdcrsfYsHLYScYcz8fcUdKs91SRj9lOjL+ OnTov1F873wIzRTmsDMv6btCbXkPyYuGWkvggP3L/WZxfWJAtt6diiacodrF0rCqwF4W 9/WJS8UjD+D+wi33dyBt7ysfc+caNycY5QUXe+MVu6oOEniyuVlkYgSGKqCcd0fVCoLw CsDQ== X-Gm-Message-State: AJIora9Kv8SQx2lGLwetq1fh5w3fxcSV2r7FUOVqHViK9QHDqmkn+d4G dT19YxV7wvALMczE7GGdEm3QpwxJlq8= X-Google-Smtp-Source: AGRyM1tBCtMDDDSgP/JvIMk6H45IuX26NxDE7ydjZmCj+9ok6oxJCtpJVK4o6wIARN4DFbXwnqFw4g== X-Received: by 2002:a05:6870:23a8:b0:101:ae39:a0f3 with SMTP id e40-20020a05687023a800b00101ae39a0f3mr3590237oap.236.1655550135531; Sat, 18 Jun 2022 04:02:15 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 3/9] ppc/pnv: use dev->parent_bus->parent to get the PHB Date: Sat, 18 Jun 2022 08:01:56 -0300 Message-Id: <20220618110202.87735-4-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::29; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x29.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550380411100001 Content-Type: text/plain; charset="utf-8" It is not advisable to execute an object_dynamic_cast() to poke into bus->qbus.parent and follow it up with a C cast into the PnvPHB type we think we got. A better way is to access the PnvPHB object via a QOM macro accessing the existing parent links of the DeviceState. For a given pnv-phb3/4-root-port 'dev', dev->parent_bus will give us the PHB bus, and dev->parent_bus->parent is the PHB. Use the adequate QOM macro to assert the type, and keep the NULL check in case we didn't get the object we were expecting. Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb3.c | 10 +++++++--- hw/pci-host/pnv_phb4.c | 10 +++++++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c index 4ba660f8b9..5e7f827415 100644 --- a/hw/pci-host/pnv_phb3.c +++ b/hw/pci-host/pnv_phb3.c @@ -1139,12 +1139,16 @@ static void pnv_phb3_root_port_realize(DeviceState = *dev, Error **errp) { PCIERootPortClass *rpc =3D PCIE_ROOT_PORT_GET_CLASS(dev); PCIDevice *pci =3D PCI_DEVICE(dev); - PCIBus *bus =3D pci_get_bus(pci); PnvPHB3 *phb =3D NULL; Error *local_err =3D NULL; =20 - phb =3D (PnvPHB3 *) object_dynamic_cast(OBJECT(bus->qbus.parent), - TYPE_PNV_PHB3); + /* + * dev->parent_bus gives access to the pnv-phb-root bus. + * The PnvPHB3 is the owner (parent) of the bus. + */ + if (dev->parent_bus) { + phb =3D PNV_PHB3(dev->parent_bus->parent); + } =20 if (!phb) { error_setg(errp, diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index ffd9d8a947..a0ee52e820 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1782,12 +1782,16 @@ static void pnv_phb4_root_port_realize(DeviceState = *dev, Error **errp) { PCIERootPortClass *rpc =3D PCIE_ROOT_PORT_GET_CLASS(dev); PCIDevice *pci =3D PCI_DEVICE(dev); - PCIBus *bus =3D pci_get_bus(pci); PnvPHB4 *phb =3D NULL; Error *local_err =3D NULL; =20 - phb =3D (PnvPHB4 *) object_dynamic_cast(OBJECT(bus->qbus.parent), - TYPE_PNV_PHB4); + /* + * dev->parent_bus gives access to the pnv-phb-root bus. + * The PnvPHB4 is the owner (parent) of the bus. + */ + if (dev->parent_bus) { + phb =3D PNV_PHB4(dev->parent_bus->parent); + } =20 if (!phb) { error_setg(errp, "%s must be connected to pnv-phb4 buses", dev->id= ); --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550635; cv=none; d=zohomail.com; s=zohoarc; b=hr7JvqSd1/ajhm6GPQlY5Ub4pUs0ZgtuetMAwJ4JgYEVgaFmIjsOLX1g+6qA/3DhowXTBlQLs8cc3HDkGVRLhb/WRCnFrbxRJVWQrpEHe4p9Qi9I4OLYCbgkkB0XRUBeIK/lvQlVt4apowgInpuHpsD7tB2GnYlNpn3AshPRt04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550635; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vgBvX04lektdxvLkMI1I/YjOTssBF/J1Ycnx3vGzq1M=; b=P8jcHQCb6gQ9ydgi2ki0PQCDwRT5Xs0F1+F3cM61Im/Ph/AHzJ0Uzmwv0c31VQjDIcUHMeQtbiYEZ7zgXRxyihDNafTb5iphgCIbO7J43fn6c4hPwb7qUkflkJEmSRFIlxylkeZG8k8vf/40ZVX0nwaKVu1J+xeRqMGEK53+5VE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655550635704937.7208564250723; Sat, 18 Jun 2022 04:10:35 -0700 (PDT) Received: from localhost ([::1]:58736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WLa-0003zd-Kc for importer@patchew.org; Sat, 18 Jun 2022 07:10:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDc-0007qp-Ox; Sat, 18 Jun 2022 07:02:21 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:33669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDb-0005fA-0Q; Sat, 18 Jun 2022 07:02:20 -0400 Received: by mail-oi1-x234.google.com with SMTP id s124so8300770oia.0; Sat, 18 Jun 2022 04:02:18 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vgBvX04lektdxvLkMI1I/YjOTssBF/J1Ycnx3vGzq1M=; b=XNKgUatWQBpqCNDXt0lwleFQie5+lLJ0NNaAiuhontmXKAhoNi8KHzF77UqIwP72kj /KpWzrxfZwI74kq5doAzzha83vHnq4Zo+J+vU0bBvBzWNJWYbq1YguqCgbakWZ6b8Ai4 wUqp6g2qQEJFDkPkKbN63kkLFmOXGVzyyvncS3FtT+qnOaZ8A4HExUQOAGAePg+UI+it ba8yDSPvqI7Gz0Z5S3sSiiIKkrFX+FS66xez63XwrzHrxeKnlsZuP4iZbHB1aXA4yk3h C5rG6nBYuoSBRsO4+PWw4DmWvCpZPBeFl44Bz3X9NCuj8VpOxD7mofIHhmDBRbKUKZEL HxfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vgBvX04lektdxvLkMI1I/YjOTssBF/J1Ycnx3vGzq1M=; b=J5Bl07lHK5L2Ks1I0Br+Yl4Hj1cDidRBgGTcURkX/oTohuBxbWtD2zfbnUsUdRELNR i/b+OLpuXt8LqmbMRMl4UGNTSidAN1Gp6VhLaOHVWI+vw5rHMOgQkD35CKEpxgwnqZrY dq/y4+IrPztMAkLnAcrOpRyEGT8dFx5T7SDs17hhEC+/INJutgkFOBhW1JJeHMizQKGF V6L2y8Kd8TEj50aGXBDfAx4zj3/USoXxxQ8J4+ds7HdioMV9MytWhWK/wPHSRwdZklE2 WfOUGLDrcjpxYrugCAIigRDx33d3KYlYbMgd0Uw9TmT1iTi0pbqnaP+KJLeEIPH7gJz/ n2xA== X-Gm-Message-State: AOAM530rpD6KFu97RwRFYYQPQWEpwGlxXR++Olq7FMIMox0ZHiEmPoIZ Ox9SIyy3vl8coqy49vgKHgLciqASKO8= X-Google-Smtp-Source: ABdhPJy3qEpHYCcmWlqNHj41GWSnWfsTj6V2/ud9WHDstvORLPk+n7tyM68aqjYRGMMX8CTQYdmswA== X-Received: by 2002:a54:4e95:0:b0:32e:1ad1:2d4 with SMTP id c21-20020a544e95000000b0032e1ad102d4mr12839899oiy.235.1655550137474; Sat, 18 Jun 2022 04:02:17 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 4/9] ppc/pnv: use dev instead of pci->qdev in root_port_realize() Date: Sat, 18 Jun 2022 08:01:57 -0300 Message-Id: <20220618110202.87735-5-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550637716100001 Content-Type: text/plain; charset="utf-8" We already have access to the 'dev' object. Reviewed-by: Frederic Barrat Signed-off-by: Daniel Henrique Barboza --- hw/pci-host/pnv_phb3.c | 4 ++-- hw/pci-host/pnv_phb4.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c index 5e7f827415..8c03cc94f2 100644 --- a/hw/pci-host/pnv_phb3.c +++ b/hw/pci-host/pnv_phb3.c @@ -1157,8 +1157,8 @@ static void pnv_phb3_root_port_realize(DeviceState *d= ev, Error **errp) } =20 /* Set unique chassis/slot values for the root port */ - qdev_prop_set_uint8(&pci->qdev, "chassis", phb->chip_id); - qdev_prop_set_uint16(&pci->qdev, "slot", phb->phb_id); + qdev_prop_set_uint8(dev, "chassis", phb->chip_id); + qdev_prop_set_uint16(dev, "slot", phb->phb_id); =20 rpc->parent_realize(dev, &local_err); if (local_err) { diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index a0ee52e820..61b45fe33c 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1781,7 +1781,6 @@ static void pnv_phb4_root_port_reset(DeviceState *dev) static void pnv_phb4_root_port_realize(DeviceState *dev, Error **errp) { PCIERootPortClass *rpc =3D PCIE_ROOT_PORT_GET_CLASS(dev); - PCIDevice *pci =3D PCI_DEVICE(dev); PnvPHB4 *phb =3D NULL; Error *local_err =3D NULL; =20 @@ -1799,8 +1798,8 @@ static void pnv_phb4_root_port_realize(DeviceState *d= ev, Error **errp) } =20 /* Set unique chassis/slot values for the root port */ - qdev_prop_set_uint8(&pci->qdev, "chassis", phb->chip_id); - qdev_prop_set_uint16(&pci->qdev, "slot", phb->phb_id); + qdev_prop_set_uint8(dev, "chassis", phb->chip_id); + qdev_prop_set_uint16(dev, "slot", phb->phb_id); =20 rpc->parent_realize(dev, &local_err); if (local_err) { --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550681; cv=none; d=zohomail.com; s=zohoarc; b=RY0fk61OfhjXqX0Vzns0PWlt6904CjqFAOLwZnFwvu5mTELDkebRQaEsn4p+0GCrQOWzrknR5AxcNaNe0o880KD5bKCWSzz9i18y+Z1yFjPvDS1Tp2DJ0yvskwv0rIztyFMQmmTXSmkAHOlKiEV3oFR0IXeLdjh2UO7/uZE02u0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550681; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nrYUXDrPZK9AjIy48/KoAnoYyl6xVl2VfnLNPEsV09s=; b=HJUXmhS9JidjtTufmo1Ucg/yfoysHR+mMQxK/F82QSJwYmVJMqVZwFbvWL/I1FVRDixqeR4Pq6J4NuR+vuo/qkqmSI7qZ+gzOYVY6Zj4QiguixKJ0/YhuTN7q/X2EXfuVuncfXWCshzqnNVO+R9Gu2PedX9h+hI+cCFmLuLzbbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655550681969582.6653324848302; Sat, 18 Jun 2022 04:11:21 -0700 (PDT) Received: from localhost ([::1]:60886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WMK-0005ZO-Uv for importer@patchew.org; Sat, 18 Jun 2022 07:11:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDf-0007sb-CL; Sat, 18 Jun 2022 07:02:25 -0400 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]:45613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDd-0005fj-ID; Sat, 18 Jun 2022 07:02:22 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1016409cf0bso8423180fac.12; Sat, 18 Jun 2022 04:02:20 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nrYUXDrPZK9AjIy48/KoAnoYyl6xVl2VfnLNPEsV09s=; b=qjvYMjeq5NZwTne3JvgAKwtr/hlE5Y7Y9j2GWEnpa/bAYH0ZW0Q+cDmoVDwEU9l84B ctyoTydN1zjNxRtaIR4B2WYdBSZNlKCrKWOyEi/gR8ob0JPu5HBC+NWPblqAPH9FlvIc oVu1QnUChvzY/Gxznhx++uDrxoUMRWGF4VWCLRQnq5/xqTaEemnaY3/uiGYy97EsykGB 1PgX/GYDqonveUHDJ4uRnt4u61uNq6CARUq7CXpR3aNynECvu3sWH8R3WLhvP6GQ1L5D X0cN02RFC8SnT61H2jWuLuw0k4K2V4uPVSVR7B9BYU9SgwYacJ9tazcfN6ioogNPGUTf jhVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nrYUXDrPZK9AjIy48/KoAnoYyl6xVl2VfnLNPEsV09s=; b=ylW2EroXsJyun6G7S4E3PPyzb3cRC/s9qSUvYTkzjyZKmf2wNPBfG/99Wg9i7sXf50 Gcoo4x3fuHxtW/ADxdFRUhjSt8LibG3W6RtS86Duk13zGYXxsEPAWW2x51TBsXsm6tAq 52GJnl0YFeQMg8JPEddsqtbAuI/Fcj3Cf3lTAhNlNvFUBqn9iDAEv0wGHPglWEDYt2ou IlYotIT0uhFtD/NZ1WrRGXvrZYJ7tck8RAqxj3vnBqYJwBapAbZSDLxEK3So9QkEwRsP O2sr09+BBj9bZCCiIRISOvhgWMJAkn7IameSvfELD8FDi/2vrozwVfNNkRG+of1JnNCX sxtg== X-Gm-Message-State: AJIora8vMhk/3tSbiEp9oALvNbXTw8KXz3emW8xCP4L7PdinqqlXzQX7 A78pflb0sdkarvUwSMqe2xGw04CngG0= X-Google-Smtp-Source: AGRyM1tdMZ6tdl0YlozXkcjiYpxGaemrECGqlx5AcdPBxnmh3LwZhaaYZcsJ7RvT7VBrS3TEQSfMHw== X-Received: by 2002:a05:6870:d215:b0:f2:5fc9:6492 with SMTP id g21-20020a056870d21500b000f25fc96492mr7859786oac.112.1655550139777; Sat, 18 Jun 2022 04:02:19 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 5/9] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array Date: Sat, 18 Jun 2022 08:01:58 -0300 Message-Id: <20220618110202.87735-6-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x2d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550683966100001 Content-Type: text/plain; charset="utf-8" The function is working today by getting all the child objects of the chip, interacting with each of them to check whether the child is a PHB, and then doing what needs to be done. We have all the chip PHBs in the phbs[] array so interacting with all child objects is unneeded. Open code pnv_ics_get_phb_ics() into pnv_ics_get() and remove both pnv_ics_get_phb_ics() and the ForeachPhb3Args struct. Signed-off-by: Daniel Henrique Barboza Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Frederic Barrat --- hw/ppc/pnv.c | 38 +++++++++++--------------------------- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 40e0cbd84d..ff7f803662 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -1939,44 +1939,28 @@ PowerPCCPU *pnv_chip_find_cpu(PnvChip *chip, uint32= _t pir) return NULL; } =20 -typedef struct ForeachPhb3Args { - int irq; - ICSState *ics; -} ForeachPhb3Args; - -static int pnv_ics_get_child(Object *child, void *opaque) -{ - ForeachPhb3Args *args =3D opaque; - PnvPHB3 *phb3 =3D (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3= ); - - if (phb3) { - if (ics_valid_irq(&phb3->lsis, args->irq)) { - args->ics =3D &phb3->lsis; - } - if (ics_valid_irq(ICS(&phb3->msis), args->irq)) { - args->ics =3D ICS(&phb3->msis); - } - } - return args->ics ? 1 : 0; -} - static ICSState *pnv_ics_get(XICSFabric *xi, int irq) { PnvMachineState *pnv =3D PNV_MACHINE(xi); - ForeachPhb3Args args =3D { irq, NULL }; - int i; + int i, j; =20 for (i =3D 0; i < pnv->num_chips; i++) { - PnvChip *chip =3D pnv->chips[i]; Pnv8Chip *chip8 =3D PNV8_CHIP(pnv->chips[i]); =20 if (ics_valid_irq(&chip8->psi.ics, irq)) { return &chip8->psi.ics; } =20 - object_child_foreach(OBJECT(chip), pnv_ics_get_child, &args); - if (args.ics) { - return args.ics; + for (j =3D 0; j < chip8->num_phbs; j++) { + PnvPHB3 *phb3 =3D &chip8->phbs[j]; + + if (ics_valid_irq(&phb3->lsis, irq)) { + return &phb3->lsis; + } + + if (ics_valid_irq(ICS(&phb3->msis), irq)) { + return ICS(&phb3->msis); + } } } return NULL; --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550528; cv=none; d=zohomail.com; s=zohoarc; b=W0KsvFZiLeMRrtY3GHAyh0OUArCl3YnfunT+wrVfgVEiW5xvzosB/dSQWRcsba6N00HtK08ck7VNIafqfACfloTq4WahprmlH+KQIsOtMxMXM0HDSQEOComLWd7XBd4vwCXeSvORXXM0CnONRnL7hPAtpqYgo3kJcXYoK/E/6qQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550528; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wFIPVAEq+m1icJUGifUbVeq3yFLPbRkYHZ6jQ/rYCBQ=; b=glzYTPqH8QduuYsc6pG99PRGNnbou4j/3th97cCdK2k/8myQdGy81rzD2S8yqKGvCA+O7GUjkPaBKwLpAsXGFzpJ80acQrnPvVSrxcK5Bi5bS0McEsyeJ6AcZ740K/WY8ETRAv9AyONFHh0MfNfERQF6+wfPeUK98sCT/jc72xk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655550528217528.6975490378564; Sat, 18 Jun 2022 04:08:48 -0700 (PDT) Received: from localhost ([::1]:54574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WJq-0000od-MN for importer@patchew.org; Sat, 18 Jun 2022 07:08:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDh-0007sh-2S; Sat, 18 Jun 2022 07:02:27 -0400 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]:46735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDf-0005fz-KN; Sat, 18 Jun 2022 07:02:24 -0400 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1013ecaf7e0so8405340fac.13; Sat, 18 Jun 2022 04:02:22 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wFIPVAEq+m1icJUGifUbVeq3yFLPbRkYHZ6jQ/rYCBQ=; b=pTALJbg2Lt45HIHLoyRB60YfRDBWCMostgoid/kvl2n2iK0tKuxt/PwCGGLdjXpbiZ vBEXlLOBsSDEeDbPWNQsk4yFNNLcMqinsCRik81b7Pa4R5JL/kAbfMASCW0FnRnNXyKw 2s9cN2HX7LG9CQFSbmdhJNsa+3NwxcifGoDp9YwLuFW5pfI/nO1reAvQrPug44cAa7YB vGJVcOR3CNT/STGEQSi5aN97AVwwSx11pya7hbdx0HUEzWYNgTPAHqH22ZlRWVhNe2dV nmG2WX8tDdLabBVgqL0KPK2dvK4P5HY/gfI5KXOiSJlxhCwuQveSfBP7RIqAYGokvRAh umUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wFIPVAEq+m1icJUGifUbVeq3yFLPbRkYHZ6jQ/rYCBQ=; b=Ku78z2RoGgXDTgAul7TG5zOqhJ9lA1MbNoXPsZTMEPnlUI+u7wrvrqOZZJyTVMCsWA j2KrXxKKwVy17PGLVGOEPUF+QIMwiUrGFM2u0h6esevgfSjKrkmhwaB3W9C16udbpC+H eGLNg7X6yb/2kXwIRWD5NfN+dFK+nUvnhiOVdBElWygzMX5YMUA+tlZ4rRZEBpG/h6Hs O/dUOz+/TdHGDkDJepcptrqiTf+PFRt0qUoRvG4q/GqYCs3AkHgglhsXj4qSJcZq7kBW KPZoNdJMDk3LW0u5W8uuG15FxsSQ+r0/+LBjl/sFyMu6XknfjGRD74rtHcfl0QMiqZLh 8O9w== X-Gm-Message-State: AJIora84bo7UF4NGiH5IaJlnbtzSRhDCmLZ2nvReAjNXOincREqF6pbg W9V2C3cbpFEYQbXgncrbRDPZaZRzGds= X-Google-Smtp-Source: AGRyM1s/z9cl+VpPIctT5rvYUjm4yHNwfKdRc51oUUPeU5UQ+Yvo8vCIkAe75YNRT3zCPciw6mwCyw== X-Received: by 2002:a05:6870:434d:b0:e5:9115:cb15 with SMTP id x13-20020a056870434d00b000e59115cb15mr13335794oah.53.1655550142048; Sat, 18 Jun 2022 04:02:22 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 6/9] ppc/pnv: make pnv_ics_resend() use chip8->phbs[] Date: Sat, 18 Jun 2022 08:01:59 -0300 Message-Id: <20220618110202.87735-7-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x31.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550529169100001 Content-Type: text/plain; charset="utf-8" pnv_ics_resend() is scrolling through all the child objects of the chip to search for the PHBs. It's faster and simpler to just use the phbs[] array. pnv_ics_resend_child() was folded into pnv_ics_resend() since it's too simple to justify its own function. Signed-off-by: Daniel Henrique Barboza Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Frederic Barrat --- hw/ppc/pnv.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index ff7f803662..08136def8e 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -1979,28 +1979,22 @@ PnvChip *pnv_get_chip(PnvMachineState *pnv, uint32_= t chip_id) return NULL; } =20 -static int pnv_ics_resend_child(Object *child, void *opaque) -{ - PnvPHB3 *phb3 =3D (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3= ); - - if (phb3) { - ics_resend(&phb3->lsis); - ics_resend(ICS(&phb3->msis)); - } - return 0; -} - static void pnv_ics_resend(XICSFabric *xi) { PnvMachineState *pnv =3D PNV_MACHINE(xi); - int i; + int i, j; =20 for (i =3D 0; i < pnv->num_chips; i++) { - PnvChip *chip =3D pnv->chips[i]; Pnv8Chip *chip8 =3D PNV8_CHIP(pnv->chips[i]); =20 ics_resend(&chip8->psi.ics); - object_child_foreach(OBJECT(chip), pnv_ics_resend_child, NULL); + + for (j =3D 0; j < chip8->num_phbs; j++) { + PnvPHB3 *phb3 =3D &chip8->phbs[j]; + + ics_resend(&phb3->lsis); + ics_resend(ICS(&phb3->msis)); + } } } =20 --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550296; cv=none; d=zohomail.com; s=zohoarc; b=M0vIUWY2b/Vdf8jHaXK/oHVXS/3/aynm/dAgZDPv6/o85fWhzpqAm52URxA5XchUkGSRRP+ErpR06iIuGDiMpDR9oMncQGDvD6u+fh0DRkw0X8mC3lXt8xYEd5CxD1W3N5D0jUM5OBjcHmwNVzvY6BvUEmgN+PQcQUUAXa45pTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550296; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Od0dwdhBZFFqDJ9QGyRexIDSgMlssXKwCdn0x95W1pI=; b=Du1Yytthi5QcqE6mrbHaBP1XSfiTq/aVAB5tLreBAVc49oGFAt4WEkOFhlpWNoarenI/QazYdYKQy0tlR/RFsZhTMEpOly/usSdNQ4MLYlQN1ea9W16Rr35vevW77ZfiPeZLTZjbHIAPCKHI5J8vvu8cV1f8KeNL61IPDIgNRWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655550295902968.074367560065; Sat, 18 Jun 2022 04:04:55 -0700 (PDT) Received: from localhost ([::1]:45734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WG6-000329-NJ for importer@patchew.org; Sat, 18 Jun 2022 07:04:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDk-0007tI-KR; Sat, 18 Jun 2022 07:02:30 -0400 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:45725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDh-0005gL-Li; Sat, 18 Jun 2022 07:02:27 -0400 Received: by mail-oi1-x230.google.com with SMTP id u9so8219829oiv.12; Sat, 18 Jun 2022 04:02:25 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Od0dwdhBZFFqDJ9QGyRexIDSgMlssXKwCdn0x95W1pI=; b=D5hUKjP/XPrAAsoeXLgOl5z56NsmP1X4yYsKa3BwblR3EkpbB8ZsXs43U4diRcpMgN GDwK+WQO362GACYF0hR1ItH5bgo/CqEGjde/oGjMqkFiTdoaVi2HTPiC1ktb8YPfb6Iy JcyPX7RUoxFCovPUFFXpU/0c2/fHE+lHjYlYEgaB4W8/QM7McIRwyq1HBFRDx0u4ZLHK ntKqOG7RbK6ZpxdkX0HHMWfIB+ICpECd/rpc9ZgfevMvbzpfaKRAU39pl4ZUBSdPhV/+ Vc63mH5n4FMcnEyGvnZATaZSkgdYI0ARmPBKj7vybw6txi4FoJgaii4+Rzfh/d8maHsE Wnmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Od0dwdhBZFFqDJ9QGyRexIDSgMlssXKwCdn0x95W1pI=; b=hqXVbQaVvSOYlQ8PpP6WbH2F7lusG1B70ZUGbmnDSzqGH994gVhcUy1JfsivxgT+6N xygjxI+/ewXOqbMw3OdIM9u3b5uacG+qNZMOluRNmGtPDH1/8hWJcgVttfJS+7iLxCz5 d+2593+cGHe83GJSw+MBCujPeZThYkSOlx6H1BtXVzCOOaI8ivh0mocrquNvjE1EUEZI VVjX0BJJ26hSyghNFhvK60xw1di/6oNm345muQPcNFbcKJF6IlTWyYD3QE3UrEwZXSth rRHIgLjOyWe7KM6F+MrmXZP/1o8Psk20urVjnG9ZkaggZlXgiFgw0TTe9RDC5AzGp3tt FNSw== X-Gm-Message-State: AOAM532EG53ODdBUXwlKn6jxsANQHZcT2TpnX0hLIlbZi52j03nI4wlL dUZWM1jPwuR+tvVW47jLC/65HiEAmwM= X-Google-Smtp-Source: ABdhPJx/7sGWXpcdmFcT+dONF3jirzhrcBotcOF9qfbrhDdpcAOfvlLGI8WNAva4gdBcT5818MaMzw== X-Received: by 2002:a05:6808:158e:b0:32f:471a:ca7d with SMTP id t14-20020a056808158e00b0032f471aca7dmr12514606oiw.236.1655550144342; Sat, 18 Jun 2022 04:02:24 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 7/9] ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[] Date: Sat, 18 Jun 2022 08:02:00 -0300 Message-Id: <20220618110202.87735-8-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550298123100001 Content-Type: text/plain; charset="utf-8" It's inneficient to scroll all child objects when we have all PHBs available in chip8->phbs[]. pnv_chip_power8_pic_print_info_child() ended up folded into pic_print_info() for simplicity. Reviewed-by: Frederic Barrat Signed-off-by: Daniel Henrique Barboza Reviewed-by: C=C3=A9dric Le Goater --- hw/ppc/pnv.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 08136def8e..2a9067687b 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -652,25 +652,19 @@ static ISABus *pnv_isa_create(PnvChip *chip, Error **= errp) return PNV_CHIP_GET_CLASS(chip)->isa_create(chip, errp); } =20 -static int pnv_chip_power8_pic_print_info_child(Object *child, void *opaqu= e) -{ - Monitor *mon =3D opaque; - PnvPHB3 *phb3 =3D (PnvPHB3 *) object_dynamic_cast(child, TYPE_PNV_PHB3= ); - - if (phb3) { - pnv_phb3_msi_pic_print_info(&phb3->msis, mon); - ics_pic_print_info(&phb3->lsis, mon); - } - return 0; -} - static void pnv_chip_power8_pic_print_info(PnvChip *chip, Monitor *mon) { Pnv8Chip *chip8 =3D PNV8_CHIP(chip); + int i; =20 ics_pic_print_info(&chip8->psi.ics, mon); - object_child_foreach(OBJECT(chip), - pnv_chip_power8_pic_print_info_child, mon); + + for (i =3D 0; i < chip8->num_phbs; i++) { + PnvPHB3 *phb3 =3D &chip8->phbs[i]; + + pnv_phb3_msi_pic_print_info(&phb3->msis, mon); + ics_pic_print_info(&phb3->lsis, mon); + } } =20 static int pnv_chip_power9_pic_print_info_child(Object *child, void *opaqu= e) --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550621; cv=none; d=zohomail.com; s=zohoarc; b=JGJaKtwnubyi7k7gN3f0K3C76W8gV5K/+kEIORSekL8sLku+cuygVRTjQ+jjsYPK5wvNCq47WE2SdwQIYjMJfQPwFiMr+jdNxmvJ/KS3NOvsUslZYqO+pldVEc9DPTLcnZasenVjpaH9AqkMT6Px38GWPFKxl/4NWUU84tA52SI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550621; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rXwjJGXcPESLvRIXnVLod9H2G4CRNeUbQSJslaYlxL4=; b=TQmas/wRAsH1Jj2Z0cYcbATo4xc2L6O1blW02Gh+5uRm2EAZUogGeSgtFf6AzzfpREMsGBpk0jVxaGQ6FaQ3U8zkZbNpaWs6l/WeOTnGnjIcLpM9w9uGUVuFY3kLRHajCz8sP2Ug13to9ixt15Je34PpuFSHVVg/WvlGQw1PcB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655550621216455.3615580657363; Sat, 18 Jun 2022 04:10:21 -0700 (PDT) Received: from localhost ([::1]:57670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WLM-00038X-1I for importer@patchew.org; Sat, 18 Jun 2022 07:10:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDm-0007tO-MZ; Sat, 18 Jun 2022 07:02:32 -0400 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:39589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDk-0005gW-1U; Sat, 18 Jun 2022 07:02:29 -0400 Received: by mail-oi1-x229.google.com with SMTP id bd16so8236612oib.6; Sat, 18 Jun 2022 04:02:27 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rXwjJGXcPESLvRIXnVLod9H2G4CRNeUbQSJslaYlxL4=; b=glAIxkjprV3UXmAGsQSeFhxgUw0tHXewKiepAlDapyCXK2G7ikURTG4LCPVH8srCJH FwWfU3NmMpAZHh8VwhAwsidJwD3pO5MOnvGhf6kEwKS4N16trj191wCibjXv4tAqK1Fh l4Q2yxRQyivqLVuExuuDIIYN+mQTApustyaawcVcpAIMNGO9euLs2wSQJRLYQ5LZIpk3 Hiy1cNEgmcCiVOS+FkEmS7mfDH/tDuu+iM2xZpjuAwj6ESZstjUZHlWbkPc/fDBXgaPk 5PqTFG1kx+pulkkQhQAoNoiDBuCQAibFbWuOl63QsJMnqCw8vZs3yuJju83sVzoSUw1d PjWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rXwjJGXcPESLvRIXnVLod9H2G4CRNeUbQSJslaYlxL4=; b=D7Yz/IVSBK3kLLWCXq9Fbso+FYATnpiw1olQi6gc++kXukorRIXFMa1MLJqDhzRUmU acdp8dzriBBWCZ8TZ7kbIKRXzmfw91fvmIQ/hkyqHZbPsoxyzkfLPjofXHGfcB8glh82 DUcPHwrv+yvym+oYwI7RykD8z0LfPZZj17vCe6w2kpwg5BwdH8mRzDeIKuLjc53/ytF3 ZsddKrvLB25RQxj/YACcjMabUTFmLlhqpqYEs8UYyXezV1tjQcjUs48qiiP0md3dHDZm zSa528gKYrdFmeQm0UxjQtN2Iqjj1d8/6rVYegb0xn+yY0/OiyWKBrbkRSEVIq9bQkD/ Qa/A== X-Gm-Message-State: AOAM5320yH4Nuxn/9pzGCuuTDz1ogvLzsKtClJWG5MB7gDzvU6bzDF01 uwheA/h3BPCCN5ytZ0naeS+s8f0xDvE= X-Google-Smtp-Source: ABdhPJwgAfAWpu3psLDYywxtI9hOESIWYbdQFTrNpsqbuY049YXcByEVCBHFhoK3vL4V+MVFShF7Fg== X-Received: by 2002:a05:6808:209e:b0:32f:32c0:7ada with SMTP id s30-20020a056808209e00b0032f32c07adamr12317728oiw.53.1655550146589; Sat, 18 Jun 2022 04:02:26 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 8/9] ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb3 root bus Date: Sat, 18 Jun 2022 08:02:01 -0300 Message-Id: <20220618110202.87735-9-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::229; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x229.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550621731100001 Content-Type: text/plain; charset="utf-8" It's unneeded. No other PCIE_BUS implements this interface. Fixes: 9ae1329ee2fe ("ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge") Signed-off-by: Daniel Henrique Barboza Reviewed-by: Frederic Barrat --- hw/pci-host/pnv_phb3.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c index 8c03cc94f2..696c9bef26 100644 --- a/hw/pci-host/pnv_phb3.c +++ b/hw/pci-host/pnv_phb3.c @@ -1129,10 +1129,6 @@ static const TypeInfo pnv_phb3_root_bus_info =3D { .name =3D TYPE_PNV_PHB3_ROOT_BUS, .parent =3D TYPE_PCIE_BUS, .class_init =3D pnv_phb3_root_bus_class_init, - .interfaces =3D (InterfaceInfo[]) { - { INTERFACE_PCIE_DEVICE }, - { } - }, }; =20 static void pnv_phb3_root_port_realize(DeviceState *dev, Error **errp) --=20 2.36.1 From nobody Sun Feb 8 05:17:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655550766; cv=none; d=zohomail.com; s=zohoarc; b=C0tWns2Sm8QpesIjaHIwkGbmePcOGveEoWQZtJzt0H8yCxTMQ4cD9XaMcP8X8BeKeh4dKoD1RNZ0My+aBPMP2CnKryVMAe+/tolDGrJI6ispuZeEqu+76wdDVnT07JCSk1uGawM8cYEmgESVEAfE89XRA/QpNDdwtEw+bex7IFc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655550766; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O27ma9UfDqSDwWIQr1tkTTbTWNQtnhkNtSvsm18kXE0=; b=HCU8EDePKlKGwTgMQpE4niU+Ge7cvQPsuNW84eadZ4vUvJjHEgILRAg1UWsZSfLWXUKSdaJniA/YFGG8/tyAIT9XDEPHQu4/Nc1vL+GxLYrtFae8BwLomIPyBvuRLuw/YWkP6L/Obvp+qngHTnEdRtxnMG4yDk12Q0mP9WiaO4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 165555076625658.539781079663385; Sat, 18 Jun 2022 04:12:46 -0700 (PDT) Received: from localhost ([::1]:36046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2WNg-0008Bv-Ns for importer@patchew.org; Sat, 18 Jun 2022 07:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2WDo-0007tq-6i; Sat, 18 Jun 2022 07:02:32 -0400 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:45725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2WDm-0005gL-PE; Sat, 18 Jun 2022 07:02:31 -0400 Received: by mail-oi1-x230.google.com with SMTP id u9so8219829oiv.12; Sat, 18 Jun 2022 04:02:29 -0700 (PDT) Received: from balboa.ibmmodules.com ([2804:431:c7c6:ccc8:8e07:268b:a09:2834]) by smtp.gmail.com with ESMTPSA id w16-20020a9d5a90000000b0060603221280sm4075456oth.80.2022.06.18.04.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jun 2022 04:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O27ma9UfDqSDwWIQr1tkTTbTWNQtnhkNtSvsm18kXE0=; b=bRbzcYiAQH0HJK9/XzkFqIIQXd8YgE6qpWEtGKyqoSyX9oz48hfEwvK591EwK9KbrC 0e6cP/MQVN6Xf4CrdeR/X7KBjPWFph/y3nOFjsvBJpZdC9TrDXc1cnjdA3z5PXbY5PTy c01VhJnt0Tk3jG8Get++viUQGrtD0cmyOZSVrDqb1znhzYIlSwXYVkjknHDEcRc2mMaR XDvh9gClJ9pVKsFNnVlaJxafp45PvbfQV/40uvRT73vqC+p1tvpZ0Wl6dtNY7VbRyeL5 15bpl9BGZVvHINwVMEX0BeKOrMVeqGvmz9FXCFSbIsU72SBw3ECBTiSXiIp6RCd83dcl V4dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O27ma9UfDqSDwWIQr1tkTTbTWNQtnhkNtSvsm18kXE0=; b=TN2WjJlbPvjK2ORmGc4l7W30LD2FDi84yOTV5d4abZkhKoow+uxF4p36gpN10iXUsF u/lFZ3at0+yvcK7VbKpqHzH0xm4oldmIkYt5s6Z44uzd0k9JtWxh4l3LaUCbpSVySmEk oixO2vxapeRxPxhMiVtMZyoRJvxxt7M0mw3RjkVcsbQjJROw03xYSVYbILO+phbV9oMT 6xCgZ0Fqpwrs/V/6tPoQ9ZGvcC7fqdQaQdbVsXlVokj41msVwbfJ6B47gdV9Ws3Ur5jI iSZFLRdDZ0HOinIe7trSiq+tllDxWEil6xuEtzHuz3Z4kBIODiK9iCgCuoY76mHDNIUL isXw== X-Gm-Message-State: AOAM5327WU4Q3PlLAvjSLN7dBv6VQ+B+xh+azt3Mfcv9nLBzrRgItUiP 5buruoCtqA4Es4wxQQCkHYsWBpxgWRA= X-Google-Smtp-Source: ABdhPJzo1Vq3Co2xkjuvbyQUx6qSuFBg+QamjhvEUzSBnuEuK1/wGxG9F7e7hJUqbdHrBCZu0rmw+w== X-Received: by 2002:a05:6808:4cc:b0:32a:f4d8:932a with SMTP id a12-20020a05680804cc00b0032af4d8932amr12570115oie.109.1655550148764; Sat, 18 Jun 2022 04:02:28 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com, Daniel Henrique Barboza Subject: [PATCH v2 9/9] ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb4 root bus Date: Sat, 18 Jun 2022 08:02:02 -0300 Message-Id: <20220618110202.87735-10-danielhb413@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220618110202.87735-1-danielhb413@gmail.com> References: <20220618110202.87735-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1655550768290100001 Content-Type: text/plain; charset="utf-8" It's unneeded. No other PCIE_BUS implements this interface. Fixes: 4f9924c4d4cf ("ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge") Signed-off-by: Daniel Henrique Barboza Reviewed-by: Frederic Barrat --- hw/pci-host/pnv_phb4.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 61b45fe33c..81f7c1fe8f 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1751,10 +1751,6 @@ static const TypeInfo pnv_phb4_root_bus_info =3D { .name =3D TYPE_PNV_PHB4_ROOT_BUS, .parent =3D TYPE_PCIE_BUS, .class_init =3D pnv_phb4_root_bus_class_init, - .interfaces =3D (InterfaceInfo[]) { - { INTERFACE_PCIE_DEVICE }, - { } - }, }; =20 static void pnv_phb4_root_port_reset(DeviceState *dev) --=20 2.36.1