From nobody Sun Feb 8 21:29:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655386100; cv=none; d=zohomail.com; s=zohoarc; b=QykaSKQjZ3TsIHUOhF2tRRdAQc8TbYFSamqqY3S0w1RdqMIQEFAGJabqu7D09K5ADCkQoTRce5Gv8PsA81GUgdey30GwScUUaOatuWqoy6YTH6dWZmtZQXEy2cudehzYvhtPPhZ69UkF2r6t01bFx38ADMpMDVLnzvY5C3w4a+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655386100; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OOPisGnzq61NrxsrGIdgBT7pO374tGQlU2DhkhUYj8E=; b=l8j7esicRgtLtXvuk+/I9+NqGrriBBf9HOMbNYqzzykgLFT4mqL+gguv6YjlUiaDLRoeYfCeck+tibj383DkSdIJPeERWpRhOPWA69dKDh8q8CSqgjYYTXJWs76T5wF+mdwQN+kfXHiziKEuplc+MV2yfWWJX8JVVoqhCaifeYM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655386100608438.1139113700259; Thu, 16 Jun 2022 06:28:20 -0700 (PDT) Received: from localhost ([::1]:33702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1pXm-0003e3-MP for importer@patchew.org; Thu, 16 Jun 2022 09:28:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1pOi-0005J4-Ml for qemu-devel@nongnu.org; Thu, 16 Jun 2022 09:19:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:56081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1pOb-0007ZV-FZ for qemu-devel@nongnu.org; Thu, 16 Jun 2022 09:18:55 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-159-hw4pvg4qMLWD4kecOTVgRg-1; Thu, 16 Jun 2022 09:18:43 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A623B185A7A4; Thu, 16 Jun 2022 13:18:42 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5319C40334E; Thu, 16 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655385527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OOPisGnzq61NrxsrGIdgBT7pO374tGQlU2DhkhUYj8E=; b=INfzLY5LOBZdTpLOBKufPhySd+HY/j9QQoHU1GkECgcfSCZt8bgvBW7e/dQT7xxUi589Ec kyNNbSRDkrUbwgudxKLuQ5C3IPlGlxppJkjQtJEpyqzSZB0y7Bd311d3Bn2nZmUyKN2Au5 YWrzIWPB+kWwK/nXRlxQhWD/VrQKhXE= X-MC-Unique: hw4pvg4qMLWD4kecOTVgRg-1 From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Cc: Kevin Wolf , Hanna Reitz , Paolo Bonzini , John Snow , Vladimir Sementsov-Ogievskiy , Wen Congyang , Xie Changlong , Markus Armbruster , Stefan Hajnoczi , Fam Zheng , qemu-devel@nongnu.org, Emanuele Giuseppe Esposito Subject: [PATCH v7 14/18] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext Date: Thu, 16 Jun 2022 09:18:31 -0400 Message-Id: <20220616131835.2004262-15-eesposit@redhat.com> In-Reply-To: <20220616131835.2004262-1-eesposit@redhat.com> References: <20220616131835.2004262-1-eesposit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655386102807100001 Content-Type: text/plain; charset="utf-8" We are always using the given bs AioContext, so there is no need to take the job ones (which is identical anyways). This also reduces the point we need to check when protecting job.aio_context field. Reviewed-by: Stefan Hajnoczi Signed-off-by: Emanuele Giuseppe Esposito --- block/commit.c | 4 ++-- block/mirror.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/commit.c b/block/commit.c index 851d1c557a..336f799172 100644 --- a/block/commit.c +++ b/block/commit.c @@ -370,7 +370,7 @@ void commit_start(const char *job_id, BlockDriverState = *bs, goto fail; } =20 - s->base =3D blk_new(s->common.job.aio_context, + s->base =3D blk_new(bdrv_get_aio_context(bs), base_perms, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED); @@ -382,7 +382,7 @@ void commit_start(const char *job_id, BlockDriverState = *bs, s->base_bs =3D base; =20 /* Required permissions are already taken with block_job_add_bdrv() */ - s->top =3D blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL); + s->top =3D blk_new(bdrv_get_aio_context(bs), 0, BLK_PERM_ALL); ret =3D blk_insert_bs(s->top, top, errp); if (ret < 0) { goto fail; diff --git a/block/mirror.c b/block/mirror.c index b38676e19d..1977e25171 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1728,7 +1728,7 @@ static BlockJob *mirror_start_job( goto fail; } =20 - s->target =3D blk_new(s->common.job.aio_context, + s->target =3D blk_new(bdrv_get_aio_context(bs), target_perms, target_shared_perms); ret =3D blk_insert_bs(s->target, target, errp); if (ret < 0) { --=20 2.31.1