From nobody Mon Feb 9 08:10:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1655335692; cv=none; d=zohomail.com; s=zohoarc; b=Zcegfyzp5DXZxOVQfO8CHeh7I7KlDNt1JEzuwVuQbwBJBzgIX2mnnGRmWxrpWQg/cHpJnLvQJQ1sLOyEsVeHzxD+8X6NdsH0AjOCbUmmesMzA3sGaugcKqkCT5icVOh7mbAuA+ua3Q8Jqp+WPS9yYNkkooEWTLiskclaGFp0I30= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655335692; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wyNXPlArU1+agHVU+vtqmeGospGYGi84Ub/Y5fnh9wo=; b=TsWmRcE4ue6oMD8w/1+9BumS3AsZ2Jvf2qAUUXJrBzv1iX+tYuDD0rD9frKB0d524guZU8l1HHbxn0yYOrfYE5lJUgvXq5y88NxIqlkAaO7C53ibw5Hwwy+USRQDpVHOKO8lgmrOb13ztdK6hd9T7fT+4YWaDOVenOX0FrfaKck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655335692939426.70620622405966; Wed, 15 Jun 2022 16:28:12 -0700 (PDT) Received: from localhost ([::1]:49786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1cQl-0006fQ-SB for importer@patchew.org; Wed, 15 Jun 2022 19:28:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1cNn-0004zh-Qt for qemu-devel@nongnu.org; Wed, 15 Jun 2022 19:25:08 -0400 Received: from mga06b.intel.com ([134.134.136.31]:58836 helo=mga06.intel.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1cNl-000102-TY for qemu-devel@nongnu.org; Wed, 15 Jun 2022 19:25:07 -0400 Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 16:25:01 -0700 Received: from dongwonk-z390-aorus-ultra-intel-gfx.fm.intel.com ([10.105.129.122]) by fmsmga007.fm.intel.com with ESMTP; 15 Jun 2022 16:25:01 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655335505; x=1686871505; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SkgAQFYz4EK2WkdQqaiDuicQvGHdG056PA3fRXjuwjo=; b=ji1PvXgZFX0fDXXvJKyQvkc2rwH2ShzCmF+tAWC4qvbZtzuRxuB/WtNt i7RHzdi2FIqkSnmju5YLn1QEm3lMHu0yiccnN4/cKpT9oxLlX85KALfFc SVLKaXFccBkUH+ZSBx6MejgGFaXtP45t7J12O7rW1lsAOphWSO+/maa5y b/YchO+7opuy+3E5mX4AVVfrKek4ZtNwQDQLmPGw1+DrvfaG7HxAfMhU6 +u/QwNL/2y+xvttm2fHdwaPnmu/+SQhp3LCUKwlmis0TVKVL225LSemD5 xRqM+efV98/q28JW9eh3MsBh+GGxrjbYmJ20cu2xmkSipjJywSPUxsyys Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="340778249" X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="340778249" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="589378018" From: Dongwon Kim To: qemu-devel@nongnu.org Cc: Dongwon Kim , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Gerd Hoffmann , Vivek Kasireddy Subject: [PATCH v2 2/2] ui/gtk: a new array param monitor to specify the target displays Date: Wed, 15 Jun 2022 16:19:42 -0700 Message-Id: <20220615231942.29981-3-dongwon.kim@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220615231942.29981-1-dongwon.kim@intel.com> References: <20220615231942.29981-1-dongwon.kim@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.31; envelope-from=dongwon.kim@intel.com; helo=mga06.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1655335693657100001 New integer array parameter, 'monitor' is for specifying the target displays where individual QEMU windows are placed upon launching. The array contains a series of numbers representing the monitor where QEMU windows are placed. Numbers in the array are mapped to QEMU windows like, [1st detached window, 2nd detached window,.... Main window] Usage example: -display gtk,monitor.0=3D0,monitor.1=3D1..... Cc: Daniel P. Berrang=C3=A9 Cc: Markus Armbruster Cc: Philippe Mathieu-Daud=C3=A9 Cc: Paolo Bonzini Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim --- qapi/ui.json | 7 ++++++- qemu-options.hx | 2 +- ui/gtk.c | 32 +++++++++++++++++++++++++++++++- 3 files changed, 38 insertions(+), 3 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 413371d5e8..5980f30c7f 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1195,12 +1195,17 @@ # assuming the guest will resize the display to match # the window size then. Otherwise it defaults to "off". # Since 3.1 +# @monitor: Array of numbers, each of which represents physical +# monitor where individual QEMU window is placed in case +# there are multiple of them +# since 7.1 # # Since: 2.12 ## { 'struct' : 'DisplayGTK', 'data' : { '*grab-on-hover' : 'bool', - '*zoom-to-fit' : 'bool' } } + '*zoom-to-fit' : 'bool', + '*monitor' : ['uint16'] } } =20 ## # @DisplayEGLHeadless: diff --git a/qemu-options.hx b/qemu-options.hx index 377d22fbd8..f79f533e9d 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1938,7 +1938,7 @@ DEF("display", HAS_ARG, QEMU_OPTION_display, #endif #if defined(CONFIG_GTK) "-display gtk[,full-screen=3Don|off][,gl=3Don|off][,grab-on-hover=3Don= |off]\n" - " [,show-cursor=3Don|off][,window-close=3Don|off]\n" + " [,monitor.=3D][,show-cursor=3Don|off][,wind= ow-close=3Don|off]\n" #endif #if defined(CONFIG_VNC) "-display vnc=3D[,]\n" diff --git a/ui/gtk.c b/ui/gtk.c index e6878c3209..fc9bf04680 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -2316,6 +2316,10 @@ static void gtk_display_init(DisplayState *ds, Displ= ayOptions *opts) GtkDisplayState *s =3D g_malloc0(sizeof(*s)); GdkDisplay *window_display; GtkIconTheme *theme; + GtkWidget *win; + GdkRectangle dest; + uint16List *mon; + int n_mon; int i; char *dir; =20 @@ -2393,7 +2397,33 @@ static void gtk_display_init(DisplayState *ds, Displ= ayOptions *opts) gtk_menu_item_activate(GTK_MENU_ITEM(s->untabify_item)); } } - if (opts->has_full_screen && + if (opts->u.gtk.has_monitor) { + i =3D 0; + n_mon =3D gdk_display_get_n_monitors(window_display); + for (mon =3D opts->u.gtk.monitor; mon; mon =3D mon->next) { + if (mon->value < n_mon) { + for (; i < s->nb_vcs; i++) { + win =3D s->vc[i].window ? s->vc[i].window : s->window; + if (opts->has_full_screen && opts->full_screen) { + gtk_window_fullscreen_on_monitor( + GTK_WINDOW(win), + gdk_display_get_default_screen(window_display), + mon->value); + } else { + gdk_monitor_get_geometry( + gdk_display_get_monitor(window_display, mon->v= alue), + &dest); + gtk_window_move(GTK_WINDOW(win), + dest.x, dest.y); + } + i++; + break; + } + } + } + } + if (!opts->u.gtk.has_monitor && + opts->has_full_screen && opts->full_screen) { gtk_menu_item_activate(GTK_MENU_ITEM(s->full_screen_item)); } --=20 2.30.2