From nobody Tue Feb 10 07:22:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1655101644; cv=none; d=zohomail.com; s=zohoarc; b=LI5hsG2VjkROTI68B4Q8L0EAzOMathi6vFGUz2+GlX8qpYramFVEwM8YV73wWiG1o/a8wm6iQr86rGDOKu18E2vnWjiWio1g5m6W8eIWUy2fyx5BDVEUjVM+C0OsnSWDGs6u04BrcOb4Ry2vZpEoS6B2BkV+SmtWzMSY/Cv5rI0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655101644; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5TRw3K+2SS8JJ3AZCDxDT7qkyVrtHOBgbmfT7Ng2Ubw=; b=Vg+jWFspmdMChnpk9Y4pKzSt4eyJgXD65b15g7lVYxxEEvSKKn4FYsi5g4J43N+/SpJSXADOhcKGGV2OoptCE/f2JWGxVF1kdpokVlEof6Q7yMmt/0vMtxzzNMGYH+CsVK3TMoxiYFGYoZWTR07+c3C5NNcSK19781giwjUcRRg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1655101644363959.8795782047822; Sun, 12 Jun 2022 23:27:24 -0700 (PDT) Received: from localhost ([::1]:59964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0dXn-0008In-8W for importer@patchew.org; Mon, 13 Jun 2022 02:27:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0dOG-0000P2-Q3 for qemu-devel@nongnu.org; Mon, 13 Jun 2022 02:17:41 -0400 Received: from mga03.intel.com ([134.134.136.65]:32802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0dOE-0005Vn-Q9 for qemu-devel@nongnu.org; Mon, 13 Jun 2022 02:17:32 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 23:17:21 -0700 Received: from duan-server-s2600bt.bj.intel.com ([10.240.192.123]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 23:17:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655101050; x=1686637050; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nr+MVTE7DGnhDyn8aP7rASCoalYk1aow0qsTuuKteKY=; b=id5EVLT6sr+KE1NrxuCiE1wvHrJw8ThGmsKtNQG2n4CIlcQWHet8RAH/ 9Bc78YA+UT7eq2VoZcFN39NKdLTD01v1kYe20q/rAus4ZzGbEKyWfrohs bUTi17comZBNliExEdtvcmNnB5nP3tDwn9j1nL4zgapt5OeNN2eKqz7ot 8G/5eqw4n0OiFappDKTeZil2bgReVBA+R+s1XgqtoePeP8fAKx/Bw/18c YJlaVxB1CcwI0C0L5m7W6upYkT68q93T/5JzBxi2rmn2oQu3uUK3HMrcE EyC5BNZ26GtXAkObP2aLtMsWlQ2vv9VWyP/AtXTROTLVNG0H6/DTj/QNR w==; X-IronPort-AV: E=McAfee;i="6400,9594,10376"; a="279229926" X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="279229926" X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="910205046" From: Zhenzhong Duan To: eric.auger@redhat.com Cc: qemu-devel@nongnu.org, mst@redhat.com, jean-philippe@linaro.org, pbonzini@redhat.com, yu.c.zhang@intel.com, chuanxiao.dong@intel.com, tina.zhang@intel.com Subject: [PATCH 3/3] virtio-iommu: Add an assert check in translate routine Date: Mon, 13 Jun 2022 14:10:10 +0800 Message-Id: <20220613061010.2674054-4-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220613061010.2674054-1-zhenzhong.duan@intel.com> References: <20220613061010.2674054-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.65; envelope-from=zhenzhong.duan@intel.com; helo=mga03.intel.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1655101646410100003 Content-Type: text/plain; charset="utf-8" With address space switch supported, dma access translation only happen after endpoint is attached to a non-bypass domain. Signed-off-by: Zhenzhong Duan --- hw/virtio/virtio-iommu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 73d5bde9d122..7c122ab95780 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -865,6 +865,10 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemor= yRegion *mr, hwaddr addr, qemu_rec_mutex_lock(&s->mutex); =20 ep =3D g_tree_lookup(s->endpoints, GUINT_TO_POINTER(sid)); + + if (bypass_allowed) + assert(ep && ep->domain && !ep->domain->bypass); + if (!ep) { if (!bypass_allowed) { error_report_once("%s sid=3D%d is not known!!", __func__, sid); --=20 2.25.1